| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auto-size the views version of the options dialog.
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
original issuse: http://codereview.chromium.org/2812026/show
Review URL: http://codereview.chromium.org/2883022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unexpected unit_tests crash on chromeos.
TBR: mnissler
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
Review URL: http://codereview.chromium.org/2812026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34209
TEST=none
Review URL: http://codereview.chromium.org/1521008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"clear cookie on exit" item wrap.
http://crbug.com/35118
TEST=none
Review URL: http://codereview.chromium.org/646059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/34088
TEST=Open 'Personal Stuff' on XP in all locales (with complex scripts installed) and make sure the Themes options are visible.
Review URL: http://codereview.chromium.org/571007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
available. For pt-PT and es-419, use pt-BR and es. For the rest of languages, fall back to the English page.
We can try a potentially better fallback (e.g using ru for uk and be), but it
also carries a risk. So, I'm leaving them alone.
Note that we cannot use '[GRITLANGCODE]' because Adobe uses a mix of language codes (e.g. 'en'), region codes ('cn', 'jp', 'kr', etc) and pseudo-region codes ('la') in their URLs.
BUG=NONE
TEST=NONE for now. Once the UI for flash setting help is added, start Chrome in one of languages whose xtb files are changed below and follow the link for the help on Flash settings. The flash help page should come up in that language.
TBR=tony
Review URL: http://codereview.chromium.org/551184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have per platform config and overrides. This is easier to manage
than the mess of <if>'s in the existing grd and xtb files.
Each platform only builds its locale_settings_{win,mac,linux}.grd file.
All the grd files generate the same platform_locale_settings.h
header (for easy inclusion in .cc files).
We use the fallback feature of grit to only specify locale specific values
in xtb files if we want to override the default for the locale.
BUG=28590
Review URL: http://codereview.chromium.org/545132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add padding to throbber.
Fix merge and sync cutoff.
BUG=27770, 29767, 29788, 29782, 29647
TEST=manually checked all languages,
Review URL: http://codereview.chromium.org/460123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bottom button.
BUG= 29447
TEST= sync bookmarks in a non-English locale; window should not be too short.
Review URL: http://codereview.chromium.org/467025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Got permission to check this in on a closed tree,
since this won't affect the tree).
BUG=24821
TEST=Manual inspection on XP should reveal no truncation in first
two tabs of the Options panel for locales listed in bug (see CL
for --lang=xx values).
Review URL: http://codereview.chromium.org/460076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23178
TEST=Requires manual inspection for text trunction on --lang=de (when closing Chrome while downloading)
Review URL: http://codereview.chromium.org/465041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of Arial as default
- Update non-English font choices (based mostly on Mozilla's choices, <http://mxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js> cross-referenced with what's installed with the OS)
BUG=http://crbug.com/19135; http://crbug.com/20171
TEST=as in bugs
Review URL: http://codereview.chromium.org/335031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23136,24858,21596
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/270081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifically, units proportional to the fonts used inside of it.
We approximate the font chosen by the wizard's CSS. In actuality, the
CSS chooses a font-face "arial", "sans-serif". We just use the default
sans serif font; arial is the default value for that property.
This fixes an issue where changing to the "Windows Classic" theme
on Vista would cause the dialog to be resized, clipping its
contents, which are unaffected by the UI font size.
Update the default GRIT sizes to closely match the old ones.
Old vs new:
http://www.corp.google.com/~ncarter/wizard-size-screenshots.png
BUG=21828
TEST=verified old size against new size in Aero Theme with default
settings; verified size stays the same under Classic theme.
Review URL: http://codereview.chromium.org/261017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before, too, but now at least it doesn't
cause zombie processes) with an observer that is notified when the user clicks OK/closes the dialog instead of running
a nested message loop and blocking. This fixes bug 20451, where nested message loops were running a confirm dialog and
could cause zombie processes at browser shutdown.
BUG=20451
TEST=None (manual: verify that the confirmation dialog is shown when you try to remove all passwords, and that no zombie is left behind if the browser is closed while the confirmation dialog is showing)
Review URL: http://codereview.chromium.org/243054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19896
Review URL: http://codereview.chromium.org/192077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19622
TEST=none
Review URL: http://codereview.chromium.org/180031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_locale_settings.
Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings).
There are no code changes.
BUG=http://crbug.com/7319
TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does).
Review URL: http://codereview.chromium.org/131060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons get cut off on the right side of the dialog. Instead
of sizing the label text based on a constant from the localized
resources, use the default text size (no-multiline text).
I also tightened up the font preview box to just use
the size of the text + a constant padding on all sides.
BUG=13366
Review URL: http://codereview.chromium.org/125013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
additional height to accommodate the buttons (in XP classic mode). Some (like .te) needed additional width to accommodate the combobox.
BUG=11487
TEST=Open Clear Browsing Data dialog in all languages and make sure no control is being truncated/squished against another control.
Review URL: http://codereview.chromium.org/118191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
Original text:
"""
This addresses 3 of the 4 issues described in Issue 9223:
1) Creates a new streamlined bubble with less text.
2) Incorporates a close [x].
3) Driven by configuration option in master_preferences file; this alternate
bubble will be used only if "oem_bubble": true is set.
Requested longer linger time feature will involve mucking with the focus
manager; this change will be uploaded separately.
BUG=9223
TEST=Add "oem_bubble": true to master_preferences file. Run chrome with
--first-run option. Alternate, smaller OEM bubble should appear over the Chrome
browser in the place of the standard first-run bubble.
"""
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
BUG=9223
TBR=mirandac
Review URL: http://codereview.chromium.org/113504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
currently hard-coded to be 400, but it needs to be localizable.I made it localizable and set the value to 80 (which makes it exactly the same width as the current one) for most locales except for Malayalam for which it's too narrow. Once reviewed and landed in the trunk, this need to be merged to the branch. BUG=11267
TEST=Run CHrome with '--lang=ml', go to Options | Advanced and click on 'Restore the defaul settings' button
at the bottom. The dialog box popping up should not have any truncated strings due to the dimension of the dialog being too small
Review URL: http://codereview.chromium.org/100008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vs Win Vista/ Win 7).
In r13773, the localizable font size/family override was added to work around the tiny
font issue for some Indian languages. Initially, I thought the 'tiny UI font' issue was completely taken care of on Vista/Win 7 (it's resolved for Malayalam) and added a check for that.
It turned out that Indian fonts on Vista and Windows 7 were updated, but the issue has not been resolved. As a result, he scale and the fonts for Windows XP do not work on Vista/Win 7 and we need to use different values for Vista/Win 7.
Note that what this CL does (having separate resource entries in a single reosource bundle for Win XP and Vista/Win 7 and picking one at run-time) is a temporary work-around for the branch and for the trunk, we need to have a better way of handling platform-dependent resources. It's not just for different flavors of Windows but also for taking care of differences between Win, Mac and Linux.
BUG=7319
TEST=On Vista/Win7/Win XP, run Chrome with '--lang=XX' where XX is hi, mr, kn, gu, te, ta, bn, ml (and or on Vista/Win 7) and make sure that UI font size looks ok and there's no truncated strings/dialog box.
Review URL: http://codereview.chromium.org/92135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).
It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).
For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used.
For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150.
When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY.
While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.
The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac.
TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same.
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.
BUG=7319
Review URL: http://codereview.chromium.org/62064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI.
For some Indian languages (Malayalam, Bengali and Telugu), we have to
use a bigger size and a font family for that script on Windows.
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.
I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is
recycled to localize the font family (or the list of font families) for html UI.
I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).
BUG=7319
Review URL: http://codereview.chromium.org/57025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average
character width (depending on which one is smaller).
BUG=8331
TEST=Open About box in all languages and make sure it is roughly
the same size as it was in 1.0.
Review URL: http://codereview.chromium.org/39214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files.
TBR=deanm
Review URL: http://codereview.chromium.org/39152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files from the tree."
Revert "window_ is null during BrowserWindow creation. Assume full screen"
Revert "Move SupportsWindowFeature from BrowserView to Browser so"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
I also used a script to convert the existing .rc files to .xtb files.
Review URL: http://codereview.chromium.org/28327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10809 0039d316-1c4b-4281-b951-d872f2087c98
|