| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
To be merged with 2.0 (172) branch.
BUG=http://crbug.com/11208
TBR=mal
Review URL: http://codereview.chromium.org/99260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This needs to be merged with 2.0 (172.x) branch.
TBR=mal
BUG=11198
Review URL: http://codereview.chromium.org/100218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Marathi (before English) because the speakers of those Indian langauges
are pretty likely to comprehend Hindi.
To be merged with 2.0 (172.x) branch.
No bug
TBR=mal
Review URL: http://codereview.chromium.org/99139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vs Win Vista/ Win 7).
In r13773, the localizable font size/family override was added to work around the tiny
font issue for some Indian languages. Initially, I thought the 'tiny UI font' issue was completely taken care of on Vista/Win 7 (it's resolved for Malayalam) and added a check for that.
It turned out that Indian fonts on Vista and Windows 7 were updated, but the issue has not been resolved. As a result, he scale and the fonts for Windows XP do not work on Vista/Win 7 and we need to use different values for Vista/Win 7.
Note that what this CL does (having separate resource entries in a single reosource bundle for Win XP and Vista/Win 7 and picking one at run-time) is a temporary work-around for the branch and for the trunk, we need to have a better way of handling platform-dependent resources. It's not just for different flavors of Windows but also for taking care of differences between Win, Mac and Linux.
BUG=7319
TEST=On Vista/Win7/Win XP, run Chrome with '--lang=XX' where XX is hi, mr, kn, gu, te, ta, bn, ml (and or on Vista/Win 7) and make sure that UI font size looks ok and there's no truncated strings/dialog box.
Review URL: http://codereview.chromium.org/92135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Includes translations for strings uploaded as of 1 April.
Lithuanian, Russian, and Serbian are not finalized.
Review URL: http://codereview.chromium.org/99035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
first-run dialog (ta,kn,te,ml)
BUG=10687
Review URL: http://codereview.chromium.org/88017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).
It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).
For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used.
For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150.
When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY.
While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.
The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac.
TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same.
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.
BUG=7319
Review URL: http://codereview.chromium.org/62064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI.
For some Indian languages (Malayalam, Bengali and Telugu), we have to
use a bigger size and a font family for that script on Windows.
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.
I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is
recycled to localize the font family (or the list of font families) for html UI.
I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).
BUG=7319
Review URL: http://codereview.chromium.org/57025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to work around a few google issues (Picasa web, China's icafe)
bug=3301
Review URL: http://codereview.chromium.org/46069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8676
TEST=Open About box in Hebrew and make sure it is not truncating the text.
Review URL: http://codereview.chromium.org/43099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
available in the encoding menu. Make windows-1255 come before
ISO-8859-8* both in the full encoding list and in Hebew Chrome's
static list.
BUG=2927
Review URL: http://codereview.chromium.org/39248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any lang (currently using --lang=ar or whatever).
Also remove app/resources/SConscript since it's filled with
windows specific code.
BUG=8125
Review URL: http://codereview.chromium.org/40246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average
character width (depending on which one is smaller).
BUG=8331
TEST=Open About box in all languages and make sure it is roughly
the same size as it was in 1.0.
Review URL: http://codereview.chromium.org/39214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files.
TBR=deanm
Review URL: http://codereview.chromium.org/39152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files from the tree."
Revert "window_ is null during BrowserWindow creation. Assume full screen"
Revert "Move SupportsWindowFeature from BrowserView to Browser so"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
I also used a script to convert the existing .rc files to .xtb files.
Review URL: http://codereview.chromium.org/28327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the scons code that walks a grd file and adds its dependencies as
build dependencies. This requires that all our dependencies are files in our
source tree (which is what motivated getting rid of the tld data as a
generated resource). I had to fix up the terms of service for this.
Also remove some code that disabled .pak file generation on windows which was
broken because it couldn't find the tld data.
Review URL: http://codereview.chromium.org/28194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some linux/mac issues that were pending and fix up the scons build to
expect the file in the grit subdir.
BUG=7537
Review URL: http://codereview.chromium.org/28035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=4782
Review URL: http://codereview.chromium.org/28003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a locale_settings.h file that we use on all platforms. However,
the rc generation isn't correct yet, so for now, use the existing
locale_settings_*.rc files.
Also go ahead and generate the en-US locale pak on linux.
Review URL: http://codereview.chromium.org/20447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update all .xtb files with current translations from the translation console.
BUG= None
TBR= tony
TEST= Find 49 friends who each speak a different language ...nevermind.
Review URL: http://codereview.chromium.org/20451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on locale_settings_en-US.rc.
We don't use this anywhere yet, just putting things in place.
- Fix preprocessor defines in grit vcproj files (needs to be defined
everywhere) and update grit_localized_resources.rules to pass the
preprocessor define to grit.
- Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a
open them.
- Update GRIT so it knows how to substitute [GRITLANGCODE] in strings
to the locale value.
Review URL: http://codereview.chromium.org/20440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which mirror the vcproj files used by Windows.
Add the linux specific code to generate .pak files that we use for
resources on linux.
This doesn't include the necessary changes to build the theme default.dll on
windows, but the windows scons build is already really broken so punting for
now.
Review URL: http://codereview.chromium.org/21371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add entries for 8 Indian languages to grd files (<translations> section)
* Change the default spellcheck language for new languages to en-US for now. They'll be switched back to
the UI language when we have spell check dictionaries for them
* Add entries for 8 languages to installer's string offset table.
This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated.
BUG=4473
Review URL: http://codereview.chromium.org/19761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Path name translation (/ to \) of various MSVSTool attributes.
* Explicit keyword= arguments to MSVSProject. This will likely
go away eventually in favor of uniform behavior.
* Add a relative_path_substitutions array that can be used
to substitute in Visual Studio variable like $(OutDir).
* Add a local_directory_prefix that can be set to './' to only
affect files in the current directory.
* Additional Keyword ordering in Tool attributes to continue to
match the default order Visual Studio generates.
* Add a Derived() proxy class that can wrap a File node to tell
the .vcproj generation that we want the derived file, not its
source(s), in the file list.
* In the individual *.scons files, add the necessary files (mostly
.h files) to file lists, and update MSVSProject() calls with
the additional necessary information.
Result is identical .vcproj files modulo the following differences:
* Four locales .vcproj files (da, en-US, he and zh-TW) with
source file orders that don't match the other locale .vcproj
files have re-ordered file lists to match the rest.
* Cosmetic XML changes (white space, ending tags) in:
chrome/app/chrome_dll.vcproj
chrome/app/generated_resources.vcproj
net/build/net_resources.vcproj
* Removal or addition of ./ prefixes from various files that don't
match the other file specifications within their individual
.vcproj files:
chrome/installer/util/util.vcproj
net/build/net.vcproj
net/build/net_unittests.vcproj
* Add missing empty sections (<ToolFiles>, <References>, <Globals>)
for consistency with other .vcproj files:
chrome/tools/test/image_diff/image_diff.vcproj
third_party/libpng/libpng.vcproj
third_party/zlib/zlib.vcproj
* Add missing RootNameSpace attribute:
chrome/test/automation/automation.vcproj
testing/gtest.vcproj
* Use && instead of \r\n as a command separator, to sidestep
XML-generation problems:
chrome/app/chrome_exe.vcproj
* Remove unnecessary (?) duplicate files in the file list:
chrome/browser/views/browser_views.vcproj
(event_utils.cc and event_utils.h were duplicated)
Review URL: http://codereview.chromium.org/17603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(en route to generating .vcproj files).
Instead of defining a list of locale_settings_*.rc files, just specify
a list of the two-letter locale abbreviations and generate all the
specific file names by interpolating the locale, not by extracting
the locale with a regular expression and doing harder-to-understand
string replacement on the file names.
Review URL: http://codereview.chromium.org/17460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
size has not increased in non-US locales.
While verifying on all locales, I noticed three
locales that had this dialog wider than others
and I shrunk those too. Those were locales:
el, fil and sv.
Review URL: http://codereview.chromium.org/15066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BN,GU,KN,ML,MR,OR,TA and TE are still using the English translation (no translation available on our site).
HE is non-RTL, which we should fix upstream.
The JS contained is harmless code that we had previously manually stripped out, but as we're not someone more automated, I'm leaving it in.
Review URL: http://codereview.chromium.org/14104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Joi has convinced me that GRIT should generate platform specific
resources files. This is easier than parsing .rc files because
GRIT effectively has an .rc parser. To that end, we need to
convert some existing .rc files to .grd files (e.g., net_resources.rc
and webkit_resources.rc). Rather than having every grd file output
to a different place and -I all the different paths, have GRIT
generate all files into one directory. This directory is
grit_derived_sources.
Review URL: http://codereview.chromium.org/13776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(r6540).
Up to now, we canonicalized to EUC-KR, TIS-620 and GB2312, but with
unforking, we'd better canonicalize to windows-949, windows-874 and GBK.
Another change is necessary in Webkit (Document.cpp), which I'll do it while unforking it.
BUG=3703
Review URL: http://codereview.chromium.org/13645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bug=4457
Review URL: http://codereview.chromium.org/13207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a the Hebrew translation missing a bunch of strings.
TBR=mal
Review URL: http://codereview.chromium.org/12976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=munjal
Review URL: http://codereview.chromium.org/13110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary
=======
Implement a prototype of multiple profiles in Chrome by
utilizing the functionality of user-data-dir command line
flag that already exists.
A profile in this case is an umbrella for all user data
including cookies, history, bookmarks, settings, etc. Each
profile gives the user a separation of all these data
elements.
User Interface
==============
- Wrench > "New window in profile" menu item, with sub-menu items.
This new menu item has sub menu items for each existing
profile, for up to 9 profiles, and one more sub menu item
to launch a window in a new profile. The 9 sub-menu items
also have the accelerators like CTRL + SHIFT + 1, CTRL +
SHIFT + 2, etc. If there are more than 9 profiles, we
will also show an extra sub-menu item, "Other...".
- New Profile dialog box
This dialog box is shown to the use when (s)he clicks
Wrench > New window in profile > <New Profile>. It lets
the user specify a profile name, and also shows a checkbox
to create a desktop shortcut to launch Chrome in that profile.
- Choose profile dialog box
This dialog box lets the user select a profile from a drop
down to open a new window in. It also has an item <New Profile>
in the drop down, selecting which will show the new profile
dialog box mentioned above. CTRL + M shortcut also launches
this dialog box.
Code Organization
=================
chrome\browser\user_data_dir_profile_manager.h/.cc:
This class provides an abstraction of profiles on top of the user
data dir command line flag.
chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc
New profile dialog box code.
chrome\browser\views\user_data_dir_profiles_dialog.h/.cc
Choose profile dialog box code.
Review URL: http://codereview.chromium.org/12895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just adds the .vcproj files and the locale_settings.rc files
they need.
I also updated SConscript.
I'll make the changes to chrome.sln and check it in after this is
checked in. Just checking these in should not affect the build until
chrome.sln is updated.
R= tony
Review URL: http://codereview.chromium.org/10968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rev just adds the _terms files. These are copied from the
en-US version.
I don't know how these get generated, nor whether translations for
the terms exist for these languages.
R=glen
Review URL: http://codereview.chromium.org/10775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(plus various renaming ripple effects masked by merge build errors):
* Move invocation of recently-created *.scons files from
chrome\SConscript into chrome\chrome.scons.
* Move the ChromeVersionRC() Builder up into chrome\chrome.scons
so it's available in all the newer *.scons files (specifically
installer\mini_installer\mini_installer.scons and
installer\setup\setup.scons).
* Build chrome.dll in a chrome_dll subdirectory, and chrome.exe in
a chrome_exe subdirectory, to avoid the name conflict when both
try to create a chrome.lib library as part of linking. Re-name
them to chrome.{dll,lib,exe} on installation into $DESTINATION_ROOT.
* Install underneath Hammer\ ($DESTINATION_ROOT) copies of:
themes\default.dll
* Portability: link against 'chrome' and 'common' from the LIBS variable,
not by explicitly listing 'chrome.lib' and 'common.lib'.
* Link interactive_ui_tests.exe links against sdch, not google_update,
and add CPPPATH directories for included resource files.
* Install a number of necessary ancillary files in explicitly in
$DESTINATION_ROOT, not $TARGET_ROOT: chrome.dll, icudt38.dll, rlz.dll,
"First Run", themes\*, locales\, Dictionaries.
* Add a 'chrome_locales' Alias for the locale .dll files installed
into the locales\ subdirectory, and use Requires() to make sure
they're installed for chrome.exe regardless of what target is used.
* Add a 'chrome_Dictionaries' Alias for the hunspell dictionaries
into the Dictionaries\ subdirectory, and use Requires() to make sure
they're installed for chrome.exe regardless of what target is used.
* Clone() the automated_ui_tests.scons construction environment so its
settings don't pollute builds of other targets.
* Add explicit dependencies on various generated .rc files (with
TODO(sgk) to figure out why they're not picked up by the
implicit dependency scan).
Review URL: http://codereview.chromium.org/10976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add 'gdm_fp' to the $LIBS setting in base\using_base.scons
(to be removed when that library moves into base\third_party).
* Have the grit Scanner search the Repository() copy of the source
file (necessary now that $TARGET_ROOT has changed).
* Change all the SConscript files underneath chrome\test and
chrome\tools to *.scons files, including updating their
contents with the current patterns.
* Add dependencies of the local_settings_*.res files on
the corresponding google_chrome_string_*.rc files, so they
get generated properly.
* Add generation of the chrome_exe.res resource file.
* Comment out some unnecessary .lib settings in the base
construction environment.
Review URL: http://codereview.chromium.org/10745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10704
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dangerous download warning cause an overlap with the label
for that download's URL.
We now use a locale-specific pixel value which changes the
height of each download's view on the download page so that
this overlap no longer happens.
BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824)
Review URL: http://codereview.chromium.org/8933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The link 'learn more' now points to a yet-to-be-created article in the help center. I moved it also, so that it appears to the right of the label (instead of below the label).
And finally, I added missing definitions for the Bookmark Manager, which I noticed while I was changing this.
Review URL: http://codereview.chromium.org/8777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill.
Review URL: http://codereview.chromium.org/8740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
text isn't truncated.
BUG=3836
Review URL: http://codereview.chromium.org/8922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2804
Review URL: http://codereview.chromium.org/8196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
translation console.
TBR=mal
Review URL: http://codereview.chromium.org/7957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3893 0039d316-1c4b-4281-b951-d872f2087c98
|