| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight.
2) Click and hold on the new tab button and its state should change
3) Release, and watch new tab get created. Verify that new button state
changes appropriately
4) Create a full tab strip of tabs. Verify that button state stays
correct as you click on the new tab button and new tabs are created but
the button doesn't move.
5) Create 2 tabs, and move the mouse button into the newtab button.
See that it highlights. hit cmd-w to close a tab. As the newtab button
moves away from under the cursor make sure it loses its highlight.
Review URL: http://codereview.chromium.org/372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and also the icon for the default plugin window).
MSVS's resource compiler can only compile resources of the same
type from a single .rc file, so we can't have ICON types scattered
across rc files. This change moves all the icon files out of
theme_resources.rc and puts them in chrome_dll.rc. This worked
in the past because these were different dlls.
This has the side benefit of not including the ico files in
the linux/mac builds.
BUG=26600
Review URL: http://codereview.chromium.org/361031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
between the balloon and the shelf, and also on the left edge.
BUG=26631
TEST=create notifications over a busy desktop background
Review URL: http://codereview.chromium.org/351028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
left out for try-server incompatibility with binary files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/348013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to display toasts on the screen, and manager for controlling the layout of the balloons.
BUG=none
TEST=none yet (part of larger patch)
Review URL: http://codereview.chromium.org/338051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install dialogs and the management ui page.
Also changed the margins on the body to match the download page and
the history page so it doesn't look as bad when you switch between them.
TEST=Install an extension without an icon and you should see the puzzle
piece icon in the install dialog.
TEST=Open the chrome://extensions page and you should see the same icon
in the top left corner.
BUG=25906
Review URL: http://codereview.chromium.org/344014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/339030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=25538
Review URL: http://codereview.chromium.org/315008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.
Review URL: http://codereview.chromium.org/329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25509
TEST=Open the extensions page and its tab should have an icon.
Review URL: http://codereview.chromium.org/332009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a Mac-like tab key image for "Press [tab] to search" on the Mac.
New image from Cole. Hello, VAG Rounded.
BUG=21444
TEST=Start typing "go" in the omnibar, the "tab" image should look Mac-ish.
On other platforms, the "Tab" image should be unchanged.
Review URL: http://codereview.chromium.org/307024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21444
TEST=Lollipops have not fallen in dirt?
Review URL: http://codereview.chromium.org/314005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The icon is a placeholder until Glen makes a pretty one.
BUG=24047
TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html
allow, deny, closing infobar, and closing tab all work as expected
Review URL: http://codereview.chromium.org/275011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/268019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/267024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using a chrome:// URL.
Review URL: http://codereview.chromium.org/255099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/257062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switches for changing the url and size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/256060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
First cut at badge implementation.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data. A subsequent change will hook it up to the extension APIs.
See http://dl.getdropbox.com/u/124107/badges.png for a picture
of what this looks like.
BUG=23268
Review URL: http://codereview.chromium.org/259004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as we have not hooked it up to ChromeOS shared library wifi code yet.
TEST=none
BUG=23090
Review URL: http://codereview.chromium.org/231014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functionality. Call into it and show new battery images
Review URL: http://codereview.chromium.org/215025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome
Review URL: http://codereview.chromium.org/217020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22517
TEST=tried it and decided it looks fine
Review URL: http://codereview.chromium.org/212044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/214034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics with a slightly darker set from Nicholas.
The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one.
BUG=21028
TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position.
Review URL: http://codereview.chromium.org/195099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
turned off.
BUG=19763
TEST=per bug. This might not appear to work given how LaunchServices caches and registers applications. You may need to test on a totally clean machine.
Review URL: http://codereview.chromium.org/194116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new file, bubble_border.cc, so that InfoBubble will be able to start using it. This also renames the resources to be more generic.
This should not result in any visual changes.
BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21170
TEST= Install a dark theme. Download something. Note that download progress bar is aesthetically pleasing.
Review URL: http://codereview.chromium.org/201095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21170
TBR=thakis
Review URL: http://codereview.chromium.org/199089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14903
TEST=Findbar icons should look more like windows, be properly themed.
Review URL: http://codereview.chromium.org/197040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab page.
This should reduce the amount of work needed since the images do not
need to be resized.
BUG=17455
TEST=No visible changes
Review URL: http://codereview.chromium.org/194028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Cole.
BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none
Review URL: http://codereview.chromium.org/165499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/181002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Cole.
BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none
Review URL: http://codereview.chromium.org/165499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174558
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Path by Cole.
BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none
Review URL: http://codereview.chromium.org/165499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://b/2071356
TEST=Create a new profile and start chrome. The thumbnail for google
chrome should look like the commited image.
Review URL: http://codereview.chromium.org/174403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to show.
I also changed to use black text on white for the menu.
BUG=None
TEST=Hide and show the different sections on new tab page and makes
sure that the checkbox is correctly synced with the state.
Review URL: http://codereview.chromium.org/174035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18227
TEST=Install a theme, verify that an infobar with a pretty icon appears.
Review URL: http://codereview.chromium.org/165205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
contains a clock, an application menu, and a non-working battery indicator.
The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc
Review URL: http://codereview.chromium.org/165272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dark themes.
BUG= http://crbug.com/18451
TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible.
Review URL: http://codereview.chromium.org/164276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22980 0039d316-1c4b-4281-b951-d872f2087c98
|