| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=none
BUGS=none
Review URL: http://codereview.chromium.org/634001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=39374
Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
This change specifically:
ui_test_utils::WaitForAppModalDialog registers for listening to notifications too late, i.e., after the dialog had been triggered.
Exposes AppModalDialogObserver so that we can register, trigger the dialog, then wait for it.
Review URL: http://codereview.chromium.org/647048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/646027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/548188
Review URL: http://codereview.chromium.org/647012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use google translate icon for official chrome builds
- use current icon for chromium
BUG=35478
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/603046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/597055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/596025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34320
Review URL: http://codereview.chromium.org/575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have a proper fix (r37722), we should revert this short term hack
(which didn't work in the end anyway).
BUG=33416
TEST=none
Review URL: http://codereview.chromium.org/562015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hooked to anything, so they'll never appear.
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/556077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Previously reviewed by sky as part of a larger change.
BUG=33314
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThemePack so we can release a dev channel.
Move new resources to the end so they don't modify current IDR ids that are now baked into BrowserThemePacks.
BUG=33416
TEST=Themes from previous dev channel work.
Review URL: http://codereview.chromium.org/551196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/553071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Committing this CL on dhg's behalf.
Original Review: http://codereview.chromium.org/542083
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Old CL: http://codereview.chromium.org/449023
Review URL: http://codereview.chromium.org/488007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/491048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/452016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/491012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do anything
Review URL: http://codereview.chromium.org/449023
TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/467060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/449023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons.
Part of the CL includes new features for TextButton class to control icon placement and appearance on hover.
BUG=none
TEST=notifications
Review URL: http://codereview.chromium.org/450045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobar.
BUG=TEST=none.
Review URL: http://codereview.chromium.org/453011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/402038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 27393, 26744
TEST= promotional messages should show up on NTP.
Review URL: http://codereview.chromium.org/394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 27393
TEST= none
Review URL: http://codereview.chromium.org/395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the external change.
BUG=26826
TEST=none
Review URL: http://codereview.chromium.org/388011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
figure out how to use the system icon without regressing startup time.
BUG=26457
TEST=Look at bookmarks bar. The folder icon, while not being the system folder icon, is at least blue.
Review URL: http://codereview.chromium.org/389012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes leak in BackingStore as shown by valgrind. XFree doesn't free
the data of the image, where as XDestroyImage does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight.
2) Click and hold on the new tab button and its state should change
3) Release, and watch new tab get created. Verify that new button state
changes appropriately
4) Create a full tab strip of tabs. Verify that button state stays
correct as you click on the new tab button and new tabs are created but
the button doesn't move.
5) Create 2 tabs, and move the mouse button into the newtab button.
See that it highlights. hit cmd-w to close a tab. As the newtab button
moves away from under the cursor make sure it loses its highlight.
Review URL: http://codereview.chromium.org/372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and also the icon for the default plugin window).
MSVS's resource compiler can only compile resources of the same
type from a single .rc file, so we can't have ICON types scattered
across rc files. This change moves all the icon files out of
theme_resources.rc and puts them in chrome_dll.rc. This worked
in the past because these were different dlls.
This has the side benefit of not including the ico files in
the linux/mac builds.
BUG=26600
Review URL: http://codereview.chromium.org/361031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
between the balloon and the shelf, and also on the left edge.
BUG=26631
TEST=create notifications over a busy desktop background
Review URL: http://codereview.chromium.org/351028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
left out for try-server incompatibility with binary files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/348013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to display toasts on the screen, and manager for controlling the layout of the balloons.
BUG=none
TEST=none yet (part of larger patch)
Review URL: http://codereview.chromium.org/338051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install dialogs and the management ui page.
Also changed the margins on the body to match the download page and
the history page so it doesn't look as bad when you switch between them.
TEST=Install an extension without an icon and you should see the puzzle
piece icon in the install dialog.
TEST=Open the chrome://extensions page and you should see the same icon
in the top left corner.
BUG=25906
Review URL: http://codereview.chromium.org/344014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/339030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=25538
Review URL: http://codereview.chromium.org/315008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.
Review URL: http://codereview.chromium.org/329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25509
TEST=Open the extensions page and its tab should have an icon.
Review URL: http://codereview.chromium.org/332009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a Mac-like tab key image for "Press [tab] to search" on the Mac.
New image from Cole. Hello, VAG Rounded.
BUG=21444
TEST=Start typing "go" in the omnibar, the "tab" image should look Mac-ish.
On other platforms, the "Tab" image should be unchanged.
Review URL: http://codereview.chromium.org/307024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21444
TEST=Lollipops have not fallen in dirt?
Review URL: http://codereview.chromium.org/314005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The icon is a placeholder until Glen makes a pretty one.
BUG=24047
TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html
allow, deny, closing infobar, and closing tab all work as expected
Review URL: http://codereview.chromium.org/275011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/268019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/267024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using a chrome:// URL.
Review URL: http://codereview.chromium.org/255099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/257062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switches for changing the url and size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/256060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28045 0039d316-1c4b-4281-b951-d872f2087c98
|