| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as a whole and not just these changes).
Change global std::strings to chars* in browser theme provider.
Add ability for ReplaceStringPlaceHolder to take up to 9 replacements.
BUG=11235,11685
Review URL: http://codereview.chromium.org/115172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was requested for Ubuntu packaging.
Review URL: http://codereview.chromium.org/115332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/115152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is paired with http://codereview.chromium.org/67284
This CL (for commit purposes) includes http://codereview.chromium.org/67284
BUG=4463,11232,11233,11234,11235
Review URL: http://codereview.chromium.org/99030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PageAction code that serves the same purpose (and more).
BUG=9812
TEST=No test needed, this shouldn't result in any noticable difference
since the RSS parsing was disabled.
Review URL: http://codereview.chromium.org/100356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/101024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add back these files which I removed earlier since Linux is using them.
The resources are duplicate until I collapse them into src/app/ later this week.
Review URL: http://codereview.chromium.org/100320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views_strings.[grd,vcproj]
views_resources.[grd,vcproj]
Moves views images (.png files) from app/theme to views/resources dir.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/100317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar.
Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button.
http://crbug.com/9049
Review URL: http://codereview.chromium.org/100288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is used for Linux, where we're currently not doing inverse selection.
Review URL: http://codereview.chromium.org/100207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.
Back to using system colors. Adds highlight icons.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826
Review URL: http://codereview.chromium.org/99102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.
Back to using system colors. Adds highlight icons.
Review URL: http://codereview.chromium.org/99102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a mapping for all the entries in the
theme_resources.grd file and adds a static method for querying
the mapping.
BUG=10639
Review URL: http://codereview.chromium.org/92085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9022
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/95008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
icon and the text to show the number of closed windows.
BUG=9022
TEST=With more than one window open close a window. Go to the new tab
page and make sure you see an entry for the closed window. The entry
should have the chrome/chromium logo and instead of 'Window' it
should say the number of tabs in the window.
Review URL: http://codereview.chromium.org/92022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Experiment with some effects.
Adds a positioner interface that allows the popup to size itself to the width of the edit view + the width of the star and go buttons. (Basically the toolbar needs to help the popup position itself).
No results yet!
Review URL: http://codereview.chromium.org/68011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add these resources to theme_resources.grd.
Review URL: http://codereview.chromium.org/73030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URL of removed thumbnails is added to a blacklist, which is a user pref.
I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a
fixed number of items, as now we may filter the ones we get back.
Note: this adds between 20 and 30ms to the first NTP load on my machine (a
3 to 5% increase).
BUG=685
TEST=Open the NTP. Click the 'Edit thumbnails' link. Remove some thumbnails.
Press Done. Edit again, use the "Restore removed" link.
Review URL: http://codereview.chromium.org/67037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(--enable-omnibox2).
This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX.
Also adds new images from Nicholas.
Review URL: http://codereview.chromium.org/67035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the progress status text indicator code from the old history page.
Make 'cancel' visible when paused.
More RTL fixes.
BUG=8220,8334
Review URL: http://codereview.chromium.org/42550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--bookmark-menu.
BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
works. Also make sure I didn't break anything on the bookmark bar.
Review URL: http://codereview.chromium.org/42460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the
feeds in the document and notify the browser to
display the RSS icon in the toolbar. You can
click on the icon, but it will just navigate to
the first feed on the page, which (unless it has
been designed to be browser friendly) will just
dump XML as text on the user.
For this reason I have disabled the code that
makes the RSS icon appear and intend to enable
it when we have a good landing page to display
the XML.
Review URL: http://codereview.chromium.org/46055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reverting for now. Will try again later
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Dock icons for window docking positions could go offscreen
before.
. It was possible to show the maximize indicator on the wrong
screen. This was because equals was not comparing the monitor bounds.
. Tweaks to color, size and animation from Glen.
BUG=none
TEST=make sure there are no bugs with docking tabs.
Review URL: http://codereview.chromium.org/42041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the filesystem and avoid the need for processing of Info.plist.
Dup of svn log since rietveld doesn't like A+D:
A + chrome/app/theme/chromium/app.icns
D chrome/app/theme/chromium/chromium.icns
M chrome/app/app-Info.plist
M chrome/chrome.gyp
Review URL: http://codereview.chromium.org/40238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and its children could be relative to it rather than their grandparent. Plumb loading status into Mac controllers. Add more loading status info to stub TabContents. Make browser window a little taller and wider so NTP didn't show scrollbars.
Review URL: http://codereview.chromium.org/31017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Unfortunately glass popups can't be made to match the mockup unless we want to completely reimplement Windows titlebar drawing, so I'm leaving them pretty much unchanged :(
BUG=7569
Review URL: http://codereview.chromium.org/28072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some linux/mac issues that were pending and fix up the scons build to
expect the file in the grit subdir.
BUG=7537
Review URL: http://codereview.chromium.org/28035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
textured window style.
Review URL: http://codereview.chromium.org/21544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the resource bundle on linux unittests and make the unit_tests
executable require the various .pak files.
Review URL: http://codereview.chromium.org/20471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which mirror the vcproj files used by Windows.
Add the linux specific code to generate .pak files that we use for
resources on linux.
This doesn't include the necessary changes to build the theme default.dll on
windows, but the windows scons build is already really broken so punting for
now.
Review URL: http://codereview.chromium.org/21371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the svn:eol-style property as blank. This should allow
the try servers to apply patches.
TBR=glen
Review URL: http://codereview.chromium.org/20370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that's what most of the lines are).
TBR=evanm
Review URL: http://codereview.chromium.org/21301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=tony (looked over my shoulder before I committed)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9631.
TBR=deanm
Review URL: http://codereview.chromium.org/23023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/20247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
popup mode pixel perfect except for the off-by-one sizing regression caught by the interactive UI test, which I haven't figured out yet.
BUG=5054
Review URL: http://codereview.chromium.org/18862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the views we'll need.
Review URL: http://codereview.chromium.org/18720
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Path name translation (/ to \) of various MSVSTool attributes.
* Explicit keyword= arguments to MSVSProject. This will likely
go away eventually in favor of uniform behavior.
* Add a relative_path_substitutions array that can be used
to substitute in Visual Studio variable like $(OutDir).
* Add a local_directory_prefix that can be set to './' to only
affect files in the current directory.
* Additional Keyword ordering in Tool attributes to continue to
match the default order Visual Studio generates.
* Add a Derived() proxy class that can wrap a File node to tell
the .vcproj generation that we want the derived file, not its
source(s), in the file list.
* In the individual *.scons files, add the necessary files (mostly
.h files) to file lists, and update MSVSProject() calls with
the additional necessary information.
Result is identical .vcproj files modulo the following differences:
* Four locales .vcproj files (da, en-US, he and zh-TW) with
source file orders that don't match the other locale .vcproj
files have re-ordered file lists to match the rest.
* Cosmetic XML changes (white space, ending tags) in:
chrome/app/chrome_dll.vcproj
chrome/app/generated_resources.vcproj
net/build/net_resources.vcproj
* Removal or addition of ./ prefixes from various files that don't
match the other file specifications within their individual
.vcproj files:
chrome/installer/util/util.vcproj
net/build/net.vcproj
net/build/net_unittests.vcproj
* Add missing empty sections (<ToolFiles>, <References>, <Globals>)
for consistency with other .vcproj files:
chrome/tools/test/image_diff/image_diff.vcproj
third_party/libpng/libpng.vcproj
third_party/zlib/zlib.vcproj
* Add missing RootNameSpace attribute:
chrome/test/automation/automation.vcproj
testing/gtest.vcproj
* Use && instead of \r\n as a command separator, to sidestep
XML-generation problems:
chrome/app/chrome_exe.vcproj
* Remove unnecessary (?) duplicate files in the file list:
chrome/browser/views/browser_views.vcproj
(event_utils.cc and event_utils.h were duplicated)
Review URL: http://codereview.chromium.org/17603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
|