| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=41286
TEST=none
Review URL: http://codereview.chromium.org/3258011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation.
BUG=46221
TEST=The upgrade item should now appear under instead of replacing the about command.
Review URL: http://codereview.chromium.org/3143046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- On by default for apps, off by default for extensions.
- Split mode means "run incognito extensions in a separate process if the user
says OK, and the two processes can only see their own profile."
- Spanning mode is what we have now, and means "run a single extension process,
but allow it to access both profiles if the user says OK."
BUG=49232
BUG=49114
TEST=extensions still work in incognito when you check "Allow in Incognito".
Review URL: http://codereview.chromium.org/3210007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not need any manually created and maintained policy-templates anymore. Therefor we delete them.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3229010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/52916
TEST=None
TBR=alcor
Review URL: http://codereview.chromium.org/3271003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add unit tests to adm_writer, clean up other writer unit tests and fix list policies generated by adm_writer. (Move KEYNAME into the PART structure.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3284006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://imgur.com/gkbct.png (normal)
http://imgur.com/ue6ao.png (hover)
BUG=51906
TEST=none
Review URL: http://codereview.chromium.org/3218006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed the mixed state icon not showing for section Connection. I overlooked the fact that we already check for mixed content, but reported state as error (whereas now we want warning).
Added link to help center explaining what this dialog means.
BUG=http://crbug.com/52916
TEST=SSL Infobubble should show link to help center and should show mixed content icon when, for example, you open an email in Gmail with an external image embedded in it.
Review URL: http://codereview.chromium.org/3221005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53248
Review URL: http://codereview.chromium.org/3250002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6046
TEST=manually
Review URL: http://codereview.chromium.org/3218004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53399
TEST=none
TBR=trungl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already submitted).
TabContents.xib changes: it was converted to the latest IB version and vertical NSSplitView was added to it
as a child for existing horizontal NSSplitView hosting devTools; new one hosts page content and sidebar content.
BrowserWindowCocoa instance listen to SIDEBAR_CHANGED notification and updates sidebar content view according
to the sidebar state linked to the current tab (adds or removes the corresponding view).
Sidebar API design doc: http://www.chromium.org/developers/design-documents/extensions/sidebar-extension-api.
BUG=51084
TEST=Run browser_tests and interactive_ui_tests.
Review URL: http://codereview.chromium.org/3228003
Patch from Aleksey Shlyapnikov <alekseys@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download in progress"
increased the size by 8% for es, it, ja, fr, ru, pt-BR and ko and verified that it fits
BUG=32164
TEST=In the bug. Original issue was on XP classic, please test there as it is most limited in the sense of space.
Review URL: http://codereview.chromium.org/3224004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53812
TEST=none
Review URL: http://codereview.chromium.org/3217009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Rename various binding targets.
BUG=53830, 53834
TEST=Mac prefs get disabled properly when configuration policy is in effect.
Review URL: http://codereview.chromium.org/3274006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53315
TEST=manual
Review URL: http://codereview.chromium.org/3162030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Bind Enabled state of password manager radio matrix and button to the new @properties.
BUG=52830
TEST=Change password manager policy, watch preferences UI.
Review URL: http://codereview.chromium.org/3241005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3259001
Adds curtain screen with "Checking for updates..." label and throbber to update screen. Curtain screen is shown at most 15 secs.
BUG=hromium-os:2444
TEST=Go through updating process and notice that first 15 seconds only spinner with "Checking for updates..." label is shown. After 15 seconds usual update progress screen is shown.
Review URL: http://codereview.chromium.org/3275004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default values instead.
BUG=chromium-os:5933
TEST=manually
Review URL: http://codereview.chromium.org/3181035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fix the bug where the wrench disappears on hover.
BUG=53248,52199
Review URL: http://codereview.chromium.org/3236001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3243009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51897
TEST=ConfigurationPolicyProviderWinTest.*
Review URL: http://codereview.chromium.org/3133012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This code has no effect unless --enable-dnssec-certs is given.)
The existing DNSSEC code will process embeded chains in certificates
and validate CERT records there in. The format of the CERT record was
just something made up as a proof of concept. This change switches
that code to using TXT records which are at least used by some other
code.
Additionally, when --enable-dnssec-certs is given. TXT record lookups
are triggered for each HTTPS connection. If DNSSEC secure, these
lookups can validate a HTTPS certificate. Even without DNSSEC, they
can by used for exclusion: if TLS fingerprints are given, but the
certificate doesn't match any of them, then the certificate is
rejected.
The next step in this series will be to perform the TXT lookup for
some percentage of dev channel users in order to measure the latency
impact. For this experiment, all behavioural changes will be disabled.
BUG=none
TEST=net_unittests
http://codereview.chromium.org/3148037/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes.
TEST=manual, run chromium on mac and click on the mic button in a speech enabled input element to see the bubble appear.
BUG=53598
Review URL: http://codereview.chromium.org/3214006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change to Preferences.xib: Setup preferences_window_controller.mm as a referencing outlet for the background mode UI so we can hide it.
BUG=53522
TEST=run chrome without --enable-background-mode, make sure associated prefs UI is not shown
Review URL: http://codereview.chromium.org/3246004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R = jshin
BUG = http://crbug.com/45505
TEST= None. These are just data files.
Review URL: http://codereview.chromium.org/3104043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the unused IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_INFO_BAR
message.
R=jcivelli
BUG=27125
TEST=No build errors.
Review URL: http://codereview.chromium.org/3262003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=TEST=none
Review URL: http://codereview.chromium.org/3241004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BackgroundModeManager, to match the gtk/windows versions. Checkbox
sets/clears the kBackgroundModeEnabled preference.
Preferences.xib change: Added new section to under-the-hood,
with a checkbox to enable/disable BackgroundModeManager (which
controls launch-on-login behavior), as well as a link to the help
center section for this feature.
BUG=53173
TEST=Adding BackgroundModeManagerTest.* in separate BackgroundModeManager CL.
Review URL: http://codereview.chromium.org/3199021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prettier error page by default.
TEST=none
BUG=41281
Review URL: http://codereview.chromium.org/3174024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual, try clicking on speech input button without a mic connected.
Review URL: http://codereview.chromium.org/3240002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.
BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57635
Review URL: http://codereview.chromium.org/3152055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3152055
Implement about:labs
Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.
BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3256001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/52916
TEST=Navigate to a page with mixed http and https content. The gray padlock should appear in the Omnibox icon and in the infobubble when you click it.
Review URL: http://codereview.chromium.org/3171031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.
BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)
Review URL: http://codereview.chromium.org/3152055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5609
TEST=none. Hold until flipflam supports are implemented.
Review URL: http://codereview.chromium.org/3112035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53449
TEST=No visible impact. Everything should still work.
Review URL: http://codereview.chromium.org/3189026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3189012/show
Implemented "Go incognito" button that appears in bottom right corner
if oobe process is done. Otherwise usual "browse without signin" link
appears in the new login entry.
BUG=chromium-os:5630
TEST=When login screen is loaded there is button in bottom right corner (if no OOBE status bar).
Review URL: http://codereview.chromium.org/3195029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changelist.
This is not the final image, just a placeholder for alcor to replace.
BUG=52916
TEST=None
TBR=jcivelli
Review URL: http://codereview.chromium.org/3191028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can choose no restore, last opened windows, or specific pages to be opened.
xib changes: Added an enabled binding to the policy-controlled "Restore on Startup" radiobox group in the "Basic" preference pane. They can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.
BUG=49297
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* Manual tests: Set the policies externally. Check that appropriate restore action is done at startup. Check that the Restore on Startup buttons are disabled.
Review URL: http://codereview.chromium.org/3115021
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3440
TEST=checked chrome_log that no warnings are written.
Review URL: http://codereview.chromium.org/3159041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added Certificate Information link.
- Changed iconography to be:
Identity : Green check mark vs. Red skull and bones
Connection: Green padlock vs. Orange exclamation point.
(This used to be Green checkmark and Orange Exclamation point for both sections.
- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.
BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.
Review URL: http://codereview.chromium.org/3187019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac and Linux, keep the client id in a global variable kept by the
child_process_logging implementations. This allows to read it in a
thread safe fashion when starting a child process.
Also replace std::string with statically allocated buffers for the
various items we add to the crash reports. This allows to properly
handle crashes upon shutdown (std::string would run its destructor,
invalidating the memory).
BUG=53231
TEST=Crash reporting should still work
Review URL: http://codereview.chromium.org/3186028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't do any behavior changes -- it just implements
the styling. So we still have multi expand, and the recently
closed section is still toggleable.
I also didn't make the changes to the placement or text of
the web store icon. I will make those separately.
Screen caps:
http://aaronboodman.com/z_dropbox/cr3156049/
BUG=53248
Review URL: http://codereview.chromium.org/3156049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This currently displays a nonsensical message, but I can't
think of any good way to change the text to describe the
key, e.g. "Exit full screen (fourth key from the left on the
top row of the keyboard)". :-P
We'd ideally include an image of the keycap in the middle of
the text, but that seems like it'll require a decent amount
of Views hacking, and will be a pain to maintain while we're
still in the process of playing around with things like font
sizes (but I've created an image that works with the current
text size, if someone more Views-proficient than me wants to
take this on). Glen agreed that this is an acceptable
compromise in the meantime.
BUG=chromium-os:3916
TEST=tried it
Review URL: http://codereview.chromium.org/3181042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53248
TEST=none
Review URL: http://codereview.chromium.org/3126031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57431 0039d316-1c4b-4281-b951-d872f2087c98
|