summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* This is r4523, with a few changes to make things work under Vista.erg@google.com2008-11-054-0/+5
| | | | | | | | | | | | | - Explicitly set_delegate(NULL) before releasing a TabContents. (I think the order messages are getting handled is different from XP; this only seems neccessary under Vista.) - r4523 and someone elses change added entries to theme_resources.rc at roughly the same time, causing happy fun crashes. - Roll in sgk's SConscript fix. Review URL: http://codereview.chromium.org/9373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a string we haven't used for a while.pkasting@chromium.org2008-11-051-3/+0
| | | | | | Review URL: http://codereview.chromium.org/9379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4715 0039d316-1c4b-4281-b951-d872f2087c98
* Always write 'dr' key to HKCU.kuchhal@chromium.org2008-11-052-6/+1
| | | | | | Review URL: http://codereview.chromium.org/9291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4710 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs1. http://b/issue?id=1447957 For machine ↵ananta@chromium.org2008-11-043-17/+4
| | | | | | | | installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal Review URL: http://codereview.chromium.org/8221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar Import - Issue 8801, migrated from public tree to svn enlistment.brg@chromium.com2008-11-041-2/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4633 0039d316-1c4b-4281-b951-d872f2087c98
* Enforces strong DEP all the time. Use the /NXCOMPAT linker flag on ↵maruel@chromium.org2008-11-042-21/+8
| | | | | | | | chrome.exe so there's no need to call anything on Vista and later to activate it. Review URL: http://codereview.chromium.org/9050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4609 0039d316-1c4b-4281-b951-d872f2087c98
* Use the worker pool instead of a one-time thread for the breakpad ↵deanm@chromium.org2008-11-042-11/+8
| | | | | | | | initialization. This allows the thread to be reused later. Review URL: http://codereview.chromium.org/9276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4585 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for models to provide addition icons to the tree. Updatessky@google.com2008-11-044-0/+4
| | | | | | | | | | | | the bookmarks folder tree model to return custom icons for search and recently bookmarked. BUG=674 TEST=none Review URL: http://codereview.chromium.org/9047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change r4523 because Vista doesn't like it.erg@google.com2008-11-044-5/+0
| | | | | | | TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
* Adding visual studio solution files.bradnelson@chromium.org2008-11-041-2/+1
| | | | | | | | | Sandbox is currently having a problem with this so it is disabled. Fixed a few stray items. Review URL: http://codereview.chromium.org/9259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4525 0039d316-1c4b-4281-b951-d872f2087c98
* Redo how we block popups. Rip out the old constrained popup window cruft ↵erg@google.com2008-11-044-0/+5
| | | | | | | | (while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests. Review URL: http://codereview.chromium.org/8782 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fragile check in DidProcessCrashcpu@google.com2008-11-031-2/+5
| | | | | | | | | | | | | - the numbers were out of sync with result_codes.h - can't use result_codes.h in base project so I extracted the generic part of it. Rahul: I hope I don't break installer assumptions here. Dan: don't feel obligated to review. Review URL: http://codereview.chromium.org/9012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4519 0039d316-1c4b-4281-b951-d872f2087c98
* Update some spell-checker stringsglen@chromium.org2008-11-011-2/+2
| | | | | | | | BUG=3956 Review URL: http://codereview.chromium.org/8987 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4384 0039d316-1c4b-4281-b951-d872f2087c98
* Localization tweaks.sky@google.com2008-10-312-2/+2
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where languages that have a long string for thepaulg@google.com2008-10-3143-0/+45
| | | | | | | | | | | | | | | | dangerous download warning cause an overlap with the label for that download's URL. We now use a locale-specific pixel value which changes the height of each download's view on the download page so that this overlap no longer happens. BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824) Review URL: http://codereview.chromium.org/8933 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4323 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd part of the reorganize options under 'UnderTheHood' (bug 3655):finnur@google.com2008-10-3143-45/+127
| | | | | | | | | | The link 'learn more' now points to a yet-to-be-created article in the help center. I moved it also, so that it appears to the right of the label (instead of below the label). And finally, I added missing definitions for the Bookmark Manager, which I noticed while I was changing this. Review URL: http://codereview.chromium.org/8777 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4317 0039d316-1c4b-4281-b951-d872f2087c98
* Adding preferences and clear browsing data for form autofill.jcampan@chromium.org2008-10-312-10/+9
| | | | | | | | BUG=None TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill. Review URL: http://codereview.chromium.org/8740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4292 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate same constant defined in three different places. No change in ↵kuchhal@chromium.org2008-10-311-9/+4
| | | | | | | | chrome.exe size. Review URL: http://codereview.chromium.org/8409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4284 0039d316-1c4b-4281-b951-d872f2087c98
* Make clear browsing data dialog wider in finnish, so that the 'clearing..' ↵glen@chromium.org2008-10-301-1/+1
| | | | | | | | | | text isn't truncated. BUG=3836 Review URL: http://codereview.chromium.org/8922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4252 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an imported string that will be used when we handle importing ofsky@google.com2008-10-301-1/+4
| | | | | | | | | | | bookmarks. BUG=674 TEST=none Review URL: http://codereview.chromium.org/8743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4248 0039d316-1c4b-4281-b951-d872f2087c98
* The strings required for the upcoming autofill UI.jcampan@chromium.org2008-10-301-0/+11
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4194 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the bookmark manager. There are still a fair number ofsky@google.com2008-10-294-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | rough edges, but I'm at a good point where I want to land what I have. Here's what is left: . Flicker on show, likely the result of restoring window placement. . tree flickers when dragging splitter. . table/tree need to autoscroll when drop cursor held at bottom of view. . prompts for deleting. . When you move an item the table snaps to the top, this is because I'm sending out model changed. need a better notification. . Operations in menu to add need to change selection. . Remember split location. I would have preferred to split this up into a couple of reviews, but everything is intertwined now. Sorry. BUG=674 TEST=don't test the bookmark manager yet, but make sure bookmark bar still works. Review URL: http://codereview.chromium.org/8197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
* Added strings to support Spellchecker operations in the context menu.sidchat@google.com2008-10-291-0/+12
| | | | | | Review URL: http://codereview.chromium.org/8710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4160 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to disable/enable Spell Check. In addition, remove additional ↵sidchat@google.com2008-10-291-1/+4
| | | | | | | | | | code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter. Issue = 120 Review URL: http://codereview.chromium.org/7935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a string that we'll need when importing bookmarks.sky@google.com2008-10-292-0/+6
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4124 0039d316-1c4b-4281-b951-d872f2087c98
* Change our phishing 'learn more' URL to something that will soon be translated.glen@chromium.org2008-10-2842-42/+42
| | | | | | | | BUG=2804 Review URL: http://codereview.chromium.org/8196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4104 0039d316-1c4b-4281-b951-d872f2087c98
* Adds strings needed for the bookmark manager.sky@google.com2008-10-281-0/+18
| | | | | | | | | BUG=3784 TEST=none Review URL: http://codereview.chromium.org/8837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4083 0039d316-1c4b-4281-b951-d872f2087c98
* Do not localize the name of 'download' directory. Chrome's UI languages can bejungshik@google.com2008-10-281-6/+0
| | | | | | | | | | | | | | | | | | | changed and a user will be confused as to where her download goes. Add DIR_DEFAULT_DOWNLOADS to chrome_paths (which is set to 'Downloads' under DIR_USER_DOCUMENTS) and use that in both save_package and download_manager. This patch does not offer a migration path. BUG=3097 TEST=Switch Chrome's UI to non-English and download a file. The file should be downloaded to '..\My Documents\Downloads' rather than '..\My Documents\<'Downloads' in that language>. Review URL: http://codereview.chromium.org/7945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4049 0039d316-1c4b-4281-b951-d872f2087c98
* Fix new string to the new format.erg@google.com2008-10-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4047 0039d316-1c4b-4281-b951-d872f2087c98
* Add string for the new popup blockserg@google.com2008-10-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/8631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4027 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suggestion to "Learn more about this problem." if there istc@google.com2008-10-271-2/+5
| | | | | | | | | | a redirect loop. We could easily use this for other errors too if there are URLs to the help center. BUG=http://crbug.com/2445 Review URL: http://codereview.chromium.org/8174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4023 0039d316-1c4b-4281-b951-d872f2087c98
* Reshuffling the options in the UnderTheHood section. A summary of my ↵finnur@google.com2008-10-273-2/+10
| | | | | | | | changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here. Review URL: http://codereview.chromium.org/7985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4005 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons modules build on Windows:sgk@google.com2008-10-251-1/+2
| | | | | | | | | | | | | | | * Add 'midl' Tool module. * Filter out the default OS_WINDOWS= definition from the Hammer modules, which messes up our build. * Fix the $PLATFORMSDK_VISTA definition. * Remove the current directory from the 'base' Alias (avoid cycles). * Remove by-hand addition of .lib, .pdb and .ilk files to the target list when build shared libraries (multiple places). * Comment out a post-action Touch() of the themes/default resource. (Thanks to bradnelson for many of the above individual fixes.) Review URL: http://codereview.chromium.org/8207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3980 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Google Cache link from local error pages.tc@google.com2008-10-241-3/+0
| | | | | | | BUG=2712 Review URL: http://codereview.chromium.org/8140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3902 0039d316-1c4b-4281-b951-d872f2087c98
* Update strings based on the most recent dumps from thetc@google.com2008-10-2482-117/+513
| | | | | | | | | translation console. TBR=mal Review URL: http://codereview.chromium.org/7957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3893 0039d316-1c4b-4281-b951-d872f2087c98
* Change installer text messages based on technical write reviewkuchhal@chromium.org2008-10-232-20/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3863 0039d316-1c4b-4281-b951-d872f2087c98
* Add a separate string for showing that chrome updated withouttc@google.com2008-10-231-1/+4
| | | | | | | | | | a version number. This makes it easier for translators to handle both cases. BUG=2656 Review URL: http://codereview.chromium.org/7900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds models needed by the bookmark manager. Specifically asky@google.com2008-10-231-0/+35
| | | | | | | | | | | | | BookmarkTableModel, which will be used to show one of the following: the children of a folder, recently bookmarked or the results of a search. And the tree model implementation that shows the folders. BUG=674 TEST=covered by unit tests Review URL: http://codereview.chromium.org/8063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the already-reviewed <http://codereview.chromium.org/2936> by ↵glen@google.com2008-10-221-0/+3
| | | | | | | | | | | | | developer0420. I updated it to always have reload enabled, as you sometimes want to reload while a page is loading. BUG=204 TBR=ben Review URL: http://codereview.chromium.org/8016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3754 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-222-4/+4
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use UuidCreate as a source of randomness, and it's not portable. This ↵deanm@chromium.org2008-10-211-1/+0
| | | | | | | | removes chrome.dll's dependence on rpcrt4.dll (although it will still likely be loaded later). If the change is fine, I will also remove it from the depends list and the build configuration files. Review URL: http://codereview.chromium.org/7818 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3687 0039d316-1c4b-4281-b951-d872f2087c98
* Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in ↵deanm@chromium.org2008-10-211-2/+0
| | | | | | | | msimg32.dll. The wrapper does a few additional santity checks, which I presume GdiAlphaBlend will have to handle anyway. This means we don't depend on msimg32.dll anymore. Review URL: http://codereview.chromium.org/7813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3656 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Chromium logo so that it's not clipped and is right-aligned ↵glen@google.com2008-10-201-0/+0
| | | | | | | | | | correctly. TBR=sky Review URL: http://codereview.chromium.org/7333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3629 0039d316-1c4b-4281-b951-d872f2087c98
* Now omaha supports displaying custom error string through registry keys.kuchhal@chromium.org2008-10-202-0/+60
| | | | | | Add error strings in Chrome installer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3616 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the default cursive font to 'Comic Sans MS' from 'Script' (that's not ↵jungshik@google.com2008-10-2042-84/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | available on the default Win XP/Vista installation) and the default fantasy font to 'Impact'. 'Impact' is not a 'fantasy' font, but there's no suitable font to use on the default Win XP. Fantasy is very rarely used so that this should not matter. In addition, change the serif font for Simplifed Chinese Chrome to Simsun from Simhei. The current setting is : A. serif : simhei sans-serif : simsun monospace : nsimsun What we should have if we want to keep the diestinction between serif and sans-serif in Simplified Chinese Chrome B. serif : simsun sans-serif: simhei monospace : nsimsun (Chinese has different typographic traditions from the western so that mapping is 'approximate') However, Simhei is rather ugly so that we do the following (losing the distinction between serif and sans-serif) C. serif: simsun sans-serif: simsun monospace: nsimsun So, for both serif and sans-serif, we just use Simsun. With that, even in rare occassions (for Chinese web sites) where serif is specified, we'd use Simsun rather than Simhei. BUG=2830 Review URL: http://codereview.chromium.org/7653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3610 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-171-0/+10
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* The translation lead requested that this sentence be a singletc@google.com2008-10-173-14/+2
| | | | | | | | | string, otherwise it will likely be grammatically incorrect. This is a hack until http://crbug.com/3295 is implemented. Review URL: http://codereview.chromium.org/7396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the following changes to the bookmark bar context menu:sky@google.com2008-10-161-2/+5
| | | | | | | | | | | | . Nukes the open menu item. . Adds open incognito and for folders open all incognito. BUG=144 TEST=Fully test the context menu of bookmark folders/urls. Review URL: http://codereview.chromium.org/7357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3464 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check in Chrome to not run user level mode if machine level Chromekuchhal@chromium.org2008-10-153-0/+7
| | | | | | is already installed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3423 0039d316-1c4b-4281-b951-d872f2087c98
* Make zomm do full page zoom instead of just text zoom.brettw@google.com2008-10-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3359 0039d316-1c4b-4281-b951-d872f2087c98