| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change Clear All to Clear all (Sentence case for all labels)
2. Remove 'uncompleted' from the downloads in progress confirm,
and change 'remove' to just 'cancel' in all cases.
R= glen
BUG= 10954
TEST= Ctrl+J and check that the label in the upper right is 'Clear all'
with a lower-case a.
TEST= Close the browser with a download in progress and verify that the prompt
is
"You have 1 download(s) in progress. If you close Google Chrome now, these
downloads will be canceled."
and the cancel button is
"Close and cancel downloads"
Review URL: http://codereview.chromium.org/92114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This provides basic support for looking up backtrace information on GNU libc systems and in Windows. The code is only enabled for FATAL log messages in debug mode. In a release build, it is unlikely that symbols will be available making the backtrace less useful.
Review URL: http://codereview.chromium.org/62140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to *not* make any behavioral change, but to
instead just get all the plugin-related files linking on Linux with
a bunch of NOTIMPLEMENTED()s in the appropriate places. It's enormous
enough already without any refactorings or new features.
Changes include:
- Lots of gcc warning fixes.
- Use portable replacements for Windows-specific functions (_strdup, etc.).
- Use TransportDIB instead of just shared memory in the plugin messaging.
Note that this is not fleshed out on Linux and on Windows it just hacks
in the existing handles so there should be no functional change.
- Fix --plugin-launcher to use cross-platform APIs.
Review URL: http://codereview.chromium.org/79020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/95002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9022
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/95008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
icon and the text to show the number of closed windows.
BUG=9022
TEST=With more than one window open close a window. Go to the new tab
page and make sure you see an entry for the closed window. The entry
should have the chrome/chromium logo and instead of 'Window' it
should say the number of tabs in the window.
Review URL: http://codereview.chromium.org/92022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
first-run dialog (ta,kn,te,ml)
BUG=10687
Review URL: http://codereview.chromium.org/88017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Link agasint Breakpad from public svn repo.
* Bump DEPS to new svn rev of Breakpad with fixes for 10.5 compilation.
* Fill in code to differentiate between processes types in crash report.
Review URL: http://codereview.chromium.org/88043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel).
Review URL: http://codereview.chromium.org/93025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
testing.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the http scheme, this allows Chromium to be set as a default browser for the Mac.
Review URL: http://codereview.chromium.org/87043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Establishes a ProxyConfig by reading settings from gconf or consulting
environment variables.
BUG=8143
Thanks to ermilov.maxim@gmail.com for his contribution: some ideas<
and code snippets from his patch were folded into this one.
(See http://codereview.chromium.org/49009)
Review URL: http://codereview.chromium.org/60009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8431
Review URL: http://codereview.chromium.org/62097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/77015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9026
"Show saved passwords" and "Exceptions" were splited into
2 dialogs, group together in one single dialog with
different pages by tabbing.
Review URL: http://codereview.chromium.org/67055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Experiment with some effects.
Adds a positioner interface that allows the popup to size itself to the width of the edit view + the width of the star and go buttons. (Basically the toolbar needs to help the popup position itself).
No results yet!
Review URL: http://codereview.chromium.org/68011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).
It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).
For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used.
For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150.
When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY.
While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.
The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac.
TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same.
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.
BUG=7319
Review URL: http://codereview.chromium.org/62064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- some minor string changes
- there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session
- link and favico are opacified as well in remove mode
- now using a dictionary instead of a list to store the URL blacklist for faster access
- now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters)
BUG=None
TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored.
Review URL: http://codereview.chromium.org/69007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add these resources to theme_resources.grd.
Review URL: http://codereview.chromium.org/73030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Create a separate controller for the bar. Hide bar when it's not supposed to be
visible instead of just allowing it to be covered by content (it's not always
covered, which leads to drawing errors).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the title of a JavaScript dialog box contains "Alert"
regardless of how it's made: whether by alert(), prompt(), or confirm().
"Alert" should be there only when the dialog box is created by alert().
Tested by: unittest, ui_tests, manually
BUG=2359
Original patch by yuzo@google.com at http://codereview.chromium.org/67099
Review URL: http://codereview.chromium.org/70002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URL of removed thumbnails is added to a blacklist, which is a user pref.
I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a
fixed number of items, as now we may filter the ones we get back.
Note: this adds between 20 and 30ms to the first NTP load on my machine (a
3 to 5% increase).
BUG=685
TEST=Open the NTP. Click the 'Edit thumbnails' link. Remove some thumbnails.
Press Done. Edit again, use the "Restore removed" link.
Review URL: http://codereview.chromium.org/67037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- In r13569 I removed it from delay load in using_libxml.vsprops
- Here I put it back in a more logical place
BUG=10012
TBR=maruel
Review URL: http://codereview.chromium.org/67073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
amenable to cross-platform implementation.
BUG=9852
Review URL: http://codereview.chromium.org/63093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- it was on delayload now needs to go to regular early bind
- I want to see the perf hit and fix the build :)
TBR=maruel
Review URL: http://codereview.chromium.org/71008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Now build is busted.
TBR=maruel
Review URL: http://codereview.chromium.org/71007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that histograms move data from renderer to browser, there
is less reason to connect to stats counters.
Stats counters were using shared memory, and now they may
plausibly use the histogram's IPC mechanism instead to
move data to the browser. The first step is remove the
inheritance, and teh next (plausible/future) step
would be to implement counters as histograms with only
one bucket.
r=mbelshe
Review URL: http://codereview.chromium.org/66029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(--enable-omnibox2).
This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX.
Also adds new images from Nicholas.
Review URL: http://codereview.chromium.org/67035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
downloads.
BUG=1028
TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode.
Review URL: http://codereview.chromium.org/62131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs.
Review URL: http://codereview.chromium.org/65011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/6138
Review URL: http://codereview.chromium.org/62167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We don't support chromehtml protocol anymore and future installers do not register it
- Avoid stale registry entries to invoke us
BUG=9860
BUG=9862
Review URL: http://codereview.chromium.org/64003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See comment in commit for gory details.
Review URL: http://codereview.chromium.org/53113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
can be done from there.
BUG=2144
Review URL: http://codereview.chromium.org/62113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a "Clear All" link to the downloads page.
Fixes jankiness of the blue bar in the download page as it loads.
Improve rendering time of the downloads page by chunking the number of
download items to do before scheduling the timeout.
BUG=9033
Review URL: http://codereview.chromium.org/62115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe).
By changing the title and disabling the button, we indicate to the user that an action was taken.
BUG=7264
TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops).
Review URL: http://codereview.chromium.org/58014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Use CFBundleVersion for the Keystone version (e.g. 172.2.0.0).
Review URL: http://codereview.chromium.org/63027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI.
For some Indian languages (Malayalam, Bengali and Telugu), we have to
use a bigger size and a font family for that script on Windows.
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.
I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is
recycled to localize the font family (or the list of font families) for html UI.
I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).
BUG=7319
Review URL: http://codereview.chromium.org/57025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/60090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents crash on startup if you have IMEs configured.
Patch from Fumitoshi Ukai.
BUG=9643
Review URL: http://codereview.chromium.org/56176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This also includes bumping the version of avutil from 49 to 50, which means the generated libs and build files are also updated.
Review URL: http://codereview.chromium.org/56129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had to disable RedirectTest because on Linux it triggered
Gdk assertion. It was a bug in our logging <-> glib logging
glue code that didn't make this test fail earlier.
http://crbug.com/9519
Review URL: http://codereview.chromium.org/56072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12947 0039d316-1c4b-4281-b951-d872f2087c98
|