summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Add a meaning attribute to two menu items to prevent string folding ↵thomasvl@chromium.org2010-03-261-2/+6
| | | | | | | | | | into other strings so they can be individually localized on the TC (in all languages). BUG=39182 TEST=none, new string entry will show in TC Review URL: http://codereview.chromium.org/1410001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42784 0039d316-1c4b-4281-b951-d872f2087c98
* Remove this icon, now that it's no longer used (due to my security ↵pkasting@chromium.org2010-03-261-0/+0
| | | | | | | | | | | iconography change). TBR=sky BUG=27570 TEST=none Review URL: http://codereview.chromium.org/1429001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42782 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-262-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Adds obscuring to credit card numbers when displayed.avi@chromium.org2010-03-261-1/+2
| | | | | | | | | | | xib change: added tag to fields that are used for credit card numbers. BUG=http://crbug.com/38259 TEST=as in bug Review URL: http://codereview.chromium.org/1219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42768 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Initial Geolocation UI.thakis@chromium.org2010-03-261-0/+754
| | | | | | | | | | | | | | | For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine. Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL. http://imgur.com/tWJhg BUG=11246 TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears. Review URL: http://codereview.chromium.org/1345005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42756 0039d316-1c4b-4281-b951-d872f2087c98
* Stop abusing cookie strings for local storage and database.jorlow@chromium.org2010-03-262-3/+9
| | | | | | | | | | | | We did the original abuse because we were past the 4.1 string freeze and needed to add new features, but we can fix this for chrome 5. TEST=The labels should be things like "Key:" instead of "Name:" and so on. BUG=34669 Review URL: http://codereview.chromium.org/1317004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42746 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt at http://codereview.chromium.org/1344002joth@chromium.org2010-03-262-4/+3
| | | | | | | | | | | | | | | | Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42739 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from he.xtb to iw.xtb because the translation console istony@chromium.org2010-03-264-4/+6
| | | | | | | | deprecating 'he' in favor of 'iw'. Review URL: http://codereview.chromium.org/1332001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42713 0039d316-1c4b-4281-b951-d872f2087c98
* Updating Chrome's localized strings from the translation console. These ↵robertshield@chromium.org2010-03-2551-478/+140
| | | | | | | | | | strings are generated from checked in .grds from revision 42543. BUG=24305 Review URL: http://codereview.chromium.org/1361001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42665 - broke build as I missed a unit test when building locally.joth@chromium.org2010-03-251-2/+0
| | | | | | | | | | | | | | | | | | | | Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/1367002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42668 0039d316-1c4b-4281-b951-d872f2087c98
* Adds geolocaiton support to the location bar content image model and content ↵joth@chromium.org2010-03-251-0/+2
| | | | | | | | | | | | | | | | | | bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42665 0039d316-1c4b-4281-b951-d872f2087c98
* Remove languages tab from Mac, because languages are set in the System ↵mirandac@chromium.org2010-03-253-831/+738
| | | | | | | | | | | | Preferences. Nib changes: Change the "fonts and languages" string to refer to "fonts" only. Remove the "languages" tab from the "fonts and languages" xib. BUG= 39008 TEST= open preferences in Mac. see no reference to languages in "Under the Hood". Review URL: http://codereview.chromium.org/1306002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42657 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Oriya from the list of UI languages for now because we're not getting ↵jshin@chromium.org2010-03-2514-1046/+0
| | | | | | | | | | | | Oriya translation updated any more. BUG=37562 TEST=On Windows, 'chrome --lang=or' will bring up English Chrome. Review URL: http://codereview.chromium.org/1144001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42655 0039d316-1c4b-4281-b951-d872f2087c98
* First part of new install dialog on Windows. Later changes willaa@chromium.org2010-03-251-8/+34
| | | | | | | | | | add tooltips and implementations on other platforms. BUG=29633 Review URL: http://codereview.chromium.org/1299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42639 0039d316-1c4b-4281-b951-d872f2087c98
* Be consistent about Text Encoding menu names on OS X - use "Encoding" in all ↵jeremy@chromium.org2010-03-252-909/+111
| | | | | | | | | | | instances. BUG=37883 TEST=View->Encoding & page menu (in toolbar)->Encoding menus should exist and have the same title. Review URL: http://codereview.chromium.org/1273001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42609 0039d316-1c4b-4281-b951-d872f2087c98
* Add all the strings required for the geolocation bubble, location bar icon, ↵joth@chromium.org2010-03-251-4/+32
| | | | | | | | | | | and inforbar BUG=11246 TEST=none Review URL: http://codereview.chromium.org/1301001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42599 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make cookie prompt dialog more Mac-likedanno@chromium.org2010-03-251-165/+219
| | | | | | | | | | | | | | | | | | | | | | | As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular. Also added unit tests. xib changes: - Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly. - Change the size of the radio buttons in the "remember" choice to be small rather than regular. - Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string - Move the details view to be below the accept/block buttons. - Change the style of the disclosure control to be a button rather than triangle. Before: http://img257.yfrog.com/img257/3066/picture3fx.png After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png BUG=38208 TEST=manual testing, added unit test for remember/block/accept controls Review URL: http://codereview.chromium.org/1102005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Allow user to change cookie expiration date in cookie promptdanno@chromium.org2010-03-251-20/+104
| | | | | | | | | | | | | | | | | Added the necessary code and madde xib changes to make it possible to select "When I close my browser" as the expiration for a cookie in the cookie prompt dialog. xib changes: - Add explicit outlet to details view controller for the layout tweaker so that can be called explicitly from code. - Modify already existing popup menu for selecting cookie expiration to have the right menu items: item 1 is content.details.expires and item 2 is ^IDS_COOKIES_COOKIE_EXPIRES_SESSION. - Wire the hidden binding of the expiration menu to the key value path content.details.canEditExpiration with a NSNegateBoolean transformer. - Wire the visibility of the "expires" text in cookie details to the key value path content.details.canEditExpiration. BUG=http://crbug.com/38405 TEST=manual testing, new units tests Review URL: http://codereview.chromium.org/1134005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42590 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: certificate viewer: tweak a few extended key usage stringsmattm@chromium.org2010-03-251-5/+5
| | | | | | | | | BUG=18119 TEST=none Review URL: http://codereview.chromium.org/1286006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42574 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: certificate viewer: Add strings for extended key usage details.mattm@chromium.org2010-03-241-0/+66
| | | | | | | | | BUG=18119 TEST=compare to firefox Review URL: http://codereview.chromium.org/1212001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42561 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the password field show the text 'Password' when empty.sky@chromium.org2010-03-241-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1222003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42558 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate Chrome sandbox changes with NaCl (add Win64 support)gregoryd@google.com2010-03-241-3/+1
| | | | | | | | | Two significant changes: - Explicitly allow processes to act as servers for named pipes for pipes with chrome.nacl prefix. This worked implicitly on Win32 but doesn't on Win64. - NaCl broker process does not run in the sandbox (by design) Review URL: http://codereview.chromium.org/1098009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42552 0039d316-1c4b-4281-b951-d872f2087c98
* Completing Chrome Frame localization by adding the resource script ↵robertshield@chromium.org2010-03-242-0/+43
| | | | | | | | | | | containing the dialog template to Chrome's generated_resources.grd. Associated changes in CF to call _AtlBaseModule.SetResourceInstance to get it to load dialog templates from a resource dll. BUG=24305 TEST=The Find in page dialog in full tab Chrome Frame is localized. Review URL: http://codereview.chromium.org/1293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42543 0039d316-1c4b-4281-b951-d872f2087c98
* views/gtk: Set the tooltip text for tab strip and new tab button. estade@chromium.org2010-03-241-0/+3
| | | | | | | | | | BUG=25442 TEST=hover the mouse through either the tab strip close button or the new tab button, see if a tooltip appears. Patch by Thiago Farina original review: http://codereview.chromium.org/669246 Review URL: http://codereview.chromium.org/1254002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42535 0039d316-1c4b-4281-b951-d872f2087c98
* Add "import bookmarks" link to bookmark bar when it is devoid of folders or ↵mirandac@chromium.org2010-03-241-83/+208
| | | | | | | | | | | | links. The link itself was added to the nib as an NSButton; the link and "no bookmarks" text were both embedded in a GTMWidthTweaker to keep them nicely positioned when localized. BUG= 28753 TEST= create browser with empty profile or remove all bookmarks. Link should appear that creates a dialog box which allows you to import data from other browsers, as in Windows version. Review URL: http://codereview.chromium.org/1246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42530 0039d316-1c4b-4281-b951-d872f2087c98
* Add instructions to chrome://extensions page for inspecting popups.rafaelw@chromium.org2010-03-241-0/+3
| | | | | | | | | | | Under "Inspect Active Views", any extension that has a browser or page action will show grayed text directing the developer to right click on the icon and select 'Inspect Popup' BUG=24477 TEST=Install an extension with a page or browser action. Go to chrome://extensions, turn on developer mode. Verify that under "inspect active views", the new instructions appear. Review URL: http://codereview.chromium.org/1198002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42529 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox M5 work, part 1: Security changespkasting@chromium.org2010-03-242-4/+7
| | | | | | | | | | | | | | | | | * Remove yellow background * Move lock icon from right side to left side (only on Win) * Change iconography * Change scheme colors * Add label for "Untrusted website" * Remove tooltip on label This also simplifies the LocationBarView code on Windows now that LocationBarImageView is unnecessary, and reorders a few things to try and be in more consistent/physical order. BUG=27570 TEST=Visit various https sites and see that the security icon is on the left, the scheme is colored, and there is no yellow background. Review URL: http://codereview.chromium.org/1056002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42502 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-242-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to disable individual plug-ins in Plug-ins tab of Content Settings ↵viettrungluu@chromium.org2010-03-242-77/+818
| | | | | | | | | | | | | | (Mac part). .xib change: Add hyperlink button with text "^IDS_PLUGIN_SELECTIVE_DISABLE" and hooked up to -openPluginsPage: of file's owner. BUG=736 TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/. Review URL: http://codereview.chromium.org/1285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42481 0039d316-1c4b-4281-b951-d872f2087c98
* strings for translate infobar's error statekuan@chromium.org2010-03-241-0/+9
| | | | | | | | | BUG=38548 TEST=none yet. Review URL: http://codereview.chromium.org/1283001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42475 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-242-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-242-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Replace about:plugins page with new page.viettrungluu@chromium.org2010-03-241-32/+0
| | | | | | | | | | | | Do this by "remapping" about:plugins to chrome://plugins/. Also delete old about:plugins page and associated strings. BUG=736 TEST=Go to about:plugins; should get new plugins page (same as chrome://plugins/). Review URL: http://codereview.chromium.org/1219005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42434 0039d316-1c4b-4281-b951-d872f2087c98
* Add MSAA Accessible information to Find bar.mhm@chromium.org2010-03-241-0/+9
| | | | | | | | | BUG=9606 TEST=Inspect32 has accessible names for those components. Review URL: http://codereview.chromium.org/1110013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42424 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple resource loader to Chrome Frame that is capable of finding, ↵robertshield@chromium.org2010-03-242-0/+24
| | | | | | | | | | | | | | | loading and extracting resources from the Chrome locale DLLs. Add the Chrome Frame resource strings to the Chrome .grds so they get built directly into the Chrome locale dlls. There is one remaining todo here, which is to load the dialog template into a grd + rc somewhere (probably in generated_resources.grd) and then get CF to load dialog templates from a different module. Will do that in another patch. BUG=24305 TEST=Chrome Frame when loaded on machines whose locales are not US English will display strings appropriate to those locales. Review URL: http://codereview.chromium.org/1240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42423 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome://plugins page that can disable plugins.viettrungluu@chromium.org2010-03-241-0/+41
| | | | | | | | | BUG=736 TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions. Review URL: http://codereview.chromium.org/1085003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
* adding fullscreen support to the mediaplayer.dhg@chromium.org2010-03-242-0/+1
| | | | | | | Tested by loading on device and clicking fullscreen button. (needs most recent codebase) Review URL: http://codereview.chromium.org/1034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of an experimental Extensions Context Menu API.asargent@chromium.org2010-03-231-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The proposal for the API is documented at: http://dev.chromium.org/developers/design-documents/extensions/context-menu-api Notable limitations in this initial implementation: -No reliable way to get at the unique, actual node clicked on in contexts like IMAGE/LINK/etc. We'll need to fix this in the long run - see the API proposal page for some notes on this. -No update or deleteAll methods ; the only way you can change items is to delete by id and re-add. -We aren't yet matching the UI goal of having the extension items at the top level include the extension icon on the left. This will require a refactoring of RenderViewContextMenu to steal some of the code from the bookmarks bar context menus, which can display favicons. -The only kind of parent->child menu that currently works is if you have a single top-level parent, and only one level of children. (This is because of how RenderViewContextMenu currently works) -No browser tests that the menu items actually get drawn (will wait on those until the above mentioned refactor is complete), or API tests (the API may change a bit based on feedback, at which point I'll write more tests). -Unit tests need to cover some more cases. BUG=32363 TEST=Should be able to create context menus with this API. Review URL: http://codereview.chromium.org/1042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42321 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Extensions to have MSAA information.mhm@chromium.org2010-03-221-0/+6
| | | | | | | | | | | | | The whole extension shelf and its items were missing MSAA information. Some of them were uninitialized due to the custom components not having any AccessibleRole. Some extensions have no name, this could happen where the user didn't put a name for their browser action in the manifest. If such case happens, we will use the extension name itself. BUG=36289 TEST=Extension shelf now has MSAA information according to Inspect32. Screenshot available on the issue tracker. Review URL: http://codereview.chromium.org/1105008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42289 0039d316-1c4b-4281-b951-d872f2087c98
* Check in new icons for omnibox security changes alone, so that my patch to ↵pkasting@chromium.org2010-03-224-0/+0
| | | | | | | | | | | actually use them can be tested on the tryservers. BUG=27570 TEST=none TBR=sky Review URL: http://codereview.chromium.org/1167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-222-3/+0
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-222-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-222-3/+0
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-222-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42156, r42157, r42160. Allow dynamic switching in and out of ↵thestig@chromium.org2010-03-201-3/+0
| | | | | | | | | | | | sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dynamic switching in and out of sidetabs mode.ben@chromium.org2010-03-191-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1001003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42156 0039d316-1c4b-4281-b951-d872f2087c98
* Notification for battery with <= 15 minutes remaining.seanparent@google.com2010-03-191-0/+7
| | | | | | | | | BUG=521 TEST=none Review URL: http://codereview.chromium.org/1079007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
* String translations (not final)oritm@google.com2010-03-1953-698/+721
| | | | | | Review URL: http://codereview.chromium.org/1085004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42131 0039d316-1c4b-4281-b951-d872f2087c98
* Update allow-extension-in-incognito warning dialog text based on UI feedback.mpcomplete@chromium.org2010-03-181-1/+1
| | | | | | | | | | Also fix a small issue with double-clicking a link in the extensions UI. BUG=37789 Review URL: http://codereview.chromium.org/1042009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42004 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 22:51:03 +0000