| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
as we have not hooked it up to ChromeOS shared library wifi code yet.
TEST=none
BUG=23090
Review URL: http://codereview.chromium.org/231014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- l10n the menus
- l10n the dangerous item buttons
- make view auto size for the dangerous item buttons
TEST=download shelf item buttons and menus are localized
BUG=20529
BUG=20530
Review URL: http://codereview.chromium.org/245009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ctrl-shift-w should close your current window.
Review URL: http://codereview.chromium.org/231025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Add PROFILE_IMPORT_PROCESS type to ChildProfileInfo.
* Other small bits of cleanup.
Review URL: http://codereview.chromium.org/220027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caches
These values are currently exposed via about:histograms/WebCoreCache. This change allows for users to monitor the cache sizes in real-time broken out by renderer.
TEST=Open task manager, right click on chrome, select columns, observe that they update along with browsing.
BUG=16221
Review URL: http://codereview.chromium.org/217010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Modify the Mac First Run dialog so that if the system in question doesn't have any browser profiles to import from, we don't display the option.
* Modify SafariImporter to only be enabled if the current user's account actually has a profile attached to it.
Review URL: http://codereview.chromium.org/218039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When sending an HTTP POST request with sufficiently large payload data (such as
uploading a file or several), the status bar should display the progress in the
form of a percentage. The ResourceDispatcherHost periodically sends upload
progress messages to the UI thread as well as to the renderer. If an upload is
occurring, other potential LoadStateChanged messages to the same RenderViewHost
are ignored; this prevents the upload progress display from being interrupted
periodically by "Waiting for <site>" messages.
Original code review:
http://codereview.chromium.org/211050
Original patch by Simon Radford
r=darin
BUG=4715
TEST=Try uploading one or more files (e.g. at a file hosting site) and confirm
that the percentage is shown in the status bar.
Review URL: http://codereview.chromium.org/244001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/238003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hook the NSMenu's delegate up to the ToolbarController in the nib and
generalize EncodingMenuControllerDelegate to work with a NSMenu
object instead of grabbing the app menu.
BUG=22639
TEST=ToolbarControllerTest.PopulateEncodingMenu
Review URL: http://codereview.chromium.org/225016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wrap more
things in USE_LINUX_BREAKPAD while we're at it.
BUG=21782
TEST=Add time.sleep(10) to /usr/bin/lsb_release; starting Chrome should not take 10 seconds more.
Review URL: http://codereview.chromium.org/209042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add touchpad sensitivity setting.
BUG=22848
TEST=none
Review URL: http://codereview.chromium.org/223012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22067
TEST=No more random strings in crash client GUIDs.
Review URL: http://codereview.chromium.org/213038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- tab menus
- page and tool menus
- menubar sub menus
TEST=the above menus should show up in Title case on Mac/GTK. these are new strings, so they will need new translations for the languages.
BUG=22254
BUG=22255
BUG=22256
Review URL: http://codereview.chromium.org/214056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/219007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories to prevent them from stomping each other when they have names that
are the same.
Also adding some dependencies on theme_resources, webkit_resources,
that were missing, but undetected due to everyone sharing the same output
directory.
BUG=22385
TEST=None
Review URL: http://codereview.chromium.org/208056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functionality. Call into it and show new battery images
Review URL: http://codereview.chromium.org/215025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome
Review URL: http://codereview.chromium.org/217020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Change hardcoded "Google Chrome" to product name.
- Implement for GTK.
BUG=21652
Review URL: http://codereview.chromium.org/212051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/217018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty
TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark
BUG=17360
Review URL: http://codereview.chromium.org/216052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/209023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22517
TEST=tried it and decided it looks fine
Review URL: http://codereview.chromium.org/212044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Default to Title Case strings for Mac and Linux/GTK.
Pass an extra define to the invoke of grit for TitleCase strings.
Test the define for grit Title Case strings and have two sets of strings where needed.
DEPs roll to pick up a new GYP that will keep int values as ints.
BUG=22253
TEST=The bookmark bar menus on Mac and linux gtk will be Title Case, in Windows and ChromeOS they will be Sentence case. NOTE: we'll the translations in the Title Case areas until new translations are entered.
Review URL: http://codereview.chromium.org/210022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Doc some environment variables.
Review URL: http://codereview.chromium.org/215050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once again, we're changing the implementation from an NSTextField to an
NSTextView. The text is no longer editable, the margins have been fixed
to not be standard cocoa margins and the font is explicitly set to
Lucida Grande.
After talking with jrg, I think the text should be selectable.
BUG=20493
BUG=20855
Review URL: http://codereview.chromium.org/216028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/214034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is more work-in-progress for the OS X task manager. The table header is complete (the right columns are there, and right-clicking the header gives a column-selection context menu just like in e.g. Task Manager), and the rows data is displayed. However, all the metrics (memory, cpu, etc) seem to be all wrong. Because of this and because too much stuff is still unimplemented (favicons in rows, the "kill process" button, the link, etc), I won't commit the change to MainMenu.xib, so users still won't be able to open this dialog.
BUG=13156
TEST=Connect view->task manager to first responder's commandDispatch:, set the menu item to "enabled", and give the menu item the tag 40005. Now opening the task manager should actually display data. Right-clicking the table header should show a functional menu that lets you select which columns to display. Clicking a column header should not select the column, double-clicking an item should not edit it. Also, when resizing the task manager, stuff should now behave in a sane way.
Review URL: http://codereview.chromium.org/208043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the universe used them".
BUG=22353
TEST=None
Review URL: http://codereview.chromium.org/210033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22177
TEST=tooltip no longer has a $1 and has the product name.
Review URL: http://codereview.chromium.org/215032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22001
TEST=Oulined in bug.
Review URL: http://codereview.chromium.org/216029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make the edit search engine window a sheet.
* Only allow one instance of the search engine manager to be opened at once.
* The search engine manager now remembers its position.
* Create NSWindow(LocalStateAdditions) category to assist with storing window
position in Chromium's local state.
BUG=21761,21762,21883,21996
TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position.
Review URL: http://codereview.chromium.org/207027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
long since been replaced by generated files from gyp.
Review URL: http://codereview.chromium.org/213013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I just changed the shelf to autosize horizontally and to be anchored at the bottom and the left and right sides in IB (it was anchored to the top left before and had no autoresizing).
BUG=none
TEST=Enable extension shelf in browser_window_controller.mm (turn #if 0 into #if 1), then build & start chromium. Resize the browser window. The shelf should now stay at the bottom of the window and stay sane.
Review URL: http://codereview.chromium.org/208023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14908
TEST=Findbar should animate open and closed, unless switching tabs.
Review URL: http://codereview.chromium.org/195105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms. This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms.
Remove the autoseparating_menu since it is no longer used.
TEST=Prefs just has a reset button and no theme popup list.
BUG=none
Review URL: http://codereview.chromium.org/214011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This rolls back 26540, gregoryd's attempt at a nacl landing.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/213019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required
TBR=bradnelson
Review URL: http://codereview.chromium.org/207025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r25955.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add touchpad speed factor setting to Chrome OS touchpad settings page.
Created slider widget with native gtk widget.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/209016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is currently only used on OS X.
We need a separate process to do profile import for 3 reasons:
1)In Firefox we load external libraries which we have no control over.
2)Conceptually it's safer to run parsing code OOP.
3)quoth chrome/browser/importer/nss_decryptor_mac.mm :
"""
On OS X the nss3 libraries are compiled with depedencies
on one another, referenced using dyld's @executable_path directive.
To make a long story short in order to get the libraries to load, dyld's
fallback path needs to be set to the directory containing the libraries.
To do so, the process this function runs in must have the
DYLD_FALLBACK_LIBRARY_PATH set on startup to said directory.
"""
BUG=14458
TEST=None Possible
Review URL: http://codereview.chromium.org/193131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
relied on making the field editable which really doesn't work for legal text you show a user
BUG=20493
BUG=20855
BUG=22179
BUG=22180
Review URL: http://codereview.chromium.org/212010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces an NSTextField with an NSTextView so the file owner
can implement some of NSTextView's delegate interface to respond
to links.
While we're here, also add an additional newline between the main text and the Google build's terms and conditions.
BUG=20493
BUG=20855
Review URL: http://codereview.chromium.org/203084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r26409.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the infrastructure for detecting out of date plugins and warning
the user about them.
Glen was ok with the infobar, although he notes that there will be a
better 'notifications' UI for this sort of thing in the future.
This UI will trigger at most once a day and only when we load the
plugin information.
This patch appears to duplicate some information from plugins2.xml,
which is the plugins database that the default plugin uses to install
missing plugins. I'm not reusing that information in this patch:
* Note that the names of the plugins are different between the two.
plugins2.xml uses a 'friendly' name, while this code needs to know
the name that the plugin itself uses.
* Also note that URLs are different. plugins2.xml wants a link to an
exe for the installer, while we want a landing page.
* The code for loading and parsing plugins2.xml is in the default
plugin, and thus would require a lot of major refactoring to use
here.
Regarding the second point, above. One could imagine that we open a
tab to "about:update-plugin#MAGICSTRING,application/x-shockwave".
Javascript on that page notes the fragment in the URL and creates a
plugin of the correct type on the page, passing MAGICSTRING to the
plugin. The renderers are updated to know that all plugins on about
pages should be directed to the default plugin.
The default plugin notes the MAGICSTRING argument and uses a new NPAPI
call to validate the string. MAGICSTRING will be a random string,
created once per instance which is needed so that the default plugin
can know that it's running on behalf of the browser, not some random
webpage. When it validates, it doesn't wait for the user to click
inside the plugin to trigger the download. It also doesn't trigger a
page reload afterwards, instead draws text to the effect of
"Successful install".
This alternative design would remove the duplication, at the cost of a
lot of work. Since it's a UI question, I asked Ben and Glen. However,
they didn't get back to me so, for now at least, this simplier
solution will suffice.
BUG=21100
http://codereview.chromium.org/197053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unable to find tagged nodes) more gracefully by triggering the
unrecoverable error handler.
This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens.
Review URL: http://codereview.chromium.org/201119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics with a slightly darker set from Nicholas.
The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one.
BUG=21028
TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position.
Review URL: http://codereview.chromium.org/195099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib changes:
- Remove the "utility," "minimize," and "hide on deactivate" bits from the
window.
- Remove the "rich text" bit from the title text field.
- Remove the "selectable" bit from the version text field.
BUG=21918
TEST=About box should not float above other windows
Review URL: http://codereview.chromium.org/206019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the class name to match a rename that happened before commit.
Make the label size changes force the fields over, but not string the fields (window grows).
Make the url description autosize to the text it gets.
Make the window track the height needed for the url description field.
BUG=21893
TEST= The url description text should stay under the url box in all languages. The labels should never clip or overlap the text fields.
Review URL: http://codereview.chromium.org/195096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26342 0039d316-1c4b-4281-b951-d872f2087c98
|