| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit link.
BUG=14958, 15073
TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.
Review URL: http://codereview.chromium.org/146108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15078
TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch.
Review URL: http://codereview.chromium.org/146088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13821
TEST=Verify that the home hover and pressed states look right
TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13152
TEST=Navigate to about:hang in a tab, verify that the dialog comes up.
Review URL: http://codereview.chromium.org/146012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crash reporting broke on Linux when we enabled the zygote model a
couple of weeks ago.
We can't just add "zygote" to the check for the process type because
the crash signal fd is set at the same time and that will change when
a renderer is forked from the zygote.
This fixes it for now, but it will need to be redone when we enable
sandboxing.
http://codereview.chromium.org/147004
BUG=14969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the alert when no printer is installed.
BUG=http://crbug.com/6833
TEST=Print to a printer that fails to print (e.g. MS XPS printer and cancel save). Try to print when no printer is installed.
Review URL: http://codereview.chromium.org/141060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of manually formatting it.
BUG=14878
TEST=Open a new window with at least 2 tabs. Close it and go to the
NTP and it should say "2 tabs" under recently closed.
Review URL: http://codereview.chromium.org/144022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not implemented but it is time to get this submitted and iron out the
remaining issues.
BUG=13362
TEST=Start chrome with --new-new-tab-page and look at play arouind with
the new tab page.
Review URL: http://codereview.chromium.org/132027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
two descriptions in hopes of helping the translators.
BUG=12442
TEST=none
Review URL: http://codereview.chromium.org/141001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hood panel to be more like on windows and remove stuff that's not needed. Disable all prefs that aren't currently hooked up.
BUG=none
TEST=Prefs on first two panels haven't stopped working.
Review URL: http://codereview.chromium.org/140004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting turned on to prevent their dependencies from assuming they emit an
import libary. This implies that these two targets should be loadable_module,
rather than manually setting IgnoreImportLibrary.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/132080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_locale_settings.
Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings).
There are no code changes.
BUG=http://crbug.com/7319
TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does).
Review URL: http://codereview.chromium.org/131060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14665
TEST=Download something, check that "show all downloads" text is on
shelf, click it, check that the downloads tab opens.
Review URL: http://codereview.chromium.org/132073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also correctly handle crashes in task manager. The infobar allows user to restart the extension process.
TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash.
http://crbug.com/14111
Review URL: http://codereview.chromium.org/126289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode".
BUG=13758
TEST=restoring closed tabs with visible windows and with no windows remaining open.
Review URL: http://codereview.chromium.org/125257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also touch up some include guards and a comment.
Review URL: http://codereview.chromium.org/131054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no browser profile is found from which we can import, disable the import
button. This was not problem on Windows since we always had IE.
BUG=14489
TEST=Rename your Firefox profile dir (~/.mozilla/firefox) and make sure that the import button is disabled on the import dialog box.
Review URL: http://codereview.chromium.org/131075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has lots of missing stuff (e.g. a custom download item view that shows
download progress, the popup is the same for in-progress and completed
downloads, no animation, everything looks ugly, the info bubble overlaps the
shelf when it's visible, no "open download manager page" link, etc), but the
basic functionality is hooked up: The shelf appears when files are downloaded,
and something ugly is added to the shelf for each download. The popup's "Reveral
in Finder" even works. The shelf is per-window as it should be.
BUG=12500
TEST=Download something and check the shelf appears. Click the close button and
make sure it disappears again.
Review URL: http://codereview.chromium.org/93129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14460 (http://crbug.com/14460)
TEST=Cmd+S on Mac should bring up the save page dialog.
Review URL: http://codereview.chromium.org/126299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No visible changes yet
Review URL: http://codereview.chromium.org/131010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Splits out the code that was in chrome/browser/views/page_info_window.{cc,h}
into a platform-independent class PageInfoWindow in
chrome/browser/page_info_window.{cc,h}
- The Windows implementation now lives in
chrome/browser/views/page_info_window_win.{cc,h}
- Created a Mac implemenation PageInfoWindowMac in
chrome/browser/cocoa/page_info_window_mac.{h,mm} to bridge to a Cocoa
NSWindowController
- Created a new NSWindowController subclass PageInfoWindowController that is in
chrome/browser/cocoa/page_info_window_controller.{h,mm}
- Created a XIB for the page info window in
chrome/app/nibs/en.lproj/PageInfo.xib
Patch by Robert Sesek <rsesek@bluestatic.org>
Review URL: http://codereview.chromium.org/115116
Review URL: http://codereview.chromium.org/125266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
narrow to hold all of text.
Increased width of bubble by 4+ chars, and for bg increased the height of bubble
by 1.
BUG=12208 (http://crbug.com/12208)
TEST=Run Chrome with --lang=ml, --lang=hi, --lang=pt-PT, --lang=bg. In 'First Run UI', press button 'Start Google Chrome' and see if there's any truncated string in the FirstRun Bubble.
Everytime you run Chrome with different language options, please make sure to delete 'First Run' file in Chrome application folder.
Patch by nciric (cira)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=incognito badge should display correctly in incognito windows.
Review URL: http://codereview.chromium.org/126204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC
Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.
This add support for:
* An "SBX_D" environment variable in the renderers which is used to
signal the end of dynamic linking so that the chroot can be
enforced.
* A sandbox_host process, running outside the sandbox, to deal with
fontconfig requests from the renderers. See the wiki page for
the reasoning behind making it a separate process.
* A new, custom SkFontHost for Skia. Because this is Chrome
specific, it will live outside the upstream Skia tree. This
FontHost can be configured either to drive fontconfig directly
(for the browser process and for any unsandboxed renderers) or to
use an IPC system. Since the same SkFontHost has to be linked into
both the browser and renderer (they are the same binary), this
switch has to be made at run time.
Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.
(Reland of r17575 which was reverted in r17577)
http://codereview.chromium.org/112074
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove urlmon.lib from activex_shim's AdditionalDependencies.
Add urlmon.lib to AdditionalDependencies in chrome_dll.vcproj
and unittests.vcproj.
Add activex_shim as a dependency of default_plugin, so the things
that link against default_plugin get urlmon.lib from the
activex_shim link_settings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=6234 (http://crbug.com/6234)
TEST=Checked the Google Gears screen to see if they got changed.
Wrench > Options > Under the Hood > Web Content
Review URL: http://codereview.chromium.org/125037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxZygote
* Move Chrome specific bits out of base
* Move away from the idea of reserved file descriptors (which don't really work
with zygotes)
* Load resources before forking renderers (means that we don't need
communication between the zygote process and the renderers)
* Make sure that gdb works against the browser again
* Make sure that we have different ASLR between the renderers and the browser.
http://codereview.chromium.org/119335
(This is a reland. First landed in r18109, reverted in r18112.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons get cut off on the right side of the dialog. Instead
of sizing the label text based on a constant from the localized
resources, use the default text size (no-multiline text).
I also tightened up the font preview box to just use
the size of the text + a constant padding on all sides.
BUG=13366
Review URL: http://codereview.chromium.org/125013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behave like calls to new, and will go through the std_new_handler
on crash. For chrome, this means that all out of memory conditions,
be they malloc induced or new induced will cause the process to
abort.
BUG=11475
TEST=none
Review URL: http://codereview.chromium.org/122041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use chrome::kBrowserProcessExecutableName instead
Original patch by tedoc2000@gmail.com
R=nsylvain,cpu
BUG=13724
http://codereview.chromium.org/119405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11824
TEST=Start German Chrome (--lang=de) with Firefox running. Try to import bookmarks and settings
from Firefox into Chrome. The dialog box alerting that Firefox is running should not be truncated.
Review URL: http://codereview.chromium.org/118320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxZygote
* Move Chrome specific bits out of base
* Move away from the idea of reserved file descriptors (which don't
really work with zygotes)
* Load resources before forking renderers (means that we don't need
communication between the zygote process and the renderers)
* Make sure that gdb works against the browser again
* Make sure that we have different ASLR between the renderers and the
browser.
http://codereview.chromium.org/119335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that removed the following strings:
IDS_OPTIONS_CLEAR_DATA_INFO
IDS_OPTIONS_CLEAR_DATA_GROUP_NAME
IDS_OPTIONS_IMPORT_DATA_INFO
IDS_OPTIONS_IMPORT_DATA_GROUP_NAME
These strings are in use internally,
by the personalization module.
Review URL: http://codereview.chromium.org/119402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've kept the old style in there now too since we have --disable-omnibox2 for a short while so QA can compare if necessary.
http://crbug.com/13647
TEST=suggestion completions should be bolded in the omnibox2 dropdown. the first "Search Google For" item should now read "<query> - Search Google" (or whatever your default search engine is).
Review URL: http://codereview.chromium.org/119341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib file changes:
- Set the min browser window size to 400x250.
BUG=http://crbug.com/11844
BUG=http://crbug.com/13015
BUG=http://crbug.com/13017
TEST=Verify that windows have a minimum size. Verify that (with a
single monitor) windows cannot be resized into the dock area, unless
their lower right corner started in the dock area. Verify that
windows can be resized across multiple monitors.
Review URL: http://codereview.chromium.org/118439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13151
TEST=default search popup persistance.
Review URL: http://codereview.chromium.org/119310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Form Autofil is currently just a checkbox. To fit the chomium design, we prefer radios for single questions because it a bit clearer which choice you choose. As well, we merged import data and clear browsing data into browsing data since the page was getting a bit long.
BUG=13222 (http://crbug.com/13222)
TEST=Tested the options pane, the form autofil worked as expected.
Review URL: http://codereview.chromium.org/119146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The lock should still show up on SSL pages.
Review URL: http://codereview.chromium.org/119323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limitations that need addressing still:
- Doesn't forcibly terminate children that should have exited but haven't
Enable with env var ENABLE_ZYGOTE_MANAGER=1.
BUG=11841
TEST=
start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites.
Here's an example script to hide and unhide the .pak files (note: do not move the directory they're in, that doesn't work):
#!/bin/sh
chmod_all() {
chmod $1 sconsbuild/Debug/chrome
for path in . locales obj/chrome/app/intermediate/repack obj/global_intermediate/* themes
do
chmod $1 sconsbuild/Debug/$path/*.pak
done
}
case $1 in
hide) chmod_all 000 ;;
show) chmod_all 755 ;;
esac
Review URL: http://codereview.chromium.org/115773
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first part of the change. I will submit code to listen
for new extension processes while task manager is open in following patch(es).
TEST=Install an extension which renders to the extension shelf, like Buildbot Monitor from http://dev.chromium.org/developers/design-documents/extensions/samples. Open the task manager. You should see the extension process.
http://crbug.com/12127
Review URL: http://codereview.chromium.org/115858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13362
TEST=No visible changes yet.
Review URL: http://codereview.chromium.org/119273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17814 0039d316-1c4b-4281-b951-d872f2087c98
|