summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Hook up the "Reset to Defaults" button in Under the Hood preferences.rsesek@chromium.org2010-06-072-47/+70
| | | | | | | | | BUG=45660 TEST=Chromium-->Preferences-->Under the Hood. Uncheck any one of the checkboxes. Click Reset to Defaults. Previous value gets restored. Review URL: http://codereview.chromium.org/2702003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49072 0039d316-1c4b-4281-b951-d872f2087c98
* Add the remaining Enum types of Mozc configs.yusukes@google.com2010-06-071-4/+104
| | | | | | | | | | | | The original patch was written by mazda@chromium.org. http://codereview.chromium.org/2453003/show BUG=chromium-os:2625 TEST=manual Review URL: http://codereview.chromium.org/2453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49042 0039d316-1c4b-4281-b951-d872f2087c98
* Update combo boxes to use a template systemzork@chromium.org2010-06-071-0/+40
| | | | | | | | | | | | Add chewing hsu selection key type Add pinyin Double Pinyin Schema box BUG=none TEST=none Review URL: http://codereview.chromium.org/2565002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49029 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu item to toggle app tab toolbars.aa@chromium.org2010-06-061-0/+12
| | | | | | Review URL: http://codereview.chromium.org/2690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49016 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48997 [causes Windows unit_tests to hang] - Group plugins in ↵viettrungluu@chromium.org2010-06-051-9/+0
| | | | | | | | | | | | | | | | | | | | | about:plugins and show update link for out-of-date ones. Patch by mavrommatis, original review here: <http://codereview.chromium.org/1991005>. Original description follows: (1) Group plugins with the same name together. (2) Show a download link for plugin versions with known security problems in about:plugins. BUG=3910 TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Review URL: http://codereview.chromium.org/2686001 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/2652002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49003 0039d316-1c4b-4281-b951-d872f2087c98
* Group plugins in about:plugins and show update link for out-of-date ones.viettrungluu@chromium.org2010-06-051-0/+9
| | | | | | | | | | | | | | | | Patch by mavrommatis, original review here: <http://codereview.chromium.org/1991005>. Original description follows: (1) Group plugins with the same name together. (2) Show a download link for plugin versions with known security problems in about:plugins. BUG=3910 TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Review URL: http://codereview.chromium.org/2686001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48997 0039d316-1c4b-4281-b951-d872f2087c98
* Change the Windows UI for notifications one more time. All controls at the ↵johnnyg@chromium.org2010-06-052-0/+1
| | | | | | | | | | | top. No more scrollbar overlap. Wrench icon for the options menu. BUG=44389 TEST=create large notification with scrollbar Review URL: http://codereview.chromium.org/2633001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48993 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Change content settings from showing tabs on top to showing a list on ↵thakis@chromium.org2010-06-041-1217/+1470
| | | | | | | | | | | | | | | | | the side. xib changes: * Set NSTabView's style to "Tabless" (but kept panes in an NSTabView, since it's a convenient method to handle multiple overlapping views in IB) * Put NSTabView into a split view, put a table view in the other split pane of the split view, gave it class TabViewSwitcherTable * changed autosize flags of all child views of the tab view items * Made the NSTabView the tabView_ of the table view BUG=45546 TEST=Content settings window should still work. If it's opened through an omnibox bubble, the right section should still be autoselected. Review URL: http://codereview.chromium.org/2534001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48956 0039d316-1c4b-4281-b951-d872f2087c98
* Added final issue categories to feedback dialog for ChromeOS.zelidrag@chromium.org2010-06-041-26/+14
| | | | | | | | | BUG=chromium-os:3564 TEST=open the feedback/bug report dialog, check the new values in the dropdown Review URL: http://codereview.chromium.org/2553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48947 0039d316-1c4b-4281-b951-d872f2087c98
* Update OOBE welcome screen based on latest mocks.glotov@chromium.org2010-06-041-1/+4
| | | | | | | | | BUG=http://crosbug.com/3279 TEST=none Review URL: http://codereview.chromium.org/2590001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48927 0039d316-1c4b-4281-b951-d872f2087c98
* Show guest login on images login screen.dpolukhin@chromium.org2010-06-041-1/+1
| | | | | | | | | | | Initial version further refactoring should remove login screen and ExistingUserController will be used for OOBE flow. BUG=crosbug.com/2226 TEST=On Chromium OS try other user login, it should be on the same screen (it doesn't work with old window manager). Review URL: http://codereview.chromium.org/2417006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48917 0039d316-1c4b-4281-b951-d872f2087c98
* tabs->spaces in generated_resources.grdestade@chromium.org2010-06-041-106/+106
| | | | | | | | | | this should also kick the builders TBR=cira Review URL: http://codereview.chromium.org/2643001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48900 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the user script that's not utf-8, and show UI that load failed.cira@chromium.org2010-06-041-0/+3
| | | | | | | | | BUG=41571 TEST=Try loading chrome/test/data/extensions/bad/bad_encoding extension. You should get error message about wrong encoding. Review URL: http://codereview.chromium.org/2260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48896 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent installation of an app if its web extent overlaps another installed app.mpcomplete@chromium.org2010-06-031-0/+3
| | | | | | | | BUG=41280 Review URL: http://codereview.chromium.org/2469004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48886 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Creating a new shortcut with enable-udd-profiles uses wrong icon.mattm@chromium.org2010-06-033-6/+3
| | | | | | | | | BUG=44847 TEST=see bug Review URL: http://codereview.chromium.org/2557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48871 0039d316-1c4b-4281-b951-d872f2087c98
* New autofill UI. Still not done:georgey@chromium.org2010-06-032-2/+50
| | | | | | | | | | 1. Countries ComboBox - need countries list. 2. Correct icons size. TEST=in the mocks. BUG=37816,39238,41232,41793,36601 Review URL: http://codereview.chromium.org/2500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48849 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the History menu behave more like the NTP in its display of ↵rsesek@chromium.org2010-06-033-4/+8
| | | | | | | | | | | | | | | | | | | | | recently closed items. Now, the menu will show Window entries that have a submenu of all the tabs. Currently, only the complete window can be restored, not submenu items (representing individual tabs) as this requires changing the TabRestoreService. That will come in a future CL. This CL also significantly refactors the internals of the history menu. XIB changes: Re-assign tag values in the History menu to those used in HistoryMenuBridge::Tags enum. BUG=43787 TEST=Open a window and navigate two tabs. Close window. In the History menu, there should be a "2 Tabs" item in the Recently Closed section. Select that to restore. TEST=Open a window and navigate two tabs. Close one tab. In the History menu, there should be that individual tab entry. Select to restore. Review URL: http://codereview.chromium.org/2481001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48844 0039d316-1c4b-4281-b951-d872f2087c98
* Add Chewing integer preferenceszork@chromium.org2010-06-031-0/+9
| | | | | | | | | BUG=chromium-os:2624 TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there Review URL: http://codereview.chromium.org/2457001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48806 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: implement update notification.estade@chromium.org2010-06-031-0/+11
| | | | | | | | | BUG=45148 TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session. Review URL: http://codereview.chromium.org/2365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cut at scaffolding for mac sidetabs. No visible changes to browser ↵pinkerton@chromium.org2010-06-021-0/+1051
| | | | | | | | | | without --enable-vertical-tabs, and even then, don't expect it to work. BUG=44773 TEST=infobars, bookmark bar, tab strip, etc should all behave correctly when showing, hiding, and widnow resizing. This cl should have no visible impact without the above flag on the command line. Review URL: http://codereview.chromium.org/2475002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48765 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the behavior so that clicking on an item forces a playback, and ↵dhg@chromium.org2010-06-021-0/+3
| | | | | | | | enqueueing an item is available from the menu. Review URL: http://codereview.chromium.org/2436008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48749 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Hook up "Clear Auto-Open Settings" buttonthakis@chromium.org2010-06-021-14/+66
| | | | | | | | | | | xib change: Hook up button to new outlet and action, bind its "enabled" property to fileHandlerUIEnabled. BUG=41794 TEST=Download a pdf and a doc file, open prefs in second window. In the download shelf, check pdf files to auto-open. Button in prefs should become active. Let doc files auto-open. Button should stay active. Disable auto-opening for both types in shelf, button should become inactive. Let pdfs auto-open, click button. Button should become inactive, pdfs should show up as non-autoopening in shelf. Review URL: http://codereview.chromium.org/2473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48736 0039d316-1c4b-4281-b951-d872f2087c98
* Added user image screen for new user login (or old user logging in throughavayvod@google.com2010-06-022-0/+8
| | | | | | | | | | | | | new user screen). If user takes snapshot and hits OK on image screen, the snapshot becomes user image. If user presses Cancel, his image is downloaded via Contacts API. BUG=cros:3175 TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown. Review URL: http://codereview.chromium.org/2118002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48735 0039d316-1c4b-4281-b951-d872f2087c98
* Set the default spellcheck language for Hungarian and Bulgarian jshin@chromium.org2010-06-022-2/+2
| | | | | | | | | | | to Hungarian and Bulgarian BUG=45006 TEST=Start Hungarian / Bulgarian Chrome with a clean profile and see the default spellcheck language matches the UI language. Review URL: http://codereview.chromium.org/2333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48734 0039d316-1c4b-4281-b951-d872f2087c98
* Show spinner on login (both images window and "New user").nkostylev@google.com2010-06-022-1/+1
| | | | | | | | | | | Added alpha channel for spinner. BUG= http://crosbug.com/3299 TEST=If the Sign in is longer than 500ms spinner will be shown. Review URL: http://codereview.chromium.org/2438001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48713 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill remove defaults from settings dialogdhollowa@chromium.org2010-06-022-157/+15
| | | | | | | | | | | The new AutoFill dialog mocks eliminate the need for a "default" address and credit card. Removing code related to UI for these defaults. Nib changes: Removed the "Default" radio button from each of the Nibs. BUG=44621 TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic Review URL: http://codereview.chromium.org/2466002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48687 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing the search button brings the NTP or close it if it is opened.jcivelli@chromium.org2010-06-011-0/+1
| | | | | | | | | | | | Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752 to work. BUG=3404 TEST=See bug. Review URL: http://codereview.chromium.org/2260004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48658 0039d316-1c4b-4281-b951-d872f2087c98
* Added notification for network message.chocobo@chromium.org2010-06-017-1/+10
| | | | | | | | BUG=chromium-os:2556 TEST=manually connect to network with wrong password and see notification. Review URL: http://codereview.chromium.org/2074017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48641 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browse without sign in mode.nkostylev@google.com2010-06-011-0/+3
| | | | | | | | | | | | | | Mount tmpfs, start new session for incognito user. Session manager change http://codereview.chromium.org/2419001 BUG= http://crosbug.com/2849 TEST=Open BWSI mode. Review URL: http://codereview.chromium.org/2371001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48635 0039d316-1c4b-4281-b951-d872f2087c98
* Add Chewing options windowzork@chromium.org2010-06-011-0/+128
| | | | | | | | | BUG=chromium-os:2624 TEST=Open the IME settings window. Add Traditional Chinese. Check that there is an options dialog next to Chewing, and click on it. Review URL: http://codereview.chromium.org/2421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48619 0039d316-1c4b-4281-b951-d872f2087c98
* Add Cangjie layout name.zork@chromium.org2010-05-311-0/+4
| | | | | | | | | BUG=chromium-os:3428 TEST=Open the IME config menu, check that cangjie has a readable name. Review URL: http://codereview.chromium.org/2412001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48595 0039d316-1c4b-4281-b951-d872f2087c98
* Adds side tab layout for chromeos. As part of this I renamed thesky@chromium.org2010-05-282-1/+3
| | | | | | | | | | | | | compact location bar menu to experimental and place both items there. The two are mutually exclusive, so toggling one untoggles the other. Also makes the status bubble not overlap the tabstrip for side tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/2340001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48531 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at experimental omnibox API. There are plenty of rough edges and ↵mpcomplete@chromium.org2010-05-281-0/+15
| | | | | | | | | | | | | | | features to work on, but it's in a usable state. When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later. I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout the omnibox code. BUG=38884 Review URL: http://codereview.chromium.org/2078021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
* Add localized values for keyboard layouts.zork@chromium.org2010-05-281-0/+107
| | | | | | | | | BUG=none TEST=Select a language with keyboard layouts in the IME option window. Review URL: http://codereview.chromium.org/2309001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48472 0039d316-1c4b-4281-b951-d872f2087c98
* landing chaitanya's patchoshima@chromium.org2010-05-281-0/+6
| | | | | | | | Adding accessibility setting to System options Review URL: http://codereview.chromium.org/2127014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48459 0039d316-1c4b-4281-b951-d872f2087c98
* Compile all the chrome_test UI tests on the Macstuartmorgan@chromium.org2010-05-271-0/+9
| | | | | | | | | | | Removes the last of the ui test exceptions on the Mac, disabling a couple of tests as necessary to keep things green. BUG=45108,45243 TEST=Tests run Review URL: http://codereview.chromium.org/2234007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48447 0039d316-1c4b-4281-b951-d872f2087c98
* Change the proxy waiting-for message to:mbelshe@chromium.org2010-05-271-1/+4
| | | | | | | | | | | | | | "Waiting for proxy tunnel..." Add a message for waiting for the SSL Handshake to complete: "Establishing secure connection..." Also make the waiting messages work for SPDY connections. BUG=none TEST=none Review URL: http://codereview.chromium.org/2262003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48430 0039d316-1c4b-4281-b951-d872f2087c98
* Update the man page to better document the --proxy-server command line flag.eroman@chromium.org2010-05-271-2/+32
| | | | | | | | In particular, explain how it can be used to specify SOCKS v4 / SOCKS v5 proxies, and give some examples. Review URL: http://codereview.chromium.org/2221006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48418 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the new tab button to side tabs.sky@chromium.org2010-05-272-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2224003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48389 0039d316-1c4b-4281-b951-d872f2087c98
* Update UI, sync and importer to properly handle managed homepage prefsmnissler@chromium.org2010-05-271-3/+23
| | | | | | | | | | | The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged BUG=43423 TEST=Manual, especially homepage options on general page of options dialog Review URL: http://codereview.chromium.org/2059001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48371 0039d316-1c4b-4281-b951-d872f2087c98
* Widen the preferred language table in the "Languages and Input".satorux@chromium.org2010-05-271-1/+1
| | | | | | | | | | | The change is for fixng trauncation that occurs with German. BUG=chromium-os:3356 TEST=manually Review URL: http://codereview.chromium.org/2220004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48353 0039d316-1c4b-4281-b951-d872f2087c98
* Implement upgrade notifications.finnur@chromium.org2010-05-262-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we detect that the installed version is newer than the version you are running we show a little throbbing orange dot over the wrench menu. If you open the wrench menu and close it again, the throbbing will stop. However, if you look at the contents of the wrench menu you'll notice that the About box menu item has been removed and in its place is a menu item "Update Chrome Now" with a bright orange icon to draw your attention to it. Clicking on the icon shows a dialog box asking whether you want to restart Chrome. If you do, the browser restarts with your session restored (even if you have Session Restore turned off). Known issues: - Currently this is Windows only. We'll have to port this to Linux and do something differnet for Mac (which doesn't have the wrench menu). - Showing an icon in front of Update Chrome causes the checkbox for the bookmark bar menu to go away. Given that we will soon redesign the menus I'm not going to spend much time trying to fix it. BUG=27941 TEST=Wait for Chrome to be upgraded in the background, an orange dot should appear over the wrench menu and if you select Update Chrome your session should be retained. Review URL: http://codereview.chromium.org/2225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
* Resize the "For quick access..." and "Import bookmarks now..." components ↵mrossetti@chromium.org2010-05-261-5/+33
| | | | | | | | | | | | | | | | | | shown in the bookmark bar when there are no bookmarks in the bar, when the window resizes. Show ellipses when each gets trimmed and hide them when they get too small. BookmarkBar.xib changes: Connect the "Import bookmarks now..." button up to the importBookmarksButton_ outlet in the BookmarkBarView. BUG=32557 TEST=1) Start up a browser with no bookmarks on the bookmarks bar. 2) Verify that the "For quick access..." and "Import bookmarks now..." test fully shows. 3) Start shrinking the width of the browser window. 4) Verify that the "Import bookmarks now..." text is shrunk/clipped and finally disappears as the window gets narrower. 5) Continue shrinking the width and verify that the "For quick access..." text is shrunk/clipped with ellipses as the window gets narrower. 6) Grow the window and verify that the "For quick access..." reappears and then the "Import book now..." does. Review URL: http://codereview.chromium.org/2243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48316 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-2/+2
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Added new chromeos-specific values for bug type dropdown in user feedback ↵zelidrag@chromium.org2010-05-262-2/+34
| | | | | | | | | | | dialog. Removed system info checkbox, fixed alignment of the link. BUG=chromium-os:3564 TEST=open the feedback/bug report dialog, check the new values in the dropdown Review URL: http://codereview.chromium.org/2220001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48229 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-251-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed dialog size due to description field height increase.zelidrag@chromium.org2010-05-251-0/+5
| | | | | | | | | BUG=chromium-os:3350 TEST=open user feedback dialog, make sure that all fields are displayed properly Review URL: http://codereview.chromium.org/2146002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48179 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the establishing_tunnel_ internal state and move to explicitmbelshe@chromium.org2010-05-251-0/+3
| | | | | | | | | | | | | states in the state machine for proxy tunnel establishment. Original work from svandebo. BUG=none TEST=existing Review URL: http://codereview.chromium.org/2101014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48173 0039d316-1c4b-4281-b951-d872f2087c98
* Call mac_util::SerOverrideAppBundlePath before invoking DiagnosticsMain for ↵csilv@chromium.org2010-05-251-7/+7
| | | | | | | | | | | | | | | Mac builds. This fixes any tests that rely on the bundle paths. (Currently this affects the 'Inspector Directory' test. BUG=none TEST=Launch Mac client from command line with --diagnostics switch. The 'Inspector Directory' test should pass. Review URL: http://codereview.chromium.org/2107017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48165 0039d316-1c4b-4281-b951-d872f2087c98