| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rkc@chromium.org.
This change hooks issue report dialog with Google Feedback backend for ChromeOS.
The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems.
Image and System Info reporting is disabled at the moment; for image, we need
feedback to get their changes in production, for reporting, the system scripts
need to be added (basic Chrome and OS version info is being sent with the report)
BUG=chromium-os:2761
TEST=none, work in progress
TBR=zelidrag
Review URL: http://codereview.chromium.org/2068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead.
features.gypi isn't needed by glue, appcache or database.
Review URL: http://codereview.chromium.org/2070001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Chromium OS. Currently disabled by default behind a command line
switch, and containing a non-real URL for now, this code is at
prototype level. It works (when enabled and pointed at a functioning
cloud print service URL), has the beginnings of some unit tests, and
has the beginnings of deeper communication with the dialog contents,
and it shuts off the DOM UI access from the dialog contents.
Patch contributed by Scott Byer
Review URL: http://codereview.chromium.org/1769006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XP, presumably because initializing ETW on Windows XP is somewhat expensive.
BUG=44109
TEST=XP page cycler buildbot should un-regress.
Review URL: http://codereview.chromium.org/2102002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43816
TEST=none
Review URL: http://codereview.chromium.org/1981014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2098001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Adjusted customize sync text field to be as wide as the content view and made it wrap. Created customizeSyncDescriptionTextField_ outlet and hooked it up.
BUG=43945
TEST=manual with French
Review URL: http://codereview.chromium.org/2001018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43930
TEST=see bug
Review URL: http://codereview.chromium.org/2005011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=Buildbots.
TBR=darin
Review URL: http://codereview.chromium.org/2014014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tasks such as the Cloud Print Proxy.
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/2001009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the circular gyp dependency between webkit.gyp
and WebKit.gyp:
webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.
The fix is to move webkit_support into its own gyp file (like we do
in an webkit only checkout). We can't use the same gyp file for in-
chromium and in-webkit because we need to change the include path for
features.gypi. In gyp, variable expansion happens after includes
(otherwise you'd have to expand variables twice and they could change
values), so we can't use a single gyp file for this.
Review URL: http://codereview.chromium.org/1995013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2049008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2041008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
containing title and URL.
BUG=43259
TEST=Add items to "show these URLs on startup" option table. They should show as titles. Hover one. You should see a tooltip with the title and URL.
Review URL: http://codereview.chromium.org/2048006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bottom line of the tabstrip).
BUG=42154
TEST=Visual inspection (line below tab should be gone, see bug for screenshot).
Review URL: http://codereview.chromium.org/2013012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1989005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43172
Review URL: http://codereview.chromium.org/2044002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1998012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1980005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2005002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=chromeos-base/chromeos-chrome builds inside of x86-generic chroot.
Review URL: http://codereview.chromium.org/1998007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2015002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2003001 broke browser tests for
login / wizard screens. This fixes them.
Review URL: http://codereview.chromium.org/1995005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2800
TEST=none
Review URL: http://codereview.chromium.org/2003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make it float with top edge.
BUG=crosbug.com/2800
TEST=Should be no visible changes with info bubble, everything should work as before. Bubble is used for example in bookmarking.
Review URL: http://codereview.chromium.org/1820002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also output chrome's time to launch on the login screen.
Review URL: http://codereview.chromium.org/2003001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37119
TEST=build official mini_installer, install with and without --chrome-sxs, check icons of created entries
Review URL: http://codereview.chromium.org/1959003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2793, chromium-os:2980
TEST=None
When we went to login images we lost the version on the main screen.
This change moves it to the background so all wizard panels will show it.
Also we currently show the time it took to boot the system. We may change
this later but it's useful for now to keep us aware of regressions.
In addition, any issues with loading libcros are displayed here as well.
Review URL: http://codereview.chromium.org/1827001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/26897
TEST=the hung renderer dialog should have the title "Page(s) Unresponsive"
Review URL: http://codereview.chromium.org/1885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: removal of dialog title
BUG=http://crbug.com/26897
TEST=as in bug
Review URL: http://codereview.chromium.org/1861003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42977
TEST=build official exe, look at it in explorer
Review URL: http://codereview.chromium.org/1736029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with added unit tests!
XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.
At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.
The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.
BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.
Review URL: http://codereview.chromium.org/1817003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use translated English strings rather than transliterated Korean strings.
* Drop "3-set 2-set" keyboard support since it's not widely used.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/1718018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixed crashing bug and ethernet not updating bug.
BUG=chromiumos:2896,2939,2996
TEST=manual, in network options dialog, the new auto-connect checkbox should now control whether or not we automatically connect to this network.
Review URL: http://codereview.chromium.org/1755013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pdfs from Cole.
BUG=42026
TEST=\
1) Small folders --> no arrows.
2) Big folders --> arrow at bottom initially.
3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow.
Open it and gently use scroll wheel to scroll. Make sure transition to "no arrow" looks good.
Close and reopen. Scroll super-fast. Make sure it ends up in the same nice place.
4) Open big big folder. Scroll so top goes offscreen so you now have 2 scroll arrows.
Use scroll wheel to gently go up and down (arrow hides and shows). Make sure transitions OK.
Scroll all the way so bottom arrow disappears. Gently up and down; watch for transitions.
Now FAST up and down. Make sure destination looks OK.
BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off.
Review URL: http://codereview.chromium.org/1813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change reverts r46025 and fixes the build break which is just a one line
change in chrome/browser/first_run_gtk.cc to move the definition of
Upgrade::new_command_line_ to be inside a #if. Details on the change and code
review feedback for the original CL can be found at
http://codereview.chromium.org/1633021.
BUG=40975
TEST=none
Review URL: http://codereview.chromium.org/1691022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.
At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.
The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.
BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.
Review URL: http://codereview.chromium.org/1760001
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1790009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.
At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.
The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.
BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.
Review URL: http://codereview.chromium.org/1760001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
background in persistent"
Broke the build.
Review URL: http://codereview.chromium.org/1718024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode, shutdown and restart the new instance. This is already done for Windows,
this CL enables the functionality for Linux.
We don't yet have a unit test for this. Local testing is done by:
1) Reducing the timer to 30 seconds.
2) Changing BrowserList::IsInPersistentMode to return true.
3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval.
4) Running "touch" command on chrome exe to pretend there is an update.
BUG=40975
TEST=none
Review URL: http://codereview.chromium.org/1633021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added the following additions:
. made the layout work for opaque_browser_frame.
. Only show the menu if the user supplied --enable-vertical-tabs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1708014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
dialog from "needs access to" to "can access" per discusison
on chromium-discuss.
Review URL: http://codereview.chromium.org/1806002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first pass. A few more may be deleted once I clean up the bookmark
context menu code.
BUG=38908
TEST=everything still works
Review URL: http://codereview.chromium.org/1763017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We had some info in the man page and other info in the about page.
This change makes the about page refer to the man page, and updates
the man page with missing info.
While I'm at it, make the HTML slightly prettier.
Review URL: http://codereview.chromium.org/1695023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visual inspection.
Review URL: http://codereview.chromium.org/1701015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/491
BUG=crosbug.com/2623
TEST=manual
Review URL: http://codereview.chromium.org/1694017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.xib changes: change all ToolbarButtonCells to GradientButtonCells.
(Previously committed at r45698, reverted at r45703. I don't know why the local
build and the try succeeded. This time, I fixed the slightly-broken include.)
BUG=42582
TEST=builds properly *and* toolbar buttons and find bar buttons still work as before
Review URL: http://codereview.chromium.org/1762012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=all try bots passed
BUG=none
Review URL: http://codereview.chromium.org/1774006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.xib changes: change all ToolbarButtonCells to GradientButtonCells.
BUG=42582
TEST=toolbar buttons and find bar buttons still work as before
Review URL: http://codereview.chromium.org/1697011
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/1695020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45703 0039d316-1c4b-4281-b951-d872f2087c98
|