| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and most likely some page cyclers.
Review URL: http://codereview.chromium.org/155236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14920
TEST=context menus on tabs.
Review URL: http://codereview.chromium.org/155173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, do some housekeeping for our current shortcuts.
* Command-Option-l - Downloads [same shortcut as Safari].
* Command-Shift-[/] - Back/forward tab.
* cntrl-pageup/pagedn - Back/forward tab.
Global Keyboard events are intercepted by a new BrowserWindow custom class.
BUG=12537,15486
TEST=Check that above keyboard shortcuts work as advertised.
Review URL: http://codereview.chromium.org/149325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make processes dumpable when they crash.
* Find crashing processes by searching for a socket inode, rather
than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs
between PID namespaces with SCM_CREDENTIALS, so we can't use the
PID there.
* Use a command line flag to the renderer to enable crash dumping.
Previously it tried to access the user's home directory for this
information.
* Search for a sandbox helper binary and, if found, use it.
* Include the source for a sandbox helper binary. It's currently not
built by default.
http://codereview.chromium.org/149230
R=evan,markus
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked.
BUG=13151
TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar.
Review URL: http://codereview.chromium.org/155151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac. I'm leaving the window resizable for now, because I dislike
non-resizable windows. This is easy enough to change later.
BUG=None
TEST=After bringing up the dialog, verify that the only way to dismiss
it is by pressing either the wait button or the kill button.
Review URL: http://codereview.chromium.org/151009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons. Observe that WCB's are themed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758
Review URL: http://codereview.chromium.org/150041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 118358.
A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.
A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.
TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/150176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons. Observe that WCB's are themed.
Review URL: http://codereview.chromium.org/150041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556.
BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link.
Review URL: http://codereview.chromium.org/147247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
going to need it again shortly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13160
TEST=none
Review URL: http://codereview.chromium.org/150163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
image can handle the new size.
BUG=None
TEST=Start chromium and the chromium logo should look the same as
before on the new tab page and on the about:version page.
Review URL: http://codereview.chromium.org/150110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
294 and 370 (if the if clause is false).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/151050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows uses Ctrl + j, but the Mac equivalent (Cmd + j) is already
in use for Edit -> Find -> Jump to Selection. I've chosen Cmd + Shift + j,
as a replacement, but it's easy enough to change.
TEST=Press the keyboard shortcut (Shift + Cmd + j) to open the download page.
BUG=15653
Review URL: http://codereview.chromium.org/150073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Launch Chrome. Create a 2nd tab. Close bookmark bar.
Cmd-F11 to enter fullscreen; make sure content is centered and both
bookmark bar and toolbar are gone. Make sure menubar gone.
Cmd-Opt-arrows to switch tabs; make sure still OK.
Cmd-F11 to go back; make sure things look normal.
Open bookmark bar.
Cmd-F11; make sure gone. Cmd-F11 again; make sure it comes back.
Confirm View-->Fullscreen menu item works.
While in fullscreen, Cmd-T to create new tab and click on a fav tile.
Make sure page loads.
While in fullscreen, try window hotkeys (Cmd-N and Cmd-W) to make sure
they work. Cmd-` to switch windows; switch back, then Cmd-F11 to
undo fullscreen.
Move the mouse to to the top of the screen; make sure menubar appears.
Move the mouse down; make sure menubar goes away.
Review URL: http://codereview.chromium.org/126294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
standard widget. This may also fix some of our resizing
issues.
BUG=http://crbug.com/14663
TEST=The resizer widget should still work as expected.
Review URL: http://codereview.chromium.org/149094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15491
TEST=Open the options menu and there should be no "null" in the UI
Review URL: http://codereview.chromium.org/147249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert.
Review URL: http://codereview.chromium.org/147233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- we collect the first two params : switch-1 and switch-2
- up to 64 chars, then it truncates
BUG=b/1910452
TEST=starting chrome should work as usual, otherwise see the bug
Review URL: http://codereview.chromium.org/149034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try loading a failing extension on the Mac; you should get some UI
Review URL: http://codereview.chromium.org/147098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the same as Chromium. Chromium was delayed, while Google Chrome
was not, resulting in another LoadLibrary of chrome.dll.
Since we are not really getting crash reports of chrome crashing
during LoadLibrary, we don't mind initializing after.
BUG:4564
TEST:about:crash still report a crash in Google Chrome and Chromium.
Review URL: http://codereview.chromium.org/146030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit link.
BUG=14958, 15073
TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.
Review URL: http://codereview.chromium.org/146108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15078
TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch.
Review URL: http://codereview.chromium.org/146088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13821
TEST=Verify that the home hover and pressed states look right
TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13152
TEST=Navigate to about:hang in a tab, verify that the dialog comes up.
Review URL: http://codereview.chromium.org/146012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crash reporting broke on Linux when we enabled the zygote model a
couple of weeks ago.
We can't just add "zygote" to the check for the process type because
the crash signal fd is set at the same time and that will change when
a renderer is forked from the zygote.
This fixes it for now, but it will need to be redone when we enable
sandboxing.
http://codereview.chromium.org/147004
BUG=14969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the alert when no printer is installed.
BUG=http://crbug.com/6833
TEST=Print to a printer that fails to print (e.g. MS XPS printer and cancel save). Try to print when no printer is installed.
Review URL: http://codereview.chromium.org/141060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of manually formatting it.
BUG=14878
TEST=Open a new window with at least 2 tabs. Close it and go to the
NTP and it should say "2 tabs" under recently closed.
Review URL: http://codereview.chromium.org/144022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not implemented but it is time to get this submitted and iron out the
remaining issues.
BUG=13362
TEST=Start chrome with --new-new-tab-page and look at play arouind with
the new tab page.
Review URL: http://codereview.chromium.org/132027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
two descriptions in hopes of helping the translators.
BUG=12442
TEST=none
Review URL: http://codereview.chromium.org/141001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hood panel to be more like on windows and remove stuff that's not needed. Disable all prefs that aren't currently hooked up.
BUG=none
TEST=Prefs on first two panels haven't stopped working.
Review URL: http://codereview.chromium.org/140004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting turned on to prevent their dependencies from assuming they emit an
import libary. This implies that these two targets should be loadable_module,
rather than manually setting IgnoreImportLibrary.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/132080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_locale_settings.
Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings).
There are no code changes.
BUG=http://crbug.com/7319
TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does).
Review URL: http://codereview.chromium.org/131060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14665
TEST=Download something, check that "show all downloads" text is on
shelf, click it, check that the downloads tab opens.
Review URL: http://codereview.chromium.org/132073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also correctly handle crashes in task manager. The infobar allows user to restart the extension process.
TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash.
http://crbug.com/14111
Review URL: http://codereview.chromium.org/126289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode".
BUG=13758
TEST=restoring closed tabs with visible windows and with no windows remaining open.
Review URL: http://codereview.chromium.org/125257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also touch up some include guards and a comment.
Review URL: http://codereview.chromium.org/131054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no browser profile is found from which we can import, disable the import
button. This was not problem on Windows since we always had IE.
BUG=14489
TEST=Rename your Firefox profile dir (~/.mozilla/firefox) and make sure that the import button is disabled on the import dialog box.
Review URL: http://codereview.chromium.org/131075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has lots of missing stuff (e.g. a custom download item view that shows
download progress, the popup is the same for in-progress and completed
downloads, no animation, everything looks ugly, the info bubble overlaps the
shelf when it's visible, no "open download manager page" link, etc), but the
basic functionality is hooked up: The shelf appears when files are downloaded,
and something ugly is added to the shelf for each download. The popup's "Reveral
in Finder" even works. The shelf is per-window as it should be.
BUG=12500
TEST=Download something and check the shelf appears. Click the close button and
make sure it disappears again.
Review URL: http://codereview.chromium.org/93129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14460 (http://crbug.com/14460)
TEST=Cmd+S on Mac should bring up the save page dialog.
Review URL: http://codereview.chromium.org/126299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18744 0039d316-1c4b-4281-b951-d872f2087c98
|