| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
to the soon-to-be-created help page for AutoFill.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1574018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These 2 strings will be used to add a prompt when the user deletes a folder or
bookmark.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1591020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the Sync Setup Wizard).
Added "Customize..." button in Sync group of "Personal Stuff" in Preferences. (Preferences.xib)
Added new customize sync dialog (SyncCustomize.xib) called by button above.
BUG=34209
TEST=manual
Review URL: http://codereview.chromium.org/1525007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
* Get rid of all GTMWidthBasedTweakers in the xib
* Change labels from "clip" to "wrap"
BUG=39390
TEST=See bug
Review URL: http://codereview.chromium.org/1605013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40565
TEST=ctrl-b does nothing; ctrl-shift-b toggles bookmark bar.
Review URL: http://codereview.chromium.org/1567025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeLoggingTest along the way.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1559016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We shouldn't call memset nor socketpair once we have crashed.
BUG=39292
TEST=none
http://codereview.chromium.org/1210006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Manage" and "Done.
xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller.
BUG=39393
TEST=See bug.
Review URL: http://codereview.chromium.org/1527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina. Previously reviewed here:
http://codereview.chromium.org/931001
BUG=23086
TEST=Chrome should work as before (no visible change).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jnj
BUG=27570
TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears.
Review URL: http://codereview.chromium.org/1560015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable.
BUG=39817
TEST=Geolocation exceptions window exists on windows, allows sorting by either column
Review URL: http://codereview.chromium.org/1539021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Change controls size in "Action" column from 'small' to 'regular'.
BUG=39818
TBR=trungl
Review URL: http://codereview.chromium.org/1609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
Content settings window: Enable & hook up "exceptions" button.
The dialog is not "live" (i.e. if it's open while settings are deleted through the bubble, the window is only updated after closing & reopening it). It's not possible to do any editing in the window, only deleting. This matches windows/linux.
http://imgur.com/q7qMK
BUG=39818
TEST=Go to a few geolocation pages, click allow/deny. Then go to content settings->locations->exceptions, the visited pages should be listed.
Review URL: http://codereview.chromium.org/1566015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two xibs in this change.
ExtensionInstallPrompt.xib: This handles the more common case of installing an extension with one or more permission warnings. There is an NSBox with room for the warnings which are separated by \n\n.
ExtensionInstallPromptNoWarnings.xib: It is also possible to install an extension with zero permission warnings. This is currently rare, but we hope to make it more common in the coming quarters. In this case, there is no NSBox and the layout is slightly different.
BUG=29633
Review URL: http://codereview.chromium.org/1540013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27570
TEST=Star should be moved to right hand end of location bar, reload to left endcap.
Review URL: http://codereview.chromium.org/1561009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29332,31778
TEST=none, just strings
Review URL: http://codereview.chromium.org/1549017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1600004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28986
TEST=Launch from a disk image without having a copy already installed in
/Applications, and with permission to write to /Applications.
Review URL: http://codereview.chromium.org/1599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mirandac
Review URL: http://codereview.chromium.org/1530016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- create new account should looks like link
- removed username and password labels, they should be visible as
background text in input fields if user hasn't typed anything yet.
BUG=none
TEST=Create new account should be link on Chromium OS login screen.
Review URL: http://codereview.chromium.org/1593005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
superfluous NTP promo string.
BUG= 37564
TEST= none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43352
Review URL: http://codereview.chromium.org/1587007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to make sure that they land before string freeze.
BUG=38352
TEST=none
Review URL: http://codereview.chromium.org/1613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
its own patch so I can get valid try results.
TBR=jcivelli@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1602004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a copy of the current star_mask.png; I'm checking this in separately from removing that or from using it in code so I can run the code change on the trybots.
TBR=glen
BUG=27570
TEST=none
Review URL: http://codereview.chromium.org/1587011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1366002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
team.
XIB changes:
* Make the button bar 35px tall.
* Change the buttons to have Rounded Textured style.
BUG=none
TEST=Chromium --> Preferences --> Basic --> [Manage]. Bottom button bar should have a textured appearance.
Review URL: http://codereview.chromium.org/1519014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link.
Review URL: http://codereview.chromium.org/1593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the appearance of the window to incorporate Alcor's feedback (see bug).
xib changes: modified the layout, size and spacing of the buttons so that they look like this: http://img59.imageshack.us/img59/1087/picture5lr.png
BUG=38208
TEST=manual tests
Review URL: http://codereview.chromium.org/1584002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the star button from the toolbar entirely. Adds a
LocationBarImageView subclass for the star icon and wires it to the
RHS of the field. Adjust the bookmark bubble to move the arrow to the
RHS and position appropriately.
BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right.
Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing. All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there.
BUG=37865
TEST=No star icon on toolbar.
TEST=Optional home button adjustments should work right.
TEST=Star action in omnibox when showing an URL.
TEST=Star action can be clicked to bookmark current page.
TEST=Bookmark bubble arrow points at star like before.
TEST=Command-d brings up bookmark bubble.
TEST=Star action changes from blank to yellow depending on state.
TEST=Star action tooltip changes depending on state.
Review URL: http://codereview.chromium.org/1540009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1604006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch stolen from Evan and a translatable string added:
<http://codereview.chromium.org/490019>.
BUG=40113
TEST=Run Chromium with --no-sandbox; should get an infobar warning that you're going to die young.
Review URL: http://codereview.chromium.org/1599010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39817
TEST=none
Review URL: http://codereview.chromium.org/1524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
superfluous NTP promo string.
BUG= 37564
TEST= none
Review URL: http://codereview.chromium.org/1587007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: added two new lines to the web database cookie prompt subview of the cookie details NSView, one for database description and one for expected database size. Wired bindings to the appropriate methods in the cookie details object in the same style as the existing fields.
Web database cookie prompt now looks like this: http://img208.imageshack.us/img208/9703/picture6j.png
BUG=36435
TEST=augmented unit tests and manual tests
Review URL: http://codereview.chromium.org/1582003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Instead, we'll be showing "Others"
BUG=crosbug.com/2167
Review URL: http://codereview.chromium.org/1608002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37394
TEST=none
Review URL: http://codereview.chromium.org/1599008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34209
TEST=none
Review URL: http://codereview.chromium.org/1521008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30657
TEST=unset GNOME_DESKTOP_SESSION_ID; run chrome and try to launch proxy config.
Review URL: http://codereview.chromium.org/1541007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/1572007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suggestions.
BUG=29633
Review URL: http://codereview.chromium.org/1527005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar folders. E.g. supports DragAndDrop.
BUG=34910
TEST=Make sure you can DnD items to/from the "off the side" chevron.
Make sure context menus on those buttons work as well (e.g. delete).
Make sure the chevron is NOT draggable.
Make sure the chevron works properly as a "hover open" button when
dragging something else around; e.g. it pops open if you hover over
it. (It's small so this may take patience).
Drop a folder from the bar into itself. Make sure we don't crash.
xib change:
- chevron button is now BookmarkButton, not MenuButton.
Also has BookmarkButtonCell in it.
- "off the side" menu removed.
Review URL: http://codereview.chromium.org/1520003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data type (bookmarks, preferences, etc).
The Customize Sync dialog appears if you click a button on the gaia login or the Options->Personal Stuff tab. This button only appears if you've set the --enable-sync-preferences or --enable-sync-autofill command-line flag.
On the Gaia login, the Customize Sync button grays out when you click 'sign in'. If the "customize sync" dialog is open, it closes when you click "cancel" on the Gaia login, and it accepts when you log in to Gaia.
Removed "Merge and Sync" from the login sequence. Also deleted the 'merge_allowed' parameter from DataTypeController and its subclasses.
Fixed strings so they all refer to "Google Chrome/Chromium sync" instead of "Bookmark sync".
BUG=34209,27259
TEST=none
Review URL: http://codereview.chromium.org/1134002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add commandDispatch: to the firstResponder.
BUG=39317
TEST=right click on bookmark bar and choose "Always Show Bookmark Bar" command.
r=thomasvl
Review URL:http://codereview.chromium.org/1545007
Review URL: http://codereview.chromium.org/1545007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not wrap poorly. Yes, this is fragile, but the only other path is to do like views and have constants for every language to force the sizes. :(
BUG=40008
TEST=see bug (auto fill prefs in English should not be wrapped)
Review URL: http://codereview.chromium.org/1559011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
another things to force the window wider.
Also put in replacement stub text in the sync status text field so it is always two lines at layout time, the code already set it to the correct state during initialization (prevents a DCHECK in some languages).
BUG=39391
TEST=see bug
Review URL: http://codereview.chromium.org/1535009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window to match.
BUG=39388
TEST=see bug
Review URL: http://codereview.chromium.org/1602001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=36601
TEST=None
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1599004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear error message once username/password are changed.
Change "Network not connected" error to more descriptive "Offline login failed and network not connected".
BUG=crosbug.com/1811, crosbug.com/1853
TEST=On any login error password field is cleared and focus is set to it. Error message is cleared once you time anything.
Review URL: http://codereview.chromium.org/1576005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Works on Windows, and on Linux with toolkit_views.
The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.
Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.
Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.
A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.
BUG=none
TEST=New keyboard accessibility interactive ui test.
Review URL: http://codereview.chromium.org/660323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by sergeyu@chromium.org
http://codereview.chromium.org/1081011/show
BUG=19848
TEST=Right-click on video, toggle "Show Controls". For audio the item must be disabled.
Review URL: http://codereview.chromium.org/1589003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43172 0039d316-1c4b-4281-b951-d872f2087c98
|