summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* Product name and version should be boldfaced in the About box.mark@chromium.org2009-10-261-8/+12
| | | | | | | | BUG=25862 TEST=The About box Review URL: http://codereview.chromium.org/330023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30116 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text alignment in the About box. The left edges of the product name,mark@chromium.org2009-10-261-6/+560
| | | | | | | | | | version, legal block, and update icon (if present) should all line up. BUG=25582 TEST=Look at it. Come over here and look at it. Review URL: http://codereview.chromium.org/334031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30107 0039d316-1c4b-4281-b951-d872f2087c98
* Make the About box display existing pending operations instead of firing offmark@chromium.org2009-10-262-3/+34
| | | | | | | | | | | | | | | | | | a new update check even when an existing update check or installation attempt is in progress. Remove the check that validates that the Update button is disabled after being clicked. This test has become very fragile now that the Update button reliably enables itself as soon as an update installation attempt fails. BUG=13165 TEST=Get the About box to offer you the opportunity to install an update. Click "Install Now". Close the About box and quickly reopen it. The update status should be "Installing new version..." and not "Checking for updates..." Review URL: http://codereview.chromium.org/339010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30100 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up bookmark bubbles and the browser window so that they shut down ↵dmaclach@chromium.org2009-10-261-409/+491
| | | | | | | | | | | | | | | | | | | correctly. BookmarkBubbleController has been made an NSWindowController instead of the view controller that it used to be, and now loads its window from the nib instead of creating it on the fly. Also cleans up fullscreen mode so that the window referenced from browser_window_controller stays constant instead of having [self window] and window_ potentially pointing at two different windows. BookmarkBubble.xib has been modified so that it instantiates a window containing a bubble view instead of just instantiating a view. BUG=25054 TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting, Review URL: http://codereview.chromium.org/333017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30095 0039d316-1c4b-4281-b951-d872f2087c98
* o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.mark@chromium.org2009-10-261-13/+2
| | | | | | | | | | | | | | | o Adds Cocoa implementation of the extension installation prompt. o Added new cross-platform implementations of the extension install error prompt. o Got rid of unused extension install strings from early implementations. o Added a string to display as the header of the error dialog, since it was inline English. Patch by Andrew Bonventre <andybons@gmail.com> BUG=19654 TEST=Install an extension on any platform, observe consistent visual behavior and messaging. Review URL: http://codereview.chromium.org/333015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-262-1/+4
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* About box auto-update improvements.mark@chromium.org2009-10-263-123/+326
| | | | | | | | | | | | | | | The About box now knows how to check to see if updates have been installed in the background without anyone having to click the Update button in the box. The About box no longer gets stuck in the "installed" state. Even if an update has been installed, the About box will still check for new updates when reopened. BUG=13165, 20488 TEST=Play with the about box and auto-update a whole lot Review URL: http://codereview.chromium.org/338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make Cmd-[ and Cmd-] work properly again.viettrungluu@chromium.org2009-10-261-66/+659
| | | | | | | | | | | | | I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed). [N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.] BUG=25810 TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift). Review URL: http://codereview.chromium.org/333026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30059 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2009-10-262-95/+99
| | | | | | Review URL: http://codereview.chromium.org/334027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-241-4/+21
| | | | | | | | | | | | | | Credits for the bookmark bar fix to dmac; stolen from http://codereview.chromium.org/267082 . BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29906 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29908 Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29990 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Extensinos menu item to GTK.estade@chromium.org2009-10-231-0/+3
| | | | | | | | | | Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled. BUG=25424 Review URL: http://codereview.chromium.org/316017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
* - "homepage" -> "home page" in two stringsthomasvl@chromium.org2009-10-231-7/+16
| | | | | | | | | | | | - Fork the show home button string since mac uses it with different context. - Updated text on the toolbar control buttons for the mac prefs window. TEST=text is changed, see bugs BUG=25667 BUG=25668 Review URL: http://codereview.chromium.org/330006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29940 0039d316-1c4b-4281-b951-d872f2087c98
* Switching to a plugin icon as the favicon for the extensions page.finnur@chromium.org2009-10-232-1/+0
| | | | | | | | | | TBR=arv BUG=25509 TEST=Open the extensions page and it should have a plugin as it's favicon. Review URL: http://codereview.chromium.org/329012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
* Turn the background of the scrolling area white.thomasvl@chromium.org2009-10-231-8/+16
| | | | | | | | BUG=25594 TEST=background is white Review URL: http://codereview.chromium.org/332011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29926 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a favicon for the Extensions page.finnur@chromium.org2009-10-232-0/+1
| | | | | | | | | BUG=25509 TEST=Open the extensions page and its tab should have an icon. Review URL: http://codereview.chromium.org/332009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nsylvainthakis@chromium.org2009-10-231-21/+4
| | | | | | Revert git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29908 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-231-4/+21
| | | | | | | | | BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29906 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure OK is only enabled when there is text in the text field for folders ↵pinkerton@chromium.org2009-10-221-5/+37
| | | | | | | | | | and items (whitespace is ok). BUG=19558 TEST=per bug, test existing folders and new folders alike. Review URL: http://codereview.chromium.org/292046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29820 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the browser in the bookmark editor. Adjust the logic controlling the ↵pinkerton@chromium.org2009-10-221-18/+24
| | | | | | | | | | | | OK button enabling. In the BookmarkEditor.xib: Connect the NSBrowser's delegate (showing the bookmark tree) to the File's Owner (BookmarkEditorController). Patch from Mike Rossetti (mrosseti@chromium.org) Original review at: http://codereview.chromium.org/287014 BUG=17613 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29784 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Convert dll_path_ to a std::wstring. This avoids having dll_path_ ↵jhawkins@chromium.org2009-10-215-16/+20
| | | | | | | | | | | uninitialized after the object is constructed. CID=1632 BUG=none TEST=none Review URL: http://codereview.chromium.org/306037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-212-4/+4
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* Messaging of the download item for extension is now:mark@chromium.org2009-10-212-51/+29
| | | | | | | | | | | | | | | | Extensions can harm your computer. Are you sure you want to continue? [Continue] [Discard] This involved taking out the GTMUILocalizerAndLayoutTweaker from the xib and placing it within the controller itself, since the content of the UI is determined at runtime and cannot rely simply on the xib contents. For Win and Linux, only the confirm button needed to change. Patch by Andy Bonventre <andybons@gmail.com> BUG=23105,25257 TEST=When clicking on a link to an extension, the messaging should be specific to extensions and the button to confirm the installation should be 'Continue' instead of 'Save'. Review URL: http://codereview.chromium.org/293014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29706 0039d316-1c4b-4281-b951-d872f2087c98
* Um, polish...something...mark@chromium.org2009-10-212-1/+6
| | | | | | | | | | | | | Use a Mac-like tab key image for "Press [tab] to search" on the Mac. New image from Cole. Hello, VAG Rounded. BUG=21444 TEST=Start typing "go" in the omnibar, the "tab" image should look Mac-ish. On other platforms, the "Tab" image should be unchanged. Review URL: http://codereview.chromium.org/307024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29691 0039d316-1c4b-4281-b951-d872f2087c98
* New tab close button images from Cole.mark@chromium.org2009-10-212-1407/+2679
| | | | | | | | BUG=21444 TEST=Lollipops have not fallen in dirt? Review URL: http://codereview.chromium.org/314005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29689 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Switch from "Cancel" to "Do Nothing" for the external protocol dialog, ↵avi@chromium.org2009-10-211-0/+3
| | | | | | | | | | | and allow remembering the "Do Nothing" choice. BUG=none TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state. Review URL: http://codereview.chromium.org/314003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29671 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix Text Encoding menu by partly reverting r29315.viettrungluu@chromium.org2009-10-211-1/+1
| | | | | | | | | | | (r29315 was http://codereview.chromium.org/273063.) r29315 incorrectly changed the code for the Text Encoding menu entry to IDC_ENCODING_AUTO_DETECT (from IDC_ENCODING_MENU), which caused it to be incorrectly recognized as the auto detect menu item.... BUG=25397 TEST=Check the View->Text Encoding menu under various circumstances. Review URL: http://codereview.chromium.org/292047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29652 0039d316-1c4b-4281-b951-d872f2087c98
* New button scheme...borders are separate from the inner contents sodavemoore@chromium.org2009-10-2156-1/+21
| | | | | | | | | | | | | | | | | | that they can be highlighted / depressed independently. Got alignment of buttons right. Support hover and pushed in StatusAreaButton. Share status area button code. New icons for battery and wifi. New images. Review URL: http://codereview.chromium.org/300018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
* Explain what '&amp;&amp;' is for in IDS_IMPORT_SETTINGS: '&amp;&amp;' should ↵jshin@chromium.org2009-10-211-2/+2
| | | | | | | | | | | be replaced with 'and' in the target language unless it's good to use '&' to mean 'and' in the language. BUG=24705 TEST=NONE Review URL: http://codereview.chromium.org/307008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29589 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the new extension management UI. For the UI mocksfinnur@chromium.org2009-10-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | see the bug details. This gets us most of the way there. We have made minor course corrections since the mocks were introduced (no date will be shown, no "Get more extensions" link is visible and the name is not linked). Known issues: The only thing missing is the fact that we show a default plugin icon for each extension (as opposed to the icon for the extension). BUG=12119 TEST=Open chrome://extensions and all the buttons and links should work (Developer Tools, Enable, Disable, Reload, Uninstall, Load, Pack, Update, etc). Review URL: http://codereview.chromium.org/293028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29584 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-201-4/+5
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Support the Bookmark bar and Other bookmarks titles in titlecase.thomasvl@chromium.org2009-10-191-6/+16
| | | | | | | | TEST=the bookmark bubble menu should have title case items for the two. BUG=24912 Review URL: http://codereview.chromium.org/297004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29431 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent multiple threads from executing the DumpDoneCallback handlercpu@chromium.org2009-10-171-0/+9
| | | | | | | | | | | | - So respawning the browser is more reliable. BUG=25091 TEST=see bug Review URL: http://codereview.chromium.org/283024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix resource ID conflict. Original patch by Thiago Farina (see ↵pkasting@chromium.org2009-10-162-39/+39
| | | | | | | | | http://codereview.chromium.org/273063 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29315 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark bubble tweaksthomasvl@chromium.org2009-10-161-3/+10
| | | | | | | | | | | TitleCase the other folder menu options. Use the helper that handles ellipsis. TEST=the other folder option is title case BUG=24912 Review URL: http://codereview.chromium.org/276065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29309 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the Developer Tools menu item in the page menu.pinkerton@chromium.org2009-10-161-20/+26
| | | | | | | | BUG=24916 TEST=per bug. Review URL: http://codereview.chromium.org/285004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29305 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure you can type in the homepage box.thomasvl@chromium.org2009-10-161-36/+36
| | | | | | | | TEST=can type in the homepage box BUG=24740 Review URL: http://codereview.chromium.org/289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29293 0039d316-1c4b-4281-b951-d872f2087c98
* Update the terms or service.laforge@chromium.org2009-10-1646-2415/+2617
| | | | | | Review URL: http://codereview.chromium.org/264074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29226 0039d316-1c4b-4281-b951-d872f2087c98
* Facelifts to sync UItim@chromium.org2009-10-1553-117/+242
| | | | | | | | BUG=23136,24858,21596 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/270081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for changing timezones.chocobo@google.com2009-10-151-0/+9
| | | | | | | | BUG=24876 TEST=none Review URL: http://codereview.chromium.org/267113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29183 0039d316-1c4b-4281-b951-d872f2087c98
* Tracks the amount of memory SQLite is using in the browser processjamesr@chromium.org2009-10-151-0/+3
| | | | | | | | | | | | | This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process. SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for. SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/276009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29173 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up "Bookmark All Tabs" on Mac as menu item in Bookmarks menu and tab ↵pinkerton@chromium.org2009-10-153-674/+197
| | | | | | | | | | context menu. Fix a typo in the grd file for adding a bookmark. BUG=24363 TEST=bookmark all tabs, edit dialog still dims OK when url is invalid for bookmarks that aren't folders. Review URL: http://codereview.chromium.org/269080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29138 0039d316-1c4b-4281-b951-d872f2087c98
* Add env variable to write minidumps to a preset directory.jeremy@chromium.org2009-10-151-0/+29
| | | | | | | | | | | | | | | | Add an |BREAKPAD_DUMP_LOCATION| environmental variable to allow overriding the default location for minidump generation. This is for ChromeBot who need a single copy of the Chrome bundle which can be run several times alternating the location of crash dumps. This isn't implemented as a command line flag because only some command line flags are passed to child processes and we need a robust solution. TEST=Minidumps should still be written for browser and renderer crashes. Review URL: http://codereview.chromium.org/264038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29126 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-152-11/+1
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-152-1/+11
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-152-11/+1
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-141-4/+28
| | | | | | | | | | | | | Stuff when the default theme is already set. This change is for the Mac OS; Windows change in a separate patch. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat. Review URL: http://codereview.chromium.org/278004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tickle the render sandbox early so it forks at the right timeevan@chromium.org2009-10-141-17/+21
| | | | | | | | | | | Otherwise, the first time the singleton is touched we've already started loading a page! We surely have a bunch of threads going at that point. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27528 Review URL: http://codereview.chromium.org/245039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29010 0039d316-1c4b-4281-b951-d872f2087c98
* Make the multiple download request dialog an infobar.estade@chromium.org2009-10-142-1/+2
| | | | | | | | | | | | The icon is a placeholder until Glen makes a pretty one. BUG=24047 TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html allow, deny, closing infobar, and closing tab all work as expected Review URL: http://codereview.chromium.org/275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd. This stringmark@chromium.org2009-10-142-16/+16
| | | | | | | | | | | | | | never belonged in chromium_strings.grd because it's not branding-dependent. Placing it in chromium_strings.grd but not google_chrome_strings.grd caused the two strings files to become out of sync, which is actually really really bad. BUG=24776 TEST=Application name shown in Mac menu bar should be Chrome, not Google Chrome Helper or anything else Review URL: http://codereview.chromium.org/277004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28980 0039d316-1c4b-4281-b951-d872f2087c98
* Updates for Under the Hood prefs from Cole:thomasvl@chromium.org2009-10-141-20/+15
| | | | | | | | | | | | - Make the scroller the width of the window. - Resize the content so any wrapping text fields have the full width. - Tweak the scroller so only bot bottom border shows. BUG=20538 TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar. Review URL: http://codereview.chromium.org/276019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28973 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 08:21:09 +0000