summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* This CL makes the safe browsing interstitial page support multiple unsafe ↵jcampan@chromium.org2009-01-231-1/+26
| | | | | | | | | | | | | | | | | | | | | | | resources in one page. We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers. With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far. This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial. BUG=5916,6207,6306 TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios: - Main page is malware - Main page is fishing - Main page is OK contains resources (images,iframes...) which are malware - Main page is OK contains resources (images,iframes...) which are phishing - Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware. Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources. (ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com) Review URL: http://codereview.chromium.org/18346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8578 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-234-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* ui refresh from cole. make it look chromey and get the basic framework for ↵pinkerton@google.com2009-01-238-436/+7546
| | | | | | | | the views we'll need. Review URL: http://codereview.chromium.org/18720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing include in scoped_ole_initializer. Without this includesky@google.com2009-01-231-0/+2
| | | | | | | | | | | someone can't just include scoped_ole_initializer and have it work. BUG=none TEST=none Review URL: http://codereview.chromium.org/18536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8563 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=1007hclam@chromium.org2009-01-231-0/+12
| | | | | | | | | Added a dialog for removing exceptions of password manager Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog. Review URL: http://codereview.chromium.org/18494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8544 0039d316-1c4b-4281-b951-d872f2087c98
* remove the NSToolbar, improve the appearance a little bit. ObjC style member ↵pinkerton@google.com2009-01-221-795/+311
| | | | | | | | names. Review URL: http://codereview.chromium.org/18501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SecondLaunch unit test.evan@chromium.org2009-01-211-1/+1
| | | | | | | | | BUG=6722 Review URL: http://codereview.chromium.org/18472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8410 0039d316-1c4b-4281-b951-d872f2087c98
* add basic command handling for browser window and for where there are no ↵pinkerton@google.com2009-01-211-2/+22
| | | | | | | | windows open. Can now create new browser windows. Review URL: http://codereview.chromium.org/18458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8387 0039d316-1c4b-4281-b951-d872f2087c98
* disable test\ntc@google.com2009-01-211-1/+1
| | | | | | | | | | disable SecondLaunch. This looks command line related. tbr=evan Review URL: http://codereview.chromium.org/18617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8369 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.dll's resources to unit_tests.exe for "in-process" testing.maruel@chromium.org2009-01-211-1/+17
| | | | | | | Add missing .h files in chrome_dll.vcproj. Review URL: http://codereview.chromium.org/18605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8366 0039d316-1c4b-4281-b951-d872f2087c98
* Get browser window showing using a Browser object and accompanying ↵pinkerton@google.com2009-01-211-0/+1200
| | | | | | | | scaffolding. Adds browser window controller and shim from NSWindow to BrowserWindow. Review URL: http://codereview.chromium.org/18368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8364 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-214-6/+10
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-173-11/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions required by the rest of the browser from RenderProcessHost to ↵brettw@chromium.org2009-01-161-1/+1
| | | | | | | | an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet. Review URL: http://codereview.chromium.org/18132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8188 0039d316-1c4b-4281-b951-d872f2087c98
* mac bootstrapping of browser main and app startup bitspinkerton@google.com2009-01-162-16/+62
| | | | | | Review URL: http://codereview.chromium.org/18112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8185 0039d316-1c4b-4281-b951-d872f2087c98
* Move webkit_resources.rc to webkit_resources.grd. Addtc@google.com2009-01-131-1/+1
| | | | | | | | | | | | | | | | | webkit_resources.vcproj which creates the .rc files and have webkit glue depend on it. I had to add a flag to grit that allows a resource to be in the header, but not in the .rc file. We do this for a test_shell only resource that is not compiled in. SCons build also works on windows. I still need to update the other .sln files and mac build. Review URL: http://codereview.chromium.org/17466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7910 0039d316-1c4b-4281-b951-d872f2087c98
* Drastically simplify configuration of the local .dll filessgk@google.com2009-01-091-99/+83
| | | | | | | | | | | | | (en route to generating .vcproj files). Instead of defining a list of locale_settings_*.rc files, just specify a list of the two-letter locale abbreviations and generate all the specific file names by interpolating the locale, not by extracting the locale with a regular expression and doing harder-to-understand string replacement on the file names. Review URL: http://codereview.chromium.org/17460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7828 0039d316-1c4b-4281-b951-d872f2087c98
* remove chrome dependencies from win sandboxing headers. Wrap sandbox code topinkerton@google.com2009-01-092-67/+56
| | | | | | | make the main routine a little cleaner. Unify the parameters of each of the "main" entry points so we can more easily abstract platform differences in the future. BUG=5323 Review URL: http://codereview.chromium.org/17426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7825 0039d316-1c4b-4281-b951-d872f2087c98
* Move default plugin resources into separate .h and .rc filestc@google.com2009-01-091-2/+4
| | | | | | | | | | from the other webkit resources. I'm going to convert webkit_resources.rc to a cross platform .grd file so I'm moving the windows specific default plugin code into a separate file. Review URL: http://codereview.chromium.org/17306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7812 0039d316-1c4b-4281-b951-d872f2087c98
* Remove net_resources.rc and net_resources.h and replace ittc@google.com2009-01-082-3/+2
| | | | | | | | | | | | | | | | with a grd file that generates the same thing. We want to do this so on linux, we will have grit generate the .h file and a platform specific resource file. There's some munging going on to be able to get the effective_tld_names_clean.dat file included in the rc. This works in visual studio and scons. I need to update chrome_kjs.sln and the webkit*.sln files and the mac build before committing. Review URL: http://codereview.chromium.org/16565 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7762 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix error messaging for http server.kuchhal@chromium.org2009-01-071-1/+1
| | | | | | | | * Fix year for copyright notice. Review URL: http://codereview.chromium.org/16581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7685 0039d316-1c4b-4281-b951-d872f2087c98
* * Create the registry key needed for "dr" value if it doesn't exist.kuchhal@chromium.org2009-01-061-2/+3
| | | | | | | | BUG=1566745 Review URL: http://codereview.chromium.org/16553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7621 0039d316-1c4b-4281-b951-d872f2087c98
* Build file change for enabling dynamic font support. This is a follow-up to ↵jungshik@google.com2009-01-061-0/+1
| | | | | | | | | | | | | the third_party/Webkit change ( http://codereview.chromium.org/16494). Update Webkit to 7592 in DEPS BUG=1303 Review URL: http://codereview.chromium.org/17036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7594 0039d316-1c4b-4281-b951-d872f2087c98
* Some more GRIT refactoring.tc@google.com2009-01-052-2/+2
| | | | | | | | | | | | | | | | | | Moved the grit .vsprops file from chrome/tools/build/win/ to /tools/grit/build and renamed to using_generated_resources.vsprops. Updated non-chrome projects to use the this new vsprops file. Created a new .rules file and renamed the old one. Now there are grit_resources.rules and grit_localized_resources.rules. The latter is what we use now, but I'll be adding some grd files that use the former in a follow up change. This is just vsprops reshuffling for now. I'll also add a using_generated_resources.scons in a follow up change. Review URL: http://codereview.chromium.org/14901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert sdk 6.1 upgrade changes.jungshik@google.com2008-12-301-32/+31
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/17021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
* Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0.jungshik@google.com2008-12-301-0/+1
| | | | | | | | | | | SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later. FYI: http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. Review URL: http://codereview.chromium.org/14908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy PostThreadMessage and PeekMessage call to help inform Windows ↵darin@chromium.org2008-12-231-9/+19
| | | | | | | | | | | that our subprocesses have started up. This causes Windows to promptly stop showing the IDC_APPSTARTING cursor when opening a new tab or navigating to a new domain via the location bar. BUG=4805 R=ananta Review URL: http://codereview.chromium.org/16464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7447 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-191-0/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4222: Clear data dialog has new fields, butfinnur@google.com2008-12-1849-52/+52
| | | | | | | | | | | | | size has not increased in non-US locales. While verifying on all locales, I noticed three locales that had this dialog wider than others and I shrunk those too. Those were locales: el, fil and sv. Review URL: http://codereview.chromium.org/15066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7273 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for running the ui_tests under Purify on thepaulg@google.com2008-12-181-1/+1
| | | | | | | | | | | | | | | | | | buildbots. With these changes, I've been able to get 106 of about 185 ui_tests running under Purify on my machine (I haven't gotten to the remaining tests yet) with minimal changes. The changes here are timeout related, allowing us to specify longer timeouts in chrome_tests.py rather than hard coding them in the tests themselves. We'll likely have to experiment on the buildbots with different timeout values, depending on how fast the bots are. Review URL: http://codereview.chromium.org/14184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7226 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-1654-8539/+8539
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
* Add a manifest to chrome.dll.paulg@google.com2008-12-162-0/+10
| | | | | | Review URL: http://codereview.chromium.org/14128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7019 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Enable spell check for this field" menu option in sub context menu for ↵sidchat@google.com2008-12-151-1/+1
| | | | | | | | context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields. Review URL: http://codereview.chromium.org/13731 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7000 0039d316-1c4b-4281-b951-d872f2087c98
* I accidentally changed a shortcut due to a bad merge of someone else's ↵pkasting@chromium.org2008-12-151-1/+1
| | | | | | | | | changes into my own. BUG=5473 Review URL: http://codereview.chromium.org/14121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6994 0039d316-1c4b-4281-b951-d872f2087c98
* Reupload of 14102glen@chromium.org2008-12-1450-5359/+4726
| | | | | | | | | | | | | BN,GU,KN,ML,MR,OR,TA and TE are still using the English translation (no translation available on our site). HE is non-RTL, which we should fix upstream. The JS contained is harmless code that we had previously manually stripped out, but as we're not someone more automated, I'm leaving it in. Review URL: http://codereview.chromium.org/14104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6975 0039d316-1c4b-4281-b951-d872f2087c98
* Have GRIT generate files into a common directory.tc@google.com2008-12-1251-103/+109
| | | | | | | | | | | | | | | Joi has convinced me that GRIT should generate platform specific resources files. This is easier than parsing .rc files because GRIT effectively has an .rc parser. To that end, we need to convert some existing .rc files to .grd files (e.g., net_resources.rc and webkit_resources.rc). Rather than having every grd file output to a different place and -I all the different paths, have GRIT generate all files into one directory. This directory is grit_derived_sources. Review URL: http://codereview.chromium.org/13776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
* Make all GRIT placeholders only use caps and underscores.tc@google.com2008-12-121-3/+3
| | | | | | | | | | | The translation console only knows how to handle CAPS and underscores for placeholders. There's a check in the GRIT code that verifies this when we generate the translation console upload format. But we never go through this code path when generating the .rc and .h files. Review URL: http://codereview.chromium.org/14071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6934 0039d316-1c4b-4281-b951-d872f2087c98
* Changes new tab page to show recently closed window correctly.sky@google.com2008-12-111-4/+8
| | | | | | | | | BUG=4804 TEST=none Review URL: http://codereview.chromium.org/13760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6836 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up to a recent unforking of WebCore/platform/text/TextCodecICU.cpp ↵jungshik@google.com2008-12-114-6/+6
| | | | | | | | | | | | | | | (r6540). Up to now, we canonicalized to EUC-KR, TIS-620 and GB2312, but with unforking, we'd better canonicalize to windows-949, windows-874 and GBK. Another change is necessary in Webkit (Document.cpp), which I'll do it while unforking it. BUG=3703 Review URL: http://codereview.chromium.org/13645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6817 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-111-0/+13
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 5.pkasting@chromium.org2008-12-102-157/+170
| | | | | | | | | | | Reorder identifiers, functions, initalization statements, etc. to all match. This preserves the original groups Ben created but makes a couple of changes: * Within each group, the order is now "by GUI order" instead of random. This can be subjective, but when I tried doing alphabetical order, it resulted in related functionality being separated pretty arbitrarily. * I moved the "window management" functions next to (but above) the "page-related" functions (this seemed a little more logical, but maybe not) I also renamed UpdateNavigationCommands() to try and reflect that it updates a lot more than navigation commands, and moved some unconditionally-initialized commands (profile stuff) in there over to InitCommandState() where they belong. Review URL: http://codereview.chromium.org/13681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6721 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 4.pkasting@chromium.org2008-12-095-62/+54
| | | | | | | | | Remove dead/unnecessary resources/identifiers/code. The trickiest bit of this to review are the browser.cc changes, where various commands are no longer initialized multiple times. Review URL: http://codereview.chromium.org/13648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6628 0039d316-1c4b-4281-b951-d872f2087c98
* step one of some refactoring to allow other platforms to re-use the app ↵pinkerton@google.com2008-12-092-39/+168
| | | | | | | | initialization code. Review URL: http://codereview.chromium.org/13295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 3.pkasting@chromium.org2008-12-081-92/+92
| | | | | | | | | | | This changes only whitespace, no code change at all. Attempt to make a couple of long multi-column chunks of text more readable by putting everything within the block at the same offsets. In the case of the .rc file, the entire file is now consistently indented. No lines I'm touching go over 80 columns. What I'm doing to browser.cc here we already do in a few (shorter) cases elsewhere, I think to good effect. Review URL: http://codereview.chromium.org/13641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6551 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, part 1.pkasting@chromium.org2008-12-083-99/+99
| | | | | | | | | | | | | | * Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB) * Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU) * Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation. * As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code) * Fix 80-column issues This patch touches move files than any subsequent patches, but should be the most rubber-stampable. Review URL: http://codereview.chromium.org/13633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98
* make icon 512x512 resolution. gosh it's pretty.pinkerton@google.com2008-12-081-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6527 0039d316-1c4b-4281-b951-d872f2087c98
* * Return error in case non admin user tries system level install.kuchhal@chromium.org2008-12-082-0/+6
| | | | | | | | | BUG=5117,4973 TBR=huanr Review URL: http://codereview.chromium.org/13200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6514 0039d316-1c4b-4281-b951-d872f2087c98
* Reupload of 12418glen@chromium.org2008-12-071-15/+46
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused string (IDS_PAGE_MENU_REPORT_PHISHING_WEBSITE_URL)jungshik@google.com2008-12-0551-52/+1
| | | | | | | bug=4457 Review URL: http://codereview.chromium.org/13207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-051-0/+24
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 05:53:33 +0000