summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* The 'should_notify' flag to determine if the notification is needed or not ishirono@chromium.org2014-07-021-0/+6
| | | | | | | | | | | | | | added by crrev.com/280573. This CL refers the flag in the JS side, and shows the notification. BUG=341902 TEST=manually R=kinaba@chromium.org, mtomasz@chromium.org Review URL: https://codereview.chromium.org/359583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280984 0039d316-1c4b-4281-b951-d872f2087c98
* Add more GN deps to the build.brettw@chromium.org2014-07-012-0/+33
| | | | | | | | | | | | | | | | | | These deps are some of those required to compile chrome/browser (so mostly those containing resources and protobufs that have generated headers). chrome/browser still has some dependencies left. Add third_party libs libaddressinput and dom_distiller_js. Add components dom_distiller and policy. Separate the generate_library_loader into a separate .gni file. Rename components_strings to just strings. R=ajwong@chromium.org Review URL: https://codereview.chromium.org/362583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280916 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a flag to enable the OK Google voice search activation setting.kcarattini@chromium.org2014-07-011-0/+8
| | | | | | | | | BUG=390086 NOTRY=true Review URL: https://codereview.chromium.org/348943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280757 0039d316-1c4b-4281-b951-d872f2087c98
* Don't set dpi aware before Win7scottmg@chromium.org2014-07-011-1/+6
| | | | | | | | | | | | | | | | | | | Because we don't support DirectWrite before Win7, enabling hidpi on Vista means that when DPI scale is set there, font rendering will be with GDI which results in bad kerning. So, leave Vista as DPI-unaware. See top left of http://imgur.com/FoIHHTh for how "changing font size" appears -- so this will probably be relatively common on Vista. I don't think there's a separate place to change just the font size, vs. changing DPI. R=cpu@chromium.org BUG=380298 Review URL: https://codereview.chromium.org/346603006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280736 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make the wrench menu and browser action borders fade in and out.erg@chromium.org2014-07-011-0/+2
| | | | | | | | | | | | | | | | All other buttons other than the wrench menu and the browser action buttons were using views::LabelButtonBorder to have a fade animation on mouse over. This transitions these two remaining cases from explicit composed prelight and hover resources to using the standard ButtonBorder. This also cleans up left over rendering of unused prelight and hover resources in gtk2_ui.cc. BUG=132719 Review URL: https://codereview.chromium.org/355123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove carbon plugin interposing codestuartmorgan@chromium.org2014-06-301-5/+0
| | | | | | | | | | | This has been defaulted off since M34, and no bugs have been reported related to it as far as I can tell. BUG=157130 Review URL: https://codereview.chromium.org/338843009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280670 0039d316-1c4b-4281-b951-d872f2087c98
* [Hotword] Set up about://voicesearch page.rlp@chromium.org2014-06-301-0/+8
| | | | | | | | | | Set up an about:// page for voice search with useful information about the extension, audio state, and preferences to aid in debugging user problems in production. BUG=382525 Review URL: https://codereview.chromium.org/350183008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280622 0039d316-1c4b-4281-b951-d872f2087c98
* Removed webstore app naming experimentsashab@chromium.org2014-06-301-16/+2
| | | | | | | | | | | Removed the no-longer-used webstore app naming experiment, so now the web store app just has a static (but still translated) name. BUG=388143 Review URL: https://codereview.chromium.org/360583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280575 0039d316-1c4b-4281-b951-d872f2087c98
* [SyncFS] Remove the runtime flag to enable SyncFS directory operationstzik@chromium.org2014-06-301-6/+0
| | | | | | | | | | Directory operations is enabled by default without flag now. BUG=161442 Review URL: https://codereview.chromium.org/349163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280565 0039d316-1c4b-4281-b951-d872f2087c98
* Rename blocked_media.png -> blocked_mediastream.png in chrome/app/theme.costan@gmail.com2014-06-273-1/+1
| | | | | | | | | | | | | | | The HTML5 media (<audio> / <video>) blocking feature will use blocked_media.png in the future. The associated bug has more context. This rename is in a separate CL because the CQ can't handle binary file renames. BUG=50132 TEST=build/gyp_chromium && ninja -C out/Debug chrome R=oshima@chromium.org Review URL: https://codereview.chromium.org/356133007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280351 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Remove the "Got it" button from the hard unplugged nortification.hirono@chromium.org2014-06-271-3/+0
| | | | | | | | | BUG=389434 TEST=test on a real device. Review URL: https://codereview.chromium.org/345553006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280280 0039d316-1c4b-4281-b951-d872f2087c98
* Re-ordered items in the App List context menusashab@chromium.org2014-06-273-8/+74
| | | | | | | | | | | Removed the View in Web Store context menu option, and moved the 'App Info' option to the bottom of the list. BUG=387512,388578 Review URL: https://codereview.chromium.org/349303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280258 0039d316-1c4b-4281-b951-d872f2087c98
* Add about flag to switch various scale factors.oshima@chromium.org2014-06-261-6/+14
| | | | | | | | | | I also made this specific to cros/win/linux as this does not make sense on other platforms. BUG=372212 Review URL: https://codereview.chromium.org/352043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279970 0039d316-1c4b-4281-b951-d872f2087c98
* rAc: pass transaction details to walletestade@chromium.org2014-06-261-0/+3
| | | | | | | | | | | | Amount and currency. This is not behind a flag because of statements on[1] which indicate it's destined for the standard. [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25471 BUG=354897 Review URL: https://codereview.chromium.org/292913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279952 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in kiosk mode launch screen.jennyz@chromium.org2014-06-261-1/+1
| | | | | | | | BUG=388871 Review URL: https://codereview.chromium.org/358613008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279921 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "managed (mode|user)" to "supervised user" (part 5)treib@chromium.org2014-06-252-51/+51
| | | | | | | | | | | | | | | | | | | | | | | | Followup to https://codereview.chromium.org/345563008/, https://codereview.chromium.org/335273005/, https://codereview.chromium.org/335833003/, and https://codereview.chromium.org/316863002/ This CL renames resource IDs. Still missing: - ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/ - JavaScript - The global ENABLE_MANAGED_USERS define TBR=oshima@chromium.org (c/app/theme and c/b/chromeos) TBR=msw@chromium.org (c/b/ui/cocoa and c/b/ui/views) TBR=noms@chromium.org (c/b/profiles) TBR=thakis@chromium.org (c/b/browser_resources.grd) All the TBRs are simple renames. BUG=385113 Review URL: https://codereview.chromium.org/350183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279835 0039d316-1c4b-4281-b951-d872f2087c98
* [Password Generation] Add new key iconsgcasto@chromium.org2014-06-253-0/+1
| | | | | | | | | | | | This change was reviewed as part of codereview.chromium.org/342833002, but has been split off so that the rest of the change can use CQ and trybots. TBR=oshima@chromium.org BUG=318977 Review URL: https://codereview.chromium.org/353903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279759 0039d316-1c4b-4281-b951-d872f2087c98
* Manual revert with a fix for the failing test.miguelg@chromium.org2014-06-251-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | Revert 279437 "Implement a permission check for push." Suspect this is cause of test failure: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/50906/steps/browser_tests/logs/Init > Implement a permission check for push. > > Extracted common functionality from the midi permission check. > A subsequent CL will move the common classes to chrome/browser/content_settings/ > and implement the midi permission check in terms of these classes. > > Note that bubbles are not yet implemented so only infobars work now. > Note also that only way to rever the permission decision right now > is to clear browser settings. > > Review URL: https://codereview.chromium.org/343743004 BUG=350378 TBR=bauerb,jam,fgorski,mvanouwerker Review URL: https://codereview.chromium.org/352063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279753 0039d316-1c4b-4281-b951-d872f2087c98
* Added l10n strings for Web Store app name and descriptionsashab@chromium.org2014-06-252-1/+18
| | | | | | | | | | | | Added l10n strings for the Web Store app's name and description. Also re-enabled the App Info dialog for this app, which was initially disabled because localisation was not available. BUG=383713 Review URL: https://codereview.chromium.org/350103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279701 0039d316-1c4b-4281-b951-d872f2087c98
* Removed all references to disable-device-enumeration flag and retained ↵carolinea@chromium.org2014-06-251-6/+0
| | | | | | | | | | functionality of MediaStreamCenter::getMediaStreamTrackSources. BUG=350564 Review URL: https://codereview.chromium.org/336833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279592 0039d316-1c4b-4281-b951-d872f2087c98
* [fsp] Add notifications in case of slow operations.mtomasz@chromium.org2014-06-241-0/+9
| | | | | | | | | | | | | | | | | | | | Previously, every request was aborted automatically if it took more than 10 seconds. However, for remote file systems using eg HTTP, on slow connection operation can take longer. Another situation is when a providing extension shows a dialog for eg. password or credentials. We don't want to abort an operation in such case. This CL introduces a notification which is shown when an operation takes longer than expected. Users can abort the operation by clicking on the 'ABORT' button. TEST=unit_tests: *FileSystemProvider*Timeout* BUG=248427 Review URL: https://codereview.chromium.org/350683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279541 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager: show out-of-process iframes.nick@chromium.org2014-06-241-0/+6
| | | | | | | | | | | | | | | If you open one tab with one cross-site iframe, it looks like this: http://imgur.com/Gm1mXwm For each WebContents, one "Subframe: " taskmanager row is shown per subframe SiteInstance. To track just the set of active RenderFrameHosts, a new WebContentsObserver method (RenderFrameHostChanged) is added. Review URL: https://codereview.chromium.org/300113007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279488 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 279437 "Implement a permission check for push."xhwang@chromium.org2014-06-241-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Suspect this is cause of test failure: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/50906/steps/browser_tests/logs/Init > Implement a permission check for push. > > Extracted common functionality from the midi permission check. > A subsequent CL will move the common classes to chrome/browser/content_settings/ > and implement the midi permission check in terms of these classes. > > Note that bubbles are not yet implemented so only infobars work now. > Note also that only way to rever the permission decision right now > is to clear browser settings. > > BUG=350378 > NOTRY=true > > (note, the mac release bot has been stuck for over an hour in the compile step, all other release builds and all other mac bots are ok) > > Review URL: https://codereview.chromium.org/343743004 TBR=miguelg@chromium.org Review URL: https://codereview.chromium.org/350213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279458 0039d316-1c4b-4281-b951-d872f2087c98
* Use Consolas for Windows 7 and above as default monospace fontcpu@chromium.org2014-06-241-0/+5
| | | | | | | | | | | | Looks better that Courier if Cleartype is enabled and much much better if directwrite is also enabled. TEST=see bug BUG=388087 Review URL: https://codereview.chromium.org/351523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279449 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a permission check for push.miguelg@chromium.org2014-06-241-0/+17
| | | | | | | | | | | | | | | | | | | Extracted common functionality from the midi permission check. A subsequent CL will move the common classes to chrome/browser/content_settings/ and implement the midi permission check in terms of these classes. Note that bubbles are not yet implemented so only infobars work now. Note also that only way to rever the permission decision right now is to clear browser settings. BUG=350378 NOTRY=true (note, the mac release bot has been stuck for over an hour in the compile step, all other release builds and all other mac bots are ok) Review URL: https://codereview.chromium.org/343743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279437 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option page as the confirmation dialog for consumer management ↵davidyu@chromium.org2014-06-241-4/+28
| | | | | | | | | | | | | enrollment and unenrollment. Rename section Security to Device control. BUG=chromium:353050 TEST=manual Review URL: https://codereview.chromium.org/324313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279365 0039d316-1c4b-4281-b951-d872f2087c98
* [Hotword] Make error indicator only appear on click. Remove help link from ↵rlp@chromium.org2014-06-241-1/+1
| | | | | | | | | | | | mic and nacl bubbles but add it to the generic error message. This adds a new class HotwordConfirmDialog to handle the situation of clicking, but not displaying the confirm dialog if there is an error. BUG=381384,381843 Review URL: https://codereview.chromium.org/341753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279349 0039d316-1c4b-4281-b951-d872f2087c98
* x509_certificate_model_openssl: implement GetExtensionsmattm@chromium.org2014-06-241-0/+15
| | | | | | | | BUG=338887 Review URL: https://codereview.chromium.org/288113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279320 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp down various chrome/ DEPS files.thestig@chromium.org2014-06-241-3/+0
| | | | | | | | TBR=isherman@chromium.org,rogerta@chromium.org,dalecurtis@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/350453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279265 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flag and field trial support for enabling HTTPS over QUIC independentlyrch@chromium.org2014-06-241-6/+0
| | | | | | | | from HTTP over QUIC. Review URL: https://codereview.chromium.org/342213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279256 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak dialog text for ECHO extension.andycai@chromium.org2014-06-231-1/+1
| | | | | | | | | | | TBR=cpu@chromium.org BUG=chromium:385704 TEST=Tested manully on daisy. Review URL: https://codereview.chromium.org/337923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279218 0039d316-1c4b-4281-b951-d872f2087c98
* Spelling fix.michaelpg@chromium.org2014-06-231-1/+1
| | | | | | | | | R=oshima@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/350643006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279194 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the consistency with permissions warnings message with respect to ↵mohammed@chromium.org2014-06-231-19/+19
| | | | | | | | | | | | | | | | | | | | | | "read" and "write". The "read" and "write" strings are all different among warnings. So far we have: Read and write Read and modify Read and change Access and modify Access and change To ensure consistency all of them should use "read" and "change" whenever possible. Also according to Helen's findings, users don't know the exact meaning of the word "access". BUG=386224 R=jww,meacer,felt Review URL: https://codereview.chromium.org/348483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279191 0039d316-1c4b-4281-b951-d872f2087c98
* Improve messaging for unsupported card type.estade@chromium.org2014-06-231-2/+14
| | | | | | | | BUG=373069 Review URL: https://codereview.chromium.org/344863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279148 0039d316-1c4b-4281-b951-d872f2087c98
* Update the URL for History learn more linksdefresne@chromium.org2014-06-231-2/+2
| | | | | | | | | | | The history learn more link redirect to a new page but drop the "hl" parameter so update the URL to use the target of the redirect. BUG=381813 Review URL: https://codereview.chromium.org/334013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279075 0039d316-1c4b-4281-b951-d872f2087c98
* Update the URL for Google Chrome Privacy Noticesdefresne@chromium.org2014-06-231-1/+1
| | | | | | | | | | | | The server URL mapping have been changed and redirect introduced, except for the language code "he" (which is incorrect and should be "iw"). Use the new URL that supports the "he" language. BUG=381361 Review URL: https://codereview.chromium.org/331863007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279062 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: fix typo in message.kinaba@chromium.org2014-06-231-2/+2
| | | | | | | | BUG=387527 Review URL: https://codereview.chromium.org/350623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279049 0039d316-1c4b-4281-b951-d872f2087c98
* Add experimental versions of the SSL interstitialfelt@chromium.org2014-06-211-0/+9
| | | | | | | | | | | | | | | | | This adds a few experimental versions of the new SSL interstitial: 1. The old layout (V1) 2. The new layout (V2) 3. The new layout, with a yellow background 4. The new layout, with a crossing guard image 5. The old layout with the new layout's text Binary images in: https://codereview.chromium.org/340173002 BUG=386033 Review URL: https://codereview.chromium.org/341653006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278969 0039d316-1c4b-4281-b951-d872f2087c98
* Warn users when their system clock is causing an SSL interstitialfelt@chromium.org2014-06-212-0/+26
| | | | | | | | | | | | - When an SSL interstitial is likely caused by a bad clock, tell users to fix their clocks. - Provide a link to a help page that explains how to reset your clock. - Adds new histograms for measuring how often probable false positive SSL errors occur: interstitial.ssl.cause.nonoverridable and interstitial.ssl.cause.noverridable. BUG=349653 Review URL: https://codereview.chromium.org/340623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278924 0039d316-1c4b-4281-b951-d872f2087c98
* Change the web store app name from "Store" to "Chrome Web Store".kalman@chromium.org2014-06-211-1/+1
| | | | | | | | | | BUG=378569 R=miket@chromium.org,lottie@chromium.org TBR=dubroy@chromium.org Review URL: https://codereview.chromium.org/335853005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278918 0039d316-1c4b-4281-b951-d872f2087c98
* Enable identity.email permission and chrome.identity.getProfileUserInfo API ↵courage@chromium.org2014-06-201-1/+1
| | | | | | | | | | | | | | | | | | | in stable This change makes some small tweaks to identity.email and getProfileUserInfo based on apps-dev feedback, and enables them in stable. The UI string for identity.email now reads "Know your email address". chrome.identity.getProfileUserInfo can be called without the email permission (in which case it returns an ID only). BUG=368343 Review URL: https://codereview.chromium.org/337423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278867 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Add a string resource for "Open in Adobe Reader"thestig@chromium.org2014-06-201-0/+6
| | | | | | | | | BUG=370746 NOTRY=true Review URL: https://codereview.chromium.org/342323009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278865 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize png files in chrome/app/themeoshima@chromium.org2014-06-2051-0/+0
| | | | | | | | | | | | Optimized 51/86 files in 01:05:47s Result: 57369 => 40173 bytes (17196 bytes: 29%) BUG=387254 TBR=msw@chromium.rog Review URL: https://codereview.chromium.org/332343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278855 0039d316-1c4b-4281-b951-d872f2087c98
* Combine the read and modify warning message for "accessibilitySettings" access.mohammed@chromium.org2014-06-201-0/+3
| | | | | | | | | | | When the extension/app requests to read and modify the accessibility settings, two messages are displayed to the user during install-time. The CL aims to combine these into one message to say "Read and modify ...". BUG=344566 R=jww,meacer,kalman Review URL: https://codereview.chromium.org/324273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278854 0039d316-1c4b-4281-b951-d872f2087c98
* Fix malware privacy policy linkfelt@chromium.org2014-06-201-1/+1
| | | | | | | | | BUG=387159 NOTRY=true Review URL: https://codereview.chromium.org/348533008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278796 0039d316-1c4b-4281-b951-d872f2087c98
* Security interstitial tweaksfelt@chromium.org2014-06-201-5/+5
| | | | | | | | | | | | Designers asked for some final tweaks to polish the interstitials. Small changes to CSS and strings. BUG=381260 passed all of the bots at least once but cq is dead dead dead: NOTRY=true Review URL: https://codereview.chromium.org/344943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278787 0039d316-1c4b-4281-b951-d872f2087c98
* Update flag description to make clear why it's needed.vitalybuka@chromium.org2014-06-201-1/+1
| | | | | | | | | BUG=379076 NOTRY=true Review URL: https://codereview.chromium.org/343173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278763 0039d316-1c4b-4281-b951-d872f2087c98
* [AiS] Add disable flag to about_flags.jdonnelly@chromium.org2014-06-201-1/+1
| | | | | | | | BUG=386638 Review URL: https://codereview.chromium.org/342713007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278746 0039d316-1c4b-4281-b951-d872f2087c98
* Updating keyboard overlay for previous/next user in multi profile modeskuhne@chromium.org2014-06-201-0/+6
| | | | | | | | | | | I updated our keyboard mapping sheets and used the python scripts to generate the changes. BUG=325792 TEST=visual Review URL: https://codereview.chromium.org/341643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278730 0039d316-1c4b-4281-b951-d872f2087c98
* Password bubble: Confirm blacklisting a site if passwords exist.mkwst@chromium.org2014-06-201-0/+10
| | | | | | | | | | | | | | If a user blacklists a site with existing saved passwords, those passwords will be deleted. In order to ensure that a user doesn't accidentally lose data, we prompt them to inform them of the risk, and ask for confirmation of the decision. BUG=384155 NOTRY=true Review URL: https://codereview.chromium.org/347033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278698 0039d316-1c4b-4281-b951-d872f2087c98