| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible
* Scope things only used by views under an appropriate conditional
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Right click a tab, "Close opened by" should not be in the context menu.
Review URL: http://codereview.chromium.org/2903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48844
TEST=Open options > Personal Stuff, see link to dashboard.
Review URL: http://codereview.chromium.org/2934010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2945009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
BUG=40745
TEST=none
Review URL: http://codereview.chromium.org/1098005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=45510
Review URL: http://codereview.chromium.org/2918003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2925004
TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/2940002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2925004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2897004
TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/2897007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2897004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
drawing code in r51367.
BUG=none
TEST=check logs. make sure that "Could not find image named 'close_bar'" is not present.
Review URL: http://codereview.chromium.org/2964001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48114
TEST=none (depends on bug 47428)
Review URL: http://codereview.chromium.org/2949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
height). Replace the stop/reload images with ones that fit the weight better. Also replace the wrench menu icon.
BUG=none
TEST=make sure dat toolbar is TIGHT.
Review URL: http://codereview.chromium.org/2811047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2923001
TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/2926001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2923001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folders with regards to hover-open when hover-opening is active.
Makes the UI more consistent.
BUG=http://crbug.com/42167
xib change: set the chevron "off the side" button's delegate to File's Owner.
Review URL: http://codereview.chromium.org/2844046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chevron.png NOT deleted since it is still used on windows.
xib change: adjust off-the-side button's cell from "bottom justified"
to "centered" since new image is centered.
BUG=http://crbug.com/45742
TEST=Add bookmarks. See chevron. See chevron at "centered" vertically (with respect to bookmark text).
Review URL: http://codereview.chromium.org/2867048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hold the reload button state change from stop to reload until the
mouse exits. Also short-circuit the stop message when the real state
should be reload. Also prevent multi-clicks from sending multiple
actions.
Toolbar.xib: reload button made kind of ReloadButton.
BUG=47184
TEST=Browse to a slow page, mouse over stop button. Should not go to reload button when throbber (in tab) stops.
TEST=After page loaded, click stop. Should not crash.
TEST=Hover over reload button. Command-r should start a reload and change the button to stop button.
Review URL: http://codereview.chromium.org/2847051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2800035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2813045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2818046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4570
TEST=started ibus-chewing, toggled properties, then verified there were no errors in /home/chronos/chrome_log.
Review URL: http://codereview.chromium.org/2836049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Second try, first try at http://codereview.chromium.org/2803035 . Also contains http://codereview.chromium.org/2838044 , changes to DEPS files (mostly cleanups), and a change to webkit/glue/plugins/webplugin_delegate_impl_win.cc .
BUG= 48419
TEST=everything still builds
Review URL: http://codereview.chromium.org/2813047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parts by hbono.
TBR=tony^work
Review URL: http://codereview.chromium.org/2838044
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2822050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Parts by hbono.
TBR=tony^work
Review URL: http://codereview.chromium.org/2838044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
THIS CHANGES THE BEHAVIOR OF HOW PERMISSIONS WORK:
Previosly an infobar was shown every time an application requested notification permissions.
Now, this is shown only the first time an application requests permissions, and the choice is remembered thereafter. If the kDesktopNotificationDefaultContentSetting preference is set, no infobar is shown at all.
This CL also adds content settings UI to manage the exceptions list on mac, win, and linux.
xib changes: Add a new pane to the content settings tab view, with the right title, radio box strings, actions, and bindings.
BUG=45547
TEST=Go to a site that shows notifications. It should only ask for permissions once, and remember the user choice after that. Content Settings->Notifications->Exceptions should show the exceptions list. The content settings pane should be fully functional, and the radio button options ("don't ask") should have an effect on pages that weren't visited before.
Review URL: http://codereview.chromium.org/2825028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NotificationExceptionsTableModel is now functional, and DesktopNotificationService::GetContentSetting contains the new permission behavior. Both aren't used anywhere yet, so still no functionality change (but this is the last CL without functionality changes).
Also add a ton of tests.
BUG=45547
TEST=unit tests
Review URL: http://codereview.chromium.org/2868042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2850044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The link will pop up a dialog that displays the cookies blocked and accessed by the current page.
The XIB change adds a link-styled button (cell type HyperlinkButtonCell) below the title and above the horizontal line on the bubble with the text IDS_BLOCKED_COOKIES_INFO. The button action is hooked up to showMoreInfo: in the File's Owner.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2799012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually on netbook
BUG=chromium-os:2625
Review URL: http://codereview.chromium.org/2815049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auto-size the views version of the options dialog.
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
original issuse: http://codereview.chromium.org/2812026/show
Review URL: http://codereview.chromium.org/2883022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was Windows-only, probably broken, and unused.
BUG=46135
TEST=ui_tests
Review URL: http://codereview.chromium.org/2859042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead. XP ignores pages read as data
while mapping image sections. This shows a reasonable improvement in cold startup performance on XP.
This change only comes into effect for headless mode which enables us to try out the effect on the perf bots
and for chrome frame processes.
Code mostly written by Amit.
Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading.
Bug=45510
Review URL: http://codereview.chromium.org/2805064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog
These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same. Preferences.xib changes by removing the radio buttons and moving other controls up. AutoFillDialog.xib adds checkbox to control AutoFill enabled preference. Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox.
BUG=47435
TEST=AutoFillDialogControllerTest.AutoFillEnabled*
Review URL: http://codereview.chromium.org/2799054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2864039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2827040/show
BUG=47995
TEST=no change
Review URL: http://codereview.chromium.org/2805068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unexpected unit_tests crash on chromeos.
TBR: mnissler
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
Review URL: http://codereview.chromium.org/2812026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16932
TEST=compiles
Review URL: http://codereview.chromium.org/2862041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
session only is treated as allow, but the cookies will expire after this session (the actual code to expire non-html cookies will follow).
BUG=47049
TEST=none
Review URL: http://codereview.chromium.org/2858018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910,47858
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Also, if the internal PDF plugin is enabled, it should stay enabled after a restart.
Review URL: http://codereview.chromium.org/2811037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also allow for editing them...
The XIB change adds a column at the end of the table with a NSCheckboxCell in it and the title IDS_EXCEPTIONS_OTR_HEADER
BUG=44480
TEST=manual
Review URL: http://codereview.chromium.org/2858032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45547
TBR=johnnyg
Review URL: http://codereview.chromium.org/2834034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame key. This change makes that decision sensitive to the existance of the PreRead value, not just the existance of the ChromeFrame key.
TEST=On Vista, create a ChromeFrame pref key, then run: chrome_frame_perftests.exe --gtest_filter=*X.PerfCold
BUG=45510
Review URL: http://codereview.chromium.org/2844023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of leftover references to "merge and sync."
BUG=48125
TEST=Start up sync, change data types, stop sync, etc, nothing should break.
Review URL: http://codereview.chromium.org/2843019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|