| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
Review URL: http://codereview.chromium.org/2800015
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(already works on mac).
BUG=44797
TEST=make sure control-alt-b shows the bookmark manager.
Review URL: http://codereview.chromium.org/2867027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move some string literals into chrome/common/chrome_switches.
There are still many uses in places that cannot depend on chrome/common.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2824008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47422
TEST=none
Review URL: http://codereview.chromium.org/2852025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2821010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+/-/Fullscreen menu items.
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2836029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsequent changes will:
* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.
Suggested review order:
- test files
- url_pattern*
- extension_extent*
- extension*
- everything else
BUG=46633
Review URL: http://codereview.chromium.org/2876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences.
BUG=44480
TEST=none
Review URL: http://codereview.chromium.org/2811025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the UI to reflect the latest mocks. Also improve the animation onto the screen.
BUG=34627
TEST=none
Review URL: http://codereview.chromium.org/2822019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Re-compresses all the image data, average savings 1%-4% in filesize.
- Removes the "Created with Adobe Whatever" string from all PNGs, shrinking
the files marginally even when the image data was already optimal.
This shaves more than 100k off of chrome.pak.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds an image to the top of the dialog, and removes the text and link at the bottom. It also removes the horizontal separators.
BUG=46716
TEST=Run Chrome in first-run with master_preferences set to load the new search engine dialog. It should look reasonable.
Review URL: http://codereview.chromium.org/2818014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47385
TEST=none
Review URL: http://codereview.chromium.org/2823029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2861021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than scattering init calls through the code, just inititialize
it once. (In particular, the gnome-keyring support also needs this
function called, and I didn't want to copy it one more time.)
TEST=no threading-related crash during gnome-keyring startup
Review URL: http://codereview.chromium.org/2873015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController.
Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views.
BUG=44773
TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths.
Review URL: http://codereview.chromium.org/2846028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
via download from gallery
original review here: http://codereview.chromium.org/2855009
BUG=45542
TEST=NONE
TBR=aa
Review URL: http://codereview.chromium.org/2872013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1830
TEST=ClockMenuButtonBrowserTest, manual
Review URL: http://codereview.chromium.org/2851020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error (C2712) is caused by using __try in function
that requires object unwinding. To fix this, move the
code that requires SEH to another function.
R=cpu
CC=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2841022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
right wrench menu in Toolbar.xib.
TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2813025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/45334
TEST=none yet
Review URL: http://codereview.chromium.org/2838011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Make a GRD change, dcommit, be prompted about having a GRD change.
Review URL: http://codereview.chromium.org/2813024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mock died on the vine. Toolbar is now indented along with the rest of the window content.
BUG=44773
TEST=hidden behind flag, nothing to test.
Review URL: http://codereview.chromium.org/2824021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The IDS_IMPORT_SETTINGS string was only being used on the Mac. Moved into a Mac only section and renamed.
BUG=41773
TEST=Title of meu item in Chrome menu should be "Import Bookmarks and Settings..."
Review URL: http://codereview.chromium.org/2874003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46646
TEST=manual tests
Review URL: http://codereview.chromium.org/2817021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new view to the preferences dialog in Preferences.xib that holds the
alert image and the warning message label. Update the visibility of the warning
banner when switching preference views in PreferencesWindowController.
BUG=43423
TEST=none
Review URL: http://codereview.chromium.org/2831004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2321
TEST=On user image in top right corner there is a menu button to remove user. Need changes in WM to work properly.
Review URL: http://codereview.chromium.org/2832012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the "Show full history" from the "Recently closed" bar since we can now get to the history using the link in the footer.
BUG=None
TEST=There should be three links at the bottom of the NTP now.
Review URL: http://codereview.chromium.org/2712004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2856011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45869
TEST=no change
Review URL: http://codereview.chromium.org/2856012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove some of the boilerplate strings.
- Allow the description field to be fully customizable and stylable.
BUG=46478
BUG=46479
Review URL: http://codereview.chromium.org/2849015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(These are my best mspaint skillz, so Glen, feel free to send me something more aesthetic, or at least centered).
BUG=none
TEST=new tab UI tests (should go back into expected range)
Review URL: http://codereview.chromium.org/2837012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in task manager:
Before
title memory
================================================
|Plug-in: Shockwave Flash | XXXXX |
After
title memory
============================================
|Plug-in: Shockwave Flash (10,0,3,52) | XXXXX |
Some crazy plug-ins embed version string on the title so for those it shows twice. There are not many that fall into that category
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2715001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2833023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pre-reading chrome.dll prior to calling loadlibrary has shown significant
improvement int he startup performance. Temporarily enabling this for
headless mode so that we can try out the effect on the perf bots.
Review URL: http://codereview.chromium.org/2814019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
o Grippy is hidden for now pending new UI. You can still resize just fine.
o The right divider is removed since the wrench menu is now always being shown.
TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2863013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44915
TEST=Start chrome with --enable-apps (and optionally --enable-accelerated-compositing). Install some apps. Now hover over the app icon and click the wrench icon.
Review URL: http://codereview.chromium.org/2832014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark model. This prevents a "flash" of the text between startp
and model load (when model is not empty).
BookmarkBarToolbarView nib change:
The "width based tweaker" object (that contains the "Bookmarks go
here" text shown when you have no bookmarks) defaults to NOT
visible.
BUG=http://crbug.com/43102
TEST=New profile. Launch chrome. Make sure you see the "bookmarks go here" text.
Add a bookmark; make sure text goes away.
Delete it; text comes back.
Add a bookmark; text goes away again.
Restart Chrome a dozen times. Make sure you never see the text, even for a flash.
Review URL: http://codereview.chromium.org/2825012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Make sure full keyboard control is on; e.g.
System Preferences --> Keyboard --> Keyboard Shortcuts --> Full Keyboard Access; "All controls" radio
Open bookmark bubble by clicking the STAR. Make sure you can tab
across all controls in this bubble in a natural order (left-->right,
top-->bottom).
BUG=http://crbug.com/41498
nib change: for each control, hook up nextKeyView outlet to the next control.
Review URL: http://codereview.chromium.org/2874001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
images from new tab animation. I'm combining this to minimize tree
bustage.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2854014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=wrote unit tests
BUG=chromium-os:4157
Review URL: http://codereview.chromium.org/2865009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual
BUG=chromium-os:2640
Review URL: http://codereview.chromium.org/2855014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
update url via download from gallery
Because of multiple failures of unit_tests and interactive_ui_tests.
BUG=45542
TEST=NONE
Review URL: http://codereview.chromium.org/2855009
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2822021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download from gallery
BUG=45542
TEST=NONE
Review URL: http://codereview.chromium.org/2855009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove cookie button.
XIB change:
Add an outlet for the Remove button.
BUG=45775
TEST=Chromium-->Preferences-->UtH-->Content Settings-->Cookies. Select a cookie. Press Delete. Select another. Press backspace. 2 cookies are deleted.
Review URL: http://codereview.chromium.org/2810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en
BUG=40745
BUG=36728
BUG=36222
TEST=New test added to focus_manager_unittest.cc
Review URL: http://codereview.chromium.org/2737010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
|