summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 30656.johnnyg@google.com2009-10-311-6/+0
| | | | | | Review URL: http://codereview.chromium.org/342072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98
* When the user has highlighted something like a URL, in the context menu show ↵pkasting@chromium.org2009-10-311-0/+6
| | | | | | | | | an options to navigate rather than searching. Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me. BUG=1978 TEST=Highlight "google.com" and right-click. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98
* Show a warning when the history files can't be read correctly.pkasting@chromium.org2009-10-301-0/+5
| | | | | | | | | | This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages. BUG=25822 TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog. Review URL: http://codereview.chromium.org/342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ExternalProtocolDialog for Chromeos.oshima@chromium.org2009-10-303-24/+48
| | | | | | | | | | | | * It simply says it's not supported as ChromeOS wont launch external program. Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary. BUG=23853 TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog. Review URL: http://codereview.chromium.org/342040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30593 0039d316-1c4b-4281-b951-d872f2087c98
* Original discussion in CL for 337010. See ↵mrossetti@chromium.org2009-10-291-14/+44
| | | | | | | | | | | http://codereview.chromium.org/337010/show/. BUG=25099 TEST=See 337010. Review URL: http://codereview.chromium.org/343042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30523 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Allow hiding tips and bookmark sync.arv@chromium.org2009-10-291-2/+6
| | | | | | | | | | | | | | | This change adds 2 new menu items to the option menu. There is pref migration code to make tips and sync visible by default. BUG=24319 TEST=Hide and show the different sections and reload to make sure it is persisted across instances of NTP. Review URL: http://codereview.chromium.org/337011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30495 0039d316-1c4b-4281-b951-d872f2087c98
* Binary theme resources for notifications. Really part of previous patch but ↵johnnyg@chromium.org2009-10-293-2/+2
| | | | | | | | | | | left out for try-server incompatibility with binary files. BUG=none TEST=none Review URL: http://codereview.chromium.org/348013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30474 0039d316-1c4b-4281-b951-d872f2087c98
* Adds UI components for desktop notifications, including balloon view classes ↵johnnyg@chromium.org2009-10-291-0/+4
| | | | | | | | | | | to display toasts on the screen, and manager for controlling the layout of the balloons. BUG=none TEST=none yet (part of larger patch) Review URL: http://codereview.chromium.org/338051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
* Only use std::string when generating the NTP CSS. This savestony@chromium.org2009-10-291-4/+0
| | | | | | | | | | | | about 10ms on the UI thread on my debug build. This saves a lot of string conversion. BUG=23120 Review URL: http://codereview.chromium.org/341028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30465 0039d316-1c4b-4281-b951-d872f2087c98
* Product name and version should NOT be boldfaced in the About box.mark@chromium.org2009-10-291-12/+8
| | | | | | | | | | Back out r30116. BUG=26170 25862 TEST=the About box Review URL: http://codereview.chromium.org/345020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30424 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize on the plugin icon (puzzle piece) as the default icon forfinnur@chromium.org2009-10-282-0/+1
| | | | | | | | | | | | | | | | | install dialogs and the management ui page. Also changed the margins on the body to match the download page and the history page so it doesn't look as bad when you switch between them. TEST=Install an extension without an icon and you should see the puzzle piece icon in the install dialog. TEST=Open the chrome://extensions page and you should see the same icon in the top left corner. BUG=25906 Review URL: http://codereview.chromium.org/344014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30384 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial implementation of AutoFill++. This implementation is hidden ↵jhawkins@chromium.org2009-10-285-0/+13
| | | | | | | | | | behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/339030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
* Prep the management page for localization.finnur@chromium.org2009-10-281-0/+45
| | | | | | | | | BUG=25947 TEST=Not easily testable until we have the strings localized. Review URL: http://codereview.chromium.org/329039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30324 0039d316-1c4b-4281-b951-d872f2087c98
* New wifi icons animation.chocobo@google.com2009-10-2810-8/+14
| | | | | | | | BUG=none TEST=25538 Review URL: http://codereview.chromium.org/315008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30318 0039d316-1c4b-4281-b951-d872f2087c98
* KSR should always support the new registration API now.mark@chromium.org2009-10-271-24/+6
| | | | | | | | | BUG=24814 TEST=Keystone-enabled Chrome launches without crashing and is able to check for and install updates. Review URL: http://codereview.chromium.org/329041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30267 0039d316-1c4b-4281-b951-d872f2087c98
* Map update check failure to "update server not available."mark@chromium.org2009-10-271-8/+11
| | | | | | | | | | | BUG=25948 TEST=With a suitably recent KSR, mess up the update server URL in the ticket, and verify that the update status line in the About box shows the gray icon with "update server not available" after attempting to check for an update. Review URL: http://codereview.chromium.org/344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30240 0039d316-1c4b-4281-b951-d872f2087c98
* Change the download location NSPathControl to refuse first responder.rsesek@chromium.org2009-10-271-1/+1
| | | | | | | | | BUG=None TEST=Preferences-->Under the Hood. Click on downloads path, don't get awkward blue focus ring. Review URL: http://codereview.chromium.org/330028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30230 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac build tool scripts only used by chrome.gyp from build/mac intomark@chromium.org2009-10-271-28/+0
| | | | | | | | | | chrome/tools/build/mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/334049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30222 0039d316-1c4b-4281-b951-d872f2087c98
* Make KeystoneGlue less antisocial.mark@chromium.org2009-10-273-21/+0
| | | | | | | | | | | | | | | | | Remove -clearRecentStatus which really tied KeystoneGlue too closely to AboutWindowController. If KeystoneGlue ever wound up with any other clients, this relationship would have been harmful. AboutWindowController now maintains a static variable to handle what -clearRecentStatus had been used for. Remove -releaseDefaultKeystoneGlue, which was only intended to be used for testing, as a workaround for test flake. The test flake has been removed. BUG=none TEST=none Review URL: http://codereview.chromium.org/333049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30215 0039d316-1c4b-4281-b951-d872f2087c98
* The TODO timer has expired. Clean up old build TODOs and celebrate two weeksmark@chromium.org2009-10-271-32/+0
| | | | | | | of versioned directory awesomeness. Review URL: http://codereview.chromium.org/334040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30188 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-261-3/+3
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* Product name and version should be boldfaced in the About box.mark@chromium.org2009-10-261-8/+12
| | | | | | | | BUG=25862 TEST=The About box Review URL: http://codereview.chromium.org/330023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30116 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text alignment in the About box. The left edges of the product name,mark@chromium.org2009-10-261-6/+560
| | | | | | | | | | version, legal block, and update icon (if present) should all line up. BUG=25582 TEST=Look at it. Come over here and look at it. Review URL: http://codereview.chromium.org/334031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30107 0039d316-1c4b-4281-b951-d872f2087c98
* Make the About box display existing pending operations instead of firing offmark@chromium.org2009-10-262-3/+34
| | | | | | | | | | | | | | | | | | a new update check even when an existing update check or installation attempt is in progress. Remove the check that validates that the Update button is disabled after being clicked. This test has become very fragile now that the Update button reliably enables itself as soon as an update installation attempt fails. BUG=13165 TEST=Get the About box to offer you the opportunity to install an update. Click "Install Now". Close the About box and quickly reopen it. The update status should be "Installing new version..." and not "Checking for updates..." Review URL: http://codereview.chromium.org/339010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30100 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up bookmark bubbles and the browser window so that they shut down ↵dmaclach@chromium.org2009-10-261-409/+491
| | | | | | | | | | | | | | | | | | | correctly. BookmarkBubbleController has been made an NSWindowController instead of the view controller that it used to be, and now loads its window from the nib instead of creating it on the fly. Also cleans up fullscreen mode so that the window referenced from browser_window_controller stays constant instead of having [self window] and window_ potentially pointing at two different windows. BookmarkBubble.xib has been modified so that it instantiates a window containing a bubble view instead of just instantiating a view. BUG=25054 TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting, Review URL: http://codereview.chromium.org/333017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30095 0039d316-1c4b-4281-b951-d872f2087c98
* o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.mark@chromium.org2009-10-261-13/+2
| | | | | | | | | | | | | | | o Adds Cocoa implementation of the extension installation prompt. o Added new cross-platform implementations of the extension install error prompt. o Got rid of unused extension install strings from early implementations. o Added a string to display as the header of the error dialog, since it was inline English. Patch by Andrew Bonventre <andybons@gmail.com> BUG=19654 TEST=Install an extension on any platform, observe consistent visual behavior and messaging. Review URL: http://codereview.chromium.org/333015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-262-1/+4
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* About box auto-update improvements.mark@chromium.org2009-10-263-123/+326
| | | | | | | | | | | | | | | The About box now knows how to check to see if updates have been installed in the background without anyone having to click the Update button in the box. The About box no longer gets stuck in the "installed" state. Even if an update has been installed, the About box will still check for new updates when reopened. BUG=13165, 20488 TEST=Play with the about box and auto-update a whole lot Review URL: http://codereview.chromium.org/338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make Cmd-[ and Cmd-] work properly again.viettrungluu@chromium.org2009-10-261-66/+659
| | | | | | | | | | | | | I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed). [N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.] BUG=25810 TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift). Review URL: http://codereview.chromium.org/333026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30059 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2009-10-262-95/+99
| | | | | | Review URL: http://codereview.chromium.org/334027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-241-4/+21
| | | | | | | | | | | | | | Credits for the bookmark bar fix to dmac; stolen from http://codereview.chromium.org/267082 . BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29906 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29908 Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29990 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Extensinos menu item to GTK.estade@chromium.org2009-10-231-0/+3
| | | | | | | | | | Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled. BUG=25424 Review URL: http://codereview.chromium.org/316017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
* - "homepage" -> "home page" in two stringsthomasvl@chromium.org2009-10-231-7/+16
| | | | | | | | | | | | - Fork the show home button string since mac uses it with different context. - Updated text on the toolbar control buttons for the mac prefs window. TEST=text is changed, see bugs BUG=25667 BUG=25668 Review URL: http://codereview.chromium.org/330006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29940 0039d316-1c4b-4281-b951-d872f2087c98
* Switching to a plugin icon as the favicon for the extensions page.finnur@chromium.org2009-10-232-1/+0
| | | | | | | | | | TBR=arv BUG=25509 TEST=Open the extensions page and it should have a plugin as it's favicon. Review URL: http://codereview.chromium.org/329012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
* Turn the background of the scrolling area white.thomasvl@chromium.org2009-10-231-8/+16
| | | | | | | | BUG=25594 TEST=background is white Review URL: http://codereview.chromium.org/332011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29926 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a favicon for the Extensions page.finnur@chromium.org2009-10-232-0/+1
| | | | | | | | | BUG=25509 TEST=Open the extensions page and its tab should have an icon. Review URL: http://codereview.chromium.org/332009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nsylvainthakis@chromium.org2009-10-231-21/+4
| | | | | | Revert git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29908 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-231-4/+21
| | | | | | | | | BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29906 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure OK is only enabled when there is text in the text field for folders ↵pinkerton@chromium.org2009-10-221-5/+37
| | | | | | | | | | and items (whitespace is ok). BUG=19558 TEST=per bug, test existing folders and new folders alike. Review URL: http://codereview.chromium.org/292046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29820 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the browser in the bookmark editor. Adjust the logic controlling the ↵pinkerton@chromium.org2009-10-221-18/+24
| | | | | | | | | | | | OK button enabling. In the BookmarkEditor.xib: Connect the NSBrowser's delegate (showing the bookmark tree) to the File's Owner (BookmarkEditorController). Patch from Mike Rossetti (mrosseti@chromium.org) Original review at: http://codereview.chromium.org/287014 BUG=17613 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29784 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Convert dll_path_ to a std::wstring. This avoids having dll_path_ ↵jhawkins@chromium.org2009-10-215-16/+20
| | | | | | | | | | | uninitialized after the object is constructed. CID=1632 BUG=none TEST=none Review URL: http://codereview.chromium.org/306037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-212-4/+4
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* Messaging of the download item for extension is now:mark@chromium.org2009-10-212-51/+29
| | | | | | | | | | | | | | | | Extensions can harm your computer. Are you sure you want to continue? [Continue] [Discard] This involved taking out the GTMUILocalizerAndLayoutTweaker from the xib and placing it within the controller itself, since the content of the UI is determined at runtime and cannot rely simply on the xib contents. For Win and Linux, only the confirm button needed to change. Patch by Andy Bonventre <andybons@gmail.com> BUG=23105,25257 TEST=When clicking on a link to an extension, the messaging should be specific to extensions and the button to confirm the installation should be 'Continue' instead of 'Save'. Review URL: http://codereview.chromium.org/293014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29706 0039d316-1c4b-4281-b951-d872f2087c98
* Um, polish...something...mark@chromium.org2009-10-212-1/+6
| | | | | | | | | | | | | Use a Mac-like tab key image for "Press [tab] to search" on the Mac. New image from Cole. Hello, VAG Rounded. BUG=21444 TEST=Start typing "go" in the omnibar, the "tab" image should look Mac-ish. On other platforms, the "Tab" image should be unchanged. Review URL: http://codereview.chromium.org/307024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29691 0039d316-1c4b-4281-b951-d872f2087c98
* New tab close button images from Cole.mark@chromium.org2009-10-212-1407/+2679
| | | | | | | | BUG=21444 TEST=Lollipops have not fallen in dirt? Review URL: http://codereview.chromium.org/314005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29689 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Switch from "Cancel" to "Do Nothing" for the external protocol dialog, ↵avi@chromium.org2009-10-211-0/+3
| | | | | | | | | | | and allow remembering the "Do Nothing" choice. BUG=none TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state. Review URL: http://codereview.chromium.org/314003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29671 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix Text Encoding menu by partly reverting r29315.viettrungluu@chromium.org2009-10-211-1/+1
| | | | | | | | | | | (r29315 was http://codereview.chromium.org/273063.) r29315 incorrectly changed the code for the Text Encoding menu entry to IDC_ENCODING_AUTO_DETECT (from IDC_ENCODING_MENU), which caused it to be incorrectly recognized as the auto detect menu item.... BUG=25397 TEST=Check the View->Text Encoding menu under various circumstances. Review URL: http://codereview.chromium.org/292047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29652 0039d316-1c4b-4281-b951-d872f2087c98
* New button scheme...borders are separate from the inner contents sodavemoore@chromium.org2009-10-2156-1/+21
| | | | | | | | | | | | | | | | | | that they can be highlighted / depressed independently. Got alignment of buttons right. Support hover and pushed in StatusAreaButton. Share status area button code. New icons for battery and wifi. New images. Review URL: http://codereview.chromium.org/300018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
* Explain what '&amp;&amp;' is for in IDS_IMPORT_SETTINGS: '&amp;&amp;' should ↵jshin@chromium.org2009-10-211-2/+2
| | | | | | | | | | | be replaced with 'and' in the target language unless it's good to use '&' to mean 'and' in the language. BUG=24705 TEST=NONE Review URL: http://codereview.chromium.org/307008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29589 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the new extension management UI. For the UI mocksfinnur@chromium.org2009-10-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | see the bug details. This gets us most of the way there. We have made minor course corrections since the mocks were introduced (no date will be shown, no "Get more extensions" link is visible and the name is not linked). Known issues: The only thing missing is the fact that we show a default plugin icon for each extension (as opposed to the icon for the extension). BUG=12119 TEST=Open chrome://extensions and all the buttons and links should work (Developer Tools, Enable, Disable, Reload, Uninstall, Load, Pack, Update, etc). Review URL: http://codereview.chromium.org/293028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29584 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 15:16:42 +0000