summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* Initial support for theming on Mac OS X.avi@chromium.org2009-07-1323-7712/+8627
| | | | | | | | | | | | | Patch by alcor. Original review: http://codereview.chromium.org/149204 BUG=http://crbug.com/14451 TEST=Open a theme, watch it apply. Review URL: http://codereview.chromium.org/155355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20553.thestig@chromium.org2009-07-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
* Additional svn ignores for native_client and Makefile.thestig@chromium.org2009-07-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
* Adds rendering and dragging of pinned tabs to gtk.sky@chromium.org2009-07-131-0/+3
| | | | | | | | | BUG=16634 TEST=not yet Review URL: http://codereview.chromium.org/149544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20523 0039d316-1c4b-4281-b951-d872f2087c98
* linux: cut down on logging spamevan@chromium.org2009-07-131-2/+8
| | | | | | Review URL: http://codereview.chromium.org/149546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20503 0039d316-1c4b-4281-b951-d872f2087c98
* posix: ignore SIGPIPE in all processes, not just the browserevan@chromium.org2009-07-111-9/+5
| | | | | | | | | E.g. plugin<->renderer channel can go down, causing SIGPIPE instead of a normal error. Review URL: http://codereview.chromium.org/155390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20448 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify how we stub breakpad. If breakpad is in, use the real file, if ↵thomasvl@chromium.org2009-07-112-26/+1
| | | | | | | | | | | not, use the stubs. We already use the stubs on unittests, so this just makes the same thing apply to the app. This gets breakpad's slow steps out of the google chrome mac rolling build. TEST=breakpad still works in official builds BUG=none TBR=mark@chromium.org Review URL: http://codereview.chromium.org/149499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20443 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-102-0/+0
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'version' text field in About Box selectable.jrg@chromium.org2009-07-101-3/+3
| | | | | | | | | BUG=crbug.com/15642 TEST=select version in about box; copy/paste it somewhere. Review URL: http://codereview.chromium.org/155361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20394 0039d316-1c4b-4281-b951-d872f2087c98
* A little bit of bookmark bar cleanup, a little bit of padding improvement.estade@chromium.org2009-07-101-1/+0
| | | | | | | | | | | | | | | | | | The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically). The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open). The code for packing bookmark bar buttons is now all in one place. Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal. BUG=15870 TEST=things look marginally better, theming still works properly Review URL: http://codereview.chromium.org/155342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20389 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the width of the font and language dialog in Arabic Chrome.jshin@chromium.org2009-07-101-1/+1
| | | | | | | | | | | BUG=9015 (http://crbug.com/9015) TEST=Launch CHrome with '--lang=ar'. In options - Advanced tab, open up 'Fonts and Languages' dialog and select 'Languages' tab. The string above 'Chrome UI language combobox' should not be truncated. TBR=finnur Review URL: http://codereview.chromium.org/126009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20361 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Localize "GTK Theme" button.erg@google.com2009-07-091-0/+3
| | | | | | Review URL: http://codereview.chromium.org/149411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20311 0039d316-1c4b-4281-b951-d872f2087c98
* Converts linux2 in grd file to chromeos.sky@chromium.org2009-07-091-1/+1
| | | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/155300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20289 0039d316-1c4b-4281-b951-d872f2087c98
* Try a new set of buttons (which should also work much better with themes).glen@chromium.org2009-07-0916-0/+0
| | | | | | | | | TBR=mirandac BUG=13821 TEST=Verify that our toolbar buttons have the same visual style in normal, hover and pressed states git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20288 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement the sad pluginevan@chromium.org2009-07-093-9/+0
| | | | | | | | | | | | | | This required moving the sad plugin resource out of the Windows-specific code. Note that it doesn't display right yet, since the place to display is covered by the GtkSocket that used to host the plugin. But that is a separate issue. (I had it draw to the side to verify the image was correctly getting loaded.) BUG=16158 Review URL: http://codereview.chromium.org/155262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20264 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix janklist issue #1: "there is a pixel line below the mainjrg@chromium.org2009-07-091-7/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | toolbar. The main toolbar should blend in with the bookmark bar when it's open" - Fix janklist issue #2: "It's way too tall - the distance from the bottom of the bar to a bookmark button bottom edge should be the same as the distance from the omnibox to the bookmark button top edge (this will probably mean that the bar has to overlap the toolbar)." - Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons have a frame around them ... " - Fix janklist issue #9: "the show/hide animation is very janky... I see a dark gray area behind". Even with animators the grey is gone, but animators are disabled for now due to races. - Fix unlisted jank related to 9: don't use animator when opening bar on launch. - Also chipped away on unit tests. TEST=Launch with bookmark bar both open and closed. Make sure OK on launch. In each case open and close a few times fast. Repeat with multiple windows open. Sanity check jank descriptions listed above are fixed. BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724 Review URL: http://codereview.chromium.org/149308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20244 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the official Google Chrome build on Linux.jam@chromium.org2009-07-091-4/+4
| | | | | | Review URL: http://codereview.chromium.org/155261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20227 0039d316-1c4b-4281-b951-d872f2087c98
* Renable sending page urls in renderer crashes on Mac.jabdelmalek@google.com2009-07-091-0/+5
| | | | | | Review URL: http://codereview.chromium.org/149370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20226 0039d316-1c4b-4281-b951-d872f2087c98
* The Mac version of the download shelf from the original CL by thakis:paul@chromium.org2009-07-081-0/+700
| | | | | | | | | | | | | | | | | | http://codereview.chromium.org/150216 Original description: Move download item to its own view and a xib, paving the way for a custom download item view. I didn't change the look of the download items yet. The context menu is now in the download item xib as well. BUG=14659,15098,14660 TEST=Download something. Everything should look like before (except for the smaller icon), but the context menu items should be disabled/enabled and checked/unchecked correctly. Review URL: http://codereview.chromium.org/149276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20200 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix broken treejrg@chromium.org2009-07-082-4/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20197 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-081-5/+5
| | | | | | Review URL: http://codereview.chromium.org/155238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 20173 because it breaks the ui_tests, plugin_testsnsylvain@chromium.org2009-07-081-5/+5
| | | | | | | | and most likely some page cyclers. Review URL: http://codereview.chromium.org/155236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-081-5/+5
| | | | | | Review URL: http://codereview.chromium.org/149305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98
* Add context menus to tabs.pinkerton@chromium.org2009-07-081-7/+303
| | | | | | | | BUG=14920 TEST=context menus on tabs. Review URL: http://codereview.chromium.org/155173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98
* Add facitility for Global Keyboard shortcuts.jeremy@chromium.org2009-07-082-12/+64
| | | | | | | | | | | | | | | | | Also, do some housekeeping for our current shortcuts. * Command-Option-l - Downloads [same shortcut as Safari]. * Command-Shift-[/] - Back/forward tab. * cntrl-pageup/pagedn - Back/forward tab. Global Keyboard events are intercepted by a new BrowserWindow custom class. BUG=12537,15486 TEST=Check that above keyboard shortcuts work as advertised. Review URL: http://codereview.chromium.org/149325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20145 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: SUID sandbox supportagl@chromium.org2009-07-081-18/+10
| | | | | | | | | | | | | | | | | | | | | * Make processes dumpable when they crash. * Find crashing processes by searching for a socket inode, rather than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs between PID namespaces with SCM_CREDENTIALS, so we can't use the PID there. * Use a command line flag to the renderer to enable crash dumping. Previously it tried to access the user's home directory for this information. * Search for a sandbox helper binary and, if found, use it. * Include the source for a sandbox helper binary. It's currently not built by default. http://codereview.chromium.org/149230 R=evan,markus BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the prefs for the optional home buttons and page/wrench buttons. ↵pinkerton@chromium.org2009-07-074-25/+3306
| | | | | | | | | | Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. BUG=13151 TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar. Review URL: http://codereview.chromium.org/155151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the ability to close or minimize the hung renderer dialogrohitrao@chromium.org2009-07-071-4/+4
| | | | | | | | | | | | on Mac. I'm leaving the window resizable for now, because I dislike non-resizable windows. This is easy enough to change later. BUG=None TEST=After bringing up the dialog, verify that the only way to dismiss it is by pressing either the wait button or the kill button. Review URL: http://codereview.chromium.org/151009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98
* Theme window control buttons.mirandac@chromium.org2009-07-076-1/+8
| | | | | | | | | | | BUG= http://crbug.com/14579 TEST= Install a theme with themed window control buttons. Observe that WCB's are themed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758 Review URL: http://codereview.chromium.org/150041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20028 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of keybindings.sky@chromium.org2009-07-071-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-031-0/+3
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19758.mirandac@chromium.org2009-07-016-8/+1
| | | | | | Review URL: http://codereview.chromium.org/150180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19763 0039d316-1c4b-4281-b951-d872f2087c98
* Theme window control buttons.mirandac@chromium.org2009-07-016-1/+8
| | | | | | | | | BUG= http://crbug.com/14579 TEST= Install a theme with themed window control buttons. Observe that WCB's are themed. Review URL: http://codereview.chromium.org/150041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19758 0039d316-1c4b-4281-b951-d872f2087c98
* Remove null link from "welcome to tips" default suggestion. Also make some ↵mirandac@chromium.org2009-07-011-0/+8
| | | | | | | | | | | hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556. BUG= http://crbug.com/15467 TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link. Review URL: http://codereview.chromium.org/147247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
* More new tab button tweaks. I'm leaving tab_start_x as I suspect I'msky@chromium.org2009-07-012-1/+0
| | | | | | | | | | | going to need it again shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/151126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19736 0039d316-1c4b-4281-b951-d872f2087c98
* Remove popup blocking pref as it's not on windows.pinkerton@chromium.org2009-07-011-61/+22
| | | | | | | | BUG=13160 TEST=none Review URL: http://codereview.chromium.org/150163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19734 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chromium logo to remove all that whitespace. All usages of thisarv@google.com2009-06-301-0/+0
| | | | | | | | | | | | | image can handle the new size. BUG=None TEST=Start chromium and the chromium logo should look the same as before on the new tab page and on the about:version page. Review URL: http://codereview.chromium.org/150110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19646 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential memleak in InitCrashReporterWithDllPath. It can leak at line ↵finnur@chromium.org2009-06-301-10/+10
| | | | | | | | | | | 294 and 370 (if the if clause is false). BUG=None TEST=None Review URL: http://codereview.chromium.org/151050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19639 0039d316-1c4b-4281-b951-d872f2087c98
* Add a keyboard shortcut for opening the download page on Mac.paul@chromium.org2009-06-301-3/+4
| | | | | | | | | | | | | Windows uses Ctrl + j, but the Mac equivalent (Cmd + j) is already in use for Edit -> Find -> Jump to Selection. I've chosen Cmd + Shift + j, as a replacement, but it's easy enough to change. TEST=Press the keyboard shortcut (Shift + Cmd + j) to open the download page. BUG=15653 Review URL: http://codereview.chromium.org/150073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19637 0039d316-1c4b-4281-b951-d872f2087c98
* Mac fullscreen mode (with pkasting).jrg@chromium.org2009-06-291-6/+41
| | | | | | | | | | | | | | | | | | | | | | | TEST=Launch Chrome. Create a 2nd tab. Close bookmark bar. Cmd-F11 to enter fullscreen; make sure content is centered and both bookmark bar and toolbar are gone. Make sure menubar gone. Cmd-Opt-arrows to switch tabs; make sure still OK. Cmd-F11 to go back; make sure things look normal. Open bookmark bar. Cmd-F11; make sure gone. Cmd-F11 again; make sure it comes back. Confirm View-->Fullscreen menu item works. While in fullscreen, Cmd-T to create new tab and click on a fav tile. Make sure page loads. While in fullscreen, try window hotkeys (Cmd-N and Cmd-W) to make sure they work. Cmd-` to switch windows; switch back, then Cmd-F11 to undo fullscreen. Move the mouse to to the top of the screen; make sure menubar appears. Move the mouse down; make sure menubar goes away. Review URL: http://codereview.chromium.org/126294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19559 0039d316-1c4b-4281-b951-d872f2087c98
* Removes our homespun grow box and replaces it with therohitrao@chromium.org2009-06-292-29/+6
| | | | | | | | | | | standard widget. This may also fix some of our resizing issues. BUG=http://crbug.com/14663 TEST=The resizer widget should still work as expected. Review URL: http://codereview.chromium.org/149094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the forgotten renames of recommendations to tips.arv@google.com2009-06-271-4/+4
| | | | | | | | | | BUG=15491 TEST=Open the options menu and there should be no "null" in the UI Review URL: http://codereview.chromium.org/147249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
* A first implementation of the SSL client auth UI.This uses the Windows API ↵jcampan@chromium.org2009-06-271-0/+9
| | | | | | | | that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Review URL: http://codereview.chromium.org/147233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome start-up parameters to information passed back in breakpad crashcpu@google.com2009-06-261-20/+42
| | | | | | | | | | | | | - we collect the first two params : switch-1 and switch-2 - up to 64 chars, then it truncates BUG=b/1910452 TEST=starting chrome should work as usual, otherwise see the bug Review URL: http://codereview.chromium.org/149034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the image used for the new tab button.sky@chromium.org2009-06-262-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/146056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19339 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary extension UI for the Mac.avi@chromium.org2009-06-251-0/+28
| | | | | | | | | BUG=none TEST=try loading a failing extension on the Mac; you should get some UI Review URL: http://codereview.chromium.org/147098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19247 0039d316-1c4b-4281-b951-d872f2087c98
* Change the breakpad initialization for Google Chrome to bensylvain@chromium.org2009-06-253-26/+33
| | | | | | | | | | | | | | | the same as Chromium. Chromium was delayed, while Google Chrome was not, resulting in another LoadLibrary of chrome.dll. Since we are not really getting crash reports of chrome crashing during LoadLibrary, we don't mind initializing after. BUG:4564 TEST:about:crash still report a crash in Google Chrome and Chromium. Review URL: http://codereview.chromium.org/146030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19242 0039d316-1c4b-4281-b951-d872f2087c98
* Add tooltips to buttons on the new new tab page as well as remove thearv@google.com2009-06-241-4/+12
| | | | | | | | | | | | | | edit link. BUG=14958, 15073 TEST=On the new new tab page. No "edit" link should show up after a long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails, show/hide list should all show tooltips. Review URL: http://codereview.chromium.org/146108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Privacy prefs and cookie prefs in "under the hood".pinkerton@chromium.org2009-06-241-83/+222
| | | | | | | | BUG=15078 TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch. Review URL: http://codereview.chromium.org/146088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19149 0039d316-1c4b-4281-b951-d872f2087c98
* Add hover and pressed states for the home button.glen@chromium.org2009-06-242-0/+0
| | | | | | | | | BUG=13821 TEST=Verify that the home hover and pressed states look right TBR=mirandac git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19137 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-07 21:24:54 +0000