| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/437030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it work without a browser window being present.
Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}.
BUG=27995
TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in.
Review URL: http://codereview.chromium.org/423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK:
- set default size of contents, rather than window as a whole---this gets line wrapping right.
All:
- change title string to Title Case instead of Sentence case
- fix Connection text for mixed/unsafe content
BUG=28507
Review URL: http://codereview.chromium.org/437026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28058
Review URL: http://codereview.chromium.org/426008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
part 1: string fix (not to be merged to 249)
BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/431002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/414075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux to poplular Linux fonts.
This CL does not change the fonts for traditional Chinese because they're the same as for English Chrome (per popular request in Mozilla bugzilla years past) and
it's not clear what to do about mscorettf (Arial, Times New Roman) we specify for most language versions of Chrome.
BUG=20171
TEST=NONE
Review URL: http://codereview.chromium.org/259060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17706
TEST=None
Review URL: http://codereview.chromium.org/414006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Functions that take a printf-style format get a new annotation, which
produces a bunch of compiler warnings when you use printf impoperly.
This change adds the annotations and fixes the warnings.
We now must use PRId64 for 64-bit numbers and the PRIsz for size_t.
Review URL: http://codereview.chromium.org/339059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The cursor was displayed with full keyboard accessibility enabled.)
Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|).
BUG=25570
TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text).
Review URL: http://codereview.chromium.org/414028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
subsequent read to fail.
This was causing MetricsServiceTest.CrashRenderers to fail on Linux branded builds with CHROME_HEADLESS set:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Google%20Chrome%20Linux/builds/4723/steps/ui_tests/logs/CrashRenderers
Review URL: http://codereview.chromium.org/414010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
28k of pak file size, but will make the binary a tad bit larger.
BUG=28174
Review URL: http://codereview.chromium.org/407007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AboutIPC.xib - Connected up controller to its window and the window delegate to the controller.
BUG=26484, 26484
TEST=See repro steps in bugs.
Review URL: http://codereview.chromium.org/402066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
higher than _ChromeMain, so that CrashReporter stacks and other symbolized
stacks aren't so confusing. Add a tool to verify that nothing violates this
ordering requirement.
BUG=28257
TEST=verify_order, which is part of the build
Review URL: http://codereview.chromium.org/414003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder).
Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above.
BUG=26157
TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported.
Review URL: http://codereview.chromium.org/378036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=LaForge
Review URL: http://codereview.chromium.org/399105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, Ctrl+Alt+B equals to AltGR+B, which corresponds to '{' on Hungarian keyboard.
BUG=27137
TEST=Switch to Hungarian keyboard layout, then try to input '{' in both omnibox and web content area by pressing AltGR+B.
Review URL: http://codereview.chromium.org/401025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tabs dialogs to a tree view.
Nib changes: Removed the NSBrowser and added an NSOutlineView.
BUG=26647,26643,26718,27634
TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view.
Review URL: http://codereview.chromium.org/393006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark.
Changes to TabView.xib:
- add Pin Tab item (to match Windows)
Still to do:
- dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team)
- on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done
BUG=25481
TEST=not yet
Review URL: http://codereview.chromium.org/375010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads.
Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads.
Enable Extensions menu item when no browser window is open.
BUG=25423
TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open.
Review URL: http://codereview.chromium.org/399072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed explicitly set first responder that was causing autocalculate not to work.
Changes to Preferences.xib
Turned on the autorecalculate flag.
BUG=27781
TEST=repro steps in bug
Review URL: http://codereview.chromium.org/402041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/402038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/403007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/397026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implement a CreateApplicationShortcutView similar to the current Gears-based one;
- Add a few profile prefs to persist user's last checked shortcut locations
- Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications"
in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls
file_util code to creates shortcut on Windows;
- Add Win7 taskbar pin/unpin support function to file_util;
- Update TabContents to replace gears with new code;
Note:
- Gears dialog is modaless but this one is a modal dialog.
- Gear's icon store is not migrated because gears icons
could still be used by shortcuts created by gears and
thus we could not delete them even after migration. And we
are not using the local ico files in the dialog even if
they exists.
- New CreateApplicationShortcutView is included when
TOOLKIT_VIEW is defined. However on platforms other
than Windows, the actual CreateShortCut code is not
implemented. Right now it calls ShellIntegration's
CreateDesktopShort if OS_LINUX is defined and
NOTREACHED() for other platforms.
BUG=25528
TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7.
Review URL: http://codereview.chromium.org/372012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=unit_tests
Patch by Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/375016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should be sentence-case rather than title-case for non-Linux,
and it shouldn't have a trailing colon on Linux.
BUG=27766
Review URL: http://codereview.chromium.org/395019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not ALL all. Make Delete and Rename enabled for folder context menu
(but disabled for "Other Bookmarks").
nib changes (related to the context menus):
- Telegate is the bookmark bar controller.
- Switched type from NSMenu to BookmarkMenu.
TEST=New window. Create folder "empty" with nothing in it. Create
folder "two" with 2 bookmarks in it. Create a final bookmark in the
top level of the bar.
Context menu (right click) over all folders.
Make sure Delete and Rename enabled for folders but not "Other Bookmarks".
Make sure "Open All" (and friends) disabled over "empty", enabled over "two".
"Open All" on "two" --> see 2 opened.
"Open All" on the bar itself --> see 3 opened.
Ditto for "Open all in new window" and "open all in incognito window".
Create a new window. In new window, make sure folders have context menus.
BUG=http://crbug.com/27522, http://crbug.com/27529
Review URL: http://codereview.chromium.org/391046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 27393, 26744
TEST= promotional messages should show up on NTP.
Review URL: http://codereview.chromium.org/394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= None
TEST= None
Review URL: http://codereview.chromium.org/395014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kathyw@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place).
Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController).
Not yet implemented: morphing between the detached bar (on the NTP) and anything else.
BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate.
Review URL: http://codereview.chromium.org/384105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appearing.
Change to BookmarkBubble.xib was to make the window not show on creation.
It will have more mods to it because of switching to IB on Snow Leopard.
BUG=27464
TEST=Make the bookmark bubble appear and disappear by clicking on the star.
Review URL: http://codereview.chromium.org/389027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
everywhere.
BUG=27163
Review URL: http://codereview.chromium.org/384108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 27393
TEST= none
Review URL: http://codereview.chromium.org/395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Honor "send screenshot" checkbox
* Save bug description and send screenshot state if user chooses "phishing report" function (that disables both); restore if the user goes back to a non-phishing bug.
* Make bug report give consistent and correct values for bug type.
BUG= 27283, 27282, 27281
TEST= Fill in data in bug description, toggle send screenshot "on". Move between "phishing" and non-phishing reports before sending. Note that description goes away and reappears appropriately.
Review URL: http://codereview.chromium.org/385047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/394002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in subtle and devious ways.
Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln,
which occured unbeknownst to the builders who continued to build webkit.sln
for most of the day. This wasn't an issue until we did a WebKit roll, where
the trickery was discovered and hell broke loose.
TBR=yaar
TEST=green bots
BUG=none
Review URL: http://codereview.chromium.org/385084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24638
TEST=Not sure how the duplicate crash reports were getting generated so can not test that but made sure that the crash reporting works fine.
Review URL: http://codereview.chromium.org/385030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from the design team, but I wanted to at least get the words
in before the string freeze.
Review URL: http://codereview.chromium.org/385075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19738
TEST=Get a Google Account into captcha state. Start syncing. You should
be presented with a captcha image and textbox to answer the challenge.
Doing so correctly shoud unlock your account and proceed with sync setup.
Review URL: http://codereview.chromium.org/389017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an l10n issue where the string was hard coded in English.
Instead of using the tips infrastructure, after setting the home page we send
an ack to the NTP and show a notification. In this way the user will see the
notification even if they have hidden the tips.
Added a ui test that clicks on the link and checks the state of the UI
afterwards.
BUG=25101
TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click
on the link "Make this my home page" at the bottom. You should see a banner at
the top. Pressing Alt-Home should now go to the NTP.
Review URL: http://codereview.chromium.org/392005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12673
TEST=as in bug
Review URL: http://codereview.chromium.org/385054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser actions rather than toolstrips.
BUG=26106
TEST=none
Review URL: http://codereview.chromium.org/384065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Popups are not implemented within this change.
BUG=23881
TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI.
Review URL: http://codereview.chromium.org/366029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Menu item is right above "Preferences..." (with an extra separator). Menu item and separator is hidden if sync is not enabled.
BUG=23073
TEST=manually
Review URL: http://codereview.chromium.org/386020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These controls are only visible when sync is enabled. This isn't finished,
but it is enough to be usable.
Made RemoveViewFromView() handle top-most views. Also added
RemoveGroupFromView().
BUG=23073
TEST=manual testing, trybots
Review URL: http://codereview.chromium.org/380006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31775 0039d316-1c4b-4281-b951-d872f2087c98
|