summaryrefslogtreecommitdiffstats
path: root/chrome/app
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Fixed behavior of Sync Autofill checkbox in Customize Sync dialogakalin@chromium.org2010-04-231-23/+36
| | | | | | | | | | | | | XIB changes: Switched on "Conditionally sets Hidden" flag for autofill checkbox. Bound "Hidden" state to autofillRegistered with NSNegateBoolean (which was incorrectly omitted). BUG=41833 TEST=manual Review URL: http://codereview.chromium.org/1700009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45404 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Use different icon for SxSmattm@chromium.org2010-04-233-1/+3
| | | | | | | | | BUG=37119 TEST=build official exe, run with --chrome-sxs Review URL: http://codereview.chromium.org/1727006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45388 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the low battery message per Cole's suggestion.oshima@chromium.org2010-04-221-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1711009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45336 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-2298-6989/+4107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd attempt to land http://codereview.chromium.org/1676002 for njwchocobo@chromium.org2010-04-211-0/+12
| | | | | | | | | | | | WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any. Pass these values down the stack into ConnectToWifiNetwork(). TEST=Compiles and login dialog shows new fields when security is 802.1x. BUG=none TBR=njw Review URL: http://codereview.chromium.org/1692005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45229 0039d316-1c4b-4281-b951-d872f2087c98
* Put a button to link to proxy setup into the prefs dialog.avi@chromium.org2010-04-211-25/+151
| | | | | | | | | | | nib changes: Added two static strings, button. BUG=http://crbug.com/22009 TEST=as in bug Review URL: http://codereview.chromium.org/1759001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45203 - Land http://codereview.chromium.org/1676002 for njwjhawkins@chromium.org2010-04-211-12/+0
| | | | | | | | | | | | tbr:njw TEST=Compiles and login dialog shows new fields when security is 802.1x BUG=none Review URL: http://codereview.chromium.org/1712003 TBR=chocobo@chromium.org Review URL: http://codereview.chromium.org/1743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45209 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/1676002 for njwchocobo@chromium.org2010-04-211-0/+12
| | | | | | | | | tbr:njw TEST=Compiles and login dialog shows new fields when security is 802.1x BUG=none Review URL: http://codereview.chromium.org/1712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45203 0039d316-1c4b-4281-b951-d872f2087c98
* (jrg@chromium.org2010-04-212-50/+1572
| | | | | | | | | | | | | | | | | | | | | | | | | | | Retry of http://codereview.chromium.org/1731001 Try servers not helpful since this includes a binary file. Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test which did not include BookmarkButton* tests :-( Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow) ) UI review follow-up for m5 bookmark bar deliverables Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1709004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spelling of Flickr.avi@chromium.org2010-04-211-3/+3
| | | | | | | | | BUG=none TEST=make sure file uploading to Flickr still works. Review URL: http://codereview.chromium.org/1718005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45195 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45151 - UI review followup for m5 bookmark bar deliverablesjrg@chromium.org2010-04-212-1572/+50
| | | | | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leakthru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1727004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45152 0039d316-1c4b-4281-b951-d872f2087c98
* UI review follow-up for m5 bookmark bar deliverablesjrg@chromium.org2010-04-212-50/+1572
| | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45151 0039d316-1c4b-4281-b951-d872f2087c98
* Add remembered networks. Reworked network options UI.chocobo@chromium.org2010-04-201-2/+17
| | | | | | | | BUG=chromium-os:2555 TEST=none Review URL: http://codereview.chromium.org/1662004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45119 0039d316-1c4b-4281-b951-d872f2087c98
* Support drawing nano tabs in the tabstrip.finnur@chromium.org2010-04-206-0/+5
| | | | | | | | | BUG=42146 TEST=Launch an Extension App and make sure it is visually differently drawn than anything else. Review URL: http://codereview.chromium.org/1689002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45103 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up Edit > Copy URL menu item to browser code.pinkerton@chromium.org2010-04-201-3/+12
| | | | | | | | BUG=41789 TEST=chose menu item, notice page url is on clipboard. Ensure it's disabled when there are no browser windows, or a non-browser window is foreground. Review URL: http://codereview.chromium.org/1700001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45078 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45065 - Relanding this. Originally landed as ↵ben@chromium.org2010-04-201-3/+0
| | | | | | | | | | | | | | | | http://codereview.chromium.org/1001003 but reverted due to reliability crashes. Relanding so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1715001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45077 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing this. Originally landed as http://codereview.chromium.org/1001003 ↵ben@chromium.org2010-04-201-0/+3
| | | | | | | | | | | | | but reverted due to reliability crashes. Re-landing so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45065 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure GoogleUpdateSettings::GetChromeChannel does not read siggi@chromium.org2010-04-201-1/+2
| | | | | | | | | | | | | from the wrong section of registry when a per-user install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45043 0039d316-1c4b-4281-b951-d872f2087c98
* xib changes only: put Autofill below Themes, hide it if autofill is not ↵dantasse@chromium.org2010-04-191-23/+40
| | | | | | | | | | | registered. BUG=41833 TEST=visual inspection of sync customize dialog: autofill should not be there. Review URL: http://codereview.chromium.org/1613023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44983 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Tint the geolocation icons in gtk mode.erg@chromium.org2010-04-192-0/+0
| | | | | | | | | BUG=41701 TEST=none Review URL: http://codereview.chromium.org/1659005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44957 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Mac UI telephone/fax fields now one.dhollowa@chromium.org2010-04-191-298/+82
| | | | | | | | | | | | | | | | | | Changes telephone and fax number entries in the Mac AutoFill dialog to be a single text field for all three (1) country code, (2) area code, (3) number. Renames address model fields city, state, country to be addressCity, addressState, addressCountry. This was due to subtle name clash with 'state' as a selector. Nib changes: (1) changes bindings to reflect the renaming of city, state, and country in the model. (2) collapse telephone and fax numbers from three fields each to a single field. BUG=41233 TEST=AutoFillAddressModelTest, AutoFillCreditCardModelTest, AutoFillAddressViewControllerTest, AutoFillCreditCardViewControllerTest Review URL: http://codereview.chromium.org/1625020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an icon that is no longer used.pkasting@chromium.org2010-04-192-316/+0
| | | | | | | | | TBR=alcor BUG=41481 TEST=none Review URL: http://codereview.chromium.org/1629025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44930 0039d316-1c4b-4281-b951-d872f2087c98
* SSL UI changes, Windows, code side (images are separate).pkasting@chromium.org2010-04-192-8/+3
| | | | | | | | | | | | | | | | * Remove "Type to search" hint * Remove "Untrusted website" label * Add EV cert bubble, make it function like a location icon for clicks/drags * Modify spacing for EV/tab-to-search bubbles to keep icons and text aligned with dropdown * Change non-EV HTTPS coloring from blue to green Mac and Linux should compile, but only some of the above changes have been made for them. Specifically, there is no EV cert bubble, the non-EV scheme color isn't changed, and the icon/text alignment in the tab-to-search bubble hasn't been touched. BUG=41481 TEST=paypal.com should generate a bubble around the lock and cert holder name, which responds to clicks and drags like the location icon would Review URL: http://codereview.chromium.org/1585043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44929 0039d316-1c4b-4281-b951-d872f2087c98
* Hover buttons for notification.oshima@chromium.org2010-04-161-0/+4
| | | | | | | | | | | | | | | * Chagned WidgetGtk so that any GtkFixed can be parent of WidgetGtk. * Close button and Options menu is moved to separate TYPE_CHILD WidgetGtk which is shown/hidden as mouse moves. TODO: host Widget is not transparent right now. I'll address this in separate CL. BUG=41011 TEST=none Review URL: http://codereview.chromium.org/1654006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44861 0039d316-1c4b-4281-b951-d872f2087c98
* SSL UI changes (icons). TBRed since trybots hate binary patches.pkasting@chromium.org2010-04-1610-363/+737
| | | | | | | | | | | | | * Add images for EV bubble * Modify images for tab-to-search to look like EV bubble * Change lock icons TBR=alcor BUG=41481 TEST=none Review URL: http://codereview.chromium.org/1652014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44859 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove divider line between "sync" and "clear" menu items in chrome menuthakis@chromium.org2010-04-161-24/+12
| | | | | | | | | BUG=41769 TEST=Guess Review URL: http://codereview.chromium.org/1623016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44817 0039d316-1c4b-4281-b951-d872f2087c98
* Improve bookmark bar folder scroll.jrg@chromium.org2010-04-161-48/+804
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=39791 TEST=\ Create bookmark folders with various quantites of bookmarks. Make sure normal folders work. Open some that don't fit on the screen. See rounded corners on bottom. Try and move mouse to bottom of screen --> window grows and scrolls. Move mouse to top of screen --> window does NOT change size but does scroll. Move mouse off folder while scrolling --> scrolling stops. Make sure no buttons get "stuck" with a mouse-enter (highlit). Make sure no "getting stuck" or "window scrolls off the screen". Briefly test subfolders. xib changes: - Window content view is now BookmarkBarFolderWindowContentView - BookmaerkBarFolderView now wrapped in an NSScrollView - Some view autosizing changed Review URL: http://codereview.chromium.org/1593025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44755 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Limit Breakpad LOG spewjeremy@chromium.org2010-04-151-1/+1
| | | | | | | | | | | | | If a user has enabled generation of breakpad dumps, we log a warning message. Before this CL a log message was printed for every single Chrome process. This CL limits the printout to just the first browser invocation. BUG=None TEST=Launch a branded build of Chrome from a terminal, open a few tabs, "Breakpad disabled" message should only be printed once. Review URL: http://codereview.chromium.org/1629019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44697 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Added logic to prevent the user from clicking OK unless he has selected ↵dantasse@chromium.org2010-04-151-749/+64
| | | | | | | | | | | | | at least one datatype to sync. xib changes: made the OK button get grayed out if you deselect all the checkboxes in the Customize Sync dialog box. (it re-enables if you select one of the checkboxes) BUG=40880 TEST=sync_customize_unittest, included Review URL: http://codereview.chromium.org/1578033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r44611 because it may have broken "unit_tests" on "Vista Tests".wtc@chromium.org2010-04-151-0/+3
| | | | | | | | BUG=27125 TEST=none Review URL: http://codereview.chromium.org/1655008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44615 0039d316-1c4b-4281-b951-d872f2087c98
* Display the SECURITY_WARNING status in the location bar for the wtc@chromium.org2010-04-151-3/+0
| | | | | | | | | | | | | | ERR_CERT_UNABLE_TO_CHECK_REVOCATION certificate error. Do not display an info bar. Remove the unused ToolbarModel::GetIconHoverText function. R=pkasting,jcivelli BUG=27125 TEST=Visit port 452 on the chrometws server. Review URL: http://codereview.chromium.org/1653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44611 0039d316-1c4b-4281-b951-d872f2087c98
* Implement cut and paste and rework copy and delete bookmark actions from ↵mrossetti@chromium.org2010-04-142-1349/+1284
| | | | | | | | | | | | | | | context menus. Eliminate bifurcated 'parentController_' data member (leaving this common behavior to the BookmarkFolderTarget class). Provide context menus (one for button and another for folder) for the folder controller thus allowing far easier identification of the target of the action. BookmarkBar.xib changes: Added Cut and Paste menu items to the button and folder contextual menus. Reconfigured the menus with separators and some rearranging to match Windows. BookmarkBarFolderWindow.xib changes: Copied the button and folder contextual menus from the BookmarkBar.xib and wired them up to the folder controller instead. BUG=23541 TEST=Present context menu for bookmark bar and verify the presence of Cut/Copy/Paste/Delete. Verify proper enabling (i.e. Paste should not be enabled until a bookmark or folder has been Cut or Copied). Perform each action Cut, Copy, Delete and Paste. Perform these tests for the contents of a folder coming off of the bookmark bar and for subfolders, too. Insure that pasting can be performed from the bar to a folder, a folder to the bar, bar to bar, folder to folder, at the beginning and at the end of each. Review URL: http://codereview.chromium.org/1611027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44505 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to use new Chrome version info from r44435.mmoss@google.com2010-04-141-1/+1
| | | | | | | | | Fixes Linux official build: chrome/app/breakpad_linux.cc:184: error: ‘PRODUCT_VERSION’ was not declared in this scope Review URL: http://codereview.chromium.org/1630022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44500 0039d316-1c4b-4281-b951-d872f2087c98
* new image for notification menu.oshima@chromium.org2010-04-141-0/+0
| | | | | | | | | | BUG=41011 TEST=none TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/1637010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44487 0039d316-1c4b-4281-b951-d872f2087c98
* Resource changes to the mediaplayerdhg@chromium.org2010-04-149-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1627017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44486 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hook up the IBActions on the ExtensionInstallPromptNoWarnings.xib so ↵rsesek@chromium.org2010-04-141-6/+23
| | | | | | | | | | | that the buttons work. BUG=crbug.com/41403 TEST=See bug report for repro steps. Review URL: http://codereview.chromium.org/1595024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44472 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at adding UI for changing the UI language.satorux@chromium.org2010-04-141-0/+9
| | | | | | | | | | | | For now, the logic for UI language switching is not yet implemented. Will add the logic in a separate patch. TEST=manually BUG=crosbug.com/2336 Review URL: http://codereview.chromium.org/1652002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44450 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FileVersionInfo into an interface with platform implementations.tony@chromium.org2010-04-143-0/+96
| | | | | | | | | | | | | This allows us to move the chrome specific version informaton used by Linux into src/chrome. Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome. In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell. Review URL: http://codereview.chromium.org/1560027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
* Shorten text next to checkmark. Use yellow text instead of an alert dialog.aa@chromium.org2010-04-131-10/+4
| | | | | | | | | | See screen cap in bug. BUG=41356 Review URL: http://codereview.chromium.org/1642006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44417 0039d316-1c4b-4281-b951-d872f2087c98
* Add new search engine dialog for first run process.mirandac@chromium.org2010-04-132-1/+51
| | | | | | | | | | BUG= 37564 TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog. Review URL: http://codereview.chromium.org/1586005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Tint omnibox icons in GTK mode differently.erg@chromium.org2010-04-135-0/+4
| | | | | | | | | | | | | - Tint highlighted icons (the *_DARK variety) the color of highlighted text. - Use new variants of the IDR_OMNIBOX_HTTP* and IDR_OMNIBOX_HISTORY* icons in GTK mode where there isn't a white background. BUG=41189 TEST=none Review URL: http://codereview.chromium.org/1559029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44401 0039d316-1c4b-4281-b951-d872f2087c98
* A common pattern for Chrome is for dialogs to "own themselves"jrg@chromium.org2010-04-132-91/+1528
| | | | | | | | | | | | | | | | | | | | | (e.g. fire and forget). As implemented on the Mac, the termination chain (e.g. when OK is pressed) is to call [NSApp endSheet:]. didEndSheet then closes the window, and the controller (set as the delegate of the window) gets a windowWillClose: callback (so the controller knows to delete itself). The problem here was that the window was ordered out (offscreen) but not actually closed, so we didn't clean up properly. BUG=40429 TEST=no valgrind suppression needed and unit_tests stay happy. nib change: window controller (file's owner) is the delegate of the window (for both nibs) Review URL: http://codereview.chromium.org/1654003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44383 0039d316-1c4b-4281-b951-d872f2087c98
* Make autofill "make this default" buttons radio buttons to match function ↵avi@chromium.org2010-04-132-4/+4
| | | | | | | | | | | | | | and to match Windows. xib change: switch the default buttons to be radio buttons. BUG=none TEST=in autofill prefs, the "make this default" buttons should be radio buttons Review URL: http://codereview.chromium.org/1528033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44360 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, missed some changes to the English Terms of Service the first time.viettrungluu@chromium.org2010-04-122-2/+4
| | | | | | | | | BUG=none TEST=two URLs in 6.1, and section 8.7 exists Review URL: http://codereview.chromium.org/1574023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44271 0039d316-1c4b-4281-b951-d872f2087c98
* Change MIUTE to MINUTE in 4 string descriptions.mal@google.com2010-04-101-4/+4
| | | | | | | | | | | No big deal, but no need to preserve the misspelling for all time. BUG= None TEST= None needed. No code change. TBR= chocobo Review URL: http://codereview.chromium.org/1508029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44181 0039d316-1c4b-4281-b951-d872f2087c98
* Round the top left and right edges of the toolbar.glen@chromium.org2010-04-101-0/+2
| | | | | | | | | BUG=40022 TEST=Make sure the top left and right eges of the toolbar are rounded. Review URL: http://codereview.chromium.org/1606021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44177 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill cmd-shift-a keyboard shortcut on Mac.dhollowa@chromium.org2010-04-101-2/+54
| | | | | | | | | | | | | | | Adds menu item "Edit->AutoFill Form" and keyboard shortcut cmd-shift-a to fill form on page with default address and/or credit card information. Nib change: add "AutoFill Form" menu item under Edit, with command id 40024. BUG=39491 TEST=Open browser window with autofillable form, invoke menu item with mouse or cmd-shift-a. Expect: form fills. Review URL: http://codereview.chromium.org/1622020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44172 0039d316-1c4b-4281-b951-d872f2087c98
* Images only checkin for try server goodness.glen@chromium.org2010-04-104-0/+0
| | | | | | | | | | See http://codereview.chromium.org/1606021 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44171 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Final (late) grd string changes.jhawkins@chromium.org2010-04-093-4/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1622019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44159 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Use as default" checkboxes to the autofill dialogs on the Mac.avi@chromium.org2010-04-092-3/+173
| | | | | | | | | | | Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault BUG=http://crbug.com/38263 TEST=as in bug Review URL: http://codereview.chromium.org/1527022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 20:40:26 +0000