| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These match the latest UX team recommendations.
BUG=431334
TEST=none
TBR=tengs@chromium.org
Review URL: https://codereview.chromium.org/709193002
Cr-Commit-Position: refs/heads/master@{#303357}
(cherry picked from commit b2b83f6d478e75f556a7d1ad9108bf37fa2e2a44)
Review URL: https://codereview.chromium.org/718053004
Cr-Commit-Position: refs/branch-heads/2214@{#21}
Cr-Branched-From: 03655fd3f6d72165dc3c9bd2c89807305316fe6c-refs/heads/master@{#303346}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=431907
Revert "Reject certificates that are valid for too long."
Was: https://codereview.chromium.org/20628006
We want this change in M41, not M40. Also, it has a date math bug. A new CL
to fix the bug and re-land will come soon.
BUG=119211
TBR=rsleevi@chromium.org,abarth,felt
Review URL: https://codereview.chromium.org/717653002
Cr-Commit-Position: refs/heads/master@{#303562}
(cherry picked from commit 03ef2046664b096b28ccc753d081050a3cd117d5)
Review URL: https://codereview.chromium.org/716843002
Cr-Commit-Position: refs/branch-heads/2214@{#8}
Cr-Branched-From: 03655fd3f6d72165dc3c9bd2c89807305316fe6c-refs/heads/master@{#303346}
|
|
|
|
|
|
|
|
|
| |
BUG=
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/708043003
Cr-Commit-Position: refs/heads/master@{#303337}
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=palmer@chromium.org
Review URL: https://codereview.chromium.org/703443005
Cr-Commit-Position: refs/heads/master@{#303333}
|
|
|
|
|
|
|
|
| |
BUG=406439
Review URL: https://codereview.chromium.org/706113005
Cr-Commit-Position: refs/heads/master@{#303331}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates the device disabling screen to match the final design.
The layout, assets and strings have been approved by UI.
In the final design, the device disabled screen always shows the domain
that owns the device (if known).
See the bug for screen shots.
BUG=425574
TEST=Updated unit and browser tests
Review URL: https://codereview.chromium.org/711753002
Cr-Commit-Position: refs/heads/master@{#303303}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not just Windows.
BUG=370746
TEST=With a fresh profile, download a PDF. In the Download Shelf, select
Always Open With System Viewer. Check that subsequent downloads of PDFs
launch the system PDF viewer. (On Corp Macs, that is defined to be
Chrome; change it to Preview.app.)
Review URL: https://codereview.chromium.org/665163005
Cr-Commit-Position: refs/heads/master@{#303298}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in conformance with the CA/Browser Forum Baseline Requirements for
certificate issuance.
This CL is adapted from a diff provided by sigbjorn@opera.com. Thanks!
BUG=119211
TBR=abarth
Review URL: https://codereview.chromium.org/20628006
Cr-Commit-Position: refs/heads/master@{#303286}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few other things to note:
- updates the 1x and 2x versions of
controlled_setting_mandatory.png.
- adds missing 2x versions of default_favicon_32.png and
default_favicon_64.png
- removes DELETE_ME placeholders now that the directories
are no longer empty.
BUG=423755
Review URL: https://codereview.chromium.org/706723002
Cr-Commit-Position: refs/heads/master@{#303255}
|
|
|
|
|
|
|
|
| |
BUG=421154
Review URL: https://codereview.chromium.org/708053004
Cr-Commit-Position: refs/heads/master@{#303220}
|
|
|
|
|
|
|
|
| |
BUG=421154
Review URL: https://codereview.chromium.org/704753006
Cr-Commit-Position: refs/heads/master@{#303216}
|
|
|
|
|
|
|
|
|
| |
BUG=431155
NOTRY=true
Review URL: https://codereview.chromium.org/709593003
Cr-Commit-Position: refs/heads/master@{#303211}
|
|
|
|
|
|
|
|
| |
BUG=309681
Review URL: https://codereview.chromium.org/410023002
Cr-Commit-Position: refs/heads/master@{#303185}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
proximity detection.
These strings and assets will be updated when the final versions are available.
Use temporary ones for now during development.
BUG=403419
TEST=none
R=tengs@chromium.org
Review URL: https://codereview.chromium.org/702903005
Cr-Commit-Position: refs/heads/master@{#303126}
|
|
|
|
|
|
|
|
|
|
| |
Clicking it launches the Hotword Audio Verification app.
BUG=390086
Review URL: https://codereview.chromium.org/701323002
Cr-Commit-Position: refs/heads/master@{#303121}
|
|
|
|
|
|
|
|
|
| |
R=benjhayden@chromium.org
BUG=428025
Review URL: https://codereview.chromium.org/702353002
Cr-Commit-Position: refs/heads/master@{#303090}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update notification strings;
- Split PAIRING_ADDED out of PAIRING_CHANGED which is set
for new Chromebook case (i.e. there was no cryptohome
keys);
- Show different bubble message for PAIRING_ADDED and
PAIRING_CHANGED;
BUG=408411,425828,428064
Review URL: https://codereview.chromium.org/696783002
Cr-Commit-Position: refs/heads/master@{#303060}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes password management bubble to use standard GRIT
placeholders instead of non-standard vertical bards (|) to delimit parts
of strings.
BUG=412150
Review URL: https://codereview.chromium.org/701843005
Cr-Commit-Position: refs/heads/master@{#303045}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous behaviour for "Reload" was accelerator "R" when the user clicks on the top part of tab and accelerator "L" when the user clicks on the page. Thus this was inconsistent. Now changing it to "R" everywhere is to my knowledge not causing any problems, because "Reload" and "Redo" both have accelerator "R", but they are not visible in the menu at the same time. "R" is also used for "Report an issue" and "Resume", but the same applies here.
Previous behaviour for "Print" was accelerator "R" (also sometimes "P"). Now changing it to "P" everywhere is also not going to cause problems, because "Paste" also has accelerator "P", but they are not visible in the menu at the same time. "P" is also used for "Play" and "Pause", but the same applies here.
BUG=113163
Review URL: https://codereview.chromium.org/680383005
Cr-Commit-Position: refs/heads/master@{#303000}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to work.
This setting is not yet wired up to anything.
BUG=403419
TEST=none
R=tengs@chromium.org
Review URL: https://codereview.chromium.org/696583002
Cr-Commit-Position: refs/heads/master@{#302925}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=404309
TEST=Run this test to see the message for disabling h264 and vp8:
browser_tests --gtest_filter=CastStreaming*
--disable-cast-streaming-hw-encoding --v=0
--vmodule=*chrome/renderer/*=3 --log --enable-logging=stderr
Review URL: https://codereview.chromium.org/693683002
Cr-Commit-Position: refs/heads/master@{#302918}
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed DISABLE_BASIC_PRINTING to ENABLE_BASIC_PRINTING.
Renamed ENABLE_FULL_PRINTING to ENABLE_PRINT_PREVIEW.
BUG=430281
Review URL: https://codereview.chromium.org/702603004
Cr-Commit-Position: refs/heads/master@{#302868}
|
|
|
|
|
|
|
|
|
|
| |
This matches the regular SSL interstitials.
BUG=414843
Review URL: https://codereview.chromium.org/703823002
Cr-Commit-Position: refs/heads/master@{#302856}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch improves the explanation of how the link text will replace
the placeholder in the text for password generation infobar.
BUG=412150
Review URL: https://codereview.chromium.org/704683003
Cr-Commit-Position: refs/heads/master@{#302851}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds an Android infobar that notifies that the generated
password was saved. The infobar shows up after creating a website account
with an auto-generated password. Generated passwords are disabled through
the field trial infrastructure. Pass these flags to try it out:
--enable-password-generation
--local-heuristics-only-for-password-generation
The desktop UI equivalent is a bubble. Unlike the bubble, this infobar
supports only one action: notifying that the auto-generated password is
saved.
This infobar styling is similar to translate infobar: the links are blue
and have underlines.
BUG=412150
Review URL: https://codereview.chromium.org/642813011
Cr-Commit-Position: refs/heads/master@{#302834}
|
|
|
|
|
|
|
|
|
|
|
| |
These should not be needed anymore.
BUG=NONE
TEST=None
Review URL: https://codereview.chromium.org/703803002
Cr-Commit-Position: refs/heads/master@{#302824}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Do not show generic file handler (file handlers which can take any type of file such as types:["*"]) as a default task.
- All file handlers are shown in context menu and menu of the combobottuon.
BUG=414566
TEST=out/Release/browser_tests --gtest_filter=GenericTask/FileManagerBrowserTest.Test/*
Review URL: https://codereview.chromium.org/700023002
Cr-Commit-Position: refs/heads/master@{#302777}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds an entry to about:flags to control the minimum TLS version as
requested by Darin. This will allow Android and ChromeOS users to reenable
SSLv3 in Chrome 40 if they need to.
Additionally, this gates the SSLv3 disabling with Finch. At the moment the
experiment doesn't actually exist and so will always return the empty string.
However, should we need to, we can define it and put everyone in the Enabled
group.
BUG=427671,419870
Review URL: https://codereview.chromium.org/693963003
Cr-Commit-Position: refs/heads/master@{#302754}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small binary that runs Chrome with the given command-line
arguments. It is intended for use with Chrome apps, so that file types
can be associated with the shim, having a custom name (and in some
cases, icon) rather than simply the name of the Chrome binary.
BUG=130455
Review URL: https://codereview.chromium.org/179223003
Cr-Commit-Position: refs/heads/master@{#302749}
|
|
|
|
|
|
|
|
| |
BUG=414843
Review URL: https://codereview.chromium.org/704623002
Cr-Commit-Position: refs/heads/master@{#302724}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the plumbing for the flag to disable the ignoring of
autocomplet='off' for password fields. This plumbing was always intended
to be temporary in case something disastrous happened and we needed to
re-enable autocomplete='off' via Finch. The time we set for this has
past, so this CL makes this a permanent change.
BUG=346708
Review URL: https://codereview.chromium.org/697233002
Cr-Commit-Position: refs/heads/master@{#302707}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS, we can't link directly to the date and time settings, so we hide the primary button and add an extra description to the main paragraph instructing them how to do so.
For all platforms, we completely hide the 'Advanced' button on the SSL clock interstitial. (It was replaced with 'Reload' in previous iterations.)
Hide Reload button for all clock errors.
BUG=414843
Review URL: https://codereview.chromium.org/693093003
Cr-Commit-Position: refs/heads/master@{#302664}
|
|
|
|
|
|
|
|
|
|
|
| |
By this support, My Maps maps shown in Drive folder have correct icon, file-type description, and file extension.
BUG=397029
TEST=Manually create a form in drive.google.com and see it appears with an icon in Files.app.
Review URL: https://codereview.chromium.org/693843002
Cr-Commit-Position: refs/heads/master@{#302593}
|
|
|
|
|
|
|
|
|
|
|
| |
...to match the one in the user manager (https://codereview.chromium.org/698433003/).
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/688323004
Cr-Commit-Position: refs/heads/master@{#302592}
|
|
|
|
|
|
|
|
|
|
|
| |
The reauth is needed to acquire the user's password to add a new cryptohome
key for sign-in.
BUG=409427
Review URL: https://codereview.chromium.org/668213003
Cr-Commit-Position: refs/heads/master@{#302541}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=asargent
Review URL: https://codereview.chromium.org/697903002
Cr-Commit-Position: refs/heads/master@{#302528}
|
|
|
|
|
|
|
|
| |
BUG=429393
Review URL: https://codereview.chromium.org/692303002
Cr-Commit-Position: refs/heads/master@{#302497}
|
|
|
|
|
|
|
|
|
|
|
| |
Similar UI has already been added to mobile platforms. Functionality is hidden behind a flag until the passwords website launches.
BUG=426508
R=estade@chromium.org, isherman@chromium.org, mkwst@chromium.org, nyquist@chromium.org
Review URL: https://codereview.chromium.org/682133003
Cr-Commit-Position: refs/heads/master@{#302486}
|
|
|
|
|
|
|
|
|
|
| |
Updates to address formats and sub-region names.
BUG=NONE
Review URL: https://codereview.chromium.org/687213004
Cr-Commit-Position: refs/heads/master@{#302465}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax of Privacy preferences within Advanced section follows the format at:
https://support.google.com/chrome/answer/2392969
https://support.google.com/chrome/answer/2392971
https://support.google.com/chrome/answer/2392709
Note that this UI text is used by src/chrome/common/localized_error.cc.
However, native code does not have access to internal Android strings like
IDS_PREFERENCES, IDS_PREFS_SECTION_ADVANCED, IDS_PREFS_PRIVACY,
IDS_NETWORK_PREDICTIONS_TITLE. Therefore unfortunately these strings must be
hardcoded.
TBR=cpu
BUG=422314
Review URL: https://codereview.chromium.org/650903004
Cr-Commit-Position: refs/heads/master@{#302463}
|
|
|
|
|
|
|
|
|
|
| |
user's profile.
BUG=427580
Review URL: https://codereview.chromium.org/688593003
Cr-Commit-Position: refs/heads/master@{#302447}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added alt-text and focusability to the revoke buttons in the App Info
dialog so they can be navigated to with the keyboard. This allows
permissions to be revoked for apps for users who are navigating with a
screen reader or only using the keyboard.
BUG=425311
Review URL: https://codereview.chromium.org/689863002
Cr-Commit-Position: refs/heads/master@{#302405}
|
|
|
|
|
|
|
|
| |
BUG=421291
Review URL: https://codereview.chromium.org/692523004
Cr-Commit-Position: refs/heads/master@{#302377}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL https://codereview.chromium.org/633373010 added some output files
but did not update the expected output files in the corresponding GN
files.
BUG=429299
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/694853003
Cr-Commit-Position: refs/heads/master@{#302334}
|
|
|
|
|
|
|
|
|
| |
BUG=419870,427671
R=davidben@chromium.org, felt@chromium.org, rsleevi@chromium.org
Review URL: https://codereview.chromium.org/649413004
Cr-Commit-Position: refs/heads/master@{#302315}
|
|
|
|
|
|
|
|
|
|
|
| |
Also, draw the white circle background in css (instead of having it baked into the icons).
As a side-effect, this allows us to have multiple badges on the same profile.
BUG=427435
Review URL: https://codereview.chromium.org/698433003
Cr-Commit-Position: refs/heads/master@{#302302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function (documented as SetProcessDpiAwareness but exported as
SetProcessDpiAwarenessInternal) has a return type of HRESULT but we
declared it as returning BOOL. This triggered the following /analyze
warning:
src\chrome\app\chrome_exe_main_win.cc(104) : warning C6216:
Compiler-inserted cast between semantically different integral
types: a Boolean type to HRESULT.
BUG=427616
Review URL: https://codereview.chromium.org/691903002
Cr-Commit-Position: refs/heads/master@{#302212}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add a protobuf for WiFi credentials
- add a ModelType for syncing WiFi credentials
- add UI for controlling whether or not WiFi credentials are synced
- add new data type to testserver
While there:
- update comment in sync_setup_overlay.js
- fix ordering of arguments to EXPECT_EQ in CheckBool
(sync_setup_handler_unittest)
- move GetSelectableTypeNameMap from sync_setup_handler.cc to model_type.cc
BUG=chromium:422045
TEST=ProfileSync, SyncSetup, SyncModel, ModelType, NigoriUtil,
ProtoEnumConversions, ProtoValueConversions,
SyncEncryptionHandlerImpl
Review URL: https://codereview.chromium.org/674633002
Cr-Commit-Position: refs/heads/master@{#302159}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network.
Previously if drive sync over cellular network is disabled, pinning a drive file
is pending without notificaiton.
This CL lets Files.app show the notifiction.
BUG=279476
TEST=DriveSpecific/FileManagerBrowserTest.Test/4
Review URL: https://codereview.chromium.org/676653002
Cr-Commit-Position: refs/heads/master@{#302063}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a flag to disable the new zip unpacker. Note, that this flag
is not used yet.
TEST=unit_tests: *AboutFlagsHistogramTest*
BUG=427775
Review URL: https://codereview.chromium.org/683413002
Cr-Commit-Position: refs/heads/master@{#301998}
|