| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
derive from it.
No functionality change.
This will be used to share the content settings exceptions dialog code between geolocation and notifications.
BUG=45547
Review URL: http://codereview.chromium.org/2838037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.
BUG=44574
TEST=none
Review URL: http://codereview.chromium.org/2805055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains SETTINGS:
Made certificate_path_ a string instead of a FilePath.
Modify ConnectToWifiNetwork to take std::string.
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/2869019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding: http://codereview.chromium.org/2860037 The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2854032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make the rendering for multiple buttons pretty by unifying sequnces of
buttons.
- Add the zoom label control and make the wrench menu model listen for
notifications about zoom percentage changing.
- Fixes crash that would have gone away once this was taken out from behind a flag
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2799043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support for language detection on the server side.
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
Original review:
http://codereview.chromium.org/2859013/show
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2860037
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2873035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
Original review:
http://codereview.chromium.org/2859013/show
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2860037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renegotiation extension was introduced into TLS in [1], to address
the attack described in [2]. In order to fully protect ourselves,
clients need to require support from servers. However, these things
take a long time to roll out.
As an initial measure, we start to require the extension from a
whitelist of servers that we known to support the extension. We are
then protected from prefix attacks against these servers. Over time,
if the list grows we might want to share it with Mozilla, but we'll
start simple.
[1] http://tools.ietf.org/html/rfc5746
[2] http://www.educatedguesswork.org/2009/11/understanding_the_tls_renegoti.html
http://codereview.chromium.org/2045006/show
TEST=Setup a dummy TLS server without renegotiation extension support (Hardy) will do and force mail.google.com to it using /etc/hosts. Navigate to https://mail.google.com and check for ERR_SSL_UNSAFE_NEGOTIATION.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Correct descriptions in ADM/ADMX template and change registry key to "Chrome" from "Google Chrome".
Fix numerous punctuation, verbiage and wording issues.
Fix HomepageIsNewTabPage so that not checking the checkbox actually forces the hompage to the homepage URL.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2806040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show update link for out-of-date ones.
Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2835018
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/2805048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2862037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding extra buttons on the translate infobar to let user easily set the "never/always translate this language" property when they declined/accepted translation for a language more than 3 times.
Original review:
http://codereview.chromium.org/2825015/show
BUG=NONE
TEST=Visit a page in a foreign language, translate the page. Repeat 4 times. On the fourth time, the "before translate" infobar should show a button that says "always translate".
Similarly when declining translations 4 times.
Review URL: http://codereview.chromium.org/2835025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping.
Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more.
BUG=44574
TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP.
Review URL: http://codereview.chromium.org/2806041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are bad.
BUG=44797
TEST=make sure control-alt-b doesn't work.
Review URL: http://codereview.chromium.org/2885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/323
TEST=none
Review URL: http://codereview.chromium.org/2870033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2835018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34627
TEST=none
Review URL: http://codereview.chromium.org/2803026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a link to http://www.google.com/support/chrome/bin/answer.py?answer=142893 on the AutoFill settings dialog.
Nib changes: Adds button with link cell connected to |openHelp:| action.
BUG=42780
TEST=manual, open dialog and click help button.
Review URL: http://codereview.chromium.org/2825027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.
Move some l10n stuff to l10n_util and use that, too.
Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())
BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.
Review URL: http://codereview.chromium.org/2822026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionInstallUI.
Also, fix a bug where a change to the geolocation permission
wasn't triggering the privilege increase path and refactor
code to try and reduce the chance of that kind of bug in the
future.
BUG=45715
Review URL: http://codereview.chromium.org/2846034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
Review URL: http://codereview.chromium.org/2800015
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(already works on mac).
BUG=44797
TEST=make sure control-alt-b shows the bookmark manager.
Review URL: http://codereview.chromium.org/2867027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move some string literals into chrome/common/chrome_switches.
There are still many uses in places that cannot depend on chrome/common.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2824008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47422
TEST=none
Review URL: http://codereview.chromium.org/2852025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2821010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+/-/Fullscreen menu items.
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2836029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsequent changes will:
* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.
Suggested review order:
- test files
- url_pattern*
- extension_extent*
- extension*
- everything else
BUG=46633
Review URL: http://codereview.chromium.org/2876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences.
BUG=44480
TEST=none
Review URL: http://codereview.chromium.org/2811025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the UI to reflect the latest mocks. Also improve the animation onto the screen.
BUG=34627
TEST=none
Review URL: http://codereview.chromium.org/2822019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Re-compresses all the image data, average savings 1%-4% in filesize.
- Removes the "Created with Adobe Whatever" string from all PNGs, shrinking
the files marginally even when the image data was already optimal.
This shaves more than 100k off of chrome.pak.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds an image to the top of the dialog, and removes the text and link at the bottom. It also removes the horizontal separators.
BUG=46716
TEST=Run Chrome in first-run with master_preferences set to load the new search engine dialog. It should look reasonable.
Review URL: http://codereview.chromium.org/2818014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47385
TEST=none
Review URL: http://codereview.chromium.org/2823029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2861021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than scattering init calls through the code, just inititialize
it once. (In particular, the gnome-keyring support also needs this
function called, and I didn't want to copy it one more time.)
TEST=no threading-related crash during gnome-keyring startup
Review URL: http://codereview.chromium.org/2873015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController.
Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views.
BUG=44773
TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths.
Review URL: http://codereview.chromium.org/2846028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
via download from gallery
original review here: http://codereview.chromium.org/2855009
BUG=45542
TEST=NONE
TBR=aa
Review URL: http://codereview.chromium.org/2872013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1830
TEST=ClockMenuButtonBrowserTest, manual
Review URL: http://codereview.chromium.org/2851020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error (C2712) is caused by using __try in function
that requires object unwinding. To fix this, move the
code that requires SEH to another function.
R=cpu
CC=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2841022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
right wrench menu in Toolbar.xib.
TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2813025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/45334
TEST=none yet
Review URL: http://codereview.chromium.org/2838011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Make a GRD change, dcommit, be prompted about having a GRD change.
Review URL: http://codereview.chromium.org/2813024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mock died on the vine. Toolbar is now indented along with the rest of the window content.
BUG=44773
TEST=hidden behind flag, nothing to test.
Review URL: http://codereview.chromium.org/2824021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The IDS_IMPORT_SETTINGS string was only being used on the Mac. Moved into a Mac only section and renamed.
BUG=41773
TEST=Title of meu item in Chrome menu should be "Import Bookmarks and Settings..."
Review URL: http://codereview.chromium.org/2874003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50448 0039d316-1c4b-4281-b951-d872f2087c98
|