| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be replaced with 'and' in the target language unless it's good to use '&' to mean 'and' in the language.
BUG=24705
TEST=NONE
Review URL: http://codereview.chromium.org/307008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
see the bug details.
This gets us most of the way there. We have made minor
course corrections since the mocks were introduced (no
date will be shown, no "Get more extensions" link is
visible and the name is not linked).
Known issues:
The only thing missing is the fact that we show a default
plugin icon for each extension (as opposed to the icon for
the extension).
BUG=12119
TEST=Open chrome://extensions and all the buttons and
links should work (Developer Tools, Enable, Disable,
Reload, Uninstall, Load, Pack, Update, etc).
Review URL: http://codereview.chromium.org/293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this.
BUG=25272
TEST=none
Review URL: http://codereview.chromium.org/300010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=the bookmark bubble menu should have title case items for the two.
BUG=24912
Review URL: http://codereview.chromium.org/297004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- So respawning the browser is more reliable.
BUG=25091
TEST=see bug
Review URL: http://codereview.chromium.org/283024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/273063 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TitleCase the other folder menu options.
Use the helper that handles ellipsis.
TEST=the other folder option is title case
BUG=24912
Review URL: http://codereview.chromium.org/276065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24916
TEST=per bug.
Review URL: http://codereview.chromium.org/285004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=can type in the homepage box
BUG=24740
Review URL: http://codereview.chromium.org/289002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/264074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23136,24858,21596
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/270081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24876
TEST=none
Review URL: http://codereview.chromium.org/267113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process. SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for.
SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/276009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
context menu. Fix a typo in the grd file for adding a bookmark.
BUG=24363
TEST=bookmark all tabs, edit dialog still dims OK when url is invalid for bookmarks that aren't folders.
Review URL: http://codereview.chromium.org/269080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an |BREAKPAD_DUMP_LOCATION| environmental variable to allow overriding the default location
for minidump generation.
This is for ChromeBot who need a single copy of the Chrome bundle which can be run several times
alternating the location of crash dumps.
This isn't implemented as a command line flag because only some command line flags are passed to child processes and we need a robust solution.
TEST=Minidumps should still be written for browser and renderer crashes.
Review URL: http://codereview.chromium.org/264038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser actions).
Test failure was a fluke. I forgot that changing
resources always makes the first bot run fail.
TBR=mpcomplete@chromium.org
BUG=24379,24671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
browser actions).
TBR=mpcomplete@chromium.org
BUG=24379,24671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, allow browser actions with no initial icons, and add
some better tests.
BUG=24379,24671
Review URL: http://codereview.chromium.org/276010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stuff when the default theme is already set.
This change is for the Mac OS; Windows change in a separate patch.
BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat.
Review URL: http://codereview.chromium.org/278004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, the first time the singleton is touched we've already started
loading a page! We surely have a bunch of threads going at that point.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27528
Review URL: http://codereview.chromium.org/245039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The icon is a placeholder until Glen makes a pretty one.
BUG=24047
TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html
allow, deny, closing infobar, and closing tab all work as expected
Review URL: http://codereview.chromium.org/275011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
never belonged in chromium_strings.grd because it's not branding-dependent.
Placing it in chromium_strings.grd but not google_chrome_strings.grd caused
the two strings files to become out of sync, which is actually really really
bad.
BUG=24776
TEST=Application name shown in Mac menu bar should be Chrome, not
Google Chrome Helper or anything else
Review URL: http://codereview.chromium.org/277004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make the scroller the width of the window.
- Resize the content so any wrapping text fields have the full width.
- Tweak the scroller so only bot bottom border shows.
BUG=20538
TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar.
Review URL: http://codereview.chromium.org/276019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of unbreaking auto-update.
BUG=14610
TEST= - The following bundles should be gone:
- Chromium.app/Contents/Frameworks/Chromium Framework.framework
- Chromium.app/Contents/Resources/Chromium Helper.app
They should be replaced by:
- Chromium.app/Contents/Versions/*/Chromium Framework.framework
- Chromium.app/Contents/Versions/*/Chromium Helper.app
- The application should continue to function properly and all tests
should still pass.
- The signed application should have the inner framework and helper
application signed, and the outer application signed. The outer seal
should permit unknown versions to be present in the Versions directory,
but should protect the active versioned directory.
- Auto-updating to an official build with this change should still work.
Review URL: http://codereview.chromium.org/261031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28875
Review URL: http://codereview.chromium.org/267043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/266067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().
TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none
Review URL: http://codereview.chromium.org/261055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/261029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We can just call this from the appropriate constructor internally.
Review URL: http://codereview.chromium.org/271051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hood prefs.
BUG=24424
TEST=under the hood has a working learn more button in the privacy section.
Review URL: http://codereview.chromium.org/268028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194108
Review URL: http://codereview.chromium.org/271052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23105
TEST=none
Review URL: http://codereview.chromium.org/261026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
depended on this, so to make the DEPS work out, I made a new base/test
directory where I moved the testing-related files into a new directory
base/test.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/266038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- XIB change: The controller has a connection to buttonView_.
- BrowserThemeProviderMac: Fix a bug where we weren't returning
default colors; we returned nil instead.
- The majority of the implementation is actually the cross platform
NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform
specific drawing on top of the background, though.
TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage
TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage
BUG=http://crbug.com/17625
Review URL: http://codereview.chromium.org/266027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= None
TEST= chrome.exe --lang=sw and chrome.exe --lang=am
Review URL: http://codereview.chromium.org/272006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add some new strings that didn't exit to the grd file needed by Mac prefs.
Update all the strings in the file to use the localizer.
BUG=20538
TEST=Almost all the pref strings should be localized, there area few new ones that won't show up localized until we do a TC run. The controls do *NOT* auto size yet, so there can be clipping/oversized controls.
Review URL: http://codereview.chromium.org/273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
simply opened the project and let it sync back up to avoid lots of warnings about unknown outlets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything.
* Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious.
BUG=2935
TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs
Review URL: http://codereview.chromium.org/266029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifically, units proportional to the fonts used inside of it.
We approximate the font chosen by the wizard's CSS. In actuality, the
CSS chooses a font-face "arial", "sans-serif". We just use the default
sans serif font; arial is the default value for that property.
This fixes an issue where changing to the "Windows Classic" theme
on Vista would cause the dialog to be resized, clipping its
contents, which are unaffected by the UI font size.
Update the default GRIT sizes to closely match the old ones.
Old vs new:
http://www.corp.google.com/~ncarter/wizard-size-screenshots.png
BUG=21828
TEST=verified old size against new size in Aero Theme with default
settings; verified size stays the same under Classic theme.
Review URL: http://codereview.chromium.org/261017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
HungRendererDialog.xib: made the "Wait" button's use Return as its normal key
equivalent; changed the "Wait" button's class to MultiKeyEquivalentButton.
BUG=21074
TEST=about:hang. Return, Enter, Esc, and Command-. (period) should all dismiss
the Hung Renderer dialog with "Wait".
Review URL: http://codereview.chromium.org/266026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for each open tab. I've currently wired this up on windows, will wire
up rest of platforms in a separate cl.
BUG=2935
TEST=on Windows open multiple tabs, right click on a tab and choose
'Bookmark all tabs'. You should then get the bookmark editor with no
url field. Accepting the dialog should result in creating a new folder
with a bookmark for each of the open tabs.
Review URL: http://codereview.chromium.org/270021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since about:memory DCHECK()s atm, the link is not completely hooked up.
In the xib, I've added a square button with height 14 and the new HyperlinkCell, contained in a GTMWidthBasedResizer or how it's called. I made sure the baseline of link on the left and button on the right is at the same height.
BUG=17989,13156
TEST=Open MainMenu.xib, click "Enable" for view->dev->taskman. Build&run chrome. Task manager should contain link.
Review URL: http://codereview.chromium.org/255018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/268019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/267024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the alert icon from the download item dangerous download xib.
- Remove the download fav icon from the download shelf xib.
- Update the download shelf to fetch the image from the pak.
- Update the download item to fetch the alert image from the pak.
- Update the bookmark bar to fetch the folder icon from the xib and cache it.
- Remove the three images from the bundles.
BUG=20230
TEST=all three still show their images
Review URL: http://codereview.chromium.org/260012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28392 0039d316-1c4b-4281-b951-d872f2087c98
|