| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4727
TEST=None
Review URL: http://codereview.chromium.org/2858061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Navigate to https://encrypted.google.com. Click the green padlock in the URL bar. Click "Certificate Information". Verify that a SHA-256 hash appears.
http://codereview.chromium.org/3005016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/2861070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49354
TEST=visual
Review URL: http://codereview.chromium.org/2834057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3005021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49541
TEST=manual
Review URL: http://codereview.chromium.org/2884028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adjust the width and the height of the dialog to work both with
Windows Classic and Windows Vista theme.
2. Make the width of list box in the dialog localizable
and adjust them per locale if necessary.
Original Review: http://codereview.chromium.org/2974009/show
BUG=48202
TEST=Go to Options | Under the Hood | Content Settings in locales listed in the bug and make sure that there's no truncation and all the UI elements can be
selected/visible/clickable both on XP (or Windows Classic them on Vista)
and Vista.
Review URL: http://codereview.chromium.org/2836061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3011013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still no logic implemented, but it's nice to have something looking pretty. :)
The current screenshot can be found at:
http://chromium-os.googlecode.com/issues/attachment?aid=6893314955718114103&name=domui.png&token=09541fa12341c817ca5b2ecff2e5d463&inline=1
BUG=chromium-os:4573
TEST=manually
Review URL: http://codereview.chromium.org/2836052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac side of http://codereview.chromium.org/2808053 .
Looks like this: http://imgur.com/leY4C.png
To provide user feedback, after an exception has been added, the exceptions window is shown.
XIB changes:
Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner.
Review URL: http://codereview.chromium.org/2884024
Patch from Bernhard Bauer <bauerb@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should check whether breakpad is initialized before
setting custom entries.
BUG=49368
TEST=Chrome.exe --disable-breakpad
Review URL: http://codereview.chromium.org/3010013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2805090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the AutoFill dialog on Mac to support multi-select and delete of items
in the address and credit card table. The "Edit..." button disables when multiple
items are selected.
Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds
the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet.
BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple.
Review URL: http://codereview.chromium.org/3039014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed OpenTanMode (confirmed with cole)
Removed ToolbarView::SetAppMenuModel
BUG=49229
TEST=none.
Review URL: http://codereview.chromium.org/2832058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it in the Omnibox.
This refactors the animation code of the DownloadStartedAnimationMac into AnimatableImage.
BUG=49341
TEST=Go to http://www.popuptest.com/popuptest3.html. When a popup is opened, see animation.
TEST=Download a file. Animation still plays.
Review URL: http://codereview.chromium.org/3014005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Swap the +/- zoom buttons so that minus is first.
* Invert the fullscreen arrows when in fullscreen mode.
BUG=49449
TEST=Visual
TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen.
Review URL: http://codereview.chromium.org/3008010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) We were using the wrong pid for the browser pid
b) We weren't initializing the StatsTable after running the zygote.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3051003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=checkperms.py is happy.
Review URL: http://codereview.chromium.org/3042006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/2808053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
kApplicationLocale preference.
bug=44504
test=none
Review URL: http://codereview.chromium.org/2809058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Manager
The main reason for this change is that both "Native Client" and "sandbox" are difficult to translate, so we won't translate "Native Client" and will replace "sandbox" with "security".
Review URL: http://codereview.chromium.org/3043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=49013
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2883026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the grd part of http://codereview.chromium.org/3001003/show
BUG=46028
TEST=None
Review URL: http://codereview.chromium.org/2832060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes to restart_browser.mm also affect the sheet displayed in the About
window. Note that the badge on the wrench menu looks bad.
BUG=45147
TEST=difficult
Review URL: http://codereview.chromium.org/2856042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35316
TEST=Disable plugins, go to a site with a flash animation. You should see a placeholder for the flash animation. When you click on it, the animation should load.
Review URL: http://codereview.chromium.org/2862031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38737
TEST=none
Review URL: http://codereview.chromium.org/3034004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page is in a different language than the one Chrome detected.
If that language is not in the list of languages that Chrome supports for translation, then we do not know what to show and we were crashing.
This CL makes it so that we show an error infobar instead.
Note that in the future we should improve the "after translate" infobar to support showing the original language as unknown. (http://crbug.com/9390)
BUG=48918
TEST=Not sure how to test without changing the code.
Review URL: http://codereview.chromium.org/3011008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27507
TEST=Navigate to https://encrypted.google.com and click the green padlock. Verify that the details presented are reasonable.
http://codereview.chromium.org/3033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries.
BUG=47120,46634,46635,47435,48881,47430
TEST=in the mocks: http://folder/roma/design/chrome/autofill/ and unit tested.
Review URL: http://codereview.chromium.org/2801020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6574
TEST=None
Review URL: http://codereview.chromium.org/2850031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tony
Review URL: http://codereview.chromium.org/3018007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
differences in other fields to distinguish entries.
Also added it to generated previews.
TODO: adjust indices in the Credit Cards.
TEST=unit tested.
BUG=none
Review URL: http://codereview.chromium.org/2835026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3035005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
title to 'Select'
and show the 'New Folder' button.
BUG=none
TEST=From preferences select a new download folder, verify button title and new folder button.
Review URL: http://codereview.chromium.org/3028002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3039006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o 4px between wrench menu and location bar/edge of window.
o 4px between reload button and location bar.
o Adjust size of wrench menu to be the same size as every other button.
o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action.
BUG=46738,48678
TEST=visual
Review URL: http://codereview.chromium.org/3027005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48997
TEST=Google Chrome gets valid crash reports for about:crash most of the time.
Review URL: http://codereview.chromium.org/2961008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/45334
TEST=build chromium, open the package, look in the resources folder, see either "org.chromium.Chromium.manifest" or "com.google.Chrome.manifest" (depending on the build). Open the file, see either "Chromium" or "Google Chrome" at the top (again, depending on the build).
Review URL: http://codereview.chromium.org/2809057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the labels data entry fields on the AutoFill preferences dialog on Mac. Labels
are now derived fields so user input is not needed.
Nib changes made are AutoFillAddressSheet.xib: removed "Label" entry and status indicator, adjusted
layout to account for new space. AutoFillCreditCardSheet.xib: removed "Label" entry and status
indicator, adjusted layout to account for new space. AutoFillDialog.xib: removed the table header,
removed the "Label" column, adjusted sizing of remaining "Summary" column to account for new space,
move the buttons lower to top-align with table.
BUG=47430
TEST=AutoFillAddressModelTest.*, AutoFillCreditCardModelTest.*, AutoFillDialogText.*
Review URL: http://codereview.chromium.org/2813052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2834050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49328
TEST=none
Review URL: http://codereview.chromium.org/3013008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CompactNavigationBar
this feature has been discontinued
* BrowserStatusAreaView
status area used to have a menu, but it's gone and this
class no longer needed.
* BrowserExtender
used to implement chromeos specific feature,
which has been replaced by chromeos/browser_view
BUG=49229
TEST=no functional chagne. all test should pass.
Review URL: http://codereview.chromium.org/3035004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adding a menu to the translate infobar that let users report when the language of a page has been incorrectly detected.
BUG=48739
TEST=Visit a page in a language that triggers the translate infobar. Select the menu to report an error. A new tab should be opened that references the page and language and let you report the error.
Review URL: http://codereview.chromium.org/2911005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a "Accounts" subpage for ChromeOS;
- Two checkboxes for allowing BWSI and allowing guest signin;
- Make measureItem in list.js returns 0 instead of -1. The itemHeight is -1
when the list is not visible. And 0 will let redraw to call measureItem
again;
- Add an onVisibilityChanged callback that is called when "visible" property
is changed; And use that to trigger user list's redraw;
- Use a mock settings object so that the UI flow could be tested;
- Update options_page.css to add a few css missed from dhg's overlay cl;
BUG=chromium-os:4734
TEST=None. This is a draft version and will be changed after UX feedbacks.
Review URL: http://codereview.chromium.org/2935011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44574
TEST=Visual
Review URL: http://codereview.chromium.org/3034002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/3034007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
|