| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
few annoying cases where someone has been monitoring Chrome under windbg,
which can skip over __debugbreak() and then show them a scary-looking
access violation.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6372008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56415,43716
TEST=Verify language & settings panel functionality on dom-ui settings window.
Review URL: http://codereview.chromium.org/6296017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
button.
BUG=69145
TEST=none
Review URL: http://codereview.chromium.org/6241010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
diagnostic messages are sent if the print system fails to initialize (this can happen on Windows if the XPS Framework is not installed on XP) as well when printer registration fails because we could not get the capabilities for the printer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6245005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiled and viewed under linux.
Review URL: http://codereview.chromium.org/6222004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58975
TEST=none
Review URL: http://codereview.chromium.org/6268005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in r42655 (http://codereview.chromium.org/1144001 ).
The corresponding grd file does not refer to this file. So, removing this file
is purely a tree clean-up.
BUG=38001
TEST=NONE (build just fine).
TBR=tony
Review URL: http://codereview.chromium.org/6323008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
link on the encryption tab and reduced the amount of text slightly. Made the dialog slightly taller so that everything fits more comfortably without the risk of overlapping elements.
BUG=69624
TEST=none
Review URL: http://codereview.chromium.org/6291008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63842
TEST=none
Review URL: http://codereview.chromium.org/6325011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Delete strings from .grd files that are at least 6 months old and aren't used anywhere.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6293012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default value is true.
* Add --disable-interactive-form-validation flag and about:flags interface
The interactive form validation feature might cause web site
compatibility issues. So we provide a way to disable it just in case.
BUG=45804,54368
TEST=manual; Open the URL "data:text/html,<form><input required></form>", click
the input field, and press ENTER key.
- A validation message is shown by default
- If you run Chrome with --disable-interactive-form-validation, no validation
message is shown and the form is submitted.
- If you enable "Disable HTML5 interacrive form validation" flag on
about:flags, no validation message is shown and the form is submitted.
Review URL: http://codereview.chromium.org/6329005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Delete strings from .grd files that are at least 6 months old and aren't used anywhere.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6260013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64877
TEST=Existing unittests; manual testing.
Review URL: http://codereview.chromium.org/6310012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To make sure that all policy definitions match the expected format. The checker is called as a presubmit hook, and can also be invoked manually. Run it without any parameters (or with --help) to get usage information.
BUG=69527
TEST=manual: checker reports no errors for correct policy definitions, checker complains for malformed policy definitions, checker is invoked as presubmit hook when policy_templates.json has been changed
Review URL: http://codereview.chromium.org/6299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the Regkey helper to consistently use and return LONG
instead of bool. Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.
Reviewers:
brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/6090006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6310011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
module", as appropriate.
BUG=42073
TEST=manual,trybotss
Review URL: http://codereview.chromium.org/6303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until UI team creates production image.
BUG=chromium-os:10711
TEST=checked to make sure the old killtab image isn't shown.
Review URL: http://codereview.chromium.org/6334006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=mnissler
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64877
TEST=Existing unittests; manual testing.
Review URL: http://codereview.chromium.org/6079012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For ChromeOS: when starting session: if locale was changed (as a result of sync or because user preference differs from login locale): show notification.
BUG=chromium-os:9164
TEST=Manual
Review URL: http://codereview.chromium.org/6249009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The former members of the dict are now included directly in the policy definitions.
BUG=64898
TEST=existing unit tests in tools/grit/grit/format/policy_templates/
Review URL: http://codereview.chromium.org/6360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
malware details to Google.
BUG=60831
TEST=relevant unit_tests,browser_tests, go to ianfette.org.
Review URL: http://codereview.chromium.org/6268001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux.
This change ensures that the appropriate command line flag (SetCrashReporterCommandLine())
is set for the NaCl process and read by the NaCl main process when it starts.
TEST=
0. Ensure that Native Client is DEPS'ed in at revision 4097 or higher
1. From src/ issue
./build/gyp_chromim -f make -dlinux_breakpad=1
2. Build Chromium (debug build)
3. With env. variable CHROME_HEADLESS=1 and NACL_CRASH_TEST=1 run
out/Debug/chrome --enable-nacl --enable-crash-reporter
4. Visit a page that attempts to load a NaCl module, e.g.,
http://naclports.googlecode.com/svn/trunk/src/gallery/index.html
5. Observe that a .dmp file is created in ~/.config/chromium/Crash\ Reports/
BUG= http://code.google.com/p/nativeclient/issues/detail?id=206
Review URL: http://codereview.chromium.org/6193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/6260003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy.
BUG=65107,63667
TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated
Review URL: http://codereview.chromium.org/5742008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new concept is the following: policy_templates.json contains all the data necessary to generate templates: policy names, English captions, descriptions, etc. This gets translated the following GRIT gatherer: policy_json.py. The text of the translated JSON file is then picked up, parsed, and passed to the writers by template_formatter.py.
BUG=64898
TEST=PolicyJsonUnittest.*
Review URL: http://codereview.chromium.org/6134006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67218
TEST=Remoting status is shown on the advanced options page.
Review URL: http://codereview.chromium.org/6214003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62103
TEST=none
Review URL: http://codereview.chromium.org/6309002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
killed instead of crashing.
It also adds "about:kill" to simulate kills.
On ChromeOS killed tabs will be reloaded as soon as the user clicks on them unless they are the only tab, or the currently focused tab is killed.
BUG=http://crosbug.com/10043, http://crosbug.com/10711
TEST=Built linux and ChromeOS Chrome and killed a tab, and then did about:crash and made sure that the "Aw, Snap!" page was displayed. Did about:kill and made sure kill page was displayed.
Review URL: http://codereview.chromium.org/6053012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't alter the envionment once we have gone multithreaded because
glibc's getenv doesn't take the environment lock. Thus we add an
EarlyNSSInit() function which can do so, early in startup.
BUG=66835
TEST=ThreadSanitizer
http://codereview.chromium.org/6185005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run chrome, install app with background page, see new art on wrench menu
Review URL: http://codereview.chromium.org/6252002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if locale was changed (as a result of sync or because user preference differs from login locale): show notification.
BUG=chromium-os:9164
TEST=Manual
Review URL: http://codereview.chromium.org/5976005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix bug 69054 (reg_writer erroneously outputs integers as decimal values).
BUG=68843, 69054
TEST=tools/grit/grit/format/policy_templates/*_unittest.py
Review URL: http://codereview.chromium.org/6176005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add support for 'deprecated' attribute in template generator
- Add support for both int- and string- based enums in the template generator
- Add logic to handle ProxyMode and fall back to ProxyServerMode
BUG=68134
TEST=ConfigurationPolicyPrefStore*, new policy template generator tests
Review URL: http://codereview.chromium.org/5958014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dialog is checked.
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/6122008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was based off of davidben's WIP cl http://codereview.chromium.org/3186021/show.
BUG=42073
TEST=add password to NSS DB with "certutil -d sql:.pki/nssdb -W", try client auth, <keygen>, cert manager
Review URL: http://codereview.chromium.org/5686002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Proper error message when directory rejects request - this requires changes in gaia_login.html to support custom error messages.
2. Fixed login OTP-enabled account.
BUG=67218
TEST=None
Review URL: http://codereview.chromium.org/6178012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31535
TEST=updated JSON serialization tests, added check in browsertest, manual test using task manager to terminate an extension process
Review URL: http://codereview.chromium.org/6158001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make the thumbnails left-aligned. The reason for this is that when thumbnails are closed, the reshuffling algorithm looks a bit busy. We want to eventually slide thumbs out on the left side on the window and then slide them back in from the right.
BUG=50307
TEST=
* Hover a thumb. It should show a close button.
* Press opt. All thumbs should show a close button.
* Press a close button. Thumb should close, the rest of the tabs should reshuffle.
Review URL: http://codereview.chromium.org/5960008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
can send that patch to the tryservers.
TBR=viettrungluu
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64870 64922
TEST=none
Review URL: http://codereview.chromium.org/6174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reading of 3rd party cookies
BUG=69066
TEST=net_unittests
Review URL: http://codereview.chromium.org/6207005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed console spam while I'm here.
BUG=63842
TEST=none
Review URL: http://codereview.chromium.org/6155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validation feedback still needs polish, but this is completely functional, so I'll leave that for a follow-up.
This introduces a new shared class for editable lists; we should migrate the existing editable lists to it, expanding as necessary, but I didn't want to make this patch too unwieldly.
BUG=63825,61742
TEST=Search engines should be editable and addable inline in DOMUI prefs.
Review URL: http://codereview.chromium.org/6151004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change hide message from 'Hide this message' to 'No thanks, hide this'.
2. Hide promo text when a default app is launched (this was already happening on uninstall).
3. Uninstall default apps when promo expires or is purposefully hidden.
4. Collapse apps section when promo expires or is purposefully hidden.
BUG=67292,69268
TEST=none
Review URL: http://codereview.chromium.org/6162006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It should now match the mocks modulo the adobe flash settings link (not sure why the mocks show it as a checkbox; AFAIK making it a checkbox is outside our ability to do).
also make it work (the time period select dropdown was broken).
BUG=69163,63843
TEST=manual
Review URL: http://codereview.chromium.org/6110006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71090 0039d316-1c4b-4281-b951-d872f2087c98
|