| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
platform resources.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it's common start Chrome from the command line, we should print
something to indicate that it's intentionally quitting immediately.
This is the source of a lot of bug reports.
BUG=12918
Review URL: http://codereview.chromium.org/155740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit d06bc0c855b1e81e36c7bfc9bef342eb358d99a5.
TBR=estade
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch. If gnome isn't installed, LinuxProxyConfig wiki page should load.
Review URL: http://codereview.chromium.org/149785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ja,ko,ar and th.
This will partly resolve [2] one of frequent complains of Chinese users (as long as they use Chinese Chrome).
See http://www.google.com/support/forum/p/Chrome/thread?tid=389f306a52817110&hl=en
Leave alone other UI language versions alone for now (Firefox has per-script/per-language min font size [1]). Eventually, there need to be per-script which requires the webkit change.
[1] http://mxr.mozilla.org/seamonkey/search?string=font.minimum-size
(note that Firefox does not set these values by default except for Thai, but offers a UI for a user to adjust).
[2] See other issues (feature requests) mentioned in http://crbug.com/16868
BUG=16875 (http://crbug.com/16875)
TEST=Open Chrome with '--lang=zh-CN' and
go to http://www.popyard.org/ and Chinese characters are larger than before.
Review URL: http://codereview.chromium.org/155607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
menu from View. Add stub menu item for Task Manager (disable).
BUG=16135
TEST=js console opens
Review URL: http://codereview.chromium.org/149677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
/etc/lsb-release does not exist on all distros, and sometimes it does
not provide any useful info. Whereas all LSB complaint distros return
useful data with the lsb_release command.
Review URL: http://codereview.chromium.org/155653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This code should enable the creation of a basic context menu for the Video and Audio tags. The actions for fullscreen, save screenshot, loop, and set playback rate are not yet implemented.
BUG=15686
TEST=None
Review URL: http://codereview.chromium.org/149604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pretty. Animations and aesthetic appeal will come in a
future CL.
BUG=http://crbug.com/14462
BUG=http://crbug.com/14937
BUG=http://crbug.com/15839
BUG=http://crbug.com/16487
TEST=Infobars should show up when expected.
Review URL: http://codereview.chromium.org/155494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the star and go buttons with a native looking thing, where
we manually draw the theme's button image for the full omnibox area
and then position the star/go buttons on top of that.
Also adds stand in versions of star_noborder and starred_noborder
until Glen can make real icons.
http://crbug.com/16227
http://crbug.com/13967
http://crbug.com/16915
Review URL: http://codereview.chromium.org/149681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try clicking the "reset to default theme" button in the prefs; it'll reset things
Review URL: http://codereview.chromium.org/155633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LocationBarCell -> AutocompleteTextFieldCell.
LocationBarFieldEditor -> AutocompleteTextFieldEditor.
AutocompleteTextField added as placeholder for future work (hints and
keyword search).
Review URL: http://codereview.chromium.org/149717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keep on this page" since all the other suggestions are pretty bad as
they are.
BUG=None
TEST=The tooltips should have been updated
Review URL: http://codereview.chromium.org/155532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
passwords.
Original CL: http://codereview.chromium.org/155291
Patch contributed by: thiago.farina@gmail.com
Review URL: http://codereview.chromium.org/155513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16664
TEST=The same tests run for Web Workers on Windows should be run on Linux and OSX.
Review URL: http://codereview.chromium.org/155015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the "Personal Stuff" tab of the options panel, "Browsing Data" should not have a capital D.
BUG=16688 (http://crbug.com/16688)
TEST=It isn't capitalized anymore
Review URL: http://codereview.chromium.org/155480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Applied memory cleanliness fix in unit test; follow-up from
http://codereview.chromium.org/149308.
* Move bookmark bar into it's own nib; minor code refactor to
accomodate.
* The toolbar STAR button somehow lost it's action; added it back in.
* Implemented delete bookmark notification callback so we behave
(remove button from the screen) when a bookmark is deleted.
* Added context menus for the bookmark bar and bookmark buttons.
* Hooked up a handful of these menu items. E.g.
- open in new tab, window, incog window
- delete bookmark (finally)
- bookmark manager (which then hits a NOTIMPLEMENTED())
- always show bookmark bar
* Truncate bookmark button text on end, not on middle.
Experimental to look more like Windows.
It looks cleaner but is less Mac-like.
* Add "draws border when mouse goes over" for bookmark buttons. Need
to do it by hand since we have a custom button drawing method.
BUG=crbug.com/8381
TEST=Here's a list:
- Make sure the bookmark buttons don't have a border unless the mouse is over them
- Toolbar "STAR" should now add bookmarks when clicked
- Test context menus on bookmark buttons, and the bar itself
- Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g.
Right click on bookmark --> delete menu item should delete button
Review URL: http://codereview.chromium.org/155358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.
The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.
BUG=None
TEST=All UI pages should work as before
Review URL: http://codereview.chromium.org/149420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by alcor.
Original review: http://codereview.chromium.org/149204
BUG=http://crbug.com/14451
TEST=Open a theme, watch it apply.
Review URL: http://codereview.chromium.org/155355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16634
TEST=not yet
Review URL: http://codereview.chromium.org/149544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
E.g. plugin<->renderer channel can go down, causing SIGPIPE instead of a
normal error.
Review URL: http://codereview.chromium.org/155390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not, use the stubs. We already use the stubs on unittests, so this just makes the same thing apply to the app. This gets breakpad's slow steps out of the google chrome mac rolling build.
TEST=breakpad still works in official builds
BUG=none
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/149499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=evmar
Review URL: http://codereview.chromium.org/149471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crbug.com/15642
TEST=select version in about box; copy/paste it somewhere.
Review URL: http://codereview.chromium.org/155361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically).
The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open).
The code for packing bookmark bar buttons is now all in one place.
Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o
I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal.
BUG=15870
TEST=things look marginally better, theming still works properly
Review URL: http://codereview.chromium.org/155342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9015 (http://crbug.com/9015)
TEST=Launch CHrome with '--lang=ar'. In options - Advanced tab, open up 'Fonts and Languages' dialog
and select 'Languages' tab. The string above 'Chrome UI language combobox' should not be truncated.
TBR=finnur
Review URL: http://codereview.chromium.org/126009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mirandac
BUG=13821
TEST=Verify that our toolbar buttons have the same visual style in normal, hover and pressed states
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required moving the sad plugin resource out of the Windows-specific code.
Note that it doesn't display right yet, since the place to display is covered
by the GtkSocket that used to host the plugin. But that is a separate issue.
(I had it draw to the side to verify the image was correctly getting loaded.)
BUG=16158
Review URL: http://codereview.chromium.org/155262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolbar. The main toolbar should blend in with the bookmark bar when
it's open"
- Fix janklist issue #2: "It's way too tall - the distance from the
bottom of the bar to a bookmark button bottom edge should be the
same as the distance from the omnibox to the bookmark button top
edge (this will probably mean that the bar has to overlap the
toolbar)."
- Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons
have a frame around them ... "
- Fix janklist issue #9: "the show/hide animation is very janky... I see
a dark gray area behind". Even with animators the grey is gone, but
animators are disabled for now due to races.
- Fix unlisted jank related to 9: don't use animator when opening bar on
launch.
- Also chipped away on unit tests.
TEST=Launch with bookmark bar both open and closed. Make sure OK on launch.
In each case open and close a few times fast.
Repeat with multiple windows open.
Sanity check jank descriptions listed above are fixed.
BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724
Review URL: http://codereview.chromium.org/149308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/150216
Original description:
Move download item to its own view and a xib, paving the way for a custom
download item view. I didn't change the look of the download items yet. The
context menu is now in the download item xib as well.
BUG=14659,15098,14660
TEST=Download something. Everything should look like before (except for the
smaller icon), but the context menu items should be disabled/enabled and
checked/unchecked correctly.
Review URL: http://codereview.chromium.org/149276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and most likely some page cyclers.
Review URL: http://codereview.chromium.org/155236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14920
TEST=context menus on tabs.
Review URL: http://codereview.chromium.org/155173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, do some housekeeping for our current shortcuts.
* Command-Option-l - Downloads [same shortcut as Safari].
* Command-Shift-[/] - Back/forward tab.
* cntrl-pageup/pagedn - Back/forward tab.
Global Keyboard events are intercepted by a new BrowserWindow custom class.
BUG=12537,15486
TEST=Check that above keyboard shortcuts work as advertised.
Review URL: http://codereview.chromium.org/149325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make processes dumpable when they crash.
* Find crashing processes by searching for a socket inode, rather
than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs
between PID namespaces with SCM_CREDENTIALS, so we can't use the
PID there.
* Use a command line flag to the renderer to enable crash dumping.
Previously it tried to access the user's home directory for this
information.
* Search for a sandbox helper binary and, if found, use it.
* Include the source for a sandbox helper binary. It's currently not
built by default.
http://codereview.chromium.org/149230
R=evan,markus
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked.
BUG=13151
TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar.
Review URL: http://codereview.chromium.org/155151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac. I'm leaving the window resizable for now, because I dislike
non-resizable windows. This is easy enough to change later.
BUG=None
TEST=After bringing up the dialog, verify that the only way to dismiss
it is by pressing either the wait button or the kill button.
Review URL: http://codereview.chromium.org/151009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons. Observe that WCB's are themed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758
Review URL: http://codereview.chromium.org/150041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
|