| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the external change.
BUG=26826
TEST=none
Review URL: http://codereview.chromium.org/388011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
figure out how to use the system icon without regressing startup time.
BUG=26457
TEST=Look at bookmarks bar. The folder icon, while not being the system folder icon, is at least blue.
Review URL: http://codereview.chromium.org/389012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27226
TEST=open task manager, enable column, compare with V8 heap profiler
Review URL: http://codereview.chromium.org/377037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes leak in BackingStore as shown by valgrind. XFree doesn't free
the data of the image, where as XDestroyImage does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/374022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028
TBR=chocobo@google.com
Review URL: http://codereview.chromium.org/384017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028
TBR=chocobo@google.com
Review URL: http://codereview.chromium.org/384014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this changelist is only for windows.
BUG=21726
TEST=verify that "Learn More" link shows up centralized beneath crash message and when clicked, opens the url specified in bug.
Review URL: http://codereview.chromium.org/377016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- align the baselines of the controls
- quick animation when changing the buttons so it is a little less sudden.
While here:
- don't update the button title while dragging through the menu, do it when done.
- Fixed up some kvo binding to stop using the ivars directly since the controller has accessors
TEST=baselines match, button updates after selection not during menu drags
BUG=27275
Review URL: http://codereview.chromium.org/388006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the single option of revoking permissions from that origin.
The renderer side change is a related issue that the full URL was being sent as the "source" of the notification rather than only the origin.
BUG=26690
TEST=open a notification
Review URL: http://codereview.chromium.org/363011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/371094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reuses the Install dialog (and makes it slightly more generic).
BUG=27162
TEST=None
Review URL: http://codereview.chromium.org/376030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/378035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add TitleCase versions of the menu policy strings (one in the range isn't used, but done to avoid more ifs in the GRD.
TEST=Since they are new strings, other langs will get English until we get them localized, but you can tell by them being in proper Title Case.
BUG=26844
Review URL: http://codereview.chromium.org/377009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Required for javascript bindings.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/376023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
clipped rather than resized. Useful for when animations are running.
BUG=http://crbug.com/26857
TEST=Animations should still work. Infobar animations should be smoother. The web contents will clip or fill with white at the bottom while the animation is running, but should resize and draw correctly when the animation finishes.
Review URL: http://codereview.chromium.org/372056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Changed Application over to type BrowserCrApplication from CrApplication.
Review URL: http://codereview.chromium.org/376025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor HyperlinkCell a bit and make it less crashy.
This depends on http://codereview.chromium.org/377026 (the changes form that CL are contained in this CL too. Ignore them.)
BUG=none
TEST=Install theme, "Show all downloads..." color should change. Uninstall theme through installing the "classic" theme in the gallery, link should be blue again. Hit "Reset to default theme" in prefs, theme should still be blue. Open and close shelf a few times and change themes, nothing should crash.
Review URL: http://codereview.chromium.org/371059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes (a bit more complicated than anticipated, because GTMUI decided to resize the image view to 0x0, since its image is only loaded in DownloadShelfController's awakeFromNib -- hence I couldn't make the image view a child of the width-based resizer):
* Replace text view with a button that has a HyperlinkView cell
* Change its text to ^IDS_SHOW_ALL_DOWNLOADS
* Add localizer and ui localizer/layout tweaker objects
* Put close button and new button into a width-based tweaker
* Put item container and image view into a box
* Let width-based tweaker resize said box
No intended functionality change. This is a prerequisite for http://codereview.chromium.org/371059 .
BUG=None
TEST=download shelf still looks like it did before, resizing hides download items when the icon would touch them.
Review URL: http://codereview.chromium.org/377026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25964
TEST=none
Review URL: http://codereview.chromium.org/371015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 26860
TEST= open bug report. enter multi-line description, using return to insert newlines.
Review URL: http://codereview.chromium.org/374024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This way modifiers are consistent on Mac and it makes sense on Windows/Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The toolbar should not have a context menu, and it should decidedly not be hooked up to the Page menu.
Changes to Toolbar.xib:
- remove the connection from the Toolbar |menu| outlet (to the Page Menu)
- connect Chrome UI Localizer's |yetAnotherObjectToLocalize_| outlet to the Page Menu
BUG=26823
TEST=See bug. Also, make sure the toolbar does NOT have a context menu, and that the Page Menu is displayed correctly.
Review URL: http://codereview.chromium.org/371049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(fix mac build breakage)
This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
BUG=21412
TBR=willchan
Review URL: http://codereview.chromium.org/376014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extensions are installed.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19738,26499
Review URL: http://codereview.chromium.org/371037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Added "^IDS_PASTE_MATCH_STYLE_MAC" to edit menu below paste with key equiv cmd-opt-shift-v, hooked up to pasteAsPlainText: on first responder.
BUG=25205
TEST=Cmd-shift-v no longer pastes. Cmd-shift-opt-v does paste, _and_ blinks the menu.
Review URL: http://codereview.chromium.org/371034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
BUG=21412
Review URL: http://codereview.chromium.org/362022
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/375019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
BUG=21412
Review URL: http://codereview.chromium.org/362022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac equivalent of r31225, http://codereview.chromium.org/377005
BUG=none
TEST=Command-shift-C and View:Developer:JavaScript Console should bring up the
Developer Tools in console mode. Command-option-J and
View:Developer:Developer Tools should show the Developer Tools window
not in console mode. The menu items should be visible in View:Developer
and in the Page menu under Developer.
Review URL: http://codereview.chromium.org/377017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight.
2) Click and hold on the new tab button and its state should change
3) Release, and watch new tab get created. Verify that new button state
changes appropriately
4) Create a full tab strip of tabs. Verify that button state stays
correct as you click on the new tab button and new tabs are created but
the button doesn't move.
5) Create 2 tabs, and move the mouse button into the newtab button.
See that it highlights. hit cmd-w to close a tab. As the newtab button
moves away from under the cursor make sure it loses its highlight.
Review URL: http://codereview.chromium.org/372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/374017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
breakpad_mac.mm:137: error: 'parsed_command_line' was not declared in this scope
since r31143
BUG=none
TEST=Breakpad-enabled build should, um, build
Review URL: http://codereview.chromium.org/374011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
expands and contracts when its title changes.
BUG= none
TEST= Open report bug dialog; choose "Send phishing report" and note that cancel button moves as send button expands.
Review URL: http://codereview.chromium.org/372021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Small shuffle to the basics page to make things look a little better
- Support for the three areas that get really wide in the prefs ui forcing the window wider, this will make sure nothing is clipped in any language.
BUG=26586
TEST=try french, german, etc. to make sure no buttons extend off the side of the prefs window.
Review URL: http://codereview.chromium.org/378012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ESC, and Send button to Return.
BUG= 26874
TEST= use report bug dialog. note correct ui.
Review URL: http://codereview.chromium.org/376006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/377005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= None.
TEST= None.
TBR= tony
Review URL: http://codereview.chromium.org/378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can add in Database, LocalStorage, and Appcache next
to the cookies for an origin.
BUG=26713
TEST=cookies_tree_model_unittest.cc
Review URL: http://codereview.chromium.org/365005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second try, now with fixed observer.
BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
Make sure it gets the result back correctly. Also make sure it still works when
called from a web page.
Review URL: http://codereview.chromium.org/373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkEditorController called BookmarkEditorBaseController, from which BookmarkEditorController and the new BookmarkAllTabsController derive. The bookmark/folder name, URL and OK button now use bindings/KVO. Added BookmarkAllTabs.xib which is nearly identical to BookmarkEditor.xib. Changed unit test since an empty bookmark name is now acceptable. Added unit test for the Bookmark All Tabs...
BookmarkEditor.xib changes: Removed the bookmark name and url as outlets and instead bound their values to controller's displayName and displayURL respectively. Bound the OK button enabling to the controller's okEnabled.
BUG=25099
TEST=Open two or more tabs. Bring up a contextual menu by control-clicking on one of the tabs. Choose the Bookmark All Tabs... menu item. A dialog will be presented in which you can type a folder name and select the parent folder in which the new folder will be placed. By default, the most recently touched folder will be selected as the parent. Click OK. Now check to parent folder to see that the newly created folder has been added and then check within that folder to see that the open tabs have been added.
Perform the above operation again only this time choose the Bookmark All Tabs... menu item found in the Bookmarks menu.
Review URL: http://codereview.chromium.org/357005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds common base classes (StyledTextField and StyledTextFieldCell) for both the find bar and omnibox text fields.
BUG=http://crbug.com/19550
TEST=Findbar results label should not be overdrawn by find text.
TEST=Autocomplete drawing (keyword, hint, lock icon) should not be affected.
Review URL: http://codereview.chromium.org/319005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31184 0039d316-1c4b-4281-b951-d872f2087c98
|