| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
right wrench menu in Toolbar.xib.
TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2813025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/45334
TEST=none yet
Review URL: http://codereview.chromium.org/2838011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Make a GRD change, dcommit, be prompted about having a GRD change.
Review URL: http://codereview.chromium.org/2813024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mock died on the vine. Toolbar is now indented along with the rest of the window content.
BUG=44773
TEST=hidden behind flag, nothing to test.
Review URL: http://codereview.chromium.org/2824021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The IDS_IMPORT_SETTINGS string was only being used on the Mac. Moved into a Mac only section and renamed.
BUG=41773
TEST=Title of meu item in Chrome menu should be "Import Bookmarks and Settings..."
Review URL: http://codereview.chromium.org/2874003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46646
TEST=manual tests
Review URL: http://codereview.chromium.org/2817021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new view to the preferences dialog in Preferences.xib that holds the
alert image and the warning message label. Update the visibility of the warning
banner when switching preference views in PreferencesWindowController.
BUG=43423
TEST=none
Review URL: http://codereview.chromium.org/2831004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2321
TEST=On user image in top right corner there is a menu button to remove user. Need changes in WM to work properly.
Review URL: http://codereview.chromium.org/2832012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the "Show full history" from the "Recently closed" bar since we can now get to the history using the link in the footer.
BUG=None
TEST=There should be three links at the bottom of the NTP now.
Review URL: http://codereview.chromium.org/2712004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2856011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45869
TEST=no change
Review URL: http://codereview.chromium.org/2856012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove some of the boilerplate strings.
- Allow the description field to be fully customizable and stylable.
BUG=46478
BUG=46479
Review URL: http://codereview.chromium.org/2849015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(These are my best mspaint skillz, so Glen, feel free to send me something more aesthetic, or at least centered).
BUG=none
TEST=new tab UI tests (should go back into expected range)
Review URL: http://codereview.chromium.org/2837012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in task manager:
Before
title memory
================================================
|Plug-in: Shockwave Flash | XXXXX |
After
title memory
============================================
|Plug-in: Shockwave Flash (10,0,3,52) | XXXXX |
Some crazy plug-ins embed version string on the title so for those it shows twice. There are not many that fall into that category
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2715001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2833023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pre-reading chrome.dll prior to calling loadlibrary has shown significant
improvement int he startup performance. Temporarily enabling this for
headless mode so that we can try out the effect on the perf bots.
Review URL: http://codereview.chromium.org/2814019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
o Grippy is hidden for now pending new UI. You can still resize just fine.
o The right divider is removed since the wrench menu is now always being shown.
TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2863013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44915
TEST=Start chrome with --enable-apps (and optionally --enable-accelerated-compositing). Install some apps. Now hover over the app icon and click the wrench icon.
Review URL: http://codereview.chromium.org/2832014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark model. This prevents a "flash" of the text between startp
and model load (when model is not empty).
BookmarkBarToolbarView nib change:
The "width based tweaker" object (that contains the "Bookmarks go
here" text shown when you have no bookmarks) defaults to NOT
visible.
BUG=http://crbug.com/43102
TEST=New profile. Launch chrome. Make sure you see the "bookmarks go here" text.
Add a bookmark; make sure text goes away.
Delete it; text comes back.
Add a bookmark; text goes away again.
Restart Chrome a dozen times. Make sure you never see the text, even for a flash.
Review URL: http://codereview.chromium.org/2825012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Make sure full keyboard control is on; e.g.
System Preferences --> Keyboard --> Keyboard Shortcuts --> Full Keyboard Access; "All controls" radio
Open bookmark bubble by clicking the STAR. Make sure you can tab
across all controls in this bubble in a natural order (left-->right,
top-->bottom).
BUG=http://crbug.com/41498
nib change: for each control, hook up nextKeyView outlet to the next control.
Review URL: http://codereview.chromium.org/2874001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
images from new tab animation. I'm combining this to minimize tree
bustage.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2854014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=wrote unit tests
BUG=chromium-os:4157
Review URL: http://codereview.chromium.org/2865009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual
BUG=chromium-os:2640
Review URL: http://codereview.chromium.org/2855014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
update url via download from gallery
Because of multiple failures of unit_tests and interactive_ui_tests.
BUG=45542
TEST=NONE
Review URL: http://codereview.chromium.org/2855009
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2822021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download from gallery
BUG=45542
TEST=NONE
Review URL: http://codereview.chromium.org/2855009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove cookie button.
XIB change:
Add an outlet for the Remove button.
BUG=45775
TEST=Chromium-->Preferences-->UtH-->Content Settings-->Cookies. Select a cookie. Press Delete. Select another. Press backspace. 2 cookies are deleted.
Review URL: http://codereview.chromium.org/2810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en
BUG=40745
BUG=36728
BUG=36222
TEST=New test added to focus_manager_unittest.cc
Review URL: http://codereview.chromium.org/2737010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The translation console at Google complains if a <ph> block has non-ASCII text.
BUG= none
TEST= translation console extract succeeds
Review URL: http://codereview.chromium.org/2808015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2845013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46716
TEST=none
Review URL: http://codereview.chromium.org/2854010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerator was not removed when it's closed by escape accelerator. This was causing crash in screen locker.
Use "Resume" text for unlock button.
Removed unnecessary TextButton dependency in screen_lock_view.h
BUG=none
TEST=lock screen using ctrl-alt-l, type wrong password and enter then hit escape twice.
It will not crash.
Review URL: http://codereview.chromium.org/2872004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chosen.
BUG=46716
TEST=new first run bubble after first run import mentions the search engine: "Search using Google from right here"
Review URL: http://codereview.chromium.org/2817009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2715003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46525
TEST=In the bug.
Review URL: http://codereview.chromium.org/2802005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements changes based on review feedback with Jeff. Validation icons should not appear in phone and fax input fields until text is input. Credit card expiration date year dropdown should list 10 years at most. CVC input fields are removed.
Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal.
BUG=46681, 46635, 46634
TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.*
Review URL: http://codereview.chromium.org/2873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This may change later, but in the meantime, this is what we want for
Japanese CrOS.
BUG=cros:2635 (http://crosbug.com/2635)
TEST=Change your UI language to Japanese and go to a web page specifying 'sans-serif', 'serif' or 'monospace' (wikipedia specifies 'sans-serif'). Make sure that IPAPGothic, IPAPMincho and IPAGothic are used.
Review URL: http://codereview.chromium.org/2821007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bottom-aligned.
Technically this does not center the icon like the bug asks; it
bottom-aligns it. However, the image in the icon itself is
top-aligned (has whitespace on the bottom). This change makes the
chevron line up with the center of bookmark button text next to it so
it looks correct.
BUG=http://crbug.com/45740
Review URL: http://codereview.chromium.org/2870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bubble object which implements WidgetWin).
TEST=none
BUG=9601
Review URL: http://codereview.chromium.org/2338001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SubjectAltName IDNs
Remove extraneous '\n' from ProcessGeneralNames.
BUG=43966
TEST=manual
Review URL: http://codereview.chromium.org/2733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib updates:
Toolbar.xib: Removed page menu and moved everything over to accomodate.
Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate.
BUG=45756
TEST=migration from having the pref hidden. It should become visible.
Review URL: http://codereview.chromium.org/2828005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3486
TEST=none
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/525
TEST=none
Review URL: http://codereview.chromium.org/2842003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modifies entry labels with trailing colon for Mac UI. Using correct validation icons now. Nib changes for AutoFillAddressSheet.xib and AutoFillCreditCardSheet.xib: rearranges labels and entry fields to right align on label colons. Changes label font to be regular size and regular weight.
BUG=46504
TEST=manual inspection of AutoFill UI.
Review URL: http://codereview.chromium.org/2842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the issues, but doesn't make the app launcher match the new style.
BUG=45745
TEST=Omnibox has endcaps, insides are aligned and padded correctly, dropdown looks good
Review URL: http://codereview.chromium.org/2721009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2736004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45743
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the Options dialog, in the Under the Hood section.
xib changes: added an enabled binding to the policy-controlled checkboxes in the "Under the Hood" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.
BUG=44394
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* Manual tests: Set the policies externally. Check that the checkbox in Options/Under the Hood/Privacy/search suggest... are disabled. Also check that the check box is set/unset as done by the policy.
Review URL: http://codereview.chromium.org/2746006
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if more than one keyboard are active.
BUG=chromium-os:3936
TEST=manual
Review URL: http://codereview.chromium.org/2787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44616
TEST=FormManagerTest.*
Review URL: http://codereview.chromium.org/2752010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
themes.
TBR=estade
BUG=45745, 45762, 45763
TEST=none
Review URL: http://codereview.chromium.org/2738011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49619 0039d316-1c4b-4281-b951-d872f2087c98
|