| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with the proper fix to the Mac nibs files under chrome/app/nibs.
Pointed out by Scott Hess (shess@chroium.org).
BUG=86901
TEST=None
R=shess@chromium.org,dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7477002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear local cache on exit
BUG=69580
TEST=configuration_policy_pref_store_unittest.cc
Review URL: http://codereview.chromium.org/7399021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
File manager is useing window.alert/confirm/prompt which are app modal, and a little janky for our purposes. Additionally, they began freezing the browser recently :/
This change adds js modal dialog replacements. They live in file_manager/ for now, but once stabalized they are intended to live in cr/ so that they can be used by other webui or component extensions.
BUG=chromium-os:17642
TEST=manually trigger all dialogs
Review URL: http://codereview.chromium.org/7495030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7470005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16936
TEST=None. Wait until implementation code checks in to test.
Review URL: http://codereview.chromium.org/7512001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7472045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7492024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds keyboard handlers (Ctrl-[XCV]), task buttons (but only for copy/paste) and context menu items for all three commands.
Introduces a butter bar (which I'd like to refactor into a stand-alone lib later) with fancy transitions.
Fixes the never-worked-right canExecute updating.
Refactor resolvePath from file_manager.js to utils.js
Added small border around the preview image.
Add the document level key handler back in.
BUG=chromium-os:14803,chromium-os:17797
TEST=Manual testing on chromeos-chrome in linux
Review URL: http://codereview.chromium.org/7461044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90033,90362
TEST=none
Review URL: http://codereview.chromium.org/7502003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17673, chromium-os:17783
TEST=none
Review URL: http://codereview.chromium.org/7508003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add button to infobar allowing user to disable feature completely
- add checkbox to password section of personal settings allowing user to toggle
whether auto-login is enabled
- some word changes to the infobar
- remove the about:flags option since we now have control in options
BUG=87151
TEST=Make sure that checkbox in options page controls feature correctly
Review URL: http://codereview.chromium.org/7485007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is a "network" service instead of "web" service.
BUG=89874
TEST=none
Review URL: http://codereview.chromium.org/7468033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was causing a crash on Mac try-bots.
BUG=86901
TEST=None
R=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7489032
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/7505001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the following shortcuts to the keyboard overlay.
* Alt - 1, Alt - 2, .., Alt - 8: go to the window at the specified position
* Alt - 9: go to the last window open
* Ctrl - Forward: switches focus to the next keyboard-accessible pane
* Ctrl - Back: switches focus to the previous keyboard-accessible pane
* Ctrl - Right: move the text cursor to the end of the next word
* Ctrl - Left: move the text cursor to the start of the previous word
* Ctrl - Alt - Z: enable or disable accessibility features
* Ctrl - Shift - Maximize: take a screenshot of the selected region
* Ctrl - Shift - O: open the Bookmark Manager
I also deleted a duplicated entry of "Close window".
BUG=chromium-os:17152
TEST=Manually checked on chromebook
Review URL: http://codereview.chromium.org/7489040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=86901
TEST=None
R=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7489032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
profile.
BUG=90164
TEST=about:flags shows warning indicating that flags are per-browser, not per-profile
Review URL: http://codereview.chromium.org/7492021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following the mock in http://crosbug.com/11690#c18, the new string is "CAPS LOCK is on. Press Search key to cancel" if Serach key is mapped to Caps Lock. "CAPS LOCK is on. Press both Shift keys to cancel" otherwise.
BUG=chromium-os:11690
TEST=manual
Review URL: http://codereview.chromium.org/7461025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file browser:
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/7495024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the second step of them:
(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan)
BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Mac)" on Mac.
Review URL: http://codereview.chromium.org/7461058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17870
TEST=build chrome, launch file manager, check that IDS_FILE_BROWSER_DOWNLOADS_DIRECTORY_WARNING is available and properly unescaped.
Review URL: http://codereview.chromium.org/7482006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=73052
TEST=NONE
Review URL: http://codereview.chromium.org/7246008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I stripped down the CL that is currently in progress so I can get the page added with placeholder text for Monday. Functionality
will therefore be based on this CL.
BUG=none
Review URL: http://codereview.chromium.org/7489018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add a trash can when you are dragging apps. Dragging the app onto the trash can will delete the app. Currently there is no confirmation dialog for the uninstall but I'm working out the details of that with Cole.
Also, refactor drag thunk code into DragWrapper.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7467014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79771
TEST=see bug
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7484034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11667
TEST=manual
Review URL: http://codereview.chromium.org/7483016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
errors until receipt of the first IPC message.
Tested by running WebGL content with this patch on Mac and Windows.
BUG=84650
TEST=none
Review URL: http://codereview.chromium.org/7458009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add account picker;
- Make oobe page able to switch from oobe display to login display;
- Add header toolbar for login display;
- Support user removal;
BUG=chromium-os:17399,chromium-os:17815
TEST=Verify account picker shows up in webui sign-in screen for 17399 and could remove non-owner user for 17815.
Review URL: http://codereview.chromium.org/7461009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- specify network name for proxy page
- provide hint when use-shared-proxies is off for remembered shared networks
BUG=chromium-os:18014,chromium-os:18052
TEST=verify per bugs' reports.
Review URL: http://codereview.chromium.org/7488010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17813
TEST=None. This is just to add in message before string freeze.
Review URL: http://codereview.chromium.org/7486008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
want to register a protocol handler, it adds the protocol to the ignored list for that user, which means it won't show up in their right-click menu for links with that protocol, and appears in an ignored list in the settings at chrome://settings/handlers
TEST=Manual testing
Review URL: http://codereview.chromium.org/7358012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
With this change we can now collapse and expand the sync promo.
BUG=89276
TEST=Ran with --sync-show-promo and verified that collapsing and un-collapsing the sync promo worked.
Review URL: http://codereview.chromium.org/7399015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88102
TEST=go to chrome://settings/personal and set up syncing
Review URL: http://codereview.chromium.org/7457011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7473013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89643, 89736
TEST=go to chrome://settings/personal when running with multi-profiles enabled.
Review URL: http://codereview.chromium.org/7400032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation.
Handle the "multiple tabs requesting certs for same site" issue.
BUG=73223,50710
TEST=Try some sites that use SSL client auth. See bug 73223 for multiple-tabs issue.
Review URL: http://codereview.chromium.org/7362008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7457017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These string changes couldn't go into R12 and R13 since this bug was assigned after the R13 string freeze hence putting the changes in to go for R14.
R=zelidrag@chromium.org,davemoore@chromium.org
BUG=chromium-os:15789
TEST=Verified that login, about:version and the about ChromeOS page use the platform string instead.
Review URL: http://codereview.chromium.org/7400022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80794
TEST=
Review URL: http://codereview.chromium.org/7383011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them new explicit permissions and install warning messages.
Also change the hidden event ttsEngine.onEvent to tts.onEvent, which is
where it belongs because it's sent to clients who call tts.speak and has
nothing to do with engines.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7258007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add images for webui login header bar so that I could try the CL later.
BUG=chromium-os:17399
TEST=Wait until the functional CL gets in to test.
Review URL: http://codereview.chromium.org/7461008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
processes for NaCl modules.
BUG=nativeclient:480
TEST=NaCl tests in Chrome
Review URL: http://codereview.chromium.org/7442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- previously, proxy is per device i.e. one proxy for all networks for all users,
and only owner can persist changes while non-owners can only change proxy
during a session.
- now, proxy is per network per user, i.e. each shared network can have a proxy
for all users, each private network can have a proxy for each user, it's up to
each user if he/she wants to use the proxies of shared networks.
this cl does several things:
- migrate previously persisted protobuf-formatted device signed settings to
string property on flimflam for each network that becomes active (i.e. that is
connected to).
- proxy changes are no longer persisted as signed setting to device; instead
proxies are persisted to flimflam and only for the specific network and
for the logged-in user if network is private.
- in oobe/login screen, proxy configuration is only for network that is
currently active i.e. being connected to. so to change proxies of different
networks, you have to first connect to the network, then open the proxy page.
- after login, proxy configuration is only enabled for remembered private
networks or where user chooses to use shared proxies of remembered shared
networks, regardless if network is active or inactive.
- after login, proxy section is removed from "Under the hood", and
chrome://settings/proxy is no longer accessible. instead,
on chrome://settings/internet, click on "Options" button of a network, in
"Network" tab, if proxy is configurable, "Change proxy settings..." button
will open the proxy page.
- each time user connects to a different network successfully, proxy of that
new network takes effect in the network stack, as will be reflected in
chrome://net-internals/#proxy.
bug: in proxy page, manual settings (http,https,ftp,socks) don't show up.
- fixed in javascript.
BUG=chromium-os:13052,chromium-os:15278,chromium-os:17409
TEST=verify that proxy can be modified for different connected networks in oobe/login and different active and inactive networks after-login, and the different proxies take effect when switching between networks.
Review URL: http://codereview.chromium.org/7384016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix string hackery in net/tools/dump_cache/dump_cache.cc
Fix const casts in chrome/installer/util/product.cc and base/process_util_win.cc.
BUG=73195
TEST=none
Review URL: http://codereview.chromium.org/7386002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This infobar has been useful, but the marginal utility of leaving it active is low.
BUG=88791
TEST=none
Review URL: http://codereview.chromium.org/7457013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll
chrome.exe
nacl64.dll
nacl64.exe
BUG=http://code.google.com/p/chromium/issues/detail?id=65350
TEST=None
R=cpu@chromium.org
Review URL: http://codereview.chromium.org/7390037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7453001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header.
R=jam@chromium.org
BUG=76699
TEST=everything compiles
Review URL: http://codereview.chromium.org/7397004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a ProfileMenuController that is owned by the AppController. It is
responsible for managing the menu and menu item title.
XIB changes:
* Add a new menu item with no submenu called Profile with tag
IDC_PROFILE_MAIN_MENU.
BUG=86179
TEST=With --multi-profiles, a Profile menu is displayed in the menubar.
Review URL: http://codereview.chromium.org/7331029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
enabled by default and make auto-login disabled by default.
BUG=None
TEST=Try all four combinations of the about flags to make sure they work
as expected.
Review URL: http://codereview.chromium.org/7401021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93032 0039d316-1c4b-4281-b951-d872f2087c98
|