| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The drawing code in the tab strip was modifying the GC, which affected
the GC used for drawing menus.
Review URL: http://codereview.chromium.org/55022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The generated header files had the wrong paths specified in the vcproj files.
- Have the .h files generate to a temp file and overwrite the real .h files if they changed from the last run. This prevents recompiling when only a resource is changed.
- Change the output file to the .rc file because otherwise the vcproj file would recompile every time because the .h file wasn't changing. Since the .rc file gets written all the time, this isn't a problem.
On a side note, you still have to re-link to get the resources in chrome.dll. I imagine if you turn on incremental linking, this would be pretty fast.
BUG=7967
Review URL: http://codereview.chromium.org/53028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
breakpad_mac.mm still needs some work, there's a bunch of scaffolding in there referring to a custom version of Breakpad I've got going locally.
Review URL: http://codereview.chromium.org/53075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance).
- Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome.
Review URL: http://codereview.chromium.org/49035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- "add bookmark" menu item enable state (e.g. disabled if no windows)
- bookmark menus built dynamically (like before)
- bookmark menus rebuild when a bookmark is added/removed
- bookmark menus take the current browser to where you want to go
- works with multiple windows (main window goes to bookmark location)
- works with no windows (bookmarks open a new window)
Review URL: http://codereview.chromium.org/49005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Firefox has had this shortcut for a long time and I am told IE8+ added it as well.
In any case, we should match Firefox.
BUG=8458
TEST=Press Ctrl+Shift+Del and the Clear Browsing Data dialog should show up.
Review URL: http://codereview.chromium.org/42540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the progress status text indicator code from the old history page.
Make 'cancel' visible when paused.
More RTL fixes.
BUG=8220,8334
Review URL: http://codereview.chromium.org/42550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the title in the task manager, and show an infobar when a page's workers die.
I also cleaned up the code in RenderView which creates a window and widget, since when I originally wrote it I wasn't aware of RenderViewHost::FromID.
Review URL: http://codereview.chromium.org/45025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At one point we changed the Clear Browsing Data dialog to remember
the values of the combobox and the checkboxes between runs. Like
with the Options dialog, changes you make take effect immediately
and as such having a Cancel button is misleading. Therefore, I am
proposing we rename it to Close.
BUG=6474
TEST=Open Clear Browsing Data dialog. The button should now say
Close.
Review URL: http://codereview.chromium.org/45019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--bookmark-menu.
BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
works. Also make sure I didn't break anything on the bookmark bar.
Review URL: http://codereview.chromium.org/42460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
platform ifdefs that are no longer necessary in Browser. Patch from thakis@google.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the browser window for windows with tabs to promote re-use in contexts other than just the browser. Add code to the tab view to track drags, but it's disabled as it still needs much work.
Review URL: http://codereview.chromium.org/42397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added missing delayload entries to chrome/app/chrome.dll.deps.
TBR=maruel
Review URL: http://codereview.chromium.org/48172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Have chrome/renderer to use FFmpeg
- Added using_media.vsprops to all affected projects that depends
on chrome/renderer.
- Added lib path "$(OutDir)\lib" to essential.vsprops
Review URL: http://codereview.chromium.org/48118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The bookmark menu is populated dynamically with bookmarks, including
subfolders --> submenus. E.g. star something --> shows up in menu.
Menu items are disabled but always present and current.
- Always Show Bookmarks" menu now live; reads from / writes to
preference, and shows correct "toggle state".
- Bookmark bar on each tab, present if requested. (Currently an empty box).
- Random stuff; e.g. bookmark prefs init moved to a x-plat location.
This CL does not contain Cole's views.
Bried english description of the nib file changes:
- add a new view for the bookmark bar in the tab; hook it up to the controller
- Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009)
- Remove dummy bookmark menu items
Review URL: http://codereview.chromium.org/46078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to work around a few google issues (Picasa web, China's icafe)
bug=3301
Review URL: http://codereview.chromium.org/46069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the
feeds in the document and notify the browser to
display the RSS icon in the toolbar. You can
click on the icon, but it will just navigate to
the first feed on the page, which (unless it has
been designed to be browser friendly) will just
dump XML as text on the user.
For this reason I have disabled the code that
makes the RSS icon appear and intend to enable
it when we have a good landing page to display
the XML.
Review URL: http://codereview.chromium.org/46055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reverting for now. Will try again later
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=6627&r2=6626&pathrev=6627
line 236
We are appending the pid to the name of the shared memory object,
which causes each renderer to get its own uninitialized copy of the
stats counters, breaking the sharing. So then the about:stats code
can't find the counters created and updated by these processes. This
includes all the V8 counters and timers.
Original issue: http://codereview.chromium.org/40012/show
Review URL: http://codereview.chromium.org/42130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image.
Review URL: http://codereview.chromium.org/43144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8676
TEST=Open About box in Hebrew and make sure it is not truncating the text.
Review URL: http://codereview.chromium.org/43099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for loading the template is enabled and the resource exists.
Review URL: http://codereview.chromium.org/42053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
only repository.
TBR: jrg
Review URL: http://codereview.chromium.org/42071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Windows; we'll do better soon.
Review URL: http://codereview.chromium.org/42018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Dock icons for window docking positions could go offscreen
before.
. It was possible to show the maximize indicator on the wrong
screen. This was because equals was not comparing the monitor bounds.
. Tweaks to color, size and animation from Glen.
BUG=none
TEST=make sure there are no bugs with docking tabs.
Review URL: http://codereview.chromium.org/42041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes. This is the code to set and maintain the URL, but we're not
using it anywhere yet.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/39202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8321
TEST=Open the option panel, under minor tweaks, the autofill text next to the check-box should say "Save text from forms to make them easier to fill out"
Review URL: http://codereview.chromium.org/41016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Small fix to get them to display (need to include webkit strings in our
language pak files).
Review URL: http://codereview.chromium.org/39296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation calls.
BUG=5671
Review URL: http://codereview.chromium.org/40301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test simulates following scenario: user opens a local html page with Chrome when a browser instance is already running. The new Chrome process should notify the existing process about new page and exit. Bug 7900 broke this behavior causing the new process to crash.
I verified that the ui_tests infrastructure would catch this crash and cause the test to fail.
BUG=7900, 8056
Review URL: http://codereview.chromium.org/39257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
available in the encoding menu. Make windows-1255 come before
ISO-8859-8* both in the full encoding list and in Hebew Chrome's
static list.
BUG=2927
Review URL: http://codereview.chromium.org/39248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any lang (currently using --lang=ar or whatever).
Also remove app/resources/SConscript since it's filled with
windows specific code.
BUG=8125
Review URL: http://codereview.chromium.org/40246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the filesystem and avoid the need for processing of Info.plist.
Dup of svn log since rietveld doesn't like A+D:
A + chrome/app/theme/chromium/app.icns
D chrome/app/theme/chromium/chromium.icns
M chrome/app/app-Info.plist
M chrome/chrome.gyp
Review URL: http://codereview.chromium.org/40238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average
character width (depending on which one is smaller).
BUG=8331
TEST=Open About box in all languages and make sure it is roughly
the same size as it was in 1.0.
Review URL: http://codereview.chromium.org/39214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files.
TBR=deanm
Review URL: http://codereview.chromium.org/39152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, our command line objects were created /after/ gtk_init had
processed |argc| and |argv|. With this patch, it's created before hand
and main's |argc| and |argv| are now kept pristine. Thus our command
line will now reflect GTK arguments that previously it wouldn't have
seen. This should be harmless.
Review URL: http://codereview.chromium.org/39172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To brand, do a "src/tools/gyp/gyp_dogfood -Dbranding=Chrome src/build/all.gyp"
(Then build, of course.)
Review URL: http://codereview.chromium.org/40066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for Chrome Release builds.
Review URL: http://codereview.chromium.org/39046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebWorkerClient/WebWorker are parallel interfaces of WebCore::{WorkerObjectProxy, WorkerContextProxy} that use Chrome data types. When WebKit requests a WorkerObjectProxy, we create an instance of WebWorkerClientImpl. This class creates an object that implements a Chromium version of WorkerObjectProxy (i.e. with Chrome data types) through WebViewDelegate. That object is a WebWorkerProxy and talks over IPC to a WebWorker object in the worker process. The WebWorker object creates the actual WebCore::Worker object using another class in glue: WebWorkerImpl.
When the WebCore::Worker object running in the worker process wants to talk back to the code running in the renderer, it talks to WebWorkerImpl which implements WebCore::WorkerObjectProxy. WebWorkerImpl converts the data types to Chrome compatible ones, and then calls the WebWorkerClient version which does IPC to get to the renderer process. This ends up at WebWorkerProxy, which calls WebWorkerClientImpl (the original class).
In future changes, sandboxing, multiple worker processes etc will be added. Note that I also had to make two small changes to WebKit, since WorkerMessagingProxy couldn't be created as is for the nested worker case. I'll either check it in myself or work with Jian to do so.
Review URL: http://codereview.chromium.org/27157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10847 0039d316-1c4b-4281-b951-d872f2087c98
|