| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=46525
TEST=In the bug.
Review URL: http://codereview.chromium.org/2802005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements changes based on review feedback with Jeff. Validation icons should not appear in phone and fax input fields until text is input. Credit card expiration date year dropdown should list 10 years at most. CVC input fields are removed.
Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal.
BUG=46681, 46635, 46634
TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.*
Review URL: http://codereview.chromium.org/2873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This may change later, but in the meantime, this is what we want for
Japanese CrOS.
BUG=cros:2635 (http://crosbug.com/2635)
TEST=Change your UI language to Japanese and go to a web page specifying 'sans-serif', 'serif' or 'monospace' (wikipedia specifies 'sans-serif'). Make sure that IPAPGothic, IPAPMincho and IPAGothic are used.
Review URL: http://codereview.chromium.org/2821007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bottom-aligned.
Technically this does not center the icon like the bug asks; it
bottom-aligns it. However, the image in the icon itself is
top-aligned (has whitespace on the bottom). This change makes the
chevron line up with the center of bookmark button text next to it so
it looks correct.
BUG=http://crbug.com/45740
Review URL: http://codereview.chromium.org/2870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bubble object which implements WidgetWin).
TEST=none
BUG=9601
Review URL: http://codereview.chromium.org/2338001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SubjectAltName IDNs
Remove extraneous '\n' from ProcessGeneralNames.
BUG=43966
TEST=manual
Review URL: http://codereview.chromium.org/2733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib updates:
Toolbar.xib: Removed page menu and moved everything over to accomodate.
Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate.
BUG=45756
TEST=migration from having the pref hidden. It should become visible.
Review URL: http://codereview.chromium.org/2828005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3486
TEST=none
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/525
TEST=none
Review URL: http://codereview.chromium.org/2842003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modifies entry labels with trailing colon for Mac UI. Using correct validation icons now. Nib changes for AutoFillAddressSheet.xib and AutoFillCreditCardSheet.xib: rearranges labels and entry fields to right align on label colons. Changes label font to be regular size and regular weight.
BUG=46504
TEST=manual inspection of AutoFill UI.
Review URL: http://codereview.chromium.org/2842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the issues, but doesn't make the app launcher match the new style.
BUG=45745
TEST=Omnibox has endcaps, insides are aligned and padded correctly, dropdown looks good
Review URL: http://codereview.chromium.org/2721009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2736004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45743
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the Options dialog, in the Under the Hood section.
xib changes: added an enabled binding to the policy-controlled checkboxes in the "Under the Hood" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.
BUG=44394
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* Manual tests: Set the policies externally. Check that the checkbox in Options/Under the Hood/Privacy/search suggest... are disabled. Also check that the check box is set/unset as done by the policy.
Review URL: http://codereview.chromium.org/2746006
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if more than one keyboard are active.
BUG=chromium-os:3936
TEST=manual
Review URL: http://codereview.chromium.org/2787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44616
TEST=FormManagerTest.*
Review URL: http://codereview.chromium.org/2752010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
themes.
TBR=estade
BUG=45745, 45762, 45763
TEST=none
Review URL: http://codereview.chromium.org/2738011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erg
BUG=none
TEST=waterfall
Review URL: http://codereview.chromium.org/2711013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45763
TEST=visual
Review URL: http://codereview.chromium.org/2745017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
BUG=45745, 45762, 45763
TEST=none
Review URL: http://codereview.chromium.org/2731011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46195
TEST=None
Review URL: http://codereview.chromium.org/2737004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=45155
TEST=Run chrome with the --enable-apps flag.Install an app - the confirmation
dialog should say "..this App..." instead of "...this Extension...". Install an
extension - it should stil say "Extension".
Review URL: http://codereview.chromium.org/2730002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace name link with name+error message in content browser;
- Show an error message ChromeOS's openItem;
- Update SimpleErrorBox so that it runs in a Chrome window;
- Put back "Show in folder" in download page and make it work with content
browser;
BUG=chromium-os:1637
TEST=Verify fix for chromium-os:1637 and verify error message pops up for unknown type file in downloads ui.
Review URL: http://codereview.chromium.org/2748007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sets correct superclass in nib file. Specifically, AutoFillTableView subclasses NSTableView. This corrects Interface Builder warnings as it checks for proper outlets on target NSTableView.
BUG=46248
TEST=compile, check that warnings are gone.
Review URL: http://codereview.chromium.org/2736006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch.
BUG=45745,45762,45763
TEST=Reload and stop should be combined; go should be gone.
Review URL: http://codereview.chromium.org/2677003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45020
TEST=See http://crosbug.com/3487
Review URL: http://codereview.chromium.org/2716007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=45144
TEST=none
Review URL: http://codereview.chromium.org/2773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2727005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial.
BUG=27177
TEST=none
Review URL: http://codereview.chromium.org/2736001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
line. This will give more space for the update strings. Keeping things simple at this point since there are already threads on chromium-dev about redoing the aboutbox/about:version for updates in general.
BUG=38685
TEST=see bug
Review URL: http://codereview.chromium.org/2740009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original patch was written by mazda@chromium.org.
http://codereview.chromium.org/2778002/show
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncCustomize.xib changes: Added checkbox for extensions and hooked it up
via KVO to SyncCustomizeController.
BUG=32413
TEST=manual
Review URL: http://codereview.chromium.org/2714006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37129,38334
TEST=install sxs, check about box, about:version, start menu shortcut name
Review URL: http://codereview.chromium.org/2753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
already do.
This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.
BUG=none
TEST=Middle-click reload. It should reload the page in a new background tab.
Review URL: http://codereview.chromium.org/2779011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a sound mute icon and swap between sound high and mute icon based on
volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
a control button and "controlbutton" style sets its hight to 30px;
BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.
Review URL: http://codereview.chromium.org/2722006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed redundent version from update string.
Added a line break to the ChromeOS version on test builds to improve appearence
(select and drag to see complete version).
Added margins to multiline edit fields without borders to make them match
single line edit fields in positioning.
Fixed an issue with setting the initial focus for GTK based windows. This
fixes the problem of the cursor showing up in the version field.
BUG=chromium-os:3571 1589 2967
TEST=none
Review URL: http://codereview.chromium.org/2620003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth.
The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes.
I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler.
I had to fix ReplaceInfoBar on Windows as it was not working properly.
BUG=40828
TEST=Test thoroughly the translate feature.
Review URL: http://codereview.chromium.org/2602003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46111
TEST=none
Review URL: http://codereview.chromium.org/2785001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/2771004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use it for "Can't access your account" link.
BUG= http://crosbug.com/3179
TEST=Open "Can't access your account" link from "New User" view.
Review URL: http://codereview.chromium.org/2675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add "pp_if", "pp_ifdef" support to xtb's <if> expr;
- Use that to specify a wider width for options dialog for ChromeOS on it and da;
BUG=none
TEST=Verify options dialog tab headers are not truncaated on ChromeOS for it and da.
Review URL: http://codereview.chromium.org/2655003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fonts available on CrOS are different from fonts on typical Linux disributions.
BUG=cros:3815 (http://crosbug.com/3815)
TEST=Go to a web page that only specifies CSS generic families (e.g. sans-serif,serif, monospace) and make sure that Ascender Sans, Ascender Serif are used.
Review URL: http://codereview.chromium.org/2702001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2722003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32413
TEST=trybots
Review URL: http://codereview.chromium.org/2724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43423
TEST=Unit test in managed_prefs_banner_base_unittest.cc, manual UI tests
Review URL: http://codereview.chromium.org/2425006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add "sign out" button
* Let chrome crash when grab is borken.
* send ScreenIsLocked signal after all inputs are grabbed.
BUG=chromium-os:2914,chromium-os:2614
TEST=manual:
set the content of /var/lib/power_manager/use_xscreensaver to 1,
reboot the machine and login
hit ctr-alt-l to enter screenlock mode
1) typing in wrong password should show message bubble with error message
2) pressing "Sign out" will terminate the session and move to login screen
Review URL: http://codereview.chromium.org/2685006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Does not contain Cole's unified edit menu / zoom controls. This is just
scaffolding that should allow all the rest of the unified menu to exist, while
letting each platform implement the native-only portions in their platform
specific ways.
Only modifies the linux implementation to actually use the new model, though the command line flag and the new model should be shared between platforms.
BUG=45734,45757
TEST=Run with --new-wrench-menu on linux. Notice how long the unified menu is.
Review URL: http://codereview.chromium.org/2677006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45660
TEST=Chromium-->Preferences-->Under the Hood. Uncheck any one of the checkboxes. Click Reset to Defaults. Previous value gets restored.
Review URL: http://codereview.chromium.org/2702003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original patch was written by mazda@chromium.org.
http://codereview.chromium.org/2453003/show
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49042 0039d316-1c4b-4281-b951-d872f2087c98
|