| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- 35077: redesign and reimplement infobars and infobars delegates to merge before- and after-translate infobars into one, whose state transitions from before-translate to translating to after-translate
- 35080: modify gradient of blue infobar per roma (to differentiate from default chrome theme)
- 35052: fix white-pixel lines in infobar buttons by stretching image sets instead of tiling them
BUG=35052,35080,35077
TEST=verify per all bug reports.
Review URL: http://codereview.chromium.org/604001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35016
TEST=With --login-manager=network screen should be shown. Currently this screen is not used in wizard process. Network selection is not fully supported.
Review URL: http://codereview.chromium.org/570041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/596025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35157
TEST=Run chrome with --login-manager=create_accout and verify that screen
works as intended.
Review URL: http://codereview.chromium.org/600003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
together at the bottom.
BUG=35089
TEST=Clear browsing data dialog should look OK in Windows Classic
Review URL: http://codereview.chromium.org/600034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second half of http://codereview.chromium.org/597013.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for GTK, although GTK has not yet moved the Clear Data button to the third page of the options.
This also eliminates a number of not-referenced strings, and makes the options dialog shorter now that we have the space to do so.
BUG=35085
TEST=Open options dialog, look on second page, Import button should have no text above it.
Review URL: http://codereview.chromium.org/597013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
another for info NSView for local storage.
* Roll GTM r280:293
BUG=33068
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.
Review URL: http://codereview.chromium.org/599003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28184
TEST=None
Review URL: http://codereview.chromium.org/587013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34912
TEST=Open Content Settings dialog in Windows Classic theme and make sure there's a Flash Player link at the bottom.
Review URL: http://codereview.chromium.org/598001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34633
TEST=none
Review URL: http://codereview.chromium.org/589005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST="Save" is always enabled, if user changes address/CC label it changes to "Address"/"Credit Card" after saving
BUG=33026
Review URL: http://codereview.chromium.org/577037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Change connection from "commandDispatch:" to "commandDispatchUsingModifiers:" for home button.
BUG=34900
TEST=Enable home button in "Basics" in the prefs. Cmd-clicking the home button should open home page in new tab.
Review URL: http://codereview.chromium.org/582009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons.
o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later.
o Alters Toolbar.xib to use the new view class instead of a plain NSView.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/565048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- re-using views implementation, but removed layout related code
- add NotificationPanel
- added SetSize in BalloonViewHost. I needed this because I removed animation code and NativeViewHostGtk doesn't know about render view. I need to think a bit more to find out how to deal wit this.
It's using existing balloon collection, but we may need one for chromeos (or may not).
BUG=33306
TEST=none
Review URL: http://codereview.chromium.org/572018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All: Remove ellipses from IDS_PAGEINFO_CERT_INFO_BUTTON, as it does not require further action to display the info.
Add use_titlecase version.
Linux: Place button in the primary area instead of secondary to match HIG (I guess).
BUG=34425
TEST=read Gnome HIG (and MSDN "Command Buttons" guidelines), open Page Info for some page, compare
Review URL: http://codereview.chromium.org/561079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/575017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Right clicking on a text input field in Web content on OS X should now show a Writing Direction submenu. Clicking on "Left To Right" should align the input to the left, and "Right To Left" should do the opposit. The "Default" menu item should always be disabled.
Review URL: http://codereview.chromium.org/566031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34320
Review URL: http://codereview.chromium.org/575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(xib change: enable 'preserve selection' in NSOutlineView.)
BUG=33333
TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al
Review URL: http://codereview.chromium.org/566005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/34088
TEST=Open 'Personal Stuff' on XP in all locales (with complex scripts installed) and make sure the Themes options are visible.
Review URL: http://codereview.chromium.org/571007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix breakage caused by <http://src.chromium.org/viewvc/chrome?view=rev&revision=37819>.
Changed tags for File->{Save Page As..., Email Page Location, Print...} and View->Text Encoding.
BUG=34463
TEST=Check that File->Save Page As... (and Cmd-S), File->Email Page Location, and View->Text Encoding work properly.
Review URL: http://codereview.chromium.org/566033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checkmark icon next to Pause to alternating the words "Pause" and "Resume".
XIB change: unset the 'On Image' on the Pause button.
BUG=23069
TEST=Download large file and verify that the menu item says "Pause." Click "Pause" and the menu item should now say "Resume".
Review URL: http://codereview.chromium.org/563001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
month and year]
BUG=33026
TEST=should appear like in mocks, when dialog is finished
Review URL: http://codereview.chromium.org/566027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/561027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have a proper fix (r37722), we should revert this short term hack
(which didn't work in the end anyway).
BUG=33416
TEST=none
Review URL: http://codereview.chromium.org/562015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whitelist.
Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it.
This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that.
There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what.
BUG=33314
TEST=Go visit some sites with popups and play with things
Review URL: http://codereview.chromium.org/562013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Make sure the content exception dialog (options->under the
hood->content settings->exceptions (for all tabs)) and editor work
correctly. Specifically try adding/removing and make sure they persist
correctly.
Review URL: http://codereview.chromium.org/564007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Change "Focus Ring" from "Default" to "None" on both scroll view and contained table view.
This does not address the ring around the first column when tabbing through.
BUG=33699
TEST=Click row in table in task manager. The table should not have a focus ring.
Review URL: http://codereview.chromium.org/559004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows systems.
BUG=28176
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578
Review URL: http://codereview.chromium.org/542030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All I did was re-save in IB, no changes.
Review URL: http://codereview.chromium.org/557081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields).
BUG= 26974
TEST= Install an extension. Bubble should show same information as windows bubble.
Review URL: http://codereview.chromium.org/527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1426
TEST=Enable Chrome based login-manager. Login should work.
Review URL: http://codereview.chromium.org/553132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Omaha active user reporting.
BUG=33457
TEST=The dr value of "1" is written with length 4 bytes.
Review URL: http://codereview.chromium.org/548204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also rewrites the affected UI bits to make it easier to do this, get rid of unnecessary code, and be more consistent with the blocked content bubble code.
BUG=32719
TEST=Content settings windows now have radio buttons that work, and remember their settings. The Flash link works too.
Review URL: http://codereview.chromium.org/558060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton.
xib change: Make download item a DownloadItemButton instead of an NSButton.
BUG=15776
TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar.
Review URL: http://codereview.chromium.org/180036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hooked to anything, so they'll never appear.
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/556077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
processes on 64bit Windows systems.
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030
TBR=gregoryd@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Windows systems.
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31297
TEST=none for now.
Review URL: http://codereview.chromium.org/557060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Previously reviewed by sky as part of a larger change.
BUG=33314
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThemePack so we can release a dev channel.
Move new resources to the end so they don't modify current IDR ids that are now baked into BrowserThemePacks.
BUG=33416
TEST=Themes from previous dev channel work.
Review URL: http://codereview.chromium.org/551196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was nessessary to add a IPC Message with no Paramter for the reload frame
request to the webkit renderer and to add a menu string. The command should
only reload the frame clicked in for opening the context menu and let the
other parts of the webpage unmodified and unrefreshed.
BUG=3858
TEST=Try to click on "Reload Frame" in the context menu of a frame and see if that frame reloads.
Review URL: http://codereview.chromium.org/552126
Patch from alexander@sulfrian.net.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
available. For pt-PT and es-419, use pt-BR and es. For the rest of languages, fall back to the English page.
We can try a potentially better fallback (e.g using ru for uk and be), but it
also carries a risk. So, I'm leaving them alone.
Note that we cannot use '[GRITLANGCODE]' because Adobe uses a mix of language codes (e.g. 'en'), region codes ('cn', 'jp', 'kr', etc) and pseudo-region codes ('la') in their URLs.
BUG=NONE
TEST=NONE for now. Once the UI for flash setting help is added, start Chrome in one of languages whose xtb files are changed below and follow the link for the help on Flash settings. The flash help page should come up in that language.
TBR=tony
Review URL: http://codereview.chromium.org/551184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also add some error messages when login fails.
Review URL: http://codereview.chromium.org/549184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What works:
1. Layout (for the most part)
2. Editing and saving the items
What does not
1. Scroll
2. Delete/Add buttons
3. some layout quirks
4. collapsible editable sets.
BUG=33026
TEST=none for now.
Review URL: http://codereview.chromium.org/554081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Xib change: move left/right edges of outer splitview out 1 pixel.)
BUG=33119
TEST=none (visual appearance only)
Review URL: http://codereview.chromium.org/556048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37339 0039d316-1c4b-4281-b951-d872f2087c98
|