| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12762
TEST=Verify that buttons can be themed.
Review URL: http://codereview.chromium.org/119025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC
Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.
This add support for:
* An "SBX_D" environment variable in the renderers which is used to
signal the end of dynamic linking so that the chroot can be
enforced.
* A sandbox_host process, running outside the sandbox, to deal with
fontconfig requests from the renderers. See the wiki page for
the reasoning behind making it a separate process.
* A new, custom SkFontHost for Skia. Because this is Chrome
specific, it will live outside the upstream Skia tree. This
FontHost can be configured either to drive fontconfig directly
(for the browser process and for any unsandboxed renderers) or to
use an IPC system. Since the same SkFontHost has to be linked into
both the browser and renderer (they are the same binary), this
switch has to be made at run time.
Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.
http://codereview.chromium.org/112074
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A change in Breakpad upstream caused the custom key/value pairs we specified to no longer be sent to crash server (e.g. process type).
This change pulls in an upstream fix and causes our code to use new APIs to specify this information.
BUG=13131
TEST=Crash breakpad, look at crash dump on crash server, make sure pytpe field is present.
Review URL: http://codereview.chromium.org/119121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
additional height to accommodate the buttons (in XP classic mode). Some (like .te) needed additional width to accommodate the combobox.
BUG=11487
TEST=Open Clear Browsing Data dialog in all languages and make sure no control is being truncated/squished against another control.
Review URL: http://codereview.chromium.org/118191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box.
Review URL: http://codereview.chromium.org/119002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
match the toolbar, and making the button images transparent.
BUG=11703
TEST=Verify that the download bar matches the theme that is installed.
Review URL: http://codereview.chromium.org/119088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hood" view into the window.
BUG=13151
TEST=enabled portions of the user data panel.
Review URL: http://codereview.chromium.org/119060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Users with CursorXP or FontExporer crash in MessageBoxW
- leads to many crash reports within seconds
solution: eat the fatal exception and exit silently.
TEST = see the bug for instructions
BUG = 12162
Review URL: http://codereview.chromium.org/118148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
builds, so we can force it off when building the locale .dll files.
Ignore gyp-generated locales.sln file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the single download case.
BUG=11278
TEST=Start a big download, close Chrome. A dialog warning that a download is in progress should be shown. Check that the main text and button text use singular when referring to the download. Start several big downloads. Close Chrome, check the text now uses plural.
Review URL: http://codereview.chromium.org/119009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/119023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/119022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crash reports.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Change text.
* Make it so popup button title doesn't overlap OK button.
BUG=13093
Review URL: http://codereview.chromium.org/119003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13097
Review URL: http://codereview.chromium.org/118080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13097
Review URL: http://codereview.chromium.org/118079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12832
TEST=Either test new command line options (update-setup-exe, new-setup-exe) of setup.exe individually or get a mini_installer that has setup.exe patch only and make sure the installer still works.
Review URL: http://codereview.chromium.org/115866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new option fields to the "User Data" tab and reorganize the "Under the Hood"
to fit a better User Experience.
RELANDING http://codereview.chromium.org/113896
TBR=ben
Review URL: http://codereview.chromium.org/115971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/115968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
included in the issue.
Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience.
BUG=11435 (http://crbug.com/11435)
TEST=Opened the option dialog and checked if functional.
Review URL: http://codereview.chromium.org/113896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Uninstall Chromium and verify that the "also delete your browsing data" text looks right.
Review URL: http://codereview.chromium.org/112073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file.
BUG=none
TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance.
Review URL: http://codereview.chromium.org/112065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=visit about:crash, no dump file left over in /tmp.
Review URL: http://codereview.chromium.org/113984
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.
BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Initially these will be drop in replacements for the existing projects.
These were generated mechanically in lieu of a looping syntax.
Review URL: http://codereview.chromium.org/115853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben
BUG=11904
TEST=See bug, verify that home buttons don't look like provided image.
Review URL: http://codereview.chromium.org/115845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Cole. TBR=jnj
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add app_locale_settings and app_strings to all the locale dlls.
BUG=12309
Review URL: http://codereview.chromium.org/115820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
localizer subclass for the prefs window.
BUG=12534
TEST=make sure branding is correct on default browser button.
Review URL: http://codereview.chromium.org/115817
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
developer tools by default.
Review URL: http://codereview.chromium.org/117003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window.
BUG=10047
TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window.
Review URL: http://codereview.chromium.org/115789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be heightened just a bit.
BUG=11487
TEST=Open Clear Data Dialog on XP with Classic Theme and the button should not overlap the combo box.
Review URL: http://codereview.chromium.org/113880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11824
TEST=Run CHrome with '--lang=ta' with Firefox runing. Try to import bookmarks and settings
from Firefox into Chrome. The dialog box alerting that Firefox is running should not be truncated.
Review URL: http://codereview.chromium.org/113516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/113879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following errors when building unit_tests:
undefined reference to `google_breakpad::WriteMinidump(char const*, int, void const*, unsigned int)'
undefined reference to `UploadCrashDump(char const*, char const*, unsigned int)'
Review URL: http://codereview.chromium.org/113876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9607
TEST=Download a large file and go to the download manager (Ctrl+J). The
remaining time of your current downloads should decreasen as the download is
getting closer to being done.
Review URL: http://codereview.chromium.org/115797
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash handler should not print garbage to the console following the crash id.
Review URL: http://codereview.chromium.org/115796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This represents crash #8 of the 2.0.180 branch, likely to
be caused by people playing with themese or have downloaded
a DLL to replace the Chrome theme from somewhere other than
us. No repro-steps, so the best is to avoid the problem.
BUG=12160
TEST=none
Review URL: http://codereview.chromium.org/115523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Reenables fetching of settings from gconf.
-Moves all gconf access to happen from the UI thread only, (where
the default glib main loop runs).
-Adds support for gconf notifications, avoiding having to poll the settings.
-Fixes a small initialization glitch in the unittest. Plus minor code style tweaks.
-Permanently removes gdk and glib threading initialization calls that
were previously disabled.
-Slight reorganization of ProxyService creation to pass down the IO
thread MessageLoop.
BUG=11111
TEST=none
Review URL: http://codereview.chromium.org/113043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commits a rewrite of the Breakpad Linux client.
The old code:
* Had a number of plain bugs in it, but those could just have been
fixed.
* Allocated memory from the heap, which is a no go.
* Made libc calls which can enter the dynamic linker - another source
of crashes.
* Didn't understand some of the tricks needed, like clone() via libc
will write to random areas of memory because it assumes that it's
only called from libpthread
Additionally, we had one more requirement which meant changing the
interface:
* We need to be able to crash dump the renderers from the browser
process.
And that last one really needed a rewrite.
We intend to try and upstream this new code into Breakpad.
The new Breakpad design works like this:
When a renderer crashes, a signal handler runs on an alternative stack
and collects information about the registers of the thread before the
crash. Then we enter Chromium specific code an send a datagram message
to a magic file descriptor (4) containing:
* the registers and tid of the crashing thread
* the active URL
* a file descriptor to a socket
* a CREDENTIALS structure giving the PID of the renderer.
On the other end of the socket is an object on the IO thread
(render_crash_handler_host_linux.cc) which reads and parses the
datagram. The CREDENTIALS structure is validated by the kernel, so the
renderer can't lie about it's PID and try and get the browser to crash
dump the wrong process.
The browser then ptraces the renderer and extracts all the needed
information to write a minidump to a temp file. Then we write a byte
to the file descriptor which the renderer gave the browser in the
datagram and that's the signal to the renderer to finish dying. It
dies by sending itself the same signal which trigger the crash dump in
the first place, so it will appear to crash as normal as far as kernel
core dumps and waitpid are concerned.
The browser then constucts a MIME message in a temp file for upload to
the crash service. We then fork out to /usr/bin/wget to actually do
the upload (since Debian numbers suggest that 99.8% of users have wget
installed.) A second forked child unlinks the temp files once wget has
completed.
For a browser crash, everything works pretty much the same except that
the datagram step is omitted and we clone() off a process to ptrace
ourselves and write the minidump.
This code is only enabled in Chrome branded builds. Stub source files
are substituted in the case of a Chromium build.
http://codereview.chromium.org/115526
BUG=9646,10772
TEST=Build a Chrome branded binary. Send SEGV to a renderer and verify that wget output appears on stderr. Send a SEGV to the main binary and verify the same.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16719 0039d316-1c4b-4281-b951-d872f2087c98
|