summaryrefslogtreecommitdiffstats
path: root/chrome/browser/about_flags.h
Commit message (Collapse)AuthorAgeFilesLines
* Owner flags storage should not save the flags names but the actual switches.pastarmovj@chromium.org2013-09-161-1/+6
| | | | | | | | | | | | | These are directly applied by the session manager which can not resolve them. It fixed an issue with the flags stored in the device settings being the flag names and not the actual switches as is required by the session manager causing the flags not to be applied to the login screen if the flag and the switch don't happen to coincide and to browser restarts even for the owner which should not happen. BUG=280935 TEST=Unit tests + manual testing as described in the bug. Review URL: https://chromiumcodereview.appspot.com/23983031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223353 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 212794 "Migrate users from "WebKit" flag to "Web Platform"."haraken@chromium.org2013-07-211-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | > Migrate users from "WebKit" flag to "Web Platform". > > We changed the name of the "Experimental WebKit Features" flag, and changed > the actual flag at the same time[1]. I decided at the time to simply throw away > the old flag; I've been reliably informed that developers aren't particularly > thrilled with that decision. "Why have my experimental features stopped > working?" they ask. "Didn't you read my G+ post?" isn't a particularly helpful > answer, especially since most people (unbelievably!) don't follow me on > The Internets™. > > This patch hacks a migration system into about:flags, which I hope we never > ever have to use again, and can safely throw away after a release cycle or two. > > [1]: https://codereview.chromium.org/14940009/ > > R=jochen@chromium.org,thakis@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/19520007 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/19514003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212828 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate users from "WebKit" flag to "Web Platform".mkwst@chromium.org2013-07-201-0/+11
| | | | | | | | | | | | | | | | | | | | | We changed the name of the "Experimental WebKit Features" flag, and changed the actual flag at the same time[1]. I decided at the time to simply throw away the old flag; I've been reliably informed that developers aren't particularly thrilled with that decision. "Why have my experimental features stopped working?" they ask. "Didn't you read my G+ post?" isn't a particularly helpful answer, especially since most people (unbelievably!) don't follow me on The Internets™. This patch hacks a migration system into about:flags, which I hope we never ever have to use again, and can safely throw away after a release cycle or two. [1]: https://codereview.chromium.org/14940009/ R=jochen@chromium.org,thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/19520007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212794 0039d316-1c4b-4281-b951-d872f2087c98
* Restart Chrome if per session flags have been specified on ChromeOS.pastarmovj@chromium.org2013-06-171-0/+5
| | | | | | | | | | | | | | | | After the profile is loaded we verify if the user has specfied any flags or if there were flags specified per policy that differ from the user specfied flags and in either case restart Chrome with the desired flags. This allows non-owners to use the about:flags page and prevents policy set flags from leaking inside user sessions. BUG=221352 TEST=unit_tests & Manually by specifying flags in non-owner session and observing them respected. Review URL: https://chromiumcodereview.appspot.com/16770002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206832 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the storage layer out of about_flags.pastarmovj@chromium.org2013-06-121-6/+10
| | | | | | | | | | | | This step is a preparation for moving owner flags storage from local state to signed settings. BUG=221353 TEST=existing about_flags tests still pass. Review URL: https://chromiumcodereview.appspot.com/16542004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205854 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/a*-c*/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205335 0039d316-1c4b-4281-b951-d872f2087c98
* Create separate sections for available/unavailable flags. dcheng@chromium.org2013-05-201-2/+7
| | | | | | | | | | | | On Linux, searching for "this experiment is not supported" returns 23 results. To make it a little easier to navigate, create a separate section to list all the unsupported experiments. BUG=179649 Review URL: https://chromiumcodereview.appspot.com/12748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201015 0039d316-1c4b-4281-b951-d872f2087c98
* Add differentiation between owner only and common flags on ChromeOS.pastarmovj@chromium.org2013-04-181-2/+8
| | | | | | | | | | | | Some flags require to be active on the login screen and those can only be activated from the owner account. BUG=chromium-os:39248 TEST=Open about:flags from non-owner account and check that "ChromeOS (owner only)" flags are grayed out. Review URL: https://chromiumcodereview.appspot.com/13467023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194890 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor about_flags.cc to make defining enabled/disabled/default flags easier.asvitkine@chromium.org2013-02-251-2/+21
| | | | | | | | | BUG=177023 TEST=Unit tests. Review URL: https://chromiumcodereview.appspot.com/12326019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184458 0039d316-1c4b-4281-b951-d872f2087c98
* Add reset all button to flags pagejryans@chromium.org2013-02-201-0/+3
| | | | | | | | | | | | Adds a "Reset all to default" button at the top of the flags page to simplify getting all experiments back to their default state. BUG=139307 Review URL: https://chromiumcodereview.appspot.com/12276012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183357 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Checkpoint: android fixes towards compilation of unit_tests.jrg@chromium.org2012-01-211-2/+3
| | | | | | | | | | | | Dependent on clipboard.h change in https://chromiumcodereview.appspot.com/9264014 BUG=None TEST= Review URL: http://codereview.chromium.org/9226012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118567 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/values.h into the base namespace. This includes a cros DEPS rolldmazzoni@chromium.org2011-07-121-2/+5
| | | | | | | | | | with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
* Modify about:flags to support switches with values.gavinp@chromium.org2011-02-111-5/+9
| | | | | | | | | | | | | | about:flags right now doesn't support switches like "--foo=bar". It only handles simple switches like "--quux". The prerender feature has a few options, and to avoid confusing contradictory mixes of simple switches, we want to use valued switches. But for that, we'll need lab support. BUG=none TEST=AboutFlagsTest.* Review URL: http://codereview.chromium.org/6483015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74599 0039d316-1c4b-4281-b951-d872f2087c98
* Remove modality of MULTI_VALUE choice types in AboutFlagsgavinp@chromium.org2011-02-091-3/+4
| | | | | | | | | | | | | | | | | | | Previously the UI for multivalues in AboutFlags was confusing, since you could "enable" or "disable" the feature, then select an option from a combobox. This change removes this modality, and instead, the first option from the multivalue should be considered the "disabled" version of the lab (we even assert that it has no command line flags). This CL was originally http://codereview.chromium.org/6410082/ , but cbentzel suggested we split it up into two CLs: this is the first of them. BUG=none TEST=AboutFlagsTest.MultiValues Review URL: http://codereview.chromium.org/6413037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74277 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability for about:flags to use a select for choosing one of manysky@chromium.org2010-12-021-0/+40
| | | | | | | | | | | values, and wires this up for instant. BUG=none TEST=none Review URL: http://codereview.chromium.org/5451003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68022 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA reporting for about:flags usage.rsesek@chromium.org2010-11-181-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4910001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66638 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in about:flags where we weren't pruning experiments thatsky@chromium.org2010-10-261-0/+38
| | | | | | | | | | | are not enabled for the current platform but were at one point. BUG=60206 TEST=none Review URL: http://codereview.chromium.org/3989002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63952 0039d316-1c4b-4281-b951-d872f2087c98
* Enable about:flags in ChromeOS, part 1thakis@chromium.org2010-10-191-3/+0
| | | | | | | | | BUG=57634 TEST=Go to about:flags in ChromeOS. It should appear. Review URL: http://codereview.chromium.org/3896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63137 0039d316-1c4b-4281-b951-d872f2087c98
* about:flags: Fix disabling experiments.thakis@chromium.org2010-10-151-1/+13
| | | | | | | | | | | | | | | The problem was that the restart code would copy the switches added by about:flags to the restarted instance, so that e.g. --enable-expose-for-tabs would be passed on the the command line even though the experiment was disabled. Now the flags added by about:switches are explicitly removed before the restart. Also wrap the switches added by about:flags with --start-flags-switches and --end-flags-switches switches. These unknown switches are ignored, but are useful to see on about:version. Also add a bunch of unrelated unit tests. BUG=56314 TEST=See bug. Review URL: http://codereview.chromium.org/3813007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62777 0039d316-1c4b-4281-b951-d872f2087c98
* Rename about:labs to about:flags, part 3/3thakis@chromium.org2010-10-151-0/+36
This renames the cc and h files, and renames the --no-labs switch to --no-experiments BUG=59139 TEST=about:flags still works Review URL: http://codereview.chromium.org/3777005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62682 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 10:10:31 +0000