| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Windows high-contrast mode is on, pop up new bubble with links to a
high-contrast extension, a search for dark themes, a link to Learn More,
and a Close link to close the bubble. Only shows the first time, as before.
The pref is renamed because the previous behavior was reverted, and users
who got the previous bubble on dev/beta should see this one now.
BUG=112944
TEST=manual testing on Windows: Alt+Shift+PrtScr
TBR=ben
Review URL: http://codereview.chromium.org/10332016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of reverted CL http://codereview.chromium.org/10025039
Relanding this patch exposed a new issues on cros:
1) KioskModeTest.EnableKioskModeTest fails (did unrelated cleanup).
2) Some bubbles crash OnWidgetMove (make |move_with_anchor_| opt-in).
3) Some bubbles crash OnWidgetClosing (cache |anchor_widget_|).
2nd patch description:
Continuation of reverted CL http://codereview.chromium.org/10021029
The original CL was reverted due to a naming conflict between:
WidgetDelegate::OnWidgetMove and Widget::Observer::OnWidgetMove.
I renamed the new Observer method to OnWidgetMoved.
Original description:
Propagate OnNativeWidgetMove to delegate/observers, etc.
NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove.
Widgets alert delegates and new Widget::Observer::OnWidgetMove.
TabDragController2: consume new observer method, simplify.
Nix BrowserWindowMoveObserver; use Widget::Observer instead.
Replace move_loop_browser_view_ with move_loop_widget.
Replace GetAttachedBrowserView with GetAttachedBrowserWidget.
BubbleDelegateView: consume new observer method.
Make bubbles move with their anchor_view's Widgets.
SchedulePaint on BubbleFrameView when mirroring its arrow.
BUG=105151,116336,124310,124324,124352,chromium-os:29747
TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions.
Review URL: http://codereview.chromium.org/10162017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10119019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac.
BUG=122238
TEST=manually with VoiceOver.
Review URL: http://codereview.chromium.org/10054037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119981
R=saintlou@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9979009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new interface to listen for changes to system color changes,
which can be used in future changelists to fix other widgets that need
to recompute their color schemes when the user toggles high-contrast mode
on and off.
NTP is currently the only place in Chrome code that uses Windows theme
colors inside the web content area; update this to invert these colors
if we're also inverting the whole web content area.
BUG=112944
TEST=Press Alt+Shift+PrtScr on Windows to toggle high-contrast mode on/off.
Review URL: https://chromiumcodereview.appspot.com/9452033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98979
TEST=This is the test
Review URL: http://codereview.chromium.org/9652029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and CQ couldn't patch it. This is exact copy of the original CL to land.
* Move automation/ui_controls to ui/ui_controls
* Refactored aura impl so that ui/ui_controls doesn't depend on
aura.
* Moved MoveMouseToCenterAndPress to ui_test_util.h as it depends on views and can't be declared in ui.
* a couple of cleanups:
- Renamed gtk_screen_utils.h to _util.h to match other util.h files.
- indent fix
- remove unnecessary includes.
This CL allows a test to use ui_controls without depending on chrome.
TBR=sky@chromium.org,erg@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9699098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=117616
TEST=manual testing
Review URL: http://codereview.chromium.org/9665026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without knowing about content's internals.
From the embedders' point of view, this is done by splitting the
"tester" interface away from the RenderViewHost interface, rather than
extending the parallel interface/implementation hierarchy; see
comments on TestRenderViewHost for the rationale.
TBR=ben@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9645003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=98979
TEST=This is the test
Review URL: http://codereview.chromium.org/9652029
TBR=aaronlevbugs@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9667031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98979
TEST=This is the test
Review URL: http://codereview.chromium.org/9652029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl.
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostImpl for content.
TBR=darin@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert 123372 - Adds deps file for content/browser/accessibility/"
This reverts commit bc95a82163a28b9bf5b17685321a9bf8d6b55113.
TBR=dtseng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9516008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89191
TEST=This is the test itself
Review URL: http://codereview.chromium.org/9466026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fieldset to MSAA's ROLE_SYSTEM_GROUPING.
BUG=89191
TEST=Manually, with AViewer
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122805
Review URL: http://codereview.chromium.org/9427028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DumpAccessibilityTreeTest.PlatformTreeDifferenceTest fails:
..\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(106): error: Value of: actual_contents8
Actual: "|ROLE_SYSTEM_DOCUMENT||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n|IA2_ROLE_SECTION||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n"
Expected: expected_contents
Which is: "|ROLE_SYSTEM_DOCUMENT||IA2_STATE_OPAQUE|IA2_STATE_VERTICAL\n|IA2_ROLE_SECTION||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n"
Revert "Revert 122617 - Adds dump accessibility tree support in Windows."
This reverts commit ca8de581137b34eb04ca8b68186f143d4bea98e8.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9429026
TBR=dtseng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9454033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert 122617 - Adds dump accessibility tree support in Windows."
This reverts commit ca8de581137b34eb04ca8b68186f143d4bea98e8.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9429026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
TEST=none
Review URL: http://codereview.chromium.org/9424039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting@chromium.org
BUG=98716
Initial commit: 122753
Reverted (linux_chromeos_gtk build problem): r122755
Review URL: https://chromiumcodereview.appspot.com/9420007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
include paths.
TBR=pkasting@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9420007
TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9355042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9420007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This largely adds human readable strings for IAccessible2 roles and states.
This is in part to make it possible to hand-edit the expected files we generate.
Sidenote: switch to string16 usage from std::string as much as possible (despite the incompatibility with API's provided by FilePath).
Review URL: https://chromiumcodereview.appspot.com/9295031
TBR=dtseng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9425021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This largely adds human readable strings for IAccessible2 roles and states.
This is in part to make it possible to hand-edit the expected files we generate.
Sidenote: switch to string16 usage from std::string as much as possible (despite the incompatibility with API's provided by FilePath).
Review URL: https://chromiumcodereview.appspot.com/9295031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 of N.
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=104132,52928,100062,89762,82616,44668,44666,62537,69034,62538,81451,67301,62539,81451,69475,106538,84427,114104,103539,100538,109669,74557,96725,52544,68287,86105,89727,96725,95274,80961,83876
Review URL: http://codereview.chromium.org/9361066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Disables a couple more a11y tests that keey timing out."
commit 62165f0e7178d76ceb97b072dd92a258e4b7ecc7.
f2c91be6ded81a8f80700ecc08b5610e3fc89e7c.
TEST=try bots.
BUG=102725, 106957
Review URL: http://codereview.chromium.org/9373044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementations.
Various dependencies on the GTK version remain, as does a single,
probably easy-to-remove dependency on the Mac implementation.
Did this primarily as follows:
a) Enforce the intent, that RenderWidgetHostView instances are created
via factory function.
b) Migrated a couple of methods to the interface, skipping
implementation for platforms where not needed.
c) Added InitAsChild, with parent view parameter, to the interface so
that Windows initialization can go through interface. Incidentally,
this fixes bug 102450. As noted in the bug, the approach of passing a
parent view pointer is somewhat ugly as it isn't needed by all
platform-specific implementations, but I think it is acceptable.
TBR=owners (interface change LGTMed by owner, rest is trivial updates)
BUG=98716,102450
Review URL: https://chromiumcodereview.appspot.com/9281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
systemPrivate
BUG=chromium-os:24954
TEST=Build success
Review URL: http://codereview.chromium.org/9130002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
web_contents.h
BUG=98716
Review URL: http://codereview.chromium.org/9113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review.
I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9015022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8991012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds some basic infrastructure to dump the contents of the platform specific BrowserAccessibility* trees.
A subset of platform specific properties has not yet been added; the BrowserAccessibility::toString() will hold such a representation. For now, every node has it's contents dumped; we can possibly use the "id" html attribute to identify "test" nodes in the future.
The BrowserTreeDumpTest class generates a baseline when one is found and compares it to the live tree resulting from loading html from
chrome/test/data/accessibility.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8971006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17602
TEST=browser_tests --gtest_filter="ExtensionApiTest.GetAlertsForTab"
Review URL: http://codereview.chromium.org/8956009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9007026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to provide more helpful spoken feedback when focusing
a toolbar button or infobar button - e.g. it can now read the full text of
the infobar when you move focus to any of its buttons.
BUG=106724
TEST=Adds new unit tests; will need new ChromeVox push to test manually.
Review URL: http://codereview.chromium.org/8850004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=106957
TEST=none
R=dmazzoni@chromium.org
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/8893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=106957
TEST=none
R=dmazzoni@chromium.org
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/8890063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
dependencies to content. We want code that tests content to live alongside the code its testing. Also, some of these depend on view_messages.h, which is internal to content.
BUG=98716
Review URL: http://codereview.chromium.org/8804001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They caused http://crbug.com/106304
BUG=99629
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/8793001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8775059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
related methods. Scrolling currently only handles the main frame, though
it's designed to be extended to support scrolling any scrollable container
shortly. Setting the text selection is only implemented for <input>
elements, pending WebKit enhancements.
BUG=104468,104469
TEST=Adds new test for scrolling logic, manual testing with accProbe.
Review URL: http://codereview.chromium.org/8770021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=try bots (win,mac,linux,linux_chromeos)
Review URL: http://codereview.chromium.org/8718005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/borwser/accessibility
BUG=104942
TEST=try bots (win, mac, linux, linux_chromeos)
Review URL: http://codereview.chromium.org/8713009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110949
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8598031
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8547015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than one of them has now flaked as per bug 104132.
TBR=dmazzoni@chromium.org
BUG=104132
Review URL: http://codereview.chromium.org/8568009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110090 0039d316-1c4b-4281-b951-d872f2087c98
|