summaryrefslogtreecommitdiffstats
path: root/chrome/browser/accessibility
Commit message (Collapse)AuthorAgeFilesLines
* Rework UMAHistogramHelper and StatisticsDeltaReader into ↵mlerman@chromium.org2014-08-211-3/+2
| | | | | | | | | | | | | | | [Chrome]HistogramTester. Design Doc (Googlers Only): https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit BUG=384011 TBR=timsteele@chromium.org Review URL: https://codereview.chromium.org/379283002 Cr-Commit-Position: refs/heads/master@{#291207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
* Added accessible name to bookmark_bar_instructions_view.evy@chromium.org2014-07-254-1/+24
| | | | | | | | | | | The state is now taken from the label with the instructions within the bookmark bar. Now an empty bookmark bar's label is accessible. BUG=395895 Review URL: https://codereview.chromium.org/408103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285704 0039d316-1c4b-4281-b951-d872f2087c98
* Remove many instances of CreateBooleanValue.estade@chromium.org2014-07-171-2/+2
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/399493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283659 0039d316-1c4b-4281-b951-d872f2087c98
* Implement accessible states and notifications for the tab strip.dmazzoni@chromium.org2014-07-101-1/+1
| | | | | | | | | | | | | | | | | | | This change just exposes information about what tabs are selected and fires proper notifications when tab selection changes. This will allow screen readers to announce when switching tabs even if the web content doesn't have focus. It's also a good first step towards making the tab strip fully accessible too (e.g. making it possible to perform operations on multiple tabs with just the keyboard). As part of this change I renamed the "selection changed" event to "text selection changed" so that there's no confusion between the text-selection-related events, and tab/list selection events. BUG=100412 Review URL: https://codereview.chromium.org/349033010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282396 0039d316-1c4b-4281-b951-d872f2087c98
* Make Views fire an accessible hover event on mouse enter.dmazzoni@chromium.org2014-05-292-0/+15
| | | | | | | | | | | | This is used for touch accessibility on Chrome OS, see bug. Fires the AX event on mouse enter and passes this through to the accessibilityPrivate API for ChromeVox. BUG=377043 Review URL: https://codereview.chromium.org/297133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273529 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup extension_service.hrdevlin.cronin@chromium.org2014-05-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If the Broken Window Theory holds true, then ExtensionService will never be cleaned up (and will, in fact, degrade faster than we can fix it) if it looks like it's messy. So, let's clean house! - Group overriden methods together, say what they override. - Move all comments to the original method declaration (i.e., if it's overriden from ExtensionServiceInterface, comment there). - Move accessors together. - Move for_test methods together. - Move methods which are not used publicly into private:. - Move simple getters/setters from the .cc to the .h. - Remove FRIEND_TESTs that should not be there. - Remove unneeded forward class declarations. - Remove unneeded includes.* *This one led to a BUNCH of fixes in other files, which relied on the transitive includes of extension_service.h. Sorry for the noise. BUG=351891 TBR=jochen@chromium.org (for every header file change - they're only fixing transitive includes) Review URL: https://codereview.chromium.org/296073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273424 0039d316-1c4b-4281-b951-d872f2087c98
* infobars: Componentize ConfirmInfoBarDelegate.tfarina@chromium.org2014-05-221-1/+1
| | | | | | | | | | | | | | | | | | Changes: 1- Change it to use ui_strings.h 2- Use IDS_APP_OK and IDS_APP_CANCEL from ui_strings. 3- Move to components/infobars/core from chrome/browser/infobars (done with tools/git/move_source_file.py). BUG=373234 TEST=chrome still links and run fine. R=droger@chromium.org, pkasting@chromium.org TBR=ben # for trivial chrome/ changes Review URL: https://codereview.chromium.org/289083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272036 0039d316-1c4b-4281-b951-d872f2087c98
* components: Extract pref_registry component out of user_prefs.tfarina@chromium.org2014-05-151-1/+1
| | | | | | | | | | | | | | | The reason for doing this is that user_prefs depends on content_browser, which brings a lot of extra dependencies that takes a lot of time to build (yeah, I'm looking at you Blink and V8) and bookmarks is one of the targets that should not depend on content. BUG=359565 TEST=green trybots R=blundell@chromium.org, sky@chromium.org, yoz@chromium.org Review URL: https://codereview.chromium.org/271793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270722 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Rename experimental.accessibility to accessibilityPrivatedmazzoni@chromium.org2014-05-093-34/+32
| | | | | | | | | | | | | | | The only difference from the original change is a fix to manifest_guest.json to prevent ChromeVox from breaking in guest mode. (I also added a new test to cover that scenario and prevent future regressions.) Original code review: https://codereview.chromium.org/106973003 BUG=278540,362442 TBR=thakis Review URL: https://codereview.chromium.org/268823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269243 0039d316-1c4b-4281-b951-d872f2087c98
* Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImplkalman@chromium.org2014-04-302-8/+8
| | | | | | | | | | | | function doesn't require divergent return value semantics depending on subclass. BUG=365732 R=rockot@chromium.org TBR=pkasting@chromium.org,dtseng@chromium.org Review URL: https://codereview.chromium.org/252653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267083 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rename experimental.accessibility to accessibilityPrivate"dtseng@chromium.org2014-04-293-28/+27
| | | | | | | | | | | | | | | This reverts commit 5d76e14014f504a496e111ecf23a433f1bbd5897. Original review: https://codereview.chromium.org/106973003 BUG=362442,278540 TBR=dmazzoni TEST=Manually verify ChromeVox starts on guest mode. NOTRY=true Review URL: https://codereview.chromium.org/258063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266737 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Fix a bunch of random style cleanups and lint errors.thestig@chromium.org2014-04-231-3/+3
| | | | | | Review URL: https://codereview.chromium.org/246403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265580 0039d316-1c4b-4281-b951-d872f2087c98
* Move Infobars core files to the Infobars componentdroger@chromium.org2014-04-182-2/+2
| | | | | | | | | | | | | | | This CL sets up the directory structure for the Infobars component and the infobars_core target. It also does a simple code move to the compoonent. This CL does not move ConfirmInfoBarDelegate because it still has a dependency on chrome/ (for strings). BUG=354379 TBR=sky, reed Review URL: https://codereview.chromium.org/240193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264792 0039d316-1c4b-4281-b951-d872f2087c98
* Use EventRouter instead of ExtensionSystem::Get->event_router()limasdf@gmail.com2014-04-171-7/+9
| | | | | | | | BUG=362672 Review URL: https://codereview.chromium.org/239453011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264478 0039d316-1c4b-4281-b951-d872f2087c98
* InfoBarService inherits from InfoBarManagerdroger@chromium.org2014-04-101-5/+3
| | | | | | | | | | | | | This allows to change the implementation of InfoBarDelegate::web_contents() such that it no longer calls InfoBarManager::web_contents() (which will be removed), but InfoBarService::web_contents() instead. BUG=354379 TBR=jochen Review URL: https://codereview.chromium.org/228293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262976 0039d316-1c4b-4281-b951-d872f2087c98
* Rename experimental.accessibility to accessibilityPrivatedmazzoni@chromium.org2014-04-033-27/+28
| | | | | | | | | | | We can land this after cl/57741007 is landed and rolled into Chrome first. BUG=278540 Review URL: https://codereview.chromium.org/106973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261291 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unused accessibility constants.thestig@chromium.org2014-04-022-11/+0
| | | | | | | | Found by Scythe. Review URL: https://codereview.chromium.org/217323007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261030 0039d316-1c4b-4281-b951-d872f2087c98
* Split InfoBarService core code into InfoBarManagerdroger@chromium.org2014-04-011-3/+5
| | | | | | | | | | | | | | | | | | | InfoBarService is now responsible for associating an InfoBarManager to a Tab and handling the interactions with the rest of chrome (notifications, navigation events). InfoBarManager has the core logic for infobar management. It owns the list of infobars. Eventually InfoBarManager will no longer rely on content/, but for now it still has a reference to a WebContents instance. This reference was kept for now to minimize the size of the change, but will be removed in a future CL. BUG=354379 TBR=jochen Review URL: https://codereview.chromium.org/211273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260847 0039d316-1c4b-4281-b951-d872f2087c98
* Use SYZYASAN instead of ADDRESS_SANITIZER.chrisha@google.com2014-03-271-2/+2
| | | | | | | | | | | We've seen different failure related to the fact that we use the same flag without providing the same API and functionality. BUG= TBR=jamesr Review URL: https://codereview.chromium.org/212643015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259855 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionHost from src/chrome to src/extensionsjamescook@chromium.org2014-03-211-1/+1
| | | | | | | | | | | | | | | | | | | This breaks another src/extensions -> src/chrome dependency. * Mechanical file move. * Clean up DEPS. * Move pinch-to-zoom handling to ExtensionViewHost as it only applies to visible extension content. No functional changes. BUG=321341 TEST=browser_tests *Extension* TBR=sky@chromium.org for header file rename across chrome/browser Review URL: https://codereview.chromium.org/198703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258494 0039d316-1c4b-4281-b951-d872f2087c98
* Move ui/base/accessibility to ui/accessibility.dmazzoni@chromium.org2014-02-254-26/+26
| | | | | | | | | | | | | | | Gets rid of the enums defined in accessibility_types.h and switches to the enums defined in ui/accessibility/ax_enums.h, which are shared by "content". Eventually, content and views may share more common accessibility code, but moving to the same enums is a good first step. BUG=316726 R=piman@chromium.org, sky@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/126763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253207 0039d316-1c4b-4281-b951-d872f2087c98
* No longer observe listener addition/removal in ChromeVox unload.dtseng@chromium.org2014-02-031-1/+1
| | | | | | | | | | | | | | This simplifies the unload codepath for ChromeVox. - remove event listener observer - remove loaded ChromeVox profile tracking - send events to ChromeVox for load using lazy dispatch TEST=Manual. Verify load speaks "ChromeVox, spoken feedback enabled" the first time only. BUG=339775,332461 Review URL: https://codereview.chromium.org/151093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248439 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.yoz@chromium.org2014-01-301-1/+1
| | | | | | | | | | | | | This moves ExtensionSystem to extensions/browser. It also moves setting the channel for Features to ChromeExtensionsBrowserClient. It also removes the duplicate ExtensionSystem::GetForBrowserContext. BUG=337707 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/147923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of UTF conversions in chrome/browser to use the base:: ↵avi@chromium.org2013-12-241-1/+1
| | | | | | | | | | | | namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/109013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242447 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-233-25/+33
| | | | | | | | | | | BUG=88666 TEST=no change R=brettw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/106433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242387 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar system refactor.pkasting@chromium.org2013-12-061-2/+2
| | | | | | | | | | | | | | | | | | | This changes the ownership model of infobars so that InfoBars are long-lived and own their InfoBarDelegates directly. The InfoBarService pseudo-owns the InfoBars (instead of deleting them directly, it tells them when they're unowned and expects them to delete themselves). This fixes leaks when infobars are closed while not visible (e.g. in a background tab) and in general makes the system clearer and easier to reason about. BUG=62154 TEST=none TBR=sky Review URL: https://codereview.chromium.org/103993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239110 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16.brettw@chromium.org2013-12-041-1/+2
| | | | | | | | | | This updates portions of chrome/browser/... to use the base namespace. BUG= Review URL: https://codereview.chromium.org/105193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 238283 "Infobar system refactor."tonyg@chromium.org2013-12-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Crashes on android BUG=325216 > Infobar system refactor. > > This changes the ownership model of infobars so that InfoBars are long-lived and > own their InfoBarDelegates directly. The InfoBarService pseudo-owns the > InfoBars (instead of deleting them directly, it tells them when they're unowned > and expects them to delete themselves). > > This fixes leaks when infobars are closed while not visible (e.g. in a > background tab) and in general makes the system clearer and easier to reason > about. > > BUG=62154 > TEST=none > R=erg@chromium.org, sail@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/22694006 TBR=pkasting@chromium.org Review URL: https://codereview.chromium.org/102163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238402 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar system refactor.pkasting@chromium.org2013-12-031-2/+2
| | | | | | | | | | | | | | | | | | | This changes the ownership model of infobars so that InfoBars are long-lived and own their InfoBarDelegates directly. The InfoBarService pseudo-owns the InfoBars (instead of deleting them directly, it tells them when they're unowned and expects them to delete themselves). This fixes leaks when infobars are closed while not visible (e.g. in a background tab) and in general makes the system clearer and easier to reason about. BUG=62154 TEST=none R=erg@chromium.org, sail@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/22694006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238283 0039d316-1c4b-4281-b951-d872f2087c98
* Added basic accessibility to TreeView.zelidrag@chromium.org2013-12-024-0/+96
| | | | | | | | | BUG=322729 TEST=manual with ChromeVox Review URL: https://codereview.chromium.org/79543010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238047 0039d316-1c4b-4281-b951-d872f2087c98
* Move EventRouter to src/extensions/browserjamescook@chromium.org2013-11-211-1/+1
| | | | | | | | | | | | | | | | Now that its dependencies on Profile, ActivityLog, RuntimeAPI and WebRequestAPI have been removed it can move into the extensions module. This is part of the AppShell extensions refactoring project. BUG=316367 TEST=compiles R=yoz@chromium.org TBR=mukai@chromium.org for mechanical file move in c/b/notifications, dmazzoni@chromium.org for mechanical file move in accessibility code Review URL: https://codereview.chromium.org/78483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236549 0039d316-1c4b-4281-b951-d872f2087c98
* Allow controls other than windows to send alert accessibility events.plundblad@chromium.org2013-11-181-0/+4
| | | | | | | | | | | | | This makes battery alerts and network state change notifications emit spoken (and braille) feedback again and fixes a crash on ash debug builds when accessibility is enabled. BUG=310766 R=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/74083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235764 0039d316-1c4b-4281-b951-d872f2087c98
* Allows views of role "menu" to receive focus events.dtseng@chromium.org2013-11-131-0/+3
| | | | | | | | | | | This fix is not meant to redo the API, but simply to make it so ChromeVox can verbalize this important control. We should note the issues with this API in terms of indicating the caller's intent and some underlying assumptions made about what events can be fired on what roles. BUG=318463 TEST=Ensure that the "apps" wrench menu gets announced by ChromeVox. Review URL: https://codereview.chromium.org/71863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234949 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a new "AccessibilityAlertInfo" event and removes ↵dtseng@chromium.org2013-11-134-1/+20
| | | | | | | | | | | AccessibilityManager::Speak and AccessibilityManager::MaybeSpeak. BUG=316710 TEST=Sign in and observe output in both braille and speech. Review URL: https://codereview.chromium.org/66583007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234876 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionTabUtil into extensions namespacerdevlin.cronin@chromium.org2013-11-131-7/+7
| | | | | | | | | | | | | | | | | BUG=117261 TBR=dmazzoni@chromium.org (accessibility) TBR=jam@chromium.org (automation) TBR=pkasting@chromium.org (infobars, ui/views) TBR=thakis@chromium.org (ui/cocoa) TBR=erg@chromium.org (ui/gtk) TBR=jennb@chromium.org (ui/panels) No functional changes, just a namespace move Review URL: https://codereview.chromium.org/23618040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234715 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/common/extensions/background_info.h to src/extensionsjamescook@chromium.org2013-11-091-1/+1
| | | | | | | | | | | | | | | | This is part of a refactor to extract extensions code from Chrome. To allow the move: * Extract extensions::file_util from extension_file_util.h/cc * Move switches::kAllowHTTPBackgroundPage to extensions/common/switches.h BUG=316218 TEST=compiles, unit_tests TBR=ben@chromium.org for mechanical header file renames across chrome/browser Review URL: https://codereview.chromium.org/65123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234065 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust ChromeVox (spoken feedback) strings and make it possible for announcemendtseng@chromium.org2013-11-052-0/+45
| | | | | | | | | | | | ts to occur directly in the extension. BUG=261451 TEST=On Aura, rapidly turn ChromeVox on and off (on login/locked screen, user s creens). Verify behaviors in above bug are true. Depends on a ChromeVox change. Review URL: https://codereview.chromium.org/42743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Profile dependency from ExtensionFunctionbenwells@chromium.org2013-10-282-7/+14
| | | | | | | | | | | | | This instead creates new variants of ExtensionFunction for Chrome APIs, which need Profile, and uses them for any API that needs to access Profiles. TBR=sky@chromium.org BUG=297942 Review URL: https://codereview.chromium.org/35893010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231406 0039d316-1c4b-4281-b951-d872f2087c98
* JSON/IDL Compiler now generates event names as of r215660. Use these ↵DHNishi@gmail.com2013-08-202-15/+21
| | | | | | | | | | generated event names instead of custom constant strings. BUG=268380 Review URL: https://chromiumcodereview.appspot.com/23013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218378 0039d316-1c4b-4281-b951-d872f2087c98
* Remove notifications from Accessibility APIcaitkp@chromium.org2013-08-174-89/+128
| | | | | | | | | | TBR=darin@chromium.org BUG=268984 TEST= no change Review URL: https://chromiumcodereview.appspot.com/22922003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218171 0039d316-1c4b-4281-b951-d872f2087c98
* Move kEnableExperimentalExtensionApis switch to extensions/common/switches.cc.yoz@chromium.org2013-07-311-2/+2
| | | | | | | | | | | Remove it from a lot of API tests that don't need it anymore. BUG=162530 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/20593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214836 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Ash browser tests by detecting command-line switch rather than OS ↵gab@chromium.org2013-07-311-5/+3
| | | | | | | | | | | | | | version. The original intent by disabling them per OS version was that regular browser tests don't run on win8_aura bots anyways... but this also makes it annoying as devs on Win8+Aura now can't run these tests as "regular" browser tests... Disable those tests by detecting the --ash-browsertests command-line flag instead. BUG=262796 Review URL: https://chromiumcodereview.appspot.com/21112003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214488 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing Ash browser_tests (on win8: browser_tests.exe ↵gab@chromium.org2013-07-221-0/+9
| | | | | | | | | | | | | | --ash-browsertests) Ran the tests locally and disabled all failing tests (I think...), will run a second pass locally and then we can push them on the waterfall Temporarily disabled tests are tracked @ https://docs.google.com/a/google.com/document/d/110YdKCAj3MxECZcW3iwYLjgTdzs2aZicLeA8OrC20Zo/edit BUG=179830, 262796 Review URL: https://chromiumcodereview.appspot.com/19697010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212940 0039d316-1c4b-4281-b951-d872f2087c98
* Updates some includes of chrome_notification_types.hjam@chromium.org2013-07-112-2/+2
| | | | | | | | TBR=brettw Review URL: https://codereview.chromium.org/18640003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211261 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup:pkasting@chromium.org2013-07-111-2/+1
| | | | | | | | | | | | | | | * Shorten code * Eliminate using directives * Rename "infobar" to "delegate" in a few places for clarity * Add a few DCHECKs BUG=none TEST=none R=dmazzoni@chromium.org, isherman@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/18209021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211254 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/, part 1.avi@chromium.org2013-06-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15789014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205122 0039d316-1c4b-4281-b951-d872f2087c98
* [InfoBar] Add InfoBarDelegate::GetIconID()dfalcantara@chromium.org2013-05-161-1/+1
| | | | | | | | | | | | | | | | | | | | | Splits apart the GetIcon() call to allow accessing the ID of the resource in addition to the loaded image. This is needed so that the Android port can determine which of the Java-side resources it needs to load for its UI. * GetIconID() is a function that gets overridden by subclasses instead of GetIcon(). GetIconID() returns the IDR_* tag that represents the icon that it would normally load. * GetIcon() now calls GetIconID() and shouldn't be overridden. * Small change to the SimpleAlertInfoBarDelegate::Create() call to account for invalid icon IDs (was NULL for bitmaps, 0 for non-existent icons). BUG=237034 Review URL: https://chromiumcodereview.appspot.com/15067008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200598 0039d316-1c4b-4281-b951-d872f2087c98
* components: Move PrefRegistrySyncable into user_prefs namespace.tfarina@chromium.org2013-05-062-5/+8
| | | | | | | | | | BUG=180785 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/14622003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198384 0039d316-1c4b-4281-b951-d872f2087c98
* Makes native and extension-based accessibility mutually exclusive.dtseng@chromium.org2013-05-032-0/+24
| | | | | | | | BUG= Review URL: https://chromiumcodereview.appspot.com/14473011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198196 0039d316-1c4b-4281-b951-d872f2087c98
* Formatting cleanup. Should be no code change.pkasting@chromium.org2013-05-031-0/+1
| | | | | | | | | | | | | | | * Don't define complex functions inline * Use DISALLOW_COPY_AND_ASSIGN where appropriate * Make consistent the headers on sections of a class declaration or .cc file * Use two newlines between major sections of a .cc file BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/14619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198027 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 20:06:20 +0000