summaryrefslogtreecommitdiffstats
path: root/chrome/browser/accessibility
Commit message (Collapse)AuthorAgeFilesLines
* Return proper and VoiceOver expected AXValue for radiobuttons.dtseng@chromium.org2011-03-221-1/+2
| | | | | | | | | R=dmazzoni@chromium.org,ctguil@chromium.org BUG=76836 TEST=manually with VoiceOver. Review URL: http://codereview.chromium.org/6675012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78948 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build (tested on trybots this time!).dmazzoni@chromium.org2011-03-141-1/+1
| | | | | | | | | | | | | | | | | | | | | Move AccessibleViewState constructor into a .cc file. Add dependency on ui/base to views_unittests so that it actually compiles source files in ui/base. Rename WindowDelegate::GetAccessibleState to WindowDelegate::GetAccessibleWindowState so that it doesn't conflict with View::GetAccessibleState in BrowserView, which inherits from both. This was a real bug, introduced recently because both GetAccessibleState methods were renamed from previous non-conflicting method names. BUG=none TEST=none Review URL: http://codereview.chromium.org/6691009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78052 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeViewAccessibilityWin from the views namespace becausedmazzoni@chromium.org2011-03-141-1/+1
| | | | | | | | | | | VS2005 doesn't allow an ATL::CComObject symbol in a namespace. BUG=none TEST=build on VS2005, VS2008 Review URL: http://codereview.chromium.org/6685049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78038 0039d316-1c4b-4281-b951-d872f2087c98
* Fix handling of case where the same AccessibilityObject appears as admazzoni@chromium.org2011-03-143-0/+38
| | | | | | | | | | | | child of more than one parent. Add some additional DCHECKs so that such a problem would be caught even earlier if they were to reoccur. BUG=75496 TEST=Addes new browser test CrossPlatformMultipleInheritanceAccessibility2 Review URL: http://codereview.chromium.org/6683010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78025 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Refactor Views accessibility.dmazzoni@chromium.org2011-03-141-5/+8
| | | | | | | | | BUG=74988 TEST=none Review URL: http://codereview.chromium.org/6581010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78006 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove renderer_id as well child_id in ↵ctguil@chromium.org2011-03-113-4/+5
| | | | | | | | BrowserAccessibilityManager::Remove Review URL: http://codereview.chromium.org/6683004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77892 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TreeNode::GetChildCount to TreeNode::child_count. Part 3.tfarina@chromium.org2011-03-103-14/+6
| | | | | | | | | | | | This is part of a serie of patches to make the TreeNode API more closer to style used in the Views Tree API (see views/view.h for reference). BUG=None TEST=existing unit_tests. Review URL: http://codereview.chromium.org/6639015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77592 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TreeNode::GetParent() to TreeNode::parent(). Part 2tfarina@chromium.org2011-03-084-6/+6
| | | | | | | | | | | | This is part of a serie of patches to make the TreeNode API more closer to style used in the Views Tree API (see views/view.h for reference). BUG=None TEST=None Review URL: http://codereview.chromium.org/6626076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77366 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-082-4/+4
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Move virtual method implementation from .h to .cc to fix clang builddmazzoni@chromium.org2011-03-082-1/+5
| | | | | | | | | | | failure. BUG=none TEST=none Review URL: http://codereview.chromium.org/6625088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77320 0039d316-1c4b-4281-b951-d872f2087c98
* Browser accessibility improvements so that screen readers can access moredmazzoni@chromium.org2011-03-0814-175/+831
| | | | | | | | | | | | | | | | | | | | | | | | | | complicated webpages without problems. First, WebAccessibility now works around a "multiple inheritance problem" in WebCore::AccessibilityObject where the same node appears as a child of multiple parents. For example, a table cell appears as a child of both a row and a column. This is solved by having each WebAccessibility parent check whether the child lists itself as an ancestor. If not, it notes the child's id only in a separate vector, so each child appears fully only once. Second, BrowserAccessibility now has internal reference counting, which allows BrowserAccessibilityManager to update any subtree while maximally reusing as many objects as possible. This fixes many screen reader interaction problems! All of this new functionality is tested with new cross-platform tests. BUG=67192 BUG=67620 TEST=Adds new unit tests and a browser test. Review URL: http://codereview.chromium.org/6625042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77316 0039d316-1c4b-4281-b951-d872f2087c98
* Rename IndexOfChild to GetIndexOf. Part 1tfarina@chromium.org2011-03-081-2/+2
| | | | | | | | | | | | This is part of a serie of patches to make the TreeNode more closer to style used in the Views Tree API (see views/view.h for reference). BUG=None TEST=None Review URL: http://codereview.chromium.org/6623037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77295 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowDelegate and NonClientView creation and management to Window.ben@chromium.org2011-03-071-5/+5
| | | | | | | | | | | This makes WindowGtk/WindowWin a little uglier for now, will improve with consolidation of more functions into Window. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6621033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77194 0039d316-1c4b-4281-b951-d872f2087c98
* Put file_system messages in their own file and move them to content, in ↵jam@chromium.org2011-03-071-0/+1
| | | | | | | | | preparation of moving child_thread. TBR=avi Review URL: http://codereview.chromium.org/6624066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77193 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-041-12/+13
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76825 - Refactor Views accessibility.jcivelli@chromium.org2011-03-041-8/+5
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6581010 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6612035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76844 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Views accessibility.dmazzoni@chromium.org2011-03-031-5/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6581010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76825 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of temporary render_view_host.h.jam@chromium.org2011-03-021-2/+2
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76477 0039d316-1c4b-4281-b951-d872f2087c98
* views: Organize all the bookmark UI files into the ↵tfarina@chromium.org2011-03-011-2/+2
| | | | | | | | | | | chrome/browser/ui/views/bookmarks/ directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6594067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76450 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on Views::Window from platforms that don't support it.estade@chromium.org2011-02-241-3/+5
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/6581015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75953 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of chrome\browser\renderer_host\test alongside their source. ↵jam@chromium.org2011-02-241-0/+204
| | | | | | | | Most of them went to content\browser\renderer_host. Review URL: http://codereview.chromium.org/6575009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75824 0039d316-1c4b-4281-b951-d872f2087c98
* Implement support for special offset constants in IAccessibleText methods.dmazzoni@chromium.org2011-02-181-1/+9
| | | | | | | | | | | This allows JAWS to fully support text editing. BUG=none TEST=manual testing with JAWS screenreader Review URL: http://codereview.chromium.org/6469037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75418 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix for problems with editable text field accessibility by not sendingdmazzoni@chromium.org2011-02-181-2/+0
| | | | | | | | | | | | children of text fields from the renderer to the browser. The child containing the text appeared to be redundant anyway. BUG=none TEST=updated unit test, manual testing with screen readers Review URL: http://codereview.chromium.org/6469038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75416 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74693. Changing approach.ben@chromium.org2011-02-141-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74849 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Widgetwin->NativeWidgetWinben@chromium.org2011-02-111-1/+0
| | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6510001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74693 0039d316-1c4b-4281-b951-d872f2087c98
* Don't include render_message_params.h from headers.jam@chromium.org2011-02-106-13/+15
| | | | | | Review URL: http://codereview.chromium.org/6479002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74401 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-091-6/+6
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74362 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74118 - Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-6/+6
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74158 0039d316-1c4b-4281-b951-d872f2087c98
* Report accessible static text content in the name rather than the value.dmazzoni@chromium.org2011-02-083-19/+29
| | | | | | | | | | | Fix the role for a list item, which WebKit categorizes as a GROUP. BUG=none TEST=updated existing test, plus manual testing with screen readers. Review URL: http://codereview.chromium.org/6250093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74124 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-6/+6
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74118 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-051-1/+1
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Use the proper role for secure text fields to distinguish from ordinary text ↵dtseng@chromium.org2011-02-031-1/+9
| | | | | | | | | | fields. BUG=57478 TEST=manually with VoiceOver. Review URL: http://codereview.chromium.org/6368060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73571 0039d316-1c4b-4281-b951-d872f2087c98
* [mac accessibility] Fix a crash that may occur while using VoiceOver.csilv@chromium.org2011-02-021-1/+4
| | | | | | | | BUG=66917 TEST=Open several complex web-pages as describe in bug, close them all without crashing. Review URL: http://codereview.chromium.org/6410014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73471 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 73197: Support Mozilla's GUID for ISimpleDOM and add a unit test for it.dmazzoni@chromium.org2011-02-012-13/+87
| | | | | | | | | | | | Original code review: http://codereview.chromium.org/6409025/ BUG=48185 TEST=Adds new test. TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/6386036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73197 - Support Mozilla's GUID for ISimpleDOM and add a unit test for it.dmazzoni@chromium.org2011-01-312-89/+15
| | | | | | | | | | | | BUG=48185 TEST=Adds new test. Review URL: http://codereview.chromium.org/6409016 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6260045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73200 0039d316-1c4b-4281-b951-d872f2087c98
* Support Mozilla's GUID for ISimpleDOM and add a unit test for it.dmazzoni@chromium.org2011-01-312-15/+89
| | | | | | | | | BUG=48185 TEST=Adds new test. Review URL: http://codereview.chromium.org/6409016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73197 0039d316-1c4b-4281-b951-d872f2087c98
* Map a few more WebKit roles to MSAA roles - thanks to Charlesdmazzoni@chromium.org2011-01-251-6/+18
| | | | | | | | Pritchard for suggesting these mappings. Review URL: http://codereview.chromium.org/6372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72440 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-212-2/+2
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS files for accessibility directories.dmazzoni@chromium.org2011-01-211-0/+3
| | | | | | Review URL: http://codereview.chromium.org/6272013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72058 0039d316-1c4b-4281-b951-d872f2087c98
* Remove action_max_timeout_ms and fix all the callers.tfarina@chromium.org2011-01-191-2/+4
| | | | | | | | | | | (This was a TODO for phajdan.jr). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-171-1/+1
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71585 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of chrome_switches.h.thestig@chromium.org2011-01-111-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6086003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 8, the last part.avi@chromium.org2011-01-071-28/+41
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70769 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ATTR_LINK_TARGET to ATTR_URL and assign it within ↵ctguil@chromium.org2010-12-201-1/+1
| | | | | | | | webaccessibility.BUG=noneTEST=none Review URL: http://codereview.chromium.org/5698002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69751 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove needed #includes for profile.h.thestig@chromium.org2010-12-101-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up AXVisited attribute.dtseng@chromium.org2010-12-101-7/+11
| | | | | | | | BUG=58804 TEST=manually with VoiceOver. Review URL: http://codereview.chromium.org/5751002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68806 0039d316-1c4b-4281-b951-d872f2087c98
* This is a continuation of http://codereview.chromium.org/5519016/, adds a ↵satish@chromium.org2010-12-092-1/+12
| | | | | | | | | | | | | new GetInstance() method for remaining files with singleton classes under chrome/browser. For types declared and used within the same .cc file, I changed them over to LazyInstance<T>. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5711001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68739 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude text controls from exposing the press action. Structure ↵dtseng@chromium.org2010-12-061-2/+9
| | | | | | | | | | PerformAction properly. BUG=none. TEST=manually with VoiceOver. Review URL: http://codereview.chromium.org/5579004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68393 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-4/+4
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98