summaryrefslogtreecommitdiffstats
path: root/chrome/browser/api/infobars
Commit message (Collapse)AuthorAgeFilesLines
* Move c/b/a/infobar files back to c/b/infobarkaiwang@chromium.org2013-03-198-571/+0
| | | | | | | | | | | | This is because we changed the approach to componentize code into src/components. So c/b/api directory is depereated. BUG=138280 Review URL: https://chromiumcodereview.appspot.com/12540009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189138 0039d316-1c4b-4281-b951-d872f2087c98
* Implement user consent InfoBar for screen capturing.sergeyu@chromium.org2013-02-072-0/+7
| | | | | | | | | | | | | | | Support for screen capturing using getUserMedia() was added in r180502 (behind a flag), but there were no notifications to let the user know that the screen is being captured. This CL dds InfoBar that is shown whenever a page requests screen capturing and lets the user approve or deny the request. BUG=134249 TBR=brettw@chromium.org (gypi changes) Review URL: https://chromiumcodereview.appspot.com/12022024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181112 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_open_disposition.h from webkit/ into ui/base.tfarina@chromium.org2013-01-221-1/+1
| | | | | | | | | | | | This reduces one more dependency on webkit from chrome. BUG=146251 R=jam@chromium.org,ben@chromium.org TBR=darin@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/12036003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178082 0039d316-1c4b-4281-b951-d872f2087c98
* infobars: Remove the downcast AsAlternateNavInfoBarDelegate() function.tfarina@chromium.org2013-01-222-5/+0
| | | | | | | | | | | | | Is enough to just static_cast to the right pointer as we know at the call sites from which type the delegate is. BUG=164772 R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/12017031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178015 0039d316-1c4b-4281-b951-d872f2087c98
* Change infobar creation to use a public static Create() method on the ↵pkasting@chromium.org2013-01-087-22/+33
| | | | | | | | | | | | | | | | | | | | | | | infobar delegate classes. Make constructors as private as possible. This has several purposes: * By preventing direct instantiation, it prevents callers from leaking if they create an infobar and don't add it to an InfoBarService. * By moving decision-making about when to show infobars into these Create() functions, there's a pattern for where such code should go, and caller code becomes simpler and easier to read. * The two bullets above together mean that for infobars which should only be displayed in certain circumstances, code can't accidentally bypass the decision logic. * It enables us to eliminate a common InfoBarService* temp on the caller side since the caller no longer needs to both pass the pointer to the infobar _and_ call AddInfoBar() on the pointer. This was also a somewhat redundant-looking pattern. * It makes it easier to change the ownership model for infobars in the future by limiting the affected callsites to only the Create() functions. Note that right now, this still feels pretty redundant since we pass all the same args to Create() functions as constructors most times. In the new ownership model constructors will no longer need to take InfoBarService*s, which will make this better. Additionally, this makes AddInfoBar()/ReplaceInfoBar() take scoped_ptr<>s to indicate they're receiving ownership. This sort of change is easy to make since we only need change the create functions. This change also has a functional effect: it eliminates some cases where we tried to only show infobars when no other infobars were already showing (discussed and approved by Glen). BUG=none TEST=none Review URL: https://codereview.chromium.org/11644059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175467 0039d316-1c4b-4281-b951-d872f2087c98
* Move one_click_signin_infobar_delegate.* from chrome/browser/api/infobars/ ↵pkasting@chromium.org2013-01-072-64/+0
| | | | | | | | | | | to chrome/browser/ui/sync/ (alongside the rest of the one_click_signin_xxx files). BUG=none TEST=none TBR=sky Review URL: https://codereview.chromium.org/11744015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175395 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup to how infobars handle expiry:pkasting@chromium.org2013-01-072-12/+11
| | | | | | | | | | | | * Make StoreActiveEntryUniqueID() take no args -- the arg was unnecessary. * Remove the unique ID setter and make its lone caller override ShouldExpireInternal() instead, to reduce the overall API surface area. * Prefer to override ShouldExpireInternal() instead of ShouldExpire() where possible, as that's a safer pattern if others copy-and-paste it, since it will change less behavior. BUG=none TEST=none Review URL: https://codereview.chromium.org/11748012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175362 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the LinkInfoBar[Delegate] classes entirely.tfarina@chromium.org2013-01-074-73/+9
| | | | | | | | | | | | | And switch to the existing AlternateNavInfoBar[Delegate] classes. BUG=164772 R=pkasting@chromium.org TBR=ben@chromium.org NOTRY=True # ios_dbg_simulator seems to be broken in lkgm? Review URL: https://codereview.chromium.org/11721003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175313 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all uses of InfoBarTabHelper -> InfoBarService. Make InfoBarTabHelperpkasting@chromium.org2012-12-202-4/+11
| | | | | | | | | | an implementation detail by declaring all its functions private. BUG=none TEST=none Review URL: https://codereview.chromium.org/11442041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174196 0039d316-1c4b-4281-b951-d872f2087c98
* Raise an infobar and deny access to WebGL if a GPU reset was detected while ↵kbr@chromium.org2012-11-202-0/+6
| | | | | | | | | | | | | | | | a web page containing WebGL content was visible. The same mechanism will work for Pepper 3D but has not been hooked up for that API yet. https://bugs.webkit.org/show_bug.cgi?id=101826 added the hooks out through the Chromium WebKit API. BUG=125125 TEST=GPUCrashTest.ContextLossRaisesInfobar Review URL: https://chromiumcodereview.appspot.com/11378008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168794 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust #fidef to match how we've actually defined our overrides.pkasting@chromium.org2012-11-071-4/+4
| | | | | | | | | BUG=none TEST=none TBR=rogerta Review URL: https://codereview.chromium.org/11363117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166334 0039d316-1c4b-4281-b951-d872f2087c98
* Switch InfoBarTabHelper to use WebContentsUserData.avi@chromium.org2012-10-111-3/+2
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11030045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161255 0039d316-1c4b-4281-b951-d872f2087c98
* Switching from ForXyz naming to FromXyz naming, for consistency.joi@chromium.org2012-09-221-1/+1
| | | | | | | | | | TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98
* Setup field trial for one-click signin inforbar. rogerta@chromium.org2012-09-142-0/+64
| | | | | | | | | | | | | BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98
* Rename InfoBarTabService -> InfoBarService.joi@chromium.org2012-08-309-26/+26
| | | | | | | | | | | | | This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce InfoBarTabService API.joi@chromium.org2012-08-2010-35/+92
| | | | | | | | | | | | | | | | The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98
* Move a few temporarily-allowed autofill dependencies to a test-file-only ↵joi@chromium.org2012-08-131-6/+6
| | | | | | | | | | | section. BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10854095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151348 0039d316-1c4b-4281-b951-d872f2087c98
* Create chrome/browser/api directory. Move infobar delegates used by Autofill ↵joi@chromium.org2012-08-1310-0/+554
to the directory. Also, consolidate infobar delegate interfaces under infobars/ rather than some under infobars/ and some under tab_contents/, as the ones under tab_contents/ were not coupled with tab_contents/ in any way. Remove feedback/proto/extension.pb.h from Autofill's DEPS file simply by dropping the include, it was not being used. BUG=140037,138280 Review URL: https://chromiumcodereview.appspot.com/10843071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151279 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-15 16:11:21 +0000