summaryrefslogtreecommitdiffstats
path: root/chrome/browser/app_controller_mac.mm
Commit message (Collapse)AuthorAgeFilesLines
* added workaround for NULL defaultProfile in app_controller_mac.mm.akalin@chromium.org2010-05-031-2/+24
| | | | | | | | | BUG=43048 TEST=manual, although couldn't repro original problem Review URL: http://codereview.chromium.org/1845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46275 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: rename app_mode_constants_mac.*.viettrungluu@chromium.org2010-04-301-1/+1
| | | | | | | | | | I foolishly gave these files a too-specialized name. BUG=none TEST=none Review URL: http://codereview.chromium.org/1727019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46125 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to check for in-progress downloads when quitting. Adds back in codepinkerton@chromium.org2010-04-281-0/+8
| | | | | | | | | removed during quit refactoring. BUG=41675 TEST=quit while downloading, can cancel and quit app, as well as cancel the quit to allow the download to complete. When download completes, closing all windows shouldn't quit (normal behavior). Review URL: http://codereview.chromium.org/1746013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45832 0039d316-1c4b-4281-b951-d872f2087c98
* Use the native Mac localization bundle utility functions.avi@chromium.org2010-04-271-26/+18
| | | | | | | | | BUG=none TEST=no change Review URL: http://codereview.chromium.org/1791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45694 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Ignore rapp events when the browser is shutting down.rohitrao@chromium.org2010-04-261-0/+6
| | | | | | | | BUG=42430 TEST=Suspected test case is to click on the dock icon immediately after quitting, but before the quit has finished. This is very timing-dependent, and I have never actually been able to reproduce the crash. Review URL: http://codereview.chromium.org/1796001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45609 0039d316-1c4b-4281-b951-d872f2087c98
* Delete native Mac bookmark manager. Remove --disable-tabbed-bookmark-manager ↵viettrungluu@chromium.org2010-04-231-11/+3
| | | | | | | | | | | | | (everywhere). Still to do: delete native bookmark managers on other platforms. BUG=38908 TEST=Everything else still works. Review URL: http://codereview.chromium.org/1751011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45462 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: reform our shutdown routine.viettrungluu@chromium.org2010-04-091-16/+61
| | | | | | | | | | | | | | | | Make shutdown be more like other platforms. Moreover: - Cancelling quit from an onbeforeunload dialog shouldn't mess up the browser. - Having quit cancelled due to a window pop up on the closure of another window shouldn't break the browser. [With this patch, it will result in the browser being in a quirky state in which the closure of the last browser window will cause a quit. But the browser won't be broken.] BUG=34384,37813,37927 TEST=See bugs. Review URL: http://codereview.chromium.org/1520006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44096 0039d316-1c4b-4281-b951-d872f2087c98
* UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.evan@chromium.org2010-03-231-3/+6
| | | | | | | | | | | | That way it is easier to keep track of those constants in reporting tools. TEST=Covered with standard ui tests Patch by Frank Mantek <fmantek@google.com>. Review URL: http://codereview.chromium.org/811005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tabbed bookmark manager by default.arv@chromium.org2010-03-191-3/+3
| | | | | | | | | | | | | | Second try with the following changes: - Remove FLAKY_ from Feed tests and makes sure they pass. BUG=4890,38609 TEST=browser_test.exe Run Chrome, Press Ctrl+Shift+B. The new bookmark manager should open in a tab. Review URL: http://codereview.chromium.org/1127006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42165 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42061 - Enable tabbed bookmark manager by default due to ↵andybons@chromium.org2010-03-191-3/+3
| | | | | | | | | | | | | | browser_tests and chrome frame breaking. BUG=4890 TEST=None Review URL: http://codereview.chromium.org/1139001 TBR=arv@chromium.org Review URL: http://codereview.chromium.org/1146004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42103 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tabbed bookmark manager by default. arv@chromium.org2010-03-191-3/+3
| | | | | | | | | BUG=4890 TEST=None Review URL: http://codereview.chromium.org/1139001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42061 0039d316-1c4b-4281-b951-d872f2087c98
* Open tabbed bookmark manager from menus as well.arv@chromium.org2010-03-121-1/+14
| | | | | | | | | | | This is the Mac part of issue 826002. BUG=37372 TEST=Start chrome with --enable-tabbed-bookmark-manage and open the BMM from the app menu, as well as bookmark bar context menu etc. All entries should take you to the tabbed bookmark manager. Review URL: http://codereview.chromium.org/871003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41361 0039d316-1c4b-4281-b951-d872f2087c98
* Fix possible race condition with updating close-tab/window key equivalents ↵pinkerton@google.com2010-03-081-5/+17
| | | | | | | | | | from a thread that's not the main thread. Go back to performSelector:withObject:afterDelay: if we are on the main thread because moving to performSelectorOnMainThread: made drag and drop really janky. BUG=37111, 37091, 32786 TEST=close-window/close tab command key regression testing, visuals dragging a tab should suck less. Review URL: http://codereview.chromium.org/668260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40899 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: record location of Chromium.app (or Google Chrome.app) bundle.viettrungluu@chromium.org2010-02-221-0/+38
| | | | | | | | | | | This will be needed by the app mode loader. BUG=13148 TEST=Run Chromium; do (from command line): "defaults read org.chromium.Chromium LastRunAppBundlePath" -- should get path to Chromium.app; move Chromium.app to another location and run it again; do "defaults ..." again -- should get path to Chromium.app at new location. Review URL: http://codereview.chromium.org/651061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39665 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: when only minimized windows present, various commands should unminimize ...viettrungluu@chromium.org2010-02-211-46/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | ... and use an existing window rather than create a new one. Also, when a dialog box (e.g., Preferences, Bookmark Manager, etc.) is active, those commands should activate an existing window (if one exists) instead of always creating a new window. The complete list of commands which should activate a miniaturized window if possible (otherwise create a new window): - File->New Tab (Cmd-T) - File->Open Location... (Cmd-L) - Edit->Find->Search the Web... (Opt-Cmd-F) - History->History (Cmd-Y) - Window->Downloads (Shift-Cmd-J) - Window->Extensions - Help->Chromium/Google Chrome Help For now, I'm letting File->Open File... (Cmd-O) always create a new window, which is consistent with Safari. BUG=21434 TEST=Close all windows; try one of the commands above (in commit message/CL description); a new window should be created and the command should work; this is all as before this CL. Create a window (if necessary) and minimize all browser windows; try one of the commands above; the last-active browser window should unminimize and the command should execute in that window. Review URL: http://codereview.chromium.org/652018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39566 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TODOs or add bug numbers to TODOspinkerton@chromium.org2010-02-121-4/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/606016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38892 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary scaffolding stubs.phajdan.jr@chromium.org2010-02-101-1/+0
| | | | | | | | | | | | | They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Import settings dialog cleanup.jeremy@chromium.org2010-02-011-4/+2
| | | | | | | | | | | | | * Make Import settings dialog app modal. * No longer allow display of multiple dialogs at once. * For some reason, unit test was present but missing from .gyp file - re-added and freshened up. BUG=33011 TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once. Review URL: http://codereview.chromium.org/556097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37689 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Enable menu cmd when no window's open.snej@chromium.org2010-01-231-0/+6
| | | | | | | | | Also fixes a related bug not mentioned in the report: app global commands like New Window etc. are disabled when the bookmark manager is active. BUG=32200 TEST=none (see bug description) Review URL: http://codereview.chromium.org/551100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36951 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: improve situation with respect to launching/DnD local files.viettrungluu@chromium.org2010-01-221-57/+34
| | | | | | | | | | | | | | | | | | This is half the solution, but it should make some stuff work. This should make double-clicking on local HTML files (when Chromium is set as default browser) work more correctly, both when Chromium is already running and when it's not. (The same, but easier to check: dragging a file or files to the Chromium application icon.) You should no longer be told that Chromium can't open HTML files. It's not the full solution since an extraneous (NTP/home page) tab -- or worse -- will be created if Chromium is not already running; solving this will require modifying browser startup. BUG=14808 TEST=Drag a file to the Chromium application icon, both when it's already running and when it's not; file should open in a tab. Do the same, but select multiple files; selected files should open in tabs. Check the same for the Chromium Dock icon (when Chromium is already running). Note that if Chromium is not running, there will be an extraneous (NTP or home page) tab. Review URL: http://codereview.chromium.org/552109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36902 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure method to set up cmd-w/cmd-shift-w runs on the main thread, add a ↵pinkerton@google.com2010-01-211-5/+6
| | | | | | | | | | DCHECK to try to catch instances where it is called away from the main thread. BUG=32786 TEST=cmd-w/cmd-shift-w should always be correct. Review URL: http://codereview.chromium.org/546106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36755 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Enable "Task Manager" menu item even if no browser is open.thakis@chromium.org2010-01-201-0/+6
| | | | | | | | | BUG=32731 TEST=Close all browser windows. View->Developer->Task Manager should still be active and still work (it should also still be active and work if browser windows are open of course) Review URL: http://codereview.chromium.org/549113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36687 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Don't crash on "Stats for nerds" link if no browser window is open.thakis@chromium.org2010-01-201-1/+1
| | | | | | | | | BUG=32659 TEST=see bug Review URL: http://codereview.chromium.org/554023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36666 0039d316-1c4b-4281-b951-d872f2087c98
* Fix command-click on buttons in background windows to perform their action ↵pinkerton@chromium.org2010-01-141-4/+31
| | | | | | | | | | in the context of the background window's controller, not the one associated with the foreground window. Command-click on back/fwd button in a background window doesn't have any special open disposition like it does in fg window. BUG=16191 TEST=menus, key commands, button command dispatching should all still work for foreground and background windows. Test cmd-clicking buttons in a browser when a non-browser is the foreground window. Review URL: http://codereview.chromium.org/543044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36287 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35137 - Getting perf numbers. Will revert.viettrungluu@chromium.org2009-12-221-25/+51
| | | | | | | | | | | | | BUG=none TEST=none TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/502099 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/504080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35138 0039d316-1c4b-4281-b951-d872f2087c98
* Getting perf numbers. Will revert.viettrungluu@chromium.org2009-12-221-51/+25
| | | | | | | | | | BUG=none TEST=none TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/502099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35137 0039d316-1c4b-4281-b951-d872f2087c98
* Commit issue 464079 for feldstein: limit the clear browsing data window to ↵mirandac@chromium.org2009-12-151-4/+2
| | | | | | | | | | only pop up once. BUG= 24980 TEST= see http://codereview.chromium.org/464079/show Review URL: http://codereview.chromium.org/501001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34557 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement "Search the Web..." (Opt-Cmd-F).viettrungluu@chromium.org2009-12-071-0/+9
| | | | | | | | | | | | | | This focuses the Omnibox with '?' in the contents with the text insertion point immediately after (and no selection), unless the Omnibox already has something beginning with '?' in which case it selects the text after the '?'. This is what Ctrl-K does on other platforms. On the Mac, we get a menu item (under Edit -> Find), and the Mac-standard shortcut of Opt-Cmd-F (users can set Cmd-K as a short cut in System Preferences if they really want). Changes to MainMenu.xib: added ^IDS_EDIT_SEARCH_WEB_MAC menu item ("Search the Web...", tag 39002, Opt-Cmd-F as keyboard shortcut, sending -commandDispatch: to first responder) as first item in Find submenu, followed by a separator. BUG=29501 TEST=Check that this feature has the behaviour described above (using both the menu item and using Opt-Cmd-F), with (1) nothing in the Omnibox to begin with, (2) a random URL in the Omnibox, and (3) "?<some search term(s)>". Check that the Omnibox is properly focused (so set focus to various places, and make sure that the Omnibox gets focused). Review URL: http://codereview.chromium.org/460111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33971 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the help menu as such so Cocoa adds the search item.thomasvl@chromium.org2009-12-011-0/+16
| | | | | | | | BUG=28987 TEST=set lang to french, launch, the help menu should have search option on 10.6 Review URL: http://codereview.chromium.org/452011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33450 0039d316-1c4b-4281-b951-d872f2087c98
* In-application Keystone ticket promotion.mark@chromium.org2009-11-281-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The concept of "ticket promotion" is added to the application when Keystone is in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome normally establishes when it launches, into a system Keystone ticket, after successful user authentication and authorization. Having a system Keystone with a system ticket means that updates are applied with root privileges instead of user privileges, essentially eliminating the possibility that a user will fall off of the auto-update train because they can read and execute but not write the application. Two principles of promotion apply: - An application on a user ticket NEEDS promotion if it determines that it doesn't have permission to write to itself. Being on a user ticket, an update attempt would fail. - An application on a user ticket WANTS promotion if it already NEEDS promotion. Additionally, if it is installed in a system-wide location such as /Applications, it will WANT promotion, even if it does not NEED it. If promotion is needed, an info bar will show up on launch requesting it. This info bar works similarly to the default browser info bar: it has a "don't bother me again" button, it will only show up after the first launch, it won't disappear on navigation if the navigation happens very quickly, and it won't show itself if another info bar is up. This means that if both the default browser info bar and the promotion info bar have a shot at showing, only one will win. In my experience, each wins about half of the time. If promotion is needed, the update UI in the About window will be hidden. Checking for updates and offering to apply them doesn't make much sense when the update won't be able to install successfully. All of the auto-update machinery is still working in the background, but the About window UI is hidden. If promotion is wanted, the About window will contain a new button allowing the user to enter promotion. This gives access to the same promotion routine as the promotion info bar. It can be used even from an administrative account that is able to update the application without promotion. It's intended to be used by the system administrator of the family without requiring them to switch to one of the kids' accounts. BUG=16360 TEST=Exhaustively, please. Review URL: http://codereview.chromium.org/437053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33241 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-251-4/+4
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Added main menu item for Sync in OS X. (Right below "Preferences..."). Made ↵akalin@chromium.org2009-11-241-0/+15
| | | | | | | | | | | | | it work without a browser window being present. Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}. BUG=27995 TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in. Review URL: http://codereview.chromium.org/423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
* Moved a whole pile of unittests over to CocoaTest.dmaclach@chromium.org2009-11-191-20/+32
| | | | | | | | | | | AboutIPC.xib - Connected up controller to its window and the window delegate to the controller. BUG=26484, 26484 TEST=See repro steps in bugs. Review URL: http://codereview.chromium.org/402066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32551 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Import Bookmarks and Settings".mrossetti@chromium.org2009-11-191-1/+12
| | | | | | | | | | | | | Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder). Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above. BUG=26157 TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported. Review URL: http://codereview.chromium.org/378036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add Extensions to the Main Menu and to the Wrench Menu.viettrungluu@chromium.org2009-11-181-0/+4
| | | | | | | | | | | | | Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads. Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads. Enable Extensions menu item when no browser window is open. BUG=25423 TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open. Review URL: http://codereview.chromium.org/399072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented ShowOptionsWindow() for OS X (except the highlightingakalin@chromium.org2009-11-141-4/+19
| | | | | | | | | | | | | | | of the given group). Refactored PreferencesWindowController a bit. Made preferences_window_controller_unittest.mm use CocoaTest instead of CocoaTestHelper and reenabled disabled test which was crashing (likely due to interactions with CocoaTestHelper). BUG=23073 TEST=manually,trybots Review URL: http://codereview.chromium.org/391050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31973 0039d316-1c4b-4281-b951-d872f2087c98
* Allow new window creation when the frontmost browser has a modal sheet attached.pinkerton@chromium.org2009-11-111-7/+5
| | | | | | | | BUG=27379 TEST=creating new windows with app modals, tab modal, window modals Review URL: http://codereview.chromium.org/387025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31667 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up our autorelease pool handling by making sure that an autorelease ↵dmaclach@chromium.org2009-11-051-1/+0
| | | | | | | | | | | | | pool isn't created while the app is handling an event sent via -[NSApp sendEvent]. Branches browser/chrome_application_mac into browser/chrome_browser_application and base/chrome_application. Renderers will run as chrome_applications, and browsers will run as chrome_browser_applications. BUG=26418, 25462, 25463, 25465 TEST=1) See bug 25857. 2) Start up. Open 3+ windows. 3)Quit. See bugs for other repro cases. Review URL: http://codereview.chromium.org/345051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31135 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser to stay above a modal plugin window (Mac)stuartmorgan@chromium.org2009-11-041-0/+9
| | | | | | | | | | | There's a flicker of the modal window being hidden then coming forward again, and the menus still work, so we'll most likely have fake the modality more aggressively at some point. This gets us the basic infrastructure though, and solves the severe usability problem. BUG=20798 TEST=Open a modal plugin window (e.g., Gmail upload). Switch to another app, then back to Chrome; the plugin window should come to the front. Review URL: http://codereview.chromium.org/355021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30965 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Report Bug" dialog to Mac OSX.mirandac@chromium.org2009-11-031-0/+13
| | | | | | | | BUG= http://crbug.com/19282 TEST= Use report bug dialog on Mac OSX. Review URL: http://codereview.chromium.org/340039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: enable History, Downloads, and Open Location... with no windows open.viettrungluu@chromium.org2009-10-301-0/+10
| | | | | | | | | BUG=25620 TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L). Review URL: http://codereview.chromium.org/329004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30615 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window restore behaviour on Mac.erg@chromium.org2009-10-291-0/+18
| | | | | | | | | | | | | | | | On the mac, there can be no windows, but the application is sitll open. This confused "Restore the pages that were open last" so that it would restore when opening a new window. BUG=13341 TEST=Open chromium. Set On Startup to "Restore the pages that were open last". Open a few tabs. Close the window (but not chromium). Click the dock icon. The tabs shouldn't be restored. But if you quit chrome and start again, things should reopen. Review URL: http://codereview.chromium.org/340023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30463 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-261-1/+1
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* About box auto-update improvements.mark@chromium.org2009-10-261-15/+8
| | | | | | | | | | | | | | | The About box now knows how to check to see if updates have been installed in the background without anyone having to click the Update button in the box. The About box no longer gets stuck in the "installed" state. Even if an update has been installed, the About box will still check for new updates when reopened. BUG=13165, 20488 TEST=Play with the about box and auto-update a whole lot Review URL: http://codereview.chromium.org/338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Enable help when there are no windows.viettrungluu@chromium.org2009-10-221-1/+6
| | | | | | | | | BUG=23825 TEST=Close all browser windows. Check that Help->Chromium Help (or Google Chrome Help) is enabled and works correctly. Review URL: http://codereview.chromium.org/303030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29744 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delay menu item fixup when the number of tabs change.pinkerton@chromium.org2009-10-191-1/+5
| | | | | | | | BUG=24878 TEST=cmd-w/cmd-shift-w are always correct for close-tab/close-window when window layering changes. Review URL: http://codereview.chromium.org/283017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29397 0039d316-1c4b-4281-b951-d872f2087c98
* The file menu was enabled even when a browser window was obscured by a modal ↵mirandac@chromium.org2009-10-131-1/+21
| | | | | | | | | | | dialog. This fix disables these menu items while the dialog window is up. BUG= http://crbug.com/23864 TEST= Open the "open file" file chooser window with cmd-o (or from the menu). Attempt to open a new tab, window, or file. Note that you cannot. Close the file chooser window, and note that these menu items are now enabled again. Review URL: http://codereview.chromium.org/269035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28836 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the about window to create a new window to handle loading web pages if ↵pinkerton@chromium.org2009-10-131-1/+1
| | | | | | | | | | there is none currently available. BUG=24234 TEST=clicking links in about window with and without browsers open. Review URL: http://codereview.chromium.org/272013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28814 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly activeIgnoringOtherApps from IDC_NEW{,_INCOGNITO}_WINDOWsgk@google.com2009-10-061-2/+10
| | | | | | | | | | | in app_controller_mac.mm, under the assumption we're either already the foreground app or should become the foreground mac (when created from the dock menu). BUG=22595 TEST="New Window" or "New Incognito Window" from dock menu with other app in foreground Review URL: http://codereview.chromium.org/256054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28091 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:43:59 +0000