| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6794030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73011
TEST=compile
Review URL: http://codereview.chromium.org/6719002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This option is off by default. This CL also removes the command line flag and
the about:flags strings.
XIB changes:
* Add a new menu item and separator.
* Wire up the menu item to -[AppController toggleConfirmToQuit:]
BUG=60591
TEST=Go to Chromium menu. See "Warn Before Quitting (Cmd+Q)". Select it to enable/disable. Feature works as before, respecting this flag.
Review URL: http://codereview.chromium.org/6708058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73011
TEST=none
Review URL: http://codereview.chromium.org/6718002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50307,72362,76702
TEST=three-finger-swipe down and Window->Tab Overview both open tab overview mode
Review URL: http://codereview.chromium.org/6459009
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6708033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6674019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and adding others into the proper impl files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6690016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6656004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73011
TEST=please go green
Review URL: http://codereview.chromium.org/6646020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73011
TEST=Tabbed options work as before. --disable-tabbed-options does nothing.
Review URL: http://codereview.chromium.org/6621076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75320
TEST=none
Review URL: http://codereview.chromium.org/6650007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First part of the remaining files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6649001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
second tap.
This also refactors the logic that was in AppController to be in the
ConfirmQuitPanelController
BUG=74976
TEST=Press and hold Cmd+Q. Windows fade out and Chromium quits when you release the keys.
TEST=Tap Cmd+Q and get the floaty window. Tap it again quickly and Chromium quits.
TEST=Tap Cmd+Q to get the floaty window. Press and hold again and the windows hide and Chromium quits when the keys are released.
Review URL: http://codereview.chromium.org/6625025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
- Match the names of the files with the current pattern used in the ui/gtk/importer directory.
BUG=None
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6628039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70296
TEST=See bug for exact steps.
Review URL: http://codereview.chromium.org/6594087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the behavior of ignore_path in BrowserNavigator.
use an enum instead. The enum controls whether to replace the path or leave it alone when bringing an already-open tab to the front.
BUG=71472
TEST=included
Review URL: http://codereview.chromium.org/6592058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6594063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserNavigator.
use an enum instead. The enum controls whether to replace the path or leave it alone when bringing an already-open tab to the front.
BUG=71472
TEST=included
Review URL: http://codereview.chromium.org/6579047
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/6588072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
use an enum instead. The enum controls whether to replace the path or leave it alone when bringing an already-open tab to the front.
BUG=71472
TEST=included
Review URL: http://codereview.chromium.org/6579047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60591
TEST=Launch Chromium and tap Cmd+Q; get the quit warning.
Review URL: http://codereview.chromium.org/6596039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
actual)" in DCHECK_EQ/NE().
Also cleans up a couple other misc. style issues.
BUG=58409
TEST=none
Review URL: http://codereview.chromium.org/6578035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
/src/chrome/browser/a*
BUG=58409
Review URL: http://codereview.chromium.org/6539002
Patch from Kushal Pisavadia <kushi.p@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50307,72362
TEST=three-finger-swipe down and Window->Tab Overview both open tab overview mode
Review URL: http://codereview.chromium.org/6459009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added "highlight_background_resources" param to BrowserWindow::ShowTaskManager()
and added support in Cocoa for drawing highlights.
BUG=71490
TEST=Click View Background Pages, see background pages are highlighted in yellow.
Review URL: http://codereview.chromium.org/6312178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In DOMUI pref mode, Mac menu items should open prefs via a browser window. Also fixes OpenSyncMyBookmarksDialog on all platforms.
BUG=67670
TEST=Choosing a pref-opening menu item from the Chrome menu on Mac should open DOMUI prefs.
Review URL: http://codereview.chromium.org/6293018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69448
TEST=manual
Review URL: http://codereview.chromium.org/6241009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6362007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
R=mirandac
Review URL: http://codereview.chromium.org/6371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6335001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile and trybots
Review URL: http://codereview.chromium.org/6339002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6122006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59972
TEST=none
Review URL: http://codereview.chromium.org/6177002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up callers to use the new location & namespace. Remove includes from
files where it wasn't necessary.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6046009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67076
TEST=manual
Review URL: http://codereview.chromium.org/5908003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on mac.
We currently use WorkerPoolLinux on mac (as an attempt to fix the fork issue -- didn't help, but didn't hurt either), so this should be safe.
This removes the last @interfaces from libbase.
Also add worker_pool_posix_unittest.cc back to base_unittests
BUG=44392,46929
TEST=Chrome still works. The PDF plugin prints no more warnings when it's loaded.
Review URL: http://codereview.chromium.org/6055001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5758001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_path_watcher into subdir
profile* into profiles/ subdir
login* into ui/login
visitedlink* into subdir
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab_menu_model->ui/tabs
tab_contents_wrapper->ui/tab_contents
view_ids.h->ui
status_bubble.h->ui
options*->ui/options
show_options_url*->ui/options
location_bar*->ui/omnibox
input_window*->ui
browser_uitests->ui/tests
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5582002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65582
Review URL: http://codereview.chromium.org/4546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do not appear.
BUG=61815
TEST=With the confirm-to-quit lab enabled, mash Cmd+Q. Only 1 floaty window appears.
Review URL: http://codereview.chromium.org/5255001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5197001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolbar.
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Review URL: http://codereview.chromium.org/4546002
TBR=rkc@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Review URL: http://codereview.chromium.org/4546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name of this file is a leftover from Windows. Split the command
ids (which are used on all platforms) out, leaving just the
Windows-specific resource IDs in the original file.
TEST=compiles
Review URL: http://codereview.chromium.org/4710001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapts things to use the Linux WorkerPool code by default, with
--disable-linux-workerpool to switch back to the old version.
The old implementation uses NSOperationQueue, which is implemented in
terms of pthread workqueues. These are implicated by the stack traces
from the recent unit test flakiness. This change attempts to
influence that flakiness.
BUG=20471, 60426
TEST=Tree green.
Review URL: http://codereview.chromium.org/4595001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27786,60591
TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds.
Review URL: http://codereview.chromium.org/4220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ARGUMENTS_ONLY was misleading since CommandLine has methods for handling "switches" and "arguments", but that constructor still allows both.
BUG=none
TEST=still builds
Review URL: http://codereview.chromium.org/3935001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63325 0039d316-1c4b-4281-b951-d872f2087c98
|