summaryrefslogtreecommitdiffstats
path: root/chrome/browser/app_menu_model.h
Commit message (Collapse)AuthorAgeFilesLines
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-061-4/+16
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* Simplifying appmenu impl.oshima@chromium.org2010-01-211-5/+1
| | | | | | | | | | | Using command id instead of index. BUG=none TEST=none Review URL: http://codereview.chromium.org/554038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36791 0039d316-1c4b-4281-b951-d872f2087c98
* Made MenuController handle dynamic labels.akalin@chromium.org2010-01-081-0/+11
| | | | | | | | | | | Made AppMenuModel handle sync item dynamically. BUG=31691 TEST=made sure wrench menu item dynamically updates sync menu item Review URL: http://codereview.chromium.org/523147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35821 0039d316-1c4b-4281-b951-d872f2087c98
* Fix racing condition that blocks profiles menu showing upxiyuan@chromium.org2009-12-221-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | Chrome should show profiles menu when "enable-udd-profiles" is supplied on command line. This is broken while refactoring app menu code from ToolbarView into AppMenuModel. Previously, the profile submenu model is kept in ToolbarView and profiles menu would show up on 2nd time app menu showing up. After the refactoring, profile menu is moved into AppMenuModel, which is re-created everytime before we show app menu. In AppMenuModel, it requests profiles data from GetProfilesHelper which will later invoke OnGetProfilesDone. However, app menu is created on the UI thread and blocks the callback until it shows up. This makes the profiles mneu empty. The fix is to leverage an existing profile list in BrowserProcess. When "enable-udd-profiles" is on, BrowserInit will get the initial profile list and NewProfileDialog will refresh it if user creates new profile. And AppMenuModel just use the list to populate the profile menu. BUG=30417 TEST=Verify profiles menu exists when "enable-udd-profiles" is on command line for issue 30417. Review URL: http://codereview.chromium.org/503062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35166 0039d316-1c4b-4281-b951-d872f2087c98
* Factor tab context menu into a shared model and fix mac and win to use it. ↵pinkerton@chromium.org2009-12-161-2/+0
| | | | | | | | | | Improve a couple of model unit tests. Remove unused members in the models. BUG=28977 TEST=context menus on tabs should work and enable/disable properly Review URL: http://codereview.chromium.org/500030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34718 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-151-0/+44
NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-08 04:45:04 +0000