summaryrefslogtreecommitdiffstats
path: root/chrome/browser/app_modal_dialog_queue.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move app_modal_dialog stuff to ui/ben@chromium.org2010-12-011-64/+0
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5471002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67894 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-051-0/+6
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* Copyright change to force builders to rebuild.sky@chromium.org2010-06-211-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2834011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50359 0039d316-1c4b-4281-b951-d872f2087c98
* Preparation for mac content confirmation dialog. More tidy in general as well.thakis@chromium.org2010-02-241-1/+15
| | | | | | | | | | Patch mostly by sky. BUG=34894 Review URL: http://codereview.chromium.org/652178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39840 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39779 - Part of http://codereview.chromium.org/650206thakis@chromium.org2010-02-231-3/+1
| | | | | | | | | Review URL: http://codereview.chromium.org/657004 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/657022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39790 0039d316-1c4b-4281-b951-d872f2087c98
* Part of http://codereview.chromium.org/650206thakis@chromium.org2010-02-231-1/+3
| | | | | | Review URL: http://codereview.chromium.org/657004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39779 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39756 - Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-231-3/+1
| | | | | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/652150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39766 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-231-1/+3
| | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in cookie prompting:sky@chromium.org2010-02-181-5/+14
| | | | | | | | | | | | | | | | | | . In certain situations we could crash because we weren't letting CookiePromptView::Init complete and then attempting to reference some NULL fields. I've fixed this by adding AppModalDialog::IsValid and moving the logic that was in Init to IsValid. This way we only create CookiePromptView when needed. . We were leaking AppModalDialogs. I've made CookiePromptView own the AppModalDialog and delete it when the CookiePromptView is deleted. BUG=36079 TEST=enable prompting for cookies, go to a bunch of sites make sure you don't crash. Review URL: http://codereview.chromium.org/632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39328 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30766. It caused failures in ui_tests ↵pam@chromium.org2009-11-031-3/+1
| | | | | | | | | | | BrowserTest.SingleBeforeUnloadAfterWindowClose and apparently made the browser_tests crash. BUG=26398 TEST=covered by ui_tests and browser_tests Review URL: http://codereview.chromium.org/354015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30775 0039d316-1c4b-4281-b951-d872f2087c98
* Set active_dialog_ before showing it, since showing a dialog can sometimespam@chromium.org2009-11-021-1/+3
| | | | | | | | | | | | actually move to the next one in the queue instead. BUG=26398 TEST=Make sure alert/confirm boxes work properly. Make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Especially make sure http://crbug.com/10699 doesn't recur. Review URL: http://codereview.chromium.org/339094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30766 0039d316-1c4b-4281-b951-d872f2087c98
* This CL is a clean-up of the app_modal_dialog_queue.cc in an attempt to fix ↵jcampan@chromium.org2009-05-281-28/+11
| | | | | | | | | | | | | | a bug 10699. Not sure what is causing the crasher. Hopefully after this clean-up we'll get a different stack-trace that might help. BUG=10699 TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Review URL: http://codereview.chromium.org/113932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17078 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-071-7/+5
| | | | | | | | | | | | JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of (likely rare) crashers that can happen if a tab is closed ↵erikkay@google.com2009-04-061-2/+8
| | | | | | | | | | right as it's about to display a JS modal dialog. I don't know how these would be triggered in the field. I ran into them through misuse of the current API (trying to pass in a NULL WebContents). Review URL: http://codereview.chromium.org/62079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13203 0039d316-1c4b-4281-b951-d872f2087c98
* ui test fail. revert.ben@chromium.org2009-02-251-5/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10322 0039d316-1c4b-4281-b951-d872f2087c98
* AppModalDialogQueue shouldn't depend on views.ben@chromium.org2009-02-251-7/+5
| | | | | | | | Add a simple test, too. Review URL: http://codereview.chromium.org/27080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10320 0039d316-1c4b-4281-b951-d872f2087c98
* Pull app modal dialog handling out of the BrowserList to remove the ↵ben@chromium.org2009-01-161-4/+3
| | | | | | | | | | ChromeViews dependency. (Required for porting). TEST=Open two browser windows. In one, enter "javascript:alert('Foo');" into the address bar and hit enter. Click on the other window. The modal dialog should be focused and the window it was opened over should flash in the taskbar, Review URL: http://codereview.chromium.org/18179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8234 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the capacity to interact with modal dialogs to the automation framework.jcampan@chromium.org2008-12-051-2/+3
| | | | | | | | | This change will be used by Ojan to implement some unload handler tests. TEST=Run the ui tests. Review URL: http://codereview.chromium.org/13113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6402 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-6/+4
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+74
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:33:08 +0000