summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete/autocomplete_edit.cc
Commit message (Collapse)AuthorAgeFilesLines
...
* Fixes bug in instant where we would end up incorrectly using thesky@chromium.org2011-10-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | preview when we shouldn't. Here's the sequence that would trigger it: 1. focus the omnibox (which triggers loading the InstantLoader). 2. Type in a string that'll autocomplete to a url. 3. Arrow over a search suggestion to a non-search entry. 4. Press enter. When you arrow over a non-search we'll hide (what was DestroyPreviewContentsAndLeaveActive) the preview. But if between steps 3 and 4 we get a response back from the page with suggestions we'll set displayable_ to true and think everything is up to date. This leads to IsCurrent returning true when it isn't. To fix this I've nuked is_active(), which was a bit confusing anyway and added is_out_date_ (still confusing, but at least it's private). BUG=100368 TEST=covered by test, see bug for test scenario. R=sreeram@chromium.org,ben@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8298005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105664 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-9/+11
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call instant's Update() if the text was not user entered.sreeram@chromium.org2011-10-121-2/+7
| | | | | | | | | | | | | | | Put back some of the checks that used to exist before r104553. These effectively prevent InstantController::Update() from being called when the omnibox text is changed due to reasons other than user input (such as accepting a LinkInfoBar suggestion). BUG=99836 TEST=See bug. Review URL: http://codereview.chromium.org/8233041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105126 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser metrics to Chrome client cl #2.georgey@chromium.org2011-10-101-0/+19
| | | | | | | | BUG=94616 TEST=none Review URL: http://codereview.chromium.org/8174012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104689 0039d316-1c4b-4281-b951-d872f2087c98
* Make instant only load searches for the default provider.sky@chromium.org2011-10-071-24/+6
| | | | | | | | | | BUG=99266 TEST=make sure instant does search only. R=sreeram@chromium.org Review URL: http://codereview.chromium.org/8176005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104553 0039d316-1c4b-4281-b951-d872f2087c98
* Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-10-051-1/+2
| | | | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. (Continuation of http://codereview.chromium.org/7795009/) BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104130 0039d316-1c4b-4281-b951-d872f2087c98
* Don't destroy instant loaders if you don't have to.sreeram@chromium.org2011-10-041-11/+7
| | | | | | | | | | | | | | | | As long as the omnibox retains focus, don't delete any instant loaders. This includes cases where the user is not typing actively, or when the user switches tabs (but retaining focus in the omnibox). The rationale is that the user may type at any time, so it's useful to keep the instant loaders ready to process the user query. BUG=none TEST=PreloadInstantTest.* Review URL: http://codereview.chromium.org/8085010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103938 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting the NetworkActionPredictor.Action histogram based on field trial.dominich@chromium.org2011-10-031-1/+3
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8095001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103709 0039d316-1c4b-4281-b951-d872f2087c98
* Reintroducing check for NULL tab before updating Instant.dominich@chromium.org2011-09-201-0/+3
| | | | | | | | | | BUG=97233 TEST=instant_browsertest.cc:* Review URL: http://codereview.chromium.org/7976007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102054 0039d316-1c4b-4281-b951-d872f2087c98
* Add Field Trial for Prerender From Omnibox.dominich@chromium.org2011-09-201-7/+4
| | | | | | | | | | BUG=95066 TEST=None Review URL: http://codereview.chromium.org/7825009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101963 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying prefetch to account for multi-profile.rlp@chromium.org2011-09-101-3/+6
| | | | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937,90114 TEST=passes existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446 Review URL: http://codereview.chromium.org/7467012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prerender-from-omnibox/Instant issues.dominich@chromium.org2011-09-081-11/+22
| | | | | | | | | | | When we attempt to show an Instant preview tab we return a boolean to indicate success. We then only try to prerender if this returns false and if the prerender-from-omnibox flag is set. BUG=94423 TEST=Manual: Tested combinations of no flags, --prerender-from-omnibox, and --restrict-instant-to-search. Review URL: http://codereview.chromium.org/7828057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100091 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100003 - Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-09-071-2/+1
| | | | | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7795009 TBR=dominich@chromium.org Review URL: http://codereview.chromium.org/7837045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100014 0039d316-1c4b-4281-b951-d872f2087c98
* Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-09-071-1/+2
| | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7795009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100003 0039d316-1c4b-4281-b951-d872f2087c98
* Track recommended actions for all UMA users.dominich@chromium.org2011-09-021-10/+13
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7830023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99367 0039d316-1c4b-4281-b951-d872f2087c98
* Remove confidence from AutocompleteMatch and use History DB instead.dominich@chromium.org2011-09-011-89/+37
| | | | | | | | | | | | Adds a class responsible for providing recommended actions given an AutocompleteMatch which uses the History Database to determine that action. BUG=92896,94423 TEST=NetworkActionPredictorTest* Review URL: http://codereview.chromium.org/7686012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99140 0039d316-1c4b-4281-b951-d872f2087c98
* Makes copying text in the omnibox always use permanent text is thesky@chromium.org2011-08-311-24/+14
| | | | | | | | | | | | user hasn't modified the url. I'll add a test case if you like this. BUG=94126 TEST=see bug R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7806001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98983 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Modifying prefetch to account for multi-profile."avi@chromium.org2011-08-191-6/+3
| | | | | | | | | | | | | | This appears to make all the CF bots crash in chrome_frame_net_tests. This reverts commit r97446. BUG=89937 TEST=n/a TBR=rlp Review URL: http://codereview.chromium.org/7685009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97467 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 97465 - Revert 97446 - Modifying prefetch to account for multi-profile.avi@chromium.org2011-08-191-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937 TEST=passes existing Review URL: http://codereview.chromium.org/7467012 TBR=rlp@chromium.org Review URL: http://codereview.chromium.org/7690006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7688006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97466 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 97446 - Modifying prefetch to account for multi-profile.avi@chromium.org2011-08-191-6/+3
| | | | | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937 TEST=passes existing Review URL: http://codereview.chromium.org/7467012 TBR=rlp@chromium.org Review URL: http://codereview.chromium.org/7690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97465 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying prefetch to account for multi-profile.rlp@chromium.org2011-08-191-3/+6
| | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937 TEST=passes existing Review URL: http://codereview.chromium.org/7467012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97446 0039d316-1c4b-4281-b951-d872f2087c98
* Enable predicted action based on AutocompleteMatch confidence (behind flag).dominich@chromium.org2011-08-171-53/+135
| | | | | | | | | | | | This change enables predicted actions based on the AutocompleteMatch confidence score. It's behind a flag which can be removed once each provider is calculating a range of confidence values that we're comfortable with. BUG=92896 TEST= Review URL: http://codereview.chromium.org/7658016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97160 0039d316-1c4b-4281-b951-d872f2087c98
* Add confidence to AutocompleteMatch.dominich@chromium.org2011-08-111-0/+2
| | | | | | | | | | | | | | Calculated by each provider using whatever measure makes sense and stored as a float in the range [0, 1]. Will be used for determining benefit of using instant, prerender, DNS preconnect to increase success rate and avoid wasted resources. Currently fed into UMA to validate experiment. BUG=None TEST=None Review URL: http://codereview.chromium.org/7607007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96446 0039d316-1c4b-4281-b951-d872f2087c98
* Remove frontend code that allows for dynamic profile setting, and read the ↵pkasting@chromium.org2011-08-081-8/+1
| | | | | | | | | | profile off the browser where possible. This matches common practice and various invariants that expect profiles to be constant for the life of the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/7574021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95889 0039d316-1c4b-4281-b951-d872f2087c98
* Profiles: Remove orphaned notifications.erg@chromium.org2011-07-291-3/+1
| | | | | | | | | | BUG=87457 TEST=none Review URL: http://codereview.chromium.org/7532013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94727 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 3.avi@chromium.org2011-07-281-1/+1
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7522018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94511 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-2/+3
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Changes SearchProvider to set the description of the first consecutivesky@chromium.org2011-07-071-13/+6
| | | | | | | | | | | | | | | | | match sharing the same template url. For example, if the results were 'A B C D' with 'A' and 'B' sharing the same provider and 'C' and 'D' sharing the same provider, then 'A' and 'C' would get descriptions. As part of this I'm always setting AutocompleteMatch::template_url (previously we only set it for keywords). BUG=88322 TEST=see bug, also covered by unit tests. R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7321001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91741 0039d316-1c4b-4281-b951-d872f2087c98
* PrerenderManager public API cleanup.dominich@chromium.org2011-06-281-2/+2
| | | | | | | | | | BUG= TEST=Prerender* Review URL: http://codereview.chromium.org/7272011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90815 0039d316-1c4b-4281-b951-d872f2087c98
* Added prerendering to omnibox. Enable through --prerender-from-omnibox ↵dominich@chromium.org2011-06-241-17/+29
| | | | | | | | | | | | command-line-flag or through the about:flag with the same name. Only effective if prerender is enabled and instant is disabled or restricted to search. BUG=87124 TEST=none Review URL: http://codereview.chromium.org/7210020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90384 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TemplateURLModel into TemplateURLService. Changes all access points ↵erg@google.com2011-06-071-6/+9
| | | | | | | | | | | | | | to go through the newly made ProfileKeyedServiceFactory subclass. In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test. BUG=77155 TEST=unit tests R=mirandac Review URL: http://codereview.chromium.org/7056056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
* Preload Instant search when omnibox is focused.sreeram@chromium.org2011-06-011-0/+4
| | | | | | | | | | | | Start preloading the default search engine's Instant URL when the omnibox is focused, in anticipation of the user typing a query (controlled by a new --preload-instant-search flag). BUG=69197 TEST=Focus the omnibox, see (through a network trace) that google.com/webhp gets loaded. Review URL: http://codereview.chromium.org/6990015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87420 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup: Change use of string::size_type to size_t (team style), ↵pkasting@chromium.org2011-05-261-3/+3
| | | | | | | | | | string::size() to string::length() (omnibox code style), and some rewrapping. BUG=none TEST=none Review URL: http://codereview.chromium.org/7075020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86922 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash involving omnibox extension keywords.mpcomplete@chromium.org2011-05-111-4/+4
| | | | | | | | | | | | The |match| sometimes did not have a valid template_url, because GetInfoForCurrentText was classifying the match using the wrong parameters. Fixed to use prefer_keyword==true in this case. BUG=81776 TEST=see bug for repro Review URL: http://codereview.chromium.org/6995032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84921 0039d316-1c4b-4281-b951-d872f2087c98
* Makes autocompleting previous search terms work on word boundaries.sky@chromium.org2011-05-091-3/+3
| | | | | | | | | | BUG=80057 TEST=covered by unit tests, but see bugs for details. R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6893140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84681 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Apps that prefer a panel over a tab, should launch that way whenfinnur@chromium.org2011-05-061-18/+19
| | | | | | | | | | launched from the Omnibox. BUG=81379 TEST=Install Scratchpad extension (from Google). Launch it from the Omnibox and it should launch as a panel app. Test Paste and Go also like you normally would (it is affected). Review URL: http://codereview.chromium.org/6913022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84428 0039d316-1c4b-4281-b951-d872f2087c98
* Disable HCP URL and term matching when HQP is enabled.mrossetti@chromium.org2011-05-061-1/+3
| | | | | | | | | | | | | | | URL term matching was incorrectly using a string where any 'http://' was being stripped. Update HQP so that it uses proper formatting classifications for URL highlighting. Reduce scores of highly scoring matches which cannot be in-line autocompleted for various reasons. Update HQP unit tests to validate URL formatting classifications. Minor renaming of variables to better reflect intention for days_ago. Prevent crash in AutocompleteEditModel::FinalizeInstantQuery if there are no search providers. BUG=79884 TEST=Updated unit tests. Type something into the omnibox and verify that the URL for an HQP result is presented in green. Type something which best matches an URL and verify that the matching substring is shown in bolded green in the URL. Review URL: http://codereview.chromium.org/6902088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84380 0039d316-1c4b-4281-b951-d872f2087c98
* automation: Rename AutomationAutocompleteEditTracker to ↵tfarina@chromium.org2011-05-041-4/+3
| | | | | | | | | | | | | AutomationOmniboxTracker. BUG=80186 TEST=None R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6898053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84020 0039d316-1c4b-4281-b951-d872f2087c98
* autocomplete: Move AutocompleteEditView/autocomplete_edit_view.* to ↵tfarina@chromium.org2011-05-031-2/+2
| | | | | | | | | | | | | | | | ui/omnibox directory. - Rename AutocompleteEditView to OmniboxView. - Move autocomplete_edit_view.* to omnibox_view.* BUG=80186 TEST=None R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6912026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83977 0039d316-1c4b-4281-b951-d872f2087c98
* Move UserMetrics to content.michaeln@google.com2011-04-271-3/+3
| | | | | | | | | | | | | | Just the class that provides the action logging API which is used all over the place is being moved. The UserMetrics class uses the notification system to inform the core of the user metrics system of each event, that core part is not being moved. Also take care of a TODO to remove the class methods that take a Profile* as a paramter (since Profile is verbotten in /content). BUG=78499 Review URL: http://codereview.chromium.org/6883021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83251 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-1/+1
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the search provider not return results that look like URLs.sky@chromium.org2011-04-041-1/+2
| | | | | | | | | | BUG=77065 TEST=see bug, also covered by unit test R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6711087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80308 0039d316-1c4b-4281-b951-d872f2087c98
* Trigger keyword mode when pressing space in middle of stringsuzhe@google.com2011-04-011-1/+46
| | | | | | | | | | | This CL uses the allow_exact_keyword_match property of AutcompleteInput class to support this inserting space in the middle case. The logic of triggering a keyword by pressing space key at the end is not changed. BUG=77211 TEST=See bug report. Review URL: http://codereview.chromium.org/6770020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80177 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up ability for page to specify instant auto completesky@chromium.org2011-03-151-12/+28
| | | | | | | | | | | | | | | | | behavior. The choices are: . immediately (current behavior and is the default). . delayed (transitions to autocompleted after a delay). . never (only show the suggestion, but never autocomplete it). I'm doing this so we can collect some data to help understand which is the less error prone of the 3. The data collection is all done on the server side. BUG=none TEST=none Review URL: http://codereview.chromium.org/6685002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78211 0039d316-1c4b-4281-b951-d872f2087c98
* fav icon -> favicon. Pass 2: GetFavIcon -> GetFaviconavi@chromium.org2011-03-151-1/+1
| | | | | | | | | BUG=76073 TEST=none; no visible change Review URL: http://codereview.chromium.org/6685059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78208 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-1/+1
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Moves responsibility for updating InstantController to ↵sky@chromium.org2011-03-061-4/+81
| | | | | | | | | | | AutocompleteEditModel. This cuts down on a fair amount of duplicate code in the various platform specific files. BUG=none TEST=none Review URL: http://codereview.chromium.org/6609030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77079 0039d316-1c4b-4281-b951-d872f2087c98
* Port autocomplete_edit_view_browsertest.cc to Mac.suzhe@chromium.org2011-03-031-2/+2
| | | | | | | | | BUG=49740 TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.* should pass on Mac. Review URL: http://codereview.chromium.org/6602070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76764 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant not load the current url if you're already viewing. Thissky@chromium.org2011-02-281-0/+4
| | | | | | | | | | | | | | situation happens if you focus the omnibox and press the down arrow. As part of this I consolidated the code for upading instant to the LocationBar. I didn't want to put this in the instant code as I'm trying to make instant know as little as possible about autocomplete. BUG=73407 TEST=see bug Review URL: http://codereview.chromium.org/6597023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76268 0039d316-1c4b-4281-b951-d872f2087c98
* Autocomplete cleanup patch. Adds AutocompleteControllerDelegate insky@chromium.org2011-02-161-34/+65
| | | | | | | | | | | | addition to the notification. The notification is now only sent out when done. Also makes the editmodel own the controller. BUG=none TEST=none Review URL: http://codereview.chromium.org/6519014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75126 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-23 00:09:19 +0000