| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=97837
TEST=NONE
Review URL: http://codereview.chromium.org/8162010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user hasn't modified the url. I'll add a test case if you like this.
BUG=94126
TEST=see bug
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7806001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the test suite implicitly provides global resources for each test,
but they're re-initialized between each test.
The performance overhead is negligible.
We need that to continue moving tests from unit_tests
to content_unittests. Because of shared test fixtures
the test suites need to be compatible.
BUG=90443
Review URL: http://codereview.chromium.org/7744039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteInput::Parse() now usually marks intranet navigations as UNKNOWN and relies on the HistoryURLProvider to do the right thing. In turn the HistoryURLProvider will mark URLs it's never seen as high-quality navigations if they have a hostname that's part of a previously-type intranet URL.
So for example, "abc/def" on a clean profile now defaults to searching rather than navigating; but if any URL on host "abc" has been typed before, both "abc/def" and "abc/def ghi" will navigate, despite the space in the second case.
This also changes the default behavior for some similar cases like "abc:81", "user:pass@abc", and "user:pass@abc:81". Again these will all now default to searching, but navigate if the host in question has been typed. Unchanged is the behavior of "abc/"; because the scheme-stripping code relies on a single trailing slash triggering a navigation, and because it's convenient for users to force navigation on an unknown host, this is still parsed as a URL.
BUG=6788
TEST=Navigate to "who/", then type "who/a b" and note that the default action is to navigate rather than search.
Review URL: http://codereview.chromium.org/7661028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=90905
Review URL: http://codereview.chromium.org/7616019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7544021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string::size() to string::length() (omnibox code style), and some rewrapping.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7075020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
launched from the Omnibox.
BUG=81379
TEST=Install Scratchpad extension (from Google). Launch it from the Omnibox and it should launch as a panel app. Test Paste and Go also like you normally would (it is affected).
Review URL: http://codereview.chromium.org/6913022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/omnibox directory.
- Rename AutocompleteEditView to OmniboxView.
- Move autocomplete_edit_view.* to omnibox_view.*
BUG=80186
TEST=None
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6912026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make GetTabContentsWrapper const for AutocompleteEditController and LocationBarView::Delegate.
BUG=71097
TEST=none
Review URL: http://codereview.chromium.org/6821085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=78732
Original BUG=71097
Original TEST=no visible change
Original Review URL: http://codereview.chromium.org/6735042
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6814029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=no visible change
Review URL: http://codereview.chromium.org/6735042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior. The choices are:
. immediately (current behavior and is the default).
. delayed (transitions to autocompleted after a delay).
. never (only show the suggestion, but never autocomplete it).
I'm doing this so we can collect some data to help understand which is
the less error prone of the 3. The data collection is all done on the
server side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6685002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76073
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6685059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditModel. This cuts down on a fair amount of duplicate code in the various platform specific files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6609030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9181
TEST=Drag a URL or ay text to the toolbar area, including back/forward/reload
buttons, and the browser action/menu area. This should not interfere with
dragging and dropping of browser actions. Test that browser actions behave
as they should (i.e. should be able to change their order in the toolbar).
Review URL: http://codereview.chromium.org/6462009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to be done in multiple steps,
because lots of tests depend on global TestingBrowserProcess.
However, the current solution is very error-prone,
and may lead to state being carried from one test
to another (via NotificationService), resulting in crashes.
In theory the ScopedTestingBrowserProcess could be made
empty for now, but re-initializing g_browser_process inside it
has two benefits:
1) It verifies that changing g_browser_process actually works.
2) It protects at least a subset of tests from carrying state.
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/6478005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66850
TEST=AutocompleteEditViewTest.TabMoveCursorToEnd and InstantTest.TabKey
Review URL: http://codereview.chromium.org/5966006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Recommit of r72380.
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6306011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6258015
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6256010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6258015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6359002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains following changes to omnibox code:
1. Make sure |keyword_ui_state_| is always updated correctly, i.e. it
should always be KEYWORD when keyword UI is visible.
2. Make sure |keyword_ui_state_| will never be changed during IME
composition.
3. Make sure OnInlineAutocompleteTextMaybeChanged() will only be called
when inline autocomplete suggest is changed.
This CL fixes following bugs. Old fix for bug 2720 and 3798 has been
removed.
BUG=2720
BUG=3798
BUG=39947
BUG=62426
TEST=See bug reports.
Review URL: http://codereview.chromium.org/6131005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditView
Renamed mac's SetSuggestedText to SetInstantSuggestion.
Consolidated two SetInstantSuggestion in gtk impl.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6106007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromeos and Touch UI.
The goal of this refactoring is to make it easy to swap AutocompleteEditView implementation between Gtk based impl and Views based one. This is 1st phrase and there will be more refacotring needed to implement AutocompleteEditViewViews.
- Added factory method AutocompleteEditViewGtk::Create,
which hides initialization details for gtk based impl.
- Moved gtk specific accessibilty code to AutocompleteEditViewGtk.
- Added TOOLKIT_VIWES only methods to AutocompleteEditView
to hide platform specific implementation. (AddToView, CommitInstatntSuggestion/SetInstantSuggestion)
BUG=none
TEST=none no functional change. all tests should pass.
Review URL: http://codereview.chromium.org/6036004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new test InstantTest.TabKey and also fixes (hopefully) InstantTest.OnSubmitEvent on Windows and InstantTest.OnCancelEvent on Mac.
BUG=62940
BUG=64696
BUG=66768
TEST=See bug report.
Review URL: http://codereview.chromium.org/5811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
provider and nothing else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user enabled predictive instant we switch to verbatim in certain
situations.
BUG=59217
TEST=see bug
Review URL: http://codereview.chromium.org/5225003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are a number of parts of this patch that need work, but it should be
good enough for us to decide if we want to pursue it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with.
BUG=61378
TEST=none
Review URL: http://codereview.chromium.org/4196009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3417011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29593
TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.FocusSearch
Review URL: http://codereview.chromium.org/3280012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
currently views only, but that will change once everything is working.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3272009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
host.
BUG=43585
TEST=see bug
Review URL: http://codereview.chromium.org/1993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
. Makes copy prefix the text with http if the user hasn't edited the
text, and the scheme is http but the text doesn't include http.
. Makes copying use the url as the text if the user hasn't edited the
text and it's http/https.
. Makes control-insert/shift-insert use our copy/paste.
BUG=41639 41489 41493
TEST=make sure copy/paste from the omnibox work sanely. Seriously
though, see the three bugs for specifics.
Review URL: http://codereview.chromium.org/1761002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45667 0039d316-1c4b-4281-b951-d872f2087c98
|