| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/cocoa/omnibox directory.
- Rename AutocompleteEditViewMac to OmniboxViewMac.
- Move autocomplete_edit_view_mac.* to omnibox_view_mac.*
BUG=80186
TEST=None
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6904049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/views/omnibox directory.
- Rename AutocompleteEditViewWin to OmniboxViewWin.
- Move autocomplete_edit_view_win.* to omnibox_view_win.*
BUG=80186
TEST=None
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6902055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression.
I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression.
The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6883110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
part of r82185 that was reverted. The change was reverted because it caused a performance regression.I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression.The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak.BUG=NoneTEST=NoneReview URL: http://codereview.chromium.org/6883110
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6879113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression.
I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression.
The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6883110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new high res icon change may have caused a perf regression. To verify I'm reverting the following chnages:
commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b
r82326 Disable loading high res icons on Mac
commit 3c39226937a39d0042b8a794f13505c7a25ca58b
r82247 Fix reload button unit test
commit f87ab117fc159566868e71e4df5672852bebd718
r82245 Unregister toolbar view from window notifications
commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1
r82239 Fix failing Mac unit tests
commit 8b681c46a139d12151323952c58122f6805d7597
r82236 Mac: Remove custom drawn buttons
commit 6ae8a2fe40485731b86267e362936db16b4c0706
r82209 Fix clang build break
commit e8a19d1e0c76f204c834318566e4206320583449
r82185 Add support for multi resolution icons
BUG=None
TEST=Compling
Review URL: http://codereview.chromium.org/6878077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version.
To support this, this change does the following:
- split theme_resource.grd into three files:
- theme_resources.grd: icons that only have one resolution
- theme_resources_standard.grd: low resolution icons
- theme_resources_large.grd: high resolution icons
- theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms.
- theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac)
- gfx::Image now support icons with multiple resolution
Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go.
Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that.
BUG=75812
TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed.
Review URL: http://codereview.chromium.org/6849030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
provider.
BUG=52444
TEST=Matches against title/url from Extension Apps should now have it's distinct Extension App icon as opposed to using the globe icon.
Review URL: http://codereview.chromium.org/6811017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL uses the allow_exact_keyword_match property of AutcompleteInput class to support this inserting space in the middle case. The logic of triggering a keyword by pressing space key at the end is not changed.
BUG=77211
TEST=See bug report.
Review URL: http://codereview.chromium.org/6770020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior. The choices are:
. immediately (current behavior and is the default).
. delayed (transitions to autocompleted after a delay).
. never (only show the suggestion, but never autocomplete it).
I'm doing this so we can collect some data to help understand which is
the less error prone of the 3. The data collection is all done on the
server side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6685002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
debug of broken contracts
BUG=58409
Review URL: http://codereview.chromium.org/6690002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditModel. This cuts down on a fair amount of duplicate code in the various platform specific files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6609030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49740
TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.* should pass on Mac.
Review URL: http://codereview.chromium.org/6602070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6598086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6542027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the definition of GetNativeImageNamed to return a gfx::Image and
adds GetImageNamed in addition. GetBitmapNamed now goes through that method. On
Linux, GetNativeImageNamed will load directly into a GdkPixbuf-backed Image. Mac
will still first load through Skia (a future CL will load directly into an
NSImage). All other platforms use Skia natively, so GetNativeImageNamed is the
same as GetImageNamed.
Mac was the only platform that used the old GetNativeImageNamed, so this also
transitions a bunch of Mac files by including ui/gfx/image.h.
This also obviates the need for platform-specific image caches in the
ResourceBundle, so there's some additional cleanup around that.
BUG=carnitas
TEST=All UI images in Chromium show up as before.
Review URL: http://codereview.chromium.org/6541031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL reverts an inappropriate change introduced by http://codereview.chromium.org/5966006.
BUG=73488
TEST=Pressing ctrl key in omnibox shouldn't affect existing inline
autocomplete suggest text.
Review URL: http://codereview.chromium.org/6541048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
addition to the notification. The notification is now only sent out
when done. Also makes the editmodel own the controller.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6519014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding r73294.
BUG=71097
TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6246028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6378014
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6286019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6378014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66850
TEST=AutocompleteEditViewTest.TabMoveCursorToEnd and InstantTest.TabKey
Review URL: http://codereview.chromium.org/5966006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Recommit of r72380.
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6306011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6258015
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6256010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6258015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL disables implicit keyword accepting completely. The user can only
accept a keyword by pressing Tab or space explicitly while the keyword hint
UI is visible.
BUG=60972
TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.AcceptKeywordBySpace
Review URL: http://codereview.chromium.org/6252003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58975
TEST=none
Review URL: http://codereview.chromium.org/6268005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains following changes to omnibox code:
1. Make sure |keyword_ui_state_| is always updated correctly, i.e. it
should always be KEYWORD when keyword UI is visible.
2. Make sure |keyword_ui_state_| will never be changed during IME
composition.
3. Make sure OnInlineAutocompleteTextMaybeChanged() will only be called
when inline autocomplete suggest is changed.
This CL fixes following bugs. Old fix for bug 2720 and 3798 has been
removed.
BUG=2720
BUG=3798
BUG=39947
BUG=62426
TEST=See bug reports.
Review URL: http://codereview.chromium.org/6131005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditView
Renamed mac's SetSuggestedText to SetInstantSuggestion.
Consolidated two SetInstantSuggestion in gtk impl.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6106007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6135006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling code.
Remove unnecessary refs to NullableString from render_thread.*
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/5961007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new test InstantTest.TabKey and also fixes (hopefully) InstantTest.OnSubmitEvent on Windows and InstantTest.OnCancelEvent on Mac.
BUG=62940
BUG=64696
BUG=66768
TEST=See bug report.
Review URL: http://codereview.chromium.org/5811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
composition text of input methods sets in the omnibox. This will prevent committing the current composition text incorrectly.
BUG=61204
TEST=Enter the keyword of an extension and type space, and inserting text with an input method, then the composition text should not be committed.
Review URL: http://codereview.chromium.org/4103011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurred because AutocompleteInput strips whitespace, but whitespace
matters for suggest text.
BUG=65701
TEST=see bug
Review URL: http://codereview.chromium.org/5561008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suggest text.
BUG=65464
TEST=Type "hello" into the omnibox. When the suggestion appears, press right (or tab). Suggest text should turn black.
Review URL: http://codereview.chromium.org/5556007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolbar stuff -> ui/toolbar
dock_info -> ui/tabs
window_sizer -> ui
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5544002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
provider and nothing else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keystroke.
Implements DeleteAtEndPressed(), which is needed for verbatim instant support.
BUG=56385,59217,64212
TEST=Open chrome with instant enabled. Type "nswi" into omnibox. Should suggest "nswindow." Now type "n." Should continue to suggest "nswindow."
TEST=Open chrome with instant enabled. Type "nswind" into omnibox. Should suggest "nswindow." Delete one character. Should not suggest "nswindow."
Review URL: http://codereview.chromium.org/5288003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56385
TEST=Suggest text should appear when instant is on.
Review URL: http://codereview.chromium.org/4643008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user enabled predictive instant we switch to verbatim in certain
situations.
BUG=59217
TEST=see bug
Review URL: http://codereview.chromium.org/5225003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are a number of parts of this patch that need work, but it should be
good enough for us to decide if we want to pursue it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55418
TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should
run tests on GTK but not Windows or Mac.
Review URL: http://codereview.chromium.org/4082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of the first stage of cleaning up ResourceBundle's interface.
BUG=58030
TEST=Compile and unit tests.
Review URL: http://codereview.chromium.org/3806007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instant results to properly move out of the way of the omnibox.
BUG=56385
TEST=Do a Google search with Instant turned on. The omnibox should not overlap with the results.
Review URL: http://codereview.chromium.org/3735005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very rough cut. Many things are still unfinished and will be fixed in future CLs:
- Clicking on instant results clears the results.
- Suggestions do not work yet.
- The omnibox popup overlaps with instant results.
- HTTP auth dialogs cause crashes.
BUG=56385
TEST=No visible impact when --enable-match-preview is not set on the command line.
TEST=Instant results should appear when typing in the omnibox.
TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar.
Review URL: http://codereview.chromium.org/3624001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove logging.h and other headers where possible.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29593
TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.FocusSearch
Review URL: http://codereview.chromium.org/3280012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59183 0039d316-1c4b-4281-b951-d872f2087c98
|