summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete/history_provider.h
Commit message (Collapse)AuthorAgeFilesLines
* Revert 111378 - HQP Refactoring (in Preparation for SQLite Cache)zmo@google.com2011-11-241-4/+0
| | | | | | | | | | | | | | | | | | | | (See crbug.com/105340 for reverting reason and how to reproduce the issue locally) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8662035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111482 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-231-0/+4
| | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111378 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations from various chrome/browser ↵thestig@chromium.org2011-11-151-8/+0
| | | | | | | | | | | subdirectories. BUG=none TEST=none Review URL: http://codereview.chromium.org/8539006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109987 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108478 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-031-4/+0
| | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8437042 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8430038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108486 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-031-0/+4
| | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8437042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108478 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108207 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-021-4/+0
| | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Review URL: http://codereview.chromium.org/8384024 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8437035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108224 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-021-0/+4
| | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Review URL: http://codereview.chromium.org/8384024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 105678 - Caused flakiness described in http://crbug.com/100479rsleevi@chromium.org2011-10-161-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HQP Refactoring (in Preparation for SQLite Cache) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson,brettw Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/. Review URL: http://codereview.chromium.org/8291005 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8310006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105697 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache) mrossetti@chromium.org2011-10-151-0/+4
| | | | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson,brettw Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/. Review URL: http://codereview.chromium.org/8291005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105678 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 105300 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-10-131-4/+0
| | | | | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731,92718 TEST=Unit tests updated. TBR=atwilson,brettw Review URL: http://codereview.chromium.org/8120004 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105313 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-10-131-0/+4
| | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731,92718 TEST=Unit tests updated. TBR=atwilson,brettw Review URL: http://codereview.chromium.org/8120004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105300 0039d316-1c4b-4281-b951-d872f2087c98
* Makes intranet urls autocomplete again. This patch gives the relevancesky@chromium.org2011-09-201-6/+0
| | | | | | | | | | | | | | that such sites had in the past. The other key it does it to make sure FixupExactSuggestion returns false so that we don't use the what you typed match. BUG=94805 TEST=see bug R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7756020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in CanFindIntranetURL() due to FixupUserInput() changing the ↵pkasting@chromium.org2011-09-011-1/+3
| | | | | | | | | | AutocompleteInput's text_ but not its parts_, and us newly trying to use those parts_ later. BUG=94158 TEST=Covered by unittests Review URL: http://codereview.chromium.org/7822009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99233 0039d316-1c4b-4281-b951-d872f2087c98
* Makes autocompleting previous search terms work on word boundaries.sky@chromium.org2011-05-091-1/+8
| | | | | | | | | | BUG=80057 TEST=covered by unit tests, but see bugs for details. R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6893140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84681 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-251-2/+2
| | | | | | | | | | | Recommit of r72380. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6306011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72380 - Remove wstring from autocomplete.avi@chromium.org2011-01-241-2/+2
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6256010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-241-2/+2
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98
* Make starred History*Provider results stay in the autocomplete dropdown, ↵msw@chromium.org2011-01-061-2/+3
| | | | | | | | | | | | | update tests. Don't delete bookmarked AutoCompleteMatches from the dropdown list, remove their history data and hide their backing store instead. Expose HistoryProvider::DeleteMatch() and add delete tests. BUG=67822 TEST=New unit tests + Check that starred History*Provider results aren't removed from the omnibox autocomplete dropdown set of matches. Review URL: http://codereview.chromium.org/6078005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70648 0039d316-1c4b-4281-b951-d872f2087c98
* Make HistoryContentsProvider results deletablethakis@chromium.org2010-12-161-1/+3
| | | | | | | | | | | | This change should allow you to press Shift+Delete to remove selected results from the Omnibox auto-complete drop-down that have been collected from the contents of pages from the user's history. BUG=14748 TEST=trybots and deleting history-contents results from the omnibox auto-complete drop-down. Review URL: http://codereview.chromium.org/5774004 Patch from Michael Wasserman <msw@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69422 0039d316-1c4b-4281-b951-d872f2087c98
* Final phase of the URL History Quick autocomplete provider integration. This ↵mrossetti@chromium.org2010-10-121-0/+53
| | | | | | | | | | | | | phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. Previous CL: http://codereview.chromium.org/3375002 BUG=23654,19736 TEST=Green bots. Start typing text which occurs in URLs which are in the history. Verify that those history items appear if they have been manually typed more than once or the have been visited more than three time or they have been visited within the last three days. Review URL: http://codereview.chromium.org/3713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62193 - Final phase of the URL History Quick autocomplete provider ↵mrossetti@chromium.org2010-10-111-53/+0
| | | | | | | | | | | | | | integration. This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. BUG=None TEST=None Review URL: http://codereview.chromium.org/3375002 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/3660007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62201 0039d316-1c4b-4281-b951-d872f2087c98
* Final phase of the URL History Quick autocomplete provider integration. ↵mrossetti@chromium.org2010-10-111-0/+53
This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. BUG=None TEST=None Review URL: http://codereview.chromium.org/3375002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62193 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-15 19:52:21 +0000